Re: [PATCH] switch stat and fopen

Marcus Meissner wrote: -if (!(fin = fopen(input_file_name, r))) return 0; if (stat(input_file_name, st) 0) return 0; +if (!(fin = fopen(input_file_name, r))) return 0; Wouldn't it be better to use fstat here to avoid a race condition? Mike

Re: AppDB performance issue

Bryan Haskins wrote: Weird I'm on dial-up even and goto the same pages, and all around the wine sites, all the time, and they load surprisingly fast. On 2/12/07, *Nick Law* [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: Nick Law wrote: Tony Lambregts wrote: Chris Morgan wrote: On

Re: avifil32: sign-compare fixes

Joris Huizer [EMAIL PROTECTED] writes: diff --git a/dlls/avifil32/avifile.c b/dlls/avifil32/avifile.c index f989c79..e7b22b1 100644 --- a/dlls/avifil32/avifile.c +++ b/dlls/avifil32/avifile.c @@ -835,7 +835,7 @@ static LONG WINAPI IAVIStream_fnFindSamp ULONG n; for (n = 0; n

Re: mshtml #10: Added SchemeIs implementation.

Jacek Caban [EMAIL PROTECTED] writes: --- dlls/mshtml/nsio.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) This one causes make test to hang in the htmldoc.c test, somewhere in test_download(). -- Alexandre Julliard [EMAIL PROTECTED]

Re: [PATCH] switch stat and fopen

On Tue, Feb 13, 2007 at 05:28:52PM +0900, Mike McCormack wrote: Marcus Meissner wrote: -if (!(fin = fopen(input_file_name, r))) return 0; if (stat(input_file_name, st) 0) return 0; +if (!(fin = fopen(input_file_name, r))) return 0; Wouldn't it be better to use fstat here

Re: Starting work on wine (Direct X Help)

Am Dienstag 13 Februar 2007 03:39 schrieb Nathan Williams: Yeah, I'm not too interested in the sound right now, but I aim to work on that eventually. As for managed mode, unless I'm mangling the wine terminology, what i mean is that it will only show up if I use a command such as: wine

Re: Linuxtag 2007

On Mo, 2007-02-12 at 17:58 +0100, Detlef Riekenberg wrote: On Mo, 2007-02-12 at 16:37 +0100, Marcus Meissner wrote: Whith your help, what can be done, I found 54 contributors for 2007 in the changelog . $ grep ^2007.* ChangeLog | sort -t +1 -u | wc -l 56 (Stefan and Francois are twice

Re: winecfg: Add check for device access to Drives tab.

Vitaliy Margolen [EMAIL PROTECTED] writes: Any reasons why this patch is not applied? http://www.winehq.org/pipermail/wine-patches/2007-January/035264.html This is one of the major headaches for users trying to get programs requiring direct CD-ROM drive access to work. And it's nearly

opengl

Hi: I want to use opengl with wine. //Here is my glxinfo. server glx vendor string:SGI server glx version string:1.2 client glx vendor string:SGI client glx version string:1.2 OpengGL vendor string:Mesa project:www.mesa3d.org OpengGL renderer string:Mesa GLX Indirect OpengGL version

Re: version: Constify a formal parameter of VerQueryValue{A|W}()

Andrew Talbot wrote: -BOOL WINAPI VerQueryValueA( LPVOID pBlock, LPSTR lpSubBlock, +BOOL WINAPI VerQueryValueA( LPVOID pBlock, LPCSTR lpSubBlock, This is wrong - in the PSDK headers it's LPSTR (the first parameter should be const though). Felix

Re: opengl

Well you don't have Direct rendering... if you dont have support from the ATI OSS drivers ( if you use ATi) then you should download the ATI or nvidia proprietary drivers. Should be in your Distros Repos, or you can set them up yourself from their sties. On 2/13/07, gaosheng [EMAIL PROTECTED]

Re: AppDB performance issue

I was just replying, and reading now, no slow down at all. It loads a little slow running through all that text, but no where near the minutes everyone says it takes them, even on dialup. On 2/13/07, Nick Law [EMAIL PROTECTED] wrote: Bryan Haskins wrote: Weird I'm on dial-up even and goto the

Re: opengl

Am Dienstag 13 Februar 2007 10:13 schrieb gaosheng: OpengGL renderer string:Mesa GLX Indirect is your reason. You do not have a 3D driver installed or properly set up pgpYV0M3mjrcT.pgp Description: PGP signature

Re: version: Constify a formal parameter of VerQueryValue{A|W}()

Felix Nawothnig wrote: Andrew Talbot wrote: -BOOL WINAPI VerQueryValueA( LPVOID pBlock, LPSTR lpSubBlock, +BOOL WINAPI VerQueryValueA( LPVOID pBlock, LPCSTR lpSubBlock, This is wrong - in the PSDK headers it's LPSTR (the first parameter should be const though). Felix I've seen this

Re: compiling out debugging messages?

On 2/12/07, Michael Stefaniuc [EMAIL PROTECTED] wrote: Lei Zhang wrote: Also, the patch from 2007/04/17 only removed -DWINE_NO_DEBUG_MSGS / -DWINE_NO_TRACE_MSGS from configure, but not from include/wine/debug.h. Right, it was a problem with a lot of people turning debug messages off and

Re: opengl

В сообщении от 13 февраля 2007 20:53 Stefan Dösinger написал(a): Am Dienstag 13 Februar 2007 10:13 schrieb gaosheng: OpengGL renderer string:Mesa GLX Indirect is your reason. You do not have a 3D driver installed or properly set up Why we can't use software rendering? -- Vitaly Lipatov, ALT

Re: comctl32: move up-down msg seq tests into new 'msg' test

On 2/13/07, Felix Nawothnig [EMAIL PROTECTED] wrote: Figured you might want a test for my listview patch - so first this. Didn't really change anything, still passed on XP SP2. --- dlls/comctl32/tests/Makefile.in |1 + dlls/comctl32/tests/msg.c | 523

Re: comctl32: move up-down msg seq tests into new 'msg' test

James Hawkins wrote: This is not what needs to happen. The generic message sequence testing code needs to be factored into msg.c, but the specific tests need to stay in each control's test file. Guessed so... How about putting it into include/wine/test.h to share the code with user32/msg?

Re: comctl32: move up-down msg seq tests into new 'msg' test

On 2/13/07, Felix Nawothnig [EMAIL PROTECTED] wrote: James Hawkins wrote: This is not what needs to happen. The generic message sequence testing code needs to be factored into msg.c, but the specific tests need to stay in each control's test file. Guessed so... How about putting it into

Re: version: Constify a formal parameter of VerQueryValue{A|W}()

Andrew Talbot wrote: I've seen this function represented with the first two parameters constified. Is anyone aware of a more const-correct version in the field than the one Felix mentions? Sorry about that, seems they changed the declaration in the new headers - I misinterpreted your comment

Re: Bug 50

Hi all, I'm writing just to ask why my patch and test case for Bug 50 (the text justification issue) weren't committed yet, so that I can take the proper measures in order that they can be. Regards, Pedro.

Re: opengl

Am Dienstag 13 Februar 2007 19:39 schrieb Vitaly Lipatov: В сообщении от 13 февраля 2007 20:53 Stefan Dösinger написал(a): Am Dienstag 13 Februar 2007 10:13 schrieb gaosheng: OpengGL renderer string:Mesa GLX Indirect is your reason. You do not have a 3D driver installed or properly set

Re: Starting work on wine (Direct X Help)

Oh, my apologies, i thought i had the terminology down pat, but i guess not! I added a comment correcting myself on the appdb. On the actual code, i think the bug lies somewhere in: IWineD3DPaletteImpl_SetEntries During the menus this is called repeatedly. Which looking at the source

Re: Add RegisterRawInputDevices stub implementation

Kovács András wrote: +BOOL WINAPI RegisterRawInputDevices(PRAWINPUTDEVICE pRawInputDevices, UINT uiNumDevices, UINT cbSize) +{ +int i; Please keep the indentation style of the original file.

Re: compiling out debugging messages?

Lei Zhang wrote: On 2/12/07, Michael Stefaniuc [EMAIL PROTECTED] wrote: Lei Zhang wrote: Also, the patch from 2007/04/17 only removed -DWINE_NO_DEBUG_MSGS / -DWINE_NO_TRACE_MSGS from configure, but not from include/wine/debug.h. Right, it was a problem with a lot of people turning debug

Re: [4/9] d3d8: Add an IDirect3DVertexDeclaration8 class to hold the wined3d vertex declaration

The idea of this patch and the next few is to create an internal d3d8 object to hold the wined3d declaration and give the d3d8 vertex shader a field to hold the d3d8 vertex declaration object. Setting the d3d8 vertex shader will then set both the wined3d shader and the wined3d vertex

Re: opengl

On 2/13/07, gaosheng [EMAIL PROTECTED] wrote: Hi: I want to use opengl with wine. //Here is my glxinfo. server glx vendor string:SGI server glx version string:1.2 client glx vendor string:SGI client glx version string:1.2 OpengGL vendor string:Mesa project:www.mesa3d.org OpengGL

Re: test.winehq.com status

On 1/31/07, Paul Vriens [EMAIL PROTECTED] wrote: Felix Nawothnig wrote: Hi. Anyone knows what happened to test.winehq.com/data? There has been no new crossbuilds for quite some time now... Felix Hi, I did sent an email to Paul Millar, but no reply yet. You can see what goes wrong with

wined3d: The sims regression

Hi, I've noticed that commit 12252d058914a66f40e976484cc7d8aa52ffca47 on the git tree causes a regression in the sims, making characters flipped upside down. It's seems to me that the y axis is flipped. I hope this helps Bye Alessandro Pignotti -- Vi Veri Veniversum Vivus Vici -Dr.

Re: Declare some WinXP related structures

Kovács András [EMAIL PROTECTED] wrote: --- a/include/winuser.h +++ b/include/winuser.h @@ -1055,6 +1055,51 @@ BOOLWINAPI SetSysColors(INT,const INT*,const COLORREF*); #define WM_GETICON 0x007f #define WM_SETICON 0x0080 + /* Windows XP messages */ +#define WM_INPUT

Re: test.winehq.com status

Lei Zhang wrote: On 1/31/07, Paul Vriens [EMAIL PROTECTED] wrote: Felix Nawothnig wrote: Hi. Anyone knows what happened to test.winehq.com/data? There has been no new crossbuilds for quite some time now... Felix Hi, I did sent an email to Paul Millar, but no reply yet. You can see what