Re: (resend) Scroll window fix

2007-03-02 Thread Dmitry Timoshkov
"Aric Stewart" <[EMAIL PROTECTED]> wrote: +SetRect( &rc, 0,40, 100,60); +SetRect( &cliprc, 0,0, 100,100); +ScrollWindowEx( hwnd1, 0, -25, &rc, &cliprc, hrgn, &rcu, SW_INVALIDATE); +SetRectRgn( tmprgn, 0,15,98,35); +CombineRgn( exprgn, exprgn, tmprgn, RGN_OR); +SetRectRgn(

Re: winex11.drv: Try to work around an access violation in dib_convert

2007-03-02 Thread Dmitry Timoshkov
"Louis. Lenders" <[EMAIL PROTECTED]> wrote: @@ -849,7 +858,17 @@ static void convert_888_to_0888_asis(int for (x=0; x < w2; x++) { /* Do 4 pixels at a time: 3 dwords in and 4 dwords out */ DWORD srcval1,srcval2; -srcval1=srcpixel[0]; +/* So

Re: [2/3] wined3d: The texldl instruction takes 3 arguments

2007-03-02 Thread H. Verbeet
On 03/03/07, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: > Changelog: > - The texldl instruction takes 3 arguments > Can the SW shader handlers be deleted now that the rest of the SW code is gone. They just get out of sync when you do things like this. Hmm, yeah. Software shaders seem to be more

Re: [2/3] wined3d: The texldl instruction takes 3 arguments

2007-03-02 Thread Ivan Gyurdiev
Changelog: - The texldl instruction takes 3 arguments Can the SW shader handlers be deleted now that the rest of the SW code is gone. They just get out of sync when you do things like this.

Re: [programs/cacls] Dummy implementation of cacls.exe (try 2)

2007-03-02 Thread Nigel \"Nia-Chiang\" Liang
Yes, sorry about that. Here is the modified patch -Nigel On 3/2/07, James Hawkins <[EMAIL PROTECTED]> wrote: On 3/2/07, Nigel Nia-Chiang Liang <[EMAIL PROTECTED]> wrote: > Hi, > > This patch implements a dummy version of cacls.exe to fix bug 7593. > +#RC_SRCS = wcmdrc.rc +#RC_BINSRC = wcmdrc.

Re: Forum proposal

2007-03-02 Thread Ben Hodgetts (Enverex)
That's not really that much of an issue as only the ML is official so devs and such don't have to go trapsing after people, they have to come here. Ex. Tomas Carnecky wrote: > Scott Ritchie wrote: >> On Thu, 2007-03-01 at 20:57 +0100, Tomas Carnecky wrote: >>> Luis C. Busquets Pérez wrote: I

Re: Forum proposal

2007-03-02 Thread Scott Ritchie
On Fri, 2007-03-02 at 12:55 +0100, Tomas Carnecky wrote: > Scott Ritchie wrote: > > On Thu, 2007-03-01 at 20:57 +0100, Tomas Carnecky wrote: > >> Luis C. Busquets Pérez wrote: > >>> I understand that for some people the mailing list is a far better > >>> thing. May be for some other, a forum is be

RE: DIB Engine & GSoC

2007-03-02 Thread Ge van Geldorp
> If I understand it correctly, there was an idea floating > around that Ge van Geldorp had which was to auto generate the > needed DIB engine code for certain color depths and functions > so you would not have to implement the whole thing at once. > if I remember correctly he did a proof of co

Re: [programs/cacls] Dummy implementation of cacls.exe

2007-03-02 Thread James Hawkins
On 3/2/07, Nigel Nia-Chiang Liang <[EMAIL PROTECTED]> wrote: Hi, This patch implements a dummy version of cacls.exe to fix bug 7593. +#RC_SRCS = wcmdrc.rc +#RC_BINSRC = wcmdrc.rc +#RC_BINARIES = wcmd.ico Did you accidentally leave these in? -- James Hawkins

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

2007-03-02 Thread Felix Nawothnig
Erich Hoover wrote: I see your point. However, since the function you are implementing is in kernel32 anyway you could abstract it away and make both functions (CopyFile and ReplaceFile) call some internal function. That way you would get rid of the locking completly which is argueably somewhat u

Re: DIB Engine & GSoC

2007-03-02 Thread Francois Gouget
On Fri, 2 Mar 2007, Stefan Dösinger wrote: [...] > But I think if you can do a fluent transition, then the huge amount of work > will be cutable into small, doable chunks of work, and if you stop after > doing half of the work for some reason the existing things are still of use. It depends what

Re: DIB Engine & GSoC

2007-03-02 Thread Benoit Pradelle
You seem to not realize that painting also happens outside of the WM_PAINT handler, moreover some apps do not call EndPaint in WM_PAINT, or call it before they paint anything. Yep effectively I realized it after sending my mail. Anyway, Alexandre think that this project is not a good choice

Re: DIB Engine & GSoC

2007-03-02 Thread Dmitry Timoshkov
"Benoit Pradelle" <[EMAIL PROTECTED]> wrote: Perhaps should we draw everything asked in memory and just send it to X when the application calls EndPaint, this way we limit the interaction with the X server (and locks). You seem to not realize that painting also happens outside of the WM_PAINT

Re: DIB Engine & GSoC

2007-03-02 Thread Steven Edwards
Hi, On 3/2/07, Damjan Jovanovic <[EMAIL PROTECTED]> wrote: The other thing is that there are many aspects of GDI drawing, you have to take into account region clipping, pens, brushes, line thickness, line style, fill style, and other wonders, and make them work in 1, 4, 8, 16, 24 and 32 bit colo

Re: ntdll: make exception test not hang when creating process fails

2007-03-02 Thread Robert Shearman
Peter Oberndorfer wrote: --- Did not seem to happen in the wild, but just make sure the test fails gracefully if launching the child fails Applies on top of the patch which should fix test result reporting If it doesn't happen in the wild, then it should stay as an "ok". -- Rob Shearman

Re: DIB Engine & GSoC

2007-03-02 Thread Benoit Pradelle
The other thing is that there are many aspects of GDI drawing, you have to take into account region clipping, pens, brushes, line thickness, line style, fill style, and other wonders, and make them work in 1, 4, 8, 16, 24 and 32 bit colour depth pixel-for-pixel exact with the way Windows does th

Re: DIB Engine & GSoC

2007-03-02 Thread Damjan Jovanovic
On 3/1/07, Benoit Pradelle <[EMAIL PROTECTED]> wrote: First thank you for your very complete answer, I'm not really familiar with Wine (and the Windows API) and I don't understand why do you think that it will be such an hard work. Read some code in dlls/winex11.drv in the wine tree, you will

Re: Forum proposal

2007-03-02 Thread Tomas Carnecky
Scott Ritchie wrote: On Thu, 2007-03-01 at 20:57 +0100, Tomas Carnecky wrote: Luis C. Busquets Pérez wrote: I understand that for some people the mailing list is a far better thing. May be for some other, a forum is better. Why not trying both systems? This question has already been answered

Re: DIB Engine & GSoC

2007-03-02 Thread Stefan Dösinger
> Benoit Pradelle [mailto:[EMAIL PROTECTED] wrote: > >I'm not really familiar with Wine (and the Windows API) and I don't > > understand > > >why do you think that it will be such an hard work. For me, the work will > > consist > > >in redirect the GDI calls from the X11 pseudo-driver to some new

Re: kernel32: Set object security on process object in CreateProcess.[try2]

2007-03-02 Thread Alexandre Julliard
Vitaliy Margolen <[EMAIL PROTECTED]> writes: > Vitaliy Margolen wrote: >> Removed todo from succeeding tests. >> >> Tests showed that only DACL can be set this way. Owner and group >> are taken from the token. And we don't need SACL at this time if ever. >> --- >> dlls/advapi32/tests/security.c

Re: Forum proposal

2007-03-02 Thread Scott Ritchie
On Thu, 2007-03-01 at 20:57 +0100, Tomas Carnecky wrote: > Luis C. Busquets Pérez wrote: > > I understand that for some people the mailing list is a far better > > thing. May be for some other, a forum is better. > > > > Why not trying both systems? > > > > This question has already been answer

[TOOLS/RFC] Use skip information on test.winehq.org

2007-03-02 Thread Paul Vriens
Hi, This patch add the skip information to test.winehq.org. I'm not a 100% sure what will happen to the already existing reports when summary.js is patched. This however is only relevant for someone opening the popup window for old reports. There could be an issue when somebody is running an old