RE: DIB Engine GSoC

2007-03-03 Thread Rolf Kalbermatter
Damjan Jovanovic [mailto:[EMAIL PROTECTED] wrote: There are probably several ways to do a DIB engine. The way I would do it, is the way that Transgaming did it in that patch a number of years back, ie. where wine does: Actually better would be IMO to place it all in GDI. A lot of the Eng.. API

GSoC project proposal: Implement the Negotiate and Kerberos SSPs based on GSSAPI

2007-03-03 Thread Kai Blin
Hi folks, after I spent my last two summers toying with the NTLM SSP, I'm considering to implement Negotiate and Kerberos this time. As we've discussed on WineConf, there's more than one way to do this. My toy idea is to not implement the ASN.1 stuff myself but instead make use of GSSAPI for

Re: (resend) Scroll window fix

2007-03-03 Thread Aric Stewart
I did my work comparing to windows 2000. I could not get the test to run at all on my windows box so i had to try to fiddle with the test to get it to work. I spent a lot of time working on windows 2000 to make this behavior the same and so feel the patch is not obviously incorrect and most

Re: (resend) Scroll window fix

2007-03-03 Thread Dmitry Timoshkov
Aric Stewart [EMAIL PROTECTED] wrote: I did my work comparing to windows 2000. I could not get the test to run at all on my windows box so i had to try to fiddle with the test to get it to work. What exactly was the problem? I spent a lot of time working on windows 2000 to make this

Re: (resend) Scroll window fix

2007-03-03 Thread Alexandre Julliard
Dmitry Timoshkov [EMAIL PROTECTED] writes: Well, apparently the fix was based on a test (that was supposed to mimic a real application behaviour that exposed a bug), and since the test is wrong (since it doesn't pass on a single flavour of Windows) the fix is wrong as well. The test failing

Re: (resend) Scroll window fix

2007-03-03 Thread Aric Stewart
I think you misunderstand. I wrote extensive tests _on windows_ that I used for this patch which where independent on the existing test in wine as i could not get the wine test to work properly in window, most likely, do to a lack of understand on the testing framework. After i made the patch

Re: DirectPlay should convert dwReserved1/2 registry keys from strings to DWORDs

2007-03-03 Thread Kai Blin
On Friday 02 March 2007 22:54, Alessandro Pignotti wrote: Hi, This is the first of several patches that will make builtin dplayx compatible with native dpwsockx, so we can kill the native override of dplayx This patch adds two compile-time warnings about implicitly declaring sscanf. Please

Re: [2/?]WineD3D: Adjust the rhw transformation for offscreen rendering

2007-03-03 Thread Stefan Dösinger
Am Samstag 03 März 2007 02:53 schrieb Stefan Dösinger: I hope I explained it correctly, these tripple upside down matrix things are the perfect way to get insane. Actually that is not totally correct - it should be - Y, -Y - height. It works because all games I have seen use Y = 0 I'll resend

Re: DirectPlay should convert dwReserved1/2 registry keys from strings to DWORDs

2007-03-03 Thread Joris Huizer
if( i == 0 ) - memcpy( lpSpData-dwReserved1, returnBuffer, sizeof(lpSpData-dwReserved1) ); + sscanf(returnBuffer, %x, lpSpData-dwReserved1); Couldnt you use: strcpy(lpSpData-dwReserved1,returnBuffer); Sorry for only replying now; Your solution is equivalent, except

Re: DirectPlay should convert dwReserved1/2 registry keys from strings to DWORDs

2007-03-03 Thread Frank Richter
On 03.03.2007 13:56, Joris Huizer wrote: if( i == 0 ) - memcpy( lpSpData-dwReserved1, returnBuffer, sizeof(lpSpData-dwReserved1) ); + sscanf(returnBuffer, %x, lpSpData-dwReserved1); Couldnt you use: strcpy(lpSpData-dwReserved1,returnBuffer); Reading a string and

Re: DirectPlay should convert dwReserved1/2 registry keys from strings to DWORDs

2007-03-03 Thread Joris Huizer
--- Frank Richter [EMAIL PROTECTED] wrote: On 03.03.2007 13:56, Joris Huizer wrote: if( i == 0 ) - memcpy( lpSpData-dwReserved1, returnBuffer, sizeof(lpSpData-dwReserved1) ); + sscanf(returnBuffer, %x, lpSpData-dwReserved1); Couldnt you use:

Re: [PATCH 1/2] comctl32: Added getter-setter tests for the tab control (second attempt)

2007-03-03 Thread Vitaliy Margolen
The_Hagop wrote: @@ -1,5 +1,6 @@ /* Unit test suite for tab control. * + * Copyright 2007 Hagop Hagopian * Copyright 2003 Vitaliy Margolen * * This library is free software; you can redistribute it and/or These are sorted in historical order. @@ -52,6 +59,8 @@ static HFONT

Re: [PATCH 2/2] comctl32: Added message sequence tests for the tab control

2007-03-03 Thread Vitaliy Margolen
The_Hagop wrote: assert(tabHandle); -SetWindowLong(tabHandle, GWL_STYLE, WS_CLIPSIBLINGS | WS_CLIPCHILDREN | TCS_FOCUSNEVER | style); -SendMessage (tabHandle, WM_SETFONT, 0, (LPARAM) hFont); +if (!tabHandle) +{ +HeapFree(GetProcessHeap(), 0, info); +

re: GSoC project proposal: Implement the Negotiate and Kerberos SSPs based on GSSAPI

2007-03-03 Thread Dan Kegel
Kai wrote: My toy idea is to not implement the ASN.1 stuff myself but instead make use of GSSAPI for this Can you explain for us non-knowledgeable folks what ASN.1 stuff you're talking about? Should using GSSAPI not work for us for whatever reason, I think it should be well within the

Re: GSoC project proposal: Implement the Negotiate and Kerberos SSPs based on GSSAPI

2007-03-03 Thread Kai Blin
On Saturday 03 March 2007 18:35, Dan Kegel wrote: Kai wrote: My toy idea is to not implement the ASN.1 stuff myself but instead make use of GSSAPI for this Can you explain for us non-knowledgeable folks what ASN.1 stuff you're talking about? ASN.1 is a standard, formal method of

Re: msi ole automation update

2007-03-03 Thread Misha Koshelev
On Sat, 2007-03-03 at 17:03 -0600, Misha Koshelev wrote: Hi everbody, I have been working on some more stuff for the MSI OLE automation, and I now have a moderately comprehensive conformance test (1000 or so lines, tests each function implemented at least for basic functionality, tests

Re: (resend) Scroll window fix

2007-03-03 Thread Peter Oberndorfer
On Tuesday 13 February 2007 14:38, Aric Stewart wrote: finds the case where the scrolling amount exceeds the window but still falls within the clipping rect. This generates an additional update region that needs to be invalidated. includes a test Hi, I think your patch has a problem. It

Re: Fix compilation on systems that don't support nameless unions.

2007-03-03 Thread Dmitry Timoshkov
Francois Gouget [EMAIL PROTECTED] wrote: This fixes compilation with gcc 2.95. programs/cmd/batch.c |8 1 files changed, 4 insertions(+), 4 deletions(-) As a more general solution that would also prevent this kind of breakage in future would be to move #define NONAMELESSUNION