Re: programs:extrac32 Add new program (Extrac32.exe) (Pre alpha version :))

2007-07-04 Thread Vitaliy Margolen
Anatoly Lyutin wrote: This program (EXTRAC32.exe) needed for extract *.cab files. Some Win programs use EXTARC32.exe for inner functions and often impossible to change unpacker. I test this EXTRAC32.exe for one program (Russian office program) and it works! I shall be glad for all comments wh

[PATCH] winspool.drv: Fallback to the first found printer as default printer [try 2]

2007-07-04 Thread Pedro Araujo Chaves Jr.
--- dlls/winspool.drv/info.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) Detlef Riekenberg wrote: Sorry, I misinterpreted the Patch because of the subject. I'm fine with your Patch, when you fix your typo: > +if (hadprinter & !haddefault) > +WINSPOOL_SetDefaul

Re: [try4 3/3] gdi32: added PATH_PolyDraw

2007-07-04 Thread Misha Koshelev
> If either part of an if-else statement is compound, then fully-bracketed > syntax (as it is known) is considered good style by some (for example, see > the Indian Hill Style and Coding Standard): it may make problem detection > easier. > > -- > Andy. Ah, ok. Never mind about this stylistic com

winealsa/dsound: Testers asked for capture patch

2007-07-04 Thread Maarten Lankhorst
Since apparantly counter strike goes 2 fps or so when alsa is used and capture is enabled, I was looking to see if that can be speed up,. Since I don't have that game I cannot do it myself, so can someone test attached patch and see if that fixes performance problems? Maarten >From 7593fcf19ba306

Re: CreateJobObject (kernel32) and friends

2007-07-04 Thread Donald Gordon
Robert Shearman wrote: > Donald Gordon wrote: >> Hi >> >> I'm trying to get Visual C++'s vcbuild (builds project files from the >> command line) running under Wine, but it seems to need CreateJobObject >> (and I'm guessing the other job object functions), which doesn't appear >> to be implemented y

Re: CreateJobObject (kernel32) and friends

2007-07-04 Thread Donald Gordon
Dan Kegel wrote: > On 7/4/07, Donald Gordon <[EMAIL PROTECTED]> wrote: >> >> I'm trying to get Visual C++'s vcbuild (builds >> >> project files from the command line) running >> >> under Wine, but it seems to need CreateJobObject >> 2005 "express". The error messages I get are: >> ... >> fixme:syn

Re: CreateJobObject (kernel32) and friends

2007-07-04 Thread Dan Kegel
On 7/4/07, Donald Gordon <[EMAIL PROTECTED]> wrote: >> I'm trying to get Visual C++'s vcbuild (builds >> project files from the command line) running >> under Wine, but it seems to need CreateJobObject 2005 "express". The error messages I get are: ... fixme:sync:CreateJobObjectW (nil) (null) Pro

Re: CreateJobObject (kernel32) and friends

2007-07-04 Thread Donald Gordon
Dan Kegel wrote: > don wrote: >> I'm trying to get Visual C++'s vcbuild (builds >> project files from the command line) running >> under Wine, but it seems to need CreateJobObject > > Which version of Visual C++ is this? > 2005 "express". The error messages I get are: Creating command line "cl.ex

re: CreateJobObject (kernel32) and friends

2007-07-04 Thread Dan Kegel
don wrote: I'm trying to get Visual C++'s vcbuild (builds project files from the command line) running under Wine, but it seems to need CreateJobObject Which version of Visual C++ is this?

Re: [PATCH] WINSPOOL.DRV: Choose first printer found as the default

2007-07-04 Thread Detlef Riekenberg
On Mi, 2007-07-04 at 00:00 -0300, Pedro Araujo Chaves Jr. wrote: > 1. The patch only sets a printer as the default if CUPS doesn't define > one itself; Sorry, I misinterpreted the Patch because of the subject. I'm fine with your Patch, when you fix your typo: > +if (hadprinter & !haddefault

Re: [try4 3/3] gdi32: added PATH_PolyDraw

2007-07-04 Thread Andrew Talbot
Misha Koshelev wrote: > On a more stylistic note, any reason for all these single line if > statements that have their contents enclosed in {}'s? (i.e., instead of: > > if (a) { >call_b(); > } > > why not just: > > if (a) >call_b(); > > If anything, this adds one unnecessary line with

[try4 3/3] gdi32: added PATH_PolyDraw

2007-07-04 Thread Misha Koshelev
> +else if((types[i] & ~PT_CLOSEFIGURE) == PT_LINETO){ > +PATH_LineTo(dc, pts[i].x, pts[i].y); > +} > +if(!((i + 2 < cbPoints) && (types[i + 1] == PT_BEZIERTO) > +&& ((types[i + 2] & ~PT_CLOSEFIGURE) == PT_BEZIERTO))){ > +

Re: [try4 3/3] gdi32: added PATH_PolyDraw

2007-07-04 Thread Misha Koshelev
> @@ -835,6 +835,10 @@ BOOL WINAPI PolyDraw(HDC hdc, const POIN > result = dc->funcs->pPolyDraw( dc->physDev, lppt, lpbTypes, cCount ); > goto end; > } > +if( PATH_IsPathOpen( dc->path ) ){ > +result = PATH_PolyDraw(dc, lppt, lpbTypes, cCount); > +goto end

Re: [advapi32] Create a standard Wine list to keep track of the service handles

2007-07-04 Thread Paul Vriens
On 7/3/07, Paul Vriens <[EMAIL PROTECTED]> wrote: Hi, This patch makes sure we can check if a service handle is valid. With this patch the tests I've sent previously will pass. If this one is accepted I'll resent the corrected tests. Changelog Create a standard Wine list to keep track of th

dsound: Disable property sets if hardware doesn't support it

2007-07-04 Thread Maarten Lankhorst
2007/7/4, Robert Reif <[EMAIL PROTECTED]>: This patch: http://www.winehq.org/pipermail/wine-patches/2007-June/039942.html causes RightMark3DSound.exe (http://audio.rightmark.org/products/rm3ds.shtml) to crash. It appears that the code always expects a property set interface to succeed and crashe

Re: secur32: Don't free the password in InitializeSecurityContextW to enable the credentials handle to be re-used in further InitializeSecurityContextW calls.

2007-07-04 Thread Kai Blin
On Wednesday 04 July 2007 12:37:02 Robert Shearman wrote: > Kai Blin wrote: > > Is that possible in Windows or is this a hack to work around a missing > > credentials cache? > > I've just sent a patch that adds a test for the assumption that > credential handles can be reused and it succeeds on Win

Re: CreateJobObject (kernel32) and friends

2007-07-04 Thread Robert Shearman
Donald Gordon wrote: Hi I'm trying to get Visual C++'s vcbuild (builds project files from the command line) running under Wine, but it seems to need CreateJobObject (and I'm guessing the other job object functions), which doesn't appear to be implemented yet. Correct. Can you not use nmake

Re: secur32: Don't free the password in InitializeSecurityContextW to enable the credentials handle to be re-used in further InitializeSecurityContextW calls.

2007-07-04 Thread Robert Shearman
Kai Blin wrote: Is that possible in Windows or is this a hack to work around a missing credentials cache? I've just sent a patch that adds a test for the assumption that credential handles can be reused and it succeeds on Windows. -- Rob Shearman

Re: ole32: Constify some variables (2 of 2) (Resend)

2007-07-04 Thread Alexandre Julliard
Andrew Talbot <[EMAIL PROTECTED]> writes: > What is wrong with this patch, please? gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_OLE32_ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2