[Winetest] Possible removal of LoadLibrary and friends in the conformance tests

2007-08-07 Thread Paul Vriens
Hi, With the current version of winetest, conformance tests for which the main dll is not available will not run anymore. This will be reported on test.winehq.org. We will be seeing the new approach as of 12:00 GMT when the new winetest.exe is available and the first tests come in. Several

Re: Direct3D Game test framework

2007-08-07 Thread martin pilka
is wined3d built? That was it - I was missing some dev libs. Thanks! I fixed that, now I am receiving this error: Not all of the E2 drivers were found. Check that you have 3DMark installed properly. Attached are the log files from installation and run. Martin 3dmark2000log.tar.gz

Re: [Winetest] Possible removal of LoadLibrary and friends in the conformance tests

2007-08-07 Thread H. Verbeet
On 07/08/07, Paul Vriens [EMAIL PROTECTED] wrote: Eventhough this is some considerable amount of work to be done, in the end the code will be cleaner (and several lines shorter). Comments/remarks ? For what it's worth, the d3d tests typically only need a single export. That should make it

Re: [Winetest] Possible removal of LoadLibrary and friends in the conformance tests

2007-08-07 Thread Paul Vriens
H. Verbeet wrote: On 07/08/07, Paul Vriens [EMAIL PROTECTED] wrote: Eventhough this is some considerable amount of work to be done, in the end the code will be cleaner (and several lines shorter). Comments/remarks ? For what it's worth, the d3d tests typically only need a single export. That

Re: [Winetest] Possible removal of LoadLibrary and friends in the conformance tests

2007-08-07 Thread H. Verbeet
On 07/08/07, Paul Vriens [EMAIL PROTECTED] wrote: You mean 'Direct3DCreate8' in the d3d8 tests (Oh wait, there's also 'ValidateVertexShader' and 'ValidatePixelShader') and 'Direct3DCreate9' in the d3d9 tests? For consistency sake we should change it there as well. Although it's just a

[Winetest] Status update (rsabase and secur32)

2007-08-07 Thread Paul Vriens
Hi, The new winetest is running fine and new reports are produced (http://test.winehq.org/data/200708071000/). I have seen at least 2 things so far that I need some info on. rsabase.dll is not available on for example w2k3 and vista but the tests ran in the past. secur32.dll is not

Re: [Winetest] Possible removal of LoadLibrary and friends in the conformance tests

2007-08-07 Thread Stefan Dösinger
Am Dienstag, 7. August 2007 10:29 schrieb H. Verbeet: On 07/08/07, Paul Vriens [EMAIL PROTECTED] wrote: You mean 'Direct3DCreate8' in the d3d8 tests (Oh wait, there's also 'ValidateVertexShader' and 'ValidatePixelShader') and 'Direct3DCreate9' in the d3d9 tests? For consistency sake we

Re: [Winetest] Possible removal of LoadLibrary and friends in the conformance tests

2007-08-07 Thread Paul Vriens
Stefan Dösinger wrote: Am Dienstag, 7. August 2007 10:29 schrieb H. Verbeet: On 07/08/07, Paul Vriens [EMAIL PROTECTED] wrote: You mean 'Direct3DCreate8' in the d3d8 tests (Oh wait, there's also 'ValidateVertexShader' and 'ValidatePixelShader') and 'Direct3DCreate9' in the d3d9 tests? For

Re: [Winetest] Status update (rsabase and secur32)

2007-08-07 Thread Kai Blin
On Tuesday 07 August 2007 14:43:33 Paul Vriens wrote: Hi, The new winetest is running fine and new reports are produced (http://test.winehq.org/data/200708071000/). I have seen at least 2 things so far that I need some info on. rsabase.dll is not available on for example w2k3 and vista but

Re: WineD3D: move fake context code over to WGL

2007-08-07 Thread Alexandre Julliard
Roderick Colenbrander [EMAIL PROTECTED] writes: Subject: [PATCH] Move WineD3D_CreateFakeGLContext and friends over to WGL. For this we need a HDC and one received from lets say GetDC(0) won't do. Further this HDC needs CS_OWNDC set. For this reason we need our own window class. Why does it

Re: [Winetest] Status update (rsabase and secur32)

2007-08-07 Thread Paul Vriens
Kai Blin wrote: On Tuesday 07 August 2007 14:43:33 Paul Vriens wrote: Hi, The new winetest is running fine and new reports are produced (http://test.winehq.org/data/200708071000/). I have seen at least 2 things so far that I need some info on. rsabase.dll is not available on for example w2k3

Re: [1/6] gdiplus: added GdipBitmapLockBits/GdipBitmapUnlockBits

2007-08-07 Thread Alexandre Julliard
Evan Stade [EMAIL PROTECTED] writes: +bm_is_selected = (BOOL) hdc; That's ugly, you should use something like (hdc != 0) instead. +stride = bmi.bmiHeader.biWidth * bitspp / 8; +stride += stride % 4; This doesn't do what you want. -- Alexandre Julliard [EMAIL PROTECTED]

Re: [2/6] gdiplus: added GdipCreateBitmapFromFile

2007-08-07 Thread Alexandre Julliard
Evan Stade [EMAIL PROTECTED] writes: +CloseHandle(file); + +if(CreateStreamOnHGlobal(buff, TRUE, stream) != S_OK){ +ERR(could not make stream\n); +GdipFree(buff); +return GenericError; +} You should create a stream on the file directly instead of

Re: Missing library - faultrep.

2007-08-07 Thread Alexandre Julliard
Peter Dons Tychsen [EMAIL PROTECTED] writes: I tried to submit a patch for this missing lib, but got zero response. Probably because there was something wrong with my commit. Any guess on what was wrong? You need to write a proper spec file with all exported functions, and you need to

Re: [winecfg] Show version again in About box

2007-08-07 Thread Dmitry Timoshkov
Paul Vriens [EMAIL PROTECTED] wrote: 'Wine 0.9.42' looks so much nicer than 'PACKAGE_STRING'. Thanks for catching this. Although a comment explaining why config.h is needed while there is no visible usage of #ifdef HAVE_xxx macros would be nice. -- Dmitry.

Re: Wine disassembly and reverse engineering rules.

2007-08-07 Thread Jakob Eriksson
James Hawkins wrote: On 8/5/07, Jakob Eriksson [EMAIL PROTECTED] wrote: DMCA Reverse engineering exemption: http://www.chillingeffects.org/reverse/faq.cgi#QID210 From the article: The reverse engineer is required to ask permission first, however. ...good luck with that.

Re: WineD3D: move fake context code over to WGL

2007-08-07 Thread Chris Robinson
On Tuesday 07 August 2007 06:54:37 am Alexandre Julliard wrote: Roderick Colenbrander [EMAIL PROTECTED] writes: Subject: [PATCH] Move WineD3D_CreateFakeGLContext and friends over to WGL. For this we need a HDC and one received from lets say GetDC(0) won't do. Further this HDC needs CS_OWNDC

Re: Wine disassembly and reverse engineering rules.

2007-08-07 Thread Jesse Allen
On 8/7/07, Jakob Eriksson [EMAIL PROTECTED] wrote: James Hawkins wrote: On 8/5/07, Jakob Eriksson [EMAIL PROTECTED] wrote: DMCA Reverse engineering exemption: http://www.chillingeffects.org/reverse/faq.cgi#QID210 From the article: The reverse engineer is required to ask

Re: [Winetest] Possible removal of LoadLibrary and friends in the conformance tests

2007-08-07 Thread Stefan Leichter
Am Tuesday 07 August 2007 09:43 schrieb Paul Vriens: This will be a lengthy process so if there are volunteers, please step up. Eventhough this is some considerable amount of work to be done, in the end the code will be cleaner (and several lines shorter). Comments/remarks ? Make sure that

Re: Missing library - faultrep.

2007-08-07 Thread Peter Dons Tychsen
On Tue, 2007-08-07 at 17:35 +0200, Alexandre Julliard wrote: Peter Dons Tychsen [EMAIL PROTECTED] writes: I tried to submit a patch for this missing lib, but got zero response. Probably because there was something wrong with my commit. Any guess on what was wrong? You need to

re: ANNOUNCE: Wine/Mono Regression Test Suite

2007-08-07 Thread Dan Kegel
Matt wrote: ...I've found that running the mono regression test suite has given me a better idea of how to approach debugging mono/wine. ... http://mhjones.org/wine/wine-tests/wine-test-reader.tar.gz I downloaded this and had a look just now. The instructions still refer to the deprecated 1.1

Re: Missing library - faultrep.

2007-08-07 Thread Alexandre Julliard
Peter Dons Tychsen [EMAIL PROTECTED] writes: You need to write a proper spec file with all exported functions, There are no exported functions (for now). So i guess an empty spec file is OK ? No, there are exported functions in the native dll, you have to declare them as stubs. -- Alexandre

Re: Missing library - faultrep.

2007-08-07 Thread Peter Dons Tychsen
On Tue, 2007-08-07 at 23:15 +0200, Alexandre Julliard wrote: Peter Dons Tychsen [EMAIL PROTECTED] writes: You need to write a proper spec file with all exported functions, There are no exported functions (for now). So i guess an empty spec file is OK ? No, there are exported functions

Re: [Winetest] Status update (rsabase and secur32)

2007-08-07 Thread Robert Kim Wireless Internet Advisor
Paul, need more details here. Is that the latest dll version? On 8/7/07, Paul Vriens [EMAIL PROTECTED] wrote: Hi, The new winetest is running fine and new reports are produced (http://test.winehq.org/data/200708071000/). I have seen at least 2 things so far that I need some info on.

Re: user32: CallWindowProc[AW] for mismatched built-in winprocs should take into account if the window is Unicode (with testcase, fixes bug #9198)

2007-08-07 Thread Dmitry Timoshkov
Mikolaj Zalewski [EMAIL PROTECTED] wrote: --- a/dlls/user32/tests/class.c +++ b/dlls/user32/tests/class.c @@ -32,6 +32,7 @@ #include winreg.h #include wingdi.h #include winuser.h +#include commctrl.h /* for WC_EDITW */ Besides using braces instead of quotes to match existing style it's not

Re: WineD3D: move fake context code over to WGL

2007-08-07 Thread Joseph Garvin
Alexandre Julliard wrote: Roderick Colenbrander [EMAIL PROTECTED] writes: Subject: [PATCH] Move WineD3D_CreateFakeGLContext and friends over to WGL. For this we need a HDC and one received from lets say GetDC(0) won't do. Further this HDC needs CS_OWNDC set. For this reason we need our own