Re: user32: static controls should have a clipping region set whilesending the WM_CTLCOLORSTATIC (with testcase, fixes bug #9195)

2007-08-23 Thread Dmitry Timoshkov
Mikolaj Zalewski [EMAIL PROTECTED] wrote: Photoshop ImageReady depends on it. You have added an explicit clipping to STATIC_PaintTextfn, but since you are working on it, please test other static styles as well. Btw, if you are keen on writing a test (or making your test generic) for button

Re: [1/5] WineD3D: Fall back to drawStridedSlow if fog coords are used

2007-08-23 Thread Stefan Dösinger
This patch is probably fine, but it makes me look into the surrounding code [ software blending, changing the strided data ], which is still incredibly misleading. That should go into its own function, with the FIXVBO macro removed (since all such macros are evil, without exception), and a

Re: wordpad: Add initial printing support

2007-08-23 Thread Stefan Dösinger
Am Donnerstag, 23. August 2007 01:52 schrieb Alexander Nicolaysen Sørnes: wordpad: Add initial printing support I usually don't read non-d3d patches, but when I saw the wordpad patches I decided to see what wordpad looks like today, and I am really impressed :-) Good work! This makes me wonder

Re: [PATCH try3 5/5] wininet: When sending INTERNET_STATUS_HANDLE_CLOSING make sure the freed handle is not yet available.

2007-08-23 Thread Alexandre Julliard
Misha Koshelev [EMAIL PROTECTED] writes: +/* As on native when the equivalent of WININET_Release is called, the handle + * is already invalid, but if a new handle is created at this time it does + * not yet get assigned the freed handle number */ if( info )

[winetest] Use of HeapAlloc and friends

2007-08-23 Thread Paul Vriens
Hi, Is there any particular reason we don't use HeapAlloc/HeapReAlloc in winetest? The rest of our programs do, but winetest uses malloc and realloc. Cheers, Paul.

Re: wordpad: Add initial printing support

2007-08-23 Thread Alexander Nicolaysen Sørnes
Torsdag 23 august 2007 12:16, skrev du : Am Donnerstag, 23. August 2007 01:52 schrieb Alexander Nicolaysen Sørnes: wordpad: Add initial printing support I usually don't read non-d3d patches, but when I saw the wordpad patches I decided to see what wordpad looks like today, and I am really

Re: [winetest] Use of HeapAlloc and friends

2007-08-23 Thread Ferenc Wagner
Paul Vriens [EMAIL PROTECTED] writes: Is there any particular reason we don't use HeapAlloc/HeapReAlloc in winetest? The rest of our programs do, but winetest uses malloc and realloc. I can't recall any. I'm more comfortable with the latter, since winetest is the only Win32 application I've

Re: [winetest] Use of HeapAlloc and friends

2007-08-23 Thread Paul Vriens
Ferenc Wagner wrote: Paul Vriens [EMAIL PROTECTED] writes: Is there any particular reason we don't use HeapAlloc/HeapReAlloc in winetest? The rest of our programs do, but winetest uses malloc and realloc. I can't recall any. I'm more comfortable with the latter, since winetest is the only

Re: [winetest] Use of HeapAlloc and friends

2007-08-23 Thread Ferenc Wagner
Paul Vriens [EMAIL PROTECTED] writes: Ferenc Wagner wrote: Paul Vriens [EMAIL PROTECTED] writes: Is there any particular reason we don't use HeapAlloc/HeapReAlloc in winetest? The rest of our programs do, but winetest uses malloc and realloc. I can't recall any. I'm more comfortable with

Re: [winetest] Use of HeapAlloc and friends

2007-08-23 Thread Dmitry Timoshkov
Paul Vriens [EMAIL PROTECTED] wrote: Is there any particular reason we don't use HeapAlloc/HeapReAlloc in winetest? The rest of our programs do, but winetest uses malloc and realloc. I recall that replacing malloc/realloc by HeapAlloc/HeapReAlloc has fixed user32/tests/msg.c failures under

Re: shlwapi: Fix UrlCombineW for absolute URLs without slashes.

2007-08-23 Thread Dmitry Timoshkov
Robert Shearman [EMAIL PROTECTED] wrote: +process_case = (*base.pszSuffix == L'/') ? 5 : 1; Although using the L prefix is harmless in this case, it's better to avoid it in Wine code IMO. -- Dmitry.

Application minimizing resizes it to icon size.

2007-08-23 Thread Meelis Mägi
Hello, i have a silly question. Why does application resized to icon size when it gets minimized ? (also when switching desktops, but thats acts as minimizing i think) Reason i ask is that, there is MMO Ryzom (ryzom.com), that gets a bit confused when minimized and ingame UI gets messed up (only

DIB Driver code available

2007-08-23 Thread Jesse Allen
Hi, I have my DIB driver code available on a public git host now: http://repo.or.cz/w/wine/dibdrv.git I'm going to briefly describe it. The dib driver (or engine) is a gdi driver. It is loaded into a dc when an application selects a dib, and overrides the existing driver. The magic takes place

Re: Application minimizing resizes it to icon size.

2007-08-23 Thread Stefan Dösinger
Am Donnerstag, 23. August 2007 18:56 schrieb Meelis Mägi: Hello, i have a silly question. Why does application resized to icon size when it gets minimized ? (also when switching desktops, but thats acts as minimizing i think) Reason i ask is that, there is MMO Ryzom (ryzom.com), that gets a

Re: DIB Driver code available

2007-08-23 Thread Alexandre Julliard
Jesse Allen [EMAIL PROTECTED] writes: Indeed, my tests show that there is a 50 second difference with GDI Get/SetPixel. If anyone wants to try my app, I'll send it to them :) Note that GetPixel is the worst possible case under X, since it takes a full server roundtrip for each pixel. So yes, a

Re: Application minimizing resizes it to icon size.

2007-08-23 Thread Meelis Mägi
2007/8/23, Stefan Dösinger [EMAIL PROTECTED]: Am Donnerstag, 23. August 2007 18:56 schrieb Meelis Mägi: Hello, i have a silly question. Why does application resized to icon size when it gets minimized ? (also when switching desktops, but thats acts as minimizing i think) Reason i ask

Re: DIB Driver code available

2007-08-23 Thread Stefan Dösinger
Am Donnerstag, 23. August 2007 18:58 schrieb Jesse Allen: Hi, I have my DIB driver code available on a public git host now: http://repo.or.cz/w/wine/dibdrv.git I'm going to briefly describe it. Is your dib driver an all or nothing replacement of winex11 GDI drawing, or can it be mixed with

Re: Application minimizing resizes it to icon size.

2007-08-23 Thread Stefan Dösinger
Am Donnerstag, 23. August 2007 20:02 schrieb Meelis Mägi: commands i used to run Ryzom: 1)wine client_ryzom_rd.exe 2)wine explorer.exe /desktop=ryzom,1280x1024 client_ryzom_rd.exe (minimizing Ryzom window inside wine desktop) Ryzom hates to be resized to icon mode in both occasions. it

Re: user32: static controls should have a clipping region set while sending the WM_CTLCOLORSTATIC (2nd version, with testcase, fixes bug #9195)

2007-08-23 Thread James Hawkins
On 8/23/07, Mikolaj Zalewski [EMAIL PROTECTED] wrote: Tests have shown that every control style should set the clipping region so I've changed the patch. You forgot the patch. -- James Hawkins

Re: DIB Driver code available

2007-08-23 Thread Jesse Allen
On 8/23/07, Stefan Dösinger [EMAIL PROTECTED] wrote: Am Donnerstag, 23. August 2007 18:58 schrieb Jesse Allen: Hi, I have my DIB driver code available on a public git host now: http://repo.or.cz/w/wine/dibdrv.git I'm going to briefly describe it. Is your dib driver an all or nothing

[test.winehq.org] Addition of todo on the results page

2007-08-23 Thread Paul Vriens
Hi, While I'm also busy with getting dll information on the page, I'm still adding stuff. This next iteration will add todo information on the pages. Current situation: http://test.winehq.org/data/200708221000/ There are several todo's for the Wine test but this is not shown on the page.

What the web test reports need.

2007-08-23 Thread Jakob Eriksson
We need a http://test.winehq.org/data/latest/ Which always points to the latest results. Instead of: http://test.winehq.org/data/200708221000/ etc... Who can fix this? regards, Jakob

Re: [patch] Garbage code in text string display

2007-08-23 Thread Guan Xin
On 8/23/07, Juan Lang [EMAIL PROTECTED] wrote: You may generally post source to wine-devel if it's short and to the point. Please don't post a binary. Acturally, this bug is obvious as I have pointed it out. No source is needed for demonstration. Also I always programmed with Borland's AFX

Re: DIB Driver code available

2007-08-23 Thread Stefan Dösinger
Am Donnerstag, 23. August 2007 20:59 schrieb Jesse Allen: While you're at it, can you make it more universal so we can add a wined3d driver too, and convince AJ about it? Okay, but the dib driver is special. A dib works on any device, so that's why I can convert between. You're not

Re: [test.winehq.org] Addition of todo on the results page

2007-08-23 Thread Michael Stefaniuc
Hello, Paul Vriens wrote: While I'm also busy with getting dll information on the page, I'm still adding stuff. This next iteration will add todo information on the pages. Current situation: http://test.winehq.org/data/200708221000/ There are several todo's for the Wine test but

Re: [patch] Garbage code in text string display

2007-08-23 Thread Reece Dunn
On 23/08/07, Guan Xin [EMAIL PROTECTED] wrote: On 8/23/07, Juan Lang [EMAIL PROTECTED] wrote: You may generally post source to wine-devel if it's short and to the point. Please don't post a binary. Acturally, this bug is obvious as I have pointed it out. No source is needed for

re: mscoree: Return S_OK if mono runtime is found

2007-08-23 Thread Dan Kegel
Hi Bryan, I believe your patch lets me install WinBITS successfully. Thanks! - Dan p.s. To be precise, it let winetricks mono12 wine msiexec /i WinBITS.msi work. I then had to do winetricks gdiplus corefonts else the startup would complain about a missing font. Now mono's only complaining

Photoshop CS2 surprise

2007-08-23 Thread Dan Kegel
I fired up Photoshop CS2 today on a hunch, and sure enough, it starts and runs just barely well enough to test! When it starts, you have to dismiss a dialog box, press ^C in the console, and then dismiss another dialog box, but after that you can open an image, edit it, and save it successfully.

Re: [test.winehq.org] Addition of todo on the results page

2007-08-23 Thread John Klehm
Bit off topic: One thing that struck me was the difference in test results for the Wine runs. This has most likely to do with old Wine installations running new tests. I will add the Wine version to the infrastructure soon so that these outcomes make more sense. In the same vein of