Re: setupapi(8/22): Implement SetupDiCreateDeviceInfoW

2007-09-20 Thread Alexandre Julliard
Juan Lang [EMAIL PROTECTED] writes: +static DWORD SETUPDI_DevNameToDevID(LPCWSTR devName) +{ +LPCWSTR ptr; +DWORD devNameLen = lstrlenW(devName), devInst = 0; +BOOL valid = TRUE; + +TRACE(%s\n, debugstr_w(devName)); +for (ptr = devName; valid *ptr ptr - devName

Re: Alexandre Julliard : wordpad.exe: We can now store binary files in the repository.

2007-09-20 Thread Alexandre Julliard
Markus Amsler [EMAIL PROTECTED] writes: So we can also add ttf fonts and get rid of the fontforge dependency? No, I don't think ttf is an appropriate source format. -- Alexandre Julliard [EMAIL PROTECTED]

Re: winex11.drv/wintab32[3/5]: make wintab strings in winex11.drv Unicode, implement WTInfoW

2007-09-20 Thread Alexandre Julliard
Mikolaj Zalewski [EMAIL PROTECTED] writes: @@ -305,8 +312,8 @@ void X11DRV_LoadTabletInfo(HWND hwnddefault) hwndTabletDefault = hwnddefault; /* Do base initializaion */ -strcpy(gSysContext.lcName, Wine Tablet Context); -strcpy(gSysDevice.NAME,Wine Tablet Device); +

Re: setupapi(8/22): Implement SetupDiCreateDeviceInfoW

2007-09-20 Thread Juan Lang
This won't do what you want. You'd need *= 10 if the id is really stored in decimal, though looks more like it should be in hex. You're right. It is decimal. Thanks. --Juan

Re: WineD3D: better video memory reporting

2007-09-20 Thread Juan Lang
Your patch appears empty: Type: text/x-diff Size: 0 bytes --Juan

[PATCH] fix small spelling mistakes

2007-09-20 Thread Juan Lang
Hi Peter, correct spelling of iff - if Just so you know, iff is a common abbreviation meaning if and only if. I don't think that's any clearer in the cases you modified, so I think your patch is fine, I just thought you (and others) might be interested. --Juan

Re: WineD3D: better video memory reporting

2007-09-20 Thread John Klehm
On 9/20/07, Juan Lang [EMAIL PROTECTED] wrote: Your patch appears empty: Came through ok here. --John Klehm

Re: Will ROS and WINE still be steady be synchronized ?

2007-09-20 Thread Shachar Shemesh
Alexander Nicolaysen Sørnes wrote: ReactOS has been known for disassembling Microsoft binaries, which is illegal in some countries, notably the US. As far as I understand this, if I disassemble Microsoft binaries (it is legal in Israel), then the resulting knowledge is legal to use - anywhere

Re: [PATCH] fix small spelling mistakes

2007-09-20 Thread Peter Oberndorfer
On Thursday 20 September 2007, Juan Lang wrote: Hi Peter, correct spelling of iff - if Just so you know, iff is a common abbreviation meaning if and only if. I don't think that's any clearer in the cases you modified, so I think your patch is fine, I just thought you (and others) might

Re: Implemented PsCreateSystemThread in ntoskrnl.exe

2007-09-20 Thread Juan Lang
Hi Carroll, +if (ProcessHandle!=0) + localThreadHandle = CreateRemoteThread(ProcessHandle,0,0,StartRoutine,StartContext,0,ThreadId); +else localThreadHandle = CreateThread(0,0,StartRoutine,StartContext,0,ThreadId); + +if (localThreadHandle==0) return STATUS_SEVERITY_ERROR; You

Re: Implemented PsCreateSystemThread in ntoskrnl.exe

2007-09-20 Thread Robert Shearman
Juan Lang wrote: Hi Carroll, +if (ProcessHandle!=0) + localThreadHandle = CreateRemoteThread(ProcessHandle,0,0,StartRoutine,StartContext,0,ThreadId); +else localThreadHandle = CreateThread(0,0,StartRoutine,StartContext,0,ThreadId); + +if (localThreadHandle==0) return

Re: Implemented PsCreateSystemThread in ntoskrnl.exe

2007-09-20 Thread Juan Lang
Actually, NtCreateThread is too low-level and so isn't implemented in Wine. RtlCreateUserThread might be better to use though. Whoops :) Thanks, Rob. --Juan

Re: Always set DIOBJECTDATAFORMAT.pguid to GUID_Button for joystick buttons

2007-09-20 Thread Vitaliy Margolen
Antonio Cuni wrote: At least one game (Pro Evolution Soccer 6) rely on the pguid field of the DIOBJECTDATAFORMAT struct to respond to joystick button's events. Setting pguid to GUID_Button solves the problem. 2007-09-20 Antonio Cuni [EMAIL PROTECTED] * dlls/dinput/joystick_linux.c,

Re: Always set DIOBJECTDATAFORMAT.pguid to GUID_Button for joystick buttons

2007-09-20 Thread John Klehm
On 9/20/07, Antonio Cuni [EMAIL PROTECTED] wrote: At least one game (Pro Evolution Soccer 6) rely on the pguid field of the DIOBJECTDATAFORMAT struct to respond to joystick button's events. Setting pguid to GUID_Button solves the problem. 2007-09-20 Antonio Cuni [EMAIL PROTECTED] *

Re: Patch: ntoskrnl.exe - Added PsCreateSystemThread

2007-09-20 Thread Dmitry Timoshkov
Carroll Vance [EMAIL PROTECTED] wrote: I have implemented PsCreateSystemThread in ntoskrnl.exe. This API i have found used by programs like nProtect gameguard, and is a pretty commonly used kernel api. This either ends up calling CreateThread or CreateRemoteThread depending on if a process

re: Will ROS and WINE still be steady be synchronized ?

2007-09-20 Thread Dan Kegel
Shachar Shemesh wrote: As far as I understand this, if I disassemble Microsoft binaries (it is legal in Israel), then the resulting knowledge is legal to use - anywhere (in other words - the only one who can be sued is me, and the jurisdiction is Israel, where the action is legal). I am not a

Re: Will ROS and WINE still be steady be synchronized ?

2007-09-20 Thread Shachar Shemesh
Dan Kegel wrote: I am not a lawyer, but I bet you're wrong there. The disassembled code is probably considered a copy, I'm not talking about moving disassembled code into our code. That is a copyright violation in Israel too. I'm talking about disassembling code in order to figure out what

Re: Will ROS and WINE still be steady be synchronized ?

2007-09-20 Thread Dan Kegel
On 9/20/07, Shachar Shemesh [EMAIL PROTECTED] wrote: I'm not talking about moving disassembled code into our code. That is a copyright violation in Israel too. I'm talking about disassembling code in order to figure out what it does, and then reimplementing that (with or without going into the

Re: Will ROS and WINE still be steady be synchronized ?

2007-09-20 Thread Shachar Shemesh
Dan Kegel wrote: We've gone over this about a dozen times. Can we get back to programming Wine now (cleanly)? - Dan Here's the law as I know it. As far as I know, it is quite identical in the US and in Israel in that regard: - Any trade secret (say, algorithm, interface, subbehavior) loses