Re: mpr: Changes comparison of dwScope in WNetOpenEnum function

2007-09-24 Thread Juan Lang
Hi Konstantin, - providerTable->table[index].dwEnumScopes & dwScope) + providerTable->table[index].dwEnumScopes & WNNC_ENUM_GLOBAL) This change looks correct, but it should be changed in the next block as well:

Re: CryptAcquireContext Failure, default/Type 024 requested

2007-09-24 Thread Rob Seger
Sweet! Thanks! I'll see what I can do and probably end up asking some more specific questions later ;) Rob On 9/24/07, Juan Lang <[EMAIL PROTECTED]> wrote: > > I found the wincrypt.h #define line that says what type 024 > > is: #define PROV_RSA_AES 24. > > In that case, it should be straightforw

Re: shdocvw: Added WebBrowser::FullScreen property implementation.

2007-09-24 Thread Reece Dunn
On 23/09/2007, Jacek Caban <[EMAIL PROTECTED]> wrote: > --- > dlls/shdocvw/shdocvw.h |1 + > dlls/shdocvw/tests/webbrowser.c | 23 +++ > dlls/shdocvw/webbrowser.c | 15 +++ > 3 files changed, 35 insertions(+), 4 deletions(-) > +hres = IWe

Re: [OT] Freemail Terms Of Use [was: Wine autorunner]

2007-09-24 Thread Reece Dunn
On 23/09/2007, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > Am Sonntag, 23. September 2007 01:42:46 schrieb Computer Dude: > _ > > Connect to the next generation of MSN Messenger > > http://imagine-msn.com/messenger/launch80/default.a

Re: CryptAcquireContext Failure, default/Type 024 requested

2007-09-24 Thread Juan Lang
> I found the wincrypt.h #define line that says what type 024 > is: #define PROV_RSA_AES 24. In that case, it should be straightforward enough to add an AES implementation to Wine's rsaenh.dll. There's free (as in speech) source available for it. Take a look at rsaenh.c and implglue.c in dlls/rs

Re: wtsapi32: add stub for WTSRegisterSessionNotification

2007-09-24 Thread Louis. Lenders
Anything wrong with these simple stubs? http://www.winehq.org/pipermail/wine-patches/2007-September/043944.html and http://www.winehq.org/pipermail/wine-patches/2007-September/043945.html ? - Yahoo! Answers - Get better answers from someone who knows. Tryi

Re: mlang: fix memory leaks in error path (found by Smatch).

2007-09-24 Thread Michael Stefaniuc
Tijl Coosemans wrote: > On Monday 24 September 2007 14:20:51 Lionel_Debroux wrote: >> ConvertINetString leaks some heap memory in an error path. Found in >> Michael Stefaniuc's list of Wine potential bugs detected by Smatch. >> >> 2007-09-24 Lionel Debroux <[EMAIL PROTECTED]> >>* dlls/mlan

Re: Would like to contribute to wine

2007-09-24 Thread Roderick Colenbrander
> > Correct but we don't have it in Wine. If we added the Drv functions, > > while I have the parts of the DIB engine unimplemented, I could > > forward back to the driver alot easier. There is maybe another way, > > but having Drv functions make sense in my mind. > > That would be perfect (IMHO),

Re: Does MWM_DECOR_BORDER really cause window to have caption?

2007-09-24 Thread Kirill K. Smirnov
> > Anyway, what is the purpose of setting MWM_DECOR_BORDER to borderless > > window (style is WS_CLIPSIBLINGS only)? KDE, XFCE, fluxbox work OK > > without it. > > If you mean the following line in > dlls/winex11.drv/window.c,X11DRV_set_wm_hints() > > else if (!(style & (WS_CHILD|WS_POPUP)

Re: mlang: fix memory leaks in error path (found by Smatch).

2007-09-24 Thread Dmitry Timoshkov
"Tijl Coosemans" <[EMAIL PROTECTED]> wrote: > > hr = ConvertINetMultiByteToUnicode(pdwMode, dwSrcEncoding, > > pSrcStr, pcSrcSize, pDstStrW, &cDstSizeW); > > if (hr != S_OK) > > -return hr; > > +goto cleanup; > > > > hr = ConvertINetUnicodeToMu

Re: mlang: fix memory leaks in error paths (found by Smatch).

2007-09-24 Thread Lionel_Debroux
Lionel_Debroux wrote: > EnumRfc1766_create leaks some heap memory in two error paths. Found in > Michael Stefaniuc's list of Wine potential bugs detected by Smatch. > > 2007-09-24 Lionel Debroux <[EMAIL PROTECTED]> >* dlls/mlang/mlang.c: >mlang: fix memory leaks in error paths (fo

Re: pdh: add tests for XP variant of api call

2007-09-24 Thread Hans Leidekker
On Monday 24 September 2007 14:20:12 Jeff Latimer wrote: > > All tests succeed here on 2003 without your patch. > That means that they must be XP specific. I noticed some vista specfic > bugs bugs being reported. The failures on Vista are at least in part different from XPs because of insuffic

Re: Does MWM_DECOR_BORDER really cause window to have caption?

2007-09-24 Thread Dmitry Timoshkov
"Kirill K. Smirnov" <[EMAIL PROTECTED]> wrote: >> There is a distinct MWM hint to add a caption to a window: MWM_DECOR_TITLE. >> If this is proved to be a KDE/XFCE bug it should be reported to an >> appropriate bug tracking system. > > It's better to write pure X11 app to demonstate it, but I am

Re: The Spouse Test

2007-09-24 Thread Tim Schmidt
On 9/24/07, Stephan Rose <[EMAIL PROTECTED]> wrote: > That reminds me, one of the things I personally would love to see Wine > support is Solidworks. It's about the only thing at work I still need to > boot into Windows for occasionally. Same here. > Solidworks actually installs now, it didn't ea

Re: mlang: fix memory leaks in error path (found by Smatch).

2007-09-24 Thread Tijl Coosemans
On Monday 24 September 2007 14:20:51 Lionel_Debroux wrote: > ConvertINetString leaks some heap memory in an error path. Found in > Michael Stefaniuc's list of Wine potential bugs detected by Smatch. > > 2007-09-24 Lionel Debroux <[EMAIL PROTECTED]> >* dlls/mlang/mlang.c: >mlang: f

Re: Does MWM_DECOR_BORDER really cause window to have caption?

2007-09-24 Thread Kirill K. Smirnov
> "Kirill K. Smirnov" <[EMAIL PROTECTED]> wrote: > > I'm trying to get winamp playlist window to be painted correctly (bug > > #8300). The problem is: > > 0) wine version is git-current. > > 1) winamp playlist window style is WS_CLIPSIBLINGS > > 2) winex11 driver converts it to MWM_DECOR_BORDER hin

Re: The Spouse Test

2007-09-24 Thread Stephan Rose
On Sun, 2007-09-23 at 00:44 -0700, Dan Kegel wrote: > When will Wine be good enough for the average person to use? > One test is, "Is it good enough to let your spouse migrate to Linux > from Windows?". > My wife's must-have app list is roughly > > Microsoft Office '97 > Adobe Photoshop Elements

Re: pdh: add tests for XP variant of api call

2007-09-24 Thread Jeff Latimer
Hans Leidekker wrote: > On Monday 24 September 2007 12:13:50 Jeff Latimer wrote: > > All tests succeed here on 2003 without your patch. That means that they must be XP specific. I noticed some vista specfic bugs bugs being reported. > Even if APIs return > different values on different versio

Re: pdh: add tests for XP variant of api call

2007-09-24 Thread Hans Leidekker
On Monday 24 September 2007 12:13:50 Jeff Latimer wrote: > This patch adds the variations to the api that XP implements. My > assumption is that these changes will, mostly, be reflected in 2003 and > Vista. I can't check them so if someone could give them a run and let > know, that would be f

Re: pdh: add tests for XP variant of api call

2007-09-24 Thread Jeff Latimer
Hans Leidekker wrote: > On Monday 24 September 2007 12:13:50 Jeff Latimer wrote: > >> I will get on with adding the variations to pdh.c >> > To prevent you doing any duplicate work, I have implementations > of PdhCalculateCounterFromRawValue, PdhCollectQueryDataEx and > PdhValidatePath{,Ex}

Re: pdh: add tests for XP variant of api call

2007-09-24 Thread Hans Leidekker
On Monday 24 September 2007 12:13:50 Jeff Latimer wrote: > This patch adds the variations to the api that XP implements. My > assumption is that these changes will, mostly, be reflected in 2003 and > Vista. I can't check them so if someone could give them a run and let > know, that would be f

Re: Would like to contribute to wine

2007-09-24 Thread Detlef Riekenberg
On So, 2007-09-23 at 17:15 -0600, Jesse Allen wrote: > Correct but we don't have it in Wine. If we added the Drv functions, > while I have the parts of the DIB engine unimplemented, I could > forward back to the driver alot easier. There is maybe another way, > but having Drv functions make sense

Re: Does MWM_DECOR_BORDER really cause window to have caption?

2007-09-24 Thread Dmitry Timoshkov
"Kirill K. Smirnov" <[EMAIL PROTECTED]> wrote: > I'm trying to get winamp playlist window to be painted correctly (bug #8300). > The problem is: > 0) wine version is git-current. > 1) winamp playlist window style is WS_CLIPSIBLINGS > 2) winex11 driver converts it to MWM_DECOR_BORDER hint. (window.

Re: Is ICU no longer a dependency of Wine?

2007-09-24 Thread Maarten Lankhorst
Scott Ritchie schreef: > I stumbled across this patch while browsing recent commits: > > http://www.winehq.org/pipermail/wine-cvs/2007-September/036309.html > > Am I correct to say that we no longer need libicu when compiling Wine? > > > By the way, it would be nice if someone shot off an email to

Does MWM_DECOR_BORDER really cause window to have caption?

2007-09-24 Thread Kirill K. Smirnov
Hi, I'm trying to get winamp playlist window to be painted correctly (bug #8300). The problem is: 0) wine version is git-current. 1) winamp playlist window style is WS_CLIPSIBLINGS 2) winex11 driver converts it to MWM_DECOR_BORDER hint. (window.c:599) 3) This hint behaviour is WM-dependent: a) KD

Re: [2/5] WineD3D: Recompile glsl pixelshaders if the sampler format changes

2007-09-24 Thread Stefan Dösinger
Am Sonntag, 23. September 2007 22:23:06 schrieb Vitaliy Margolen: > Stefan Dösinger wrote: > > > > This patch causes noticeable slowdown in Counter Strike Source stress test > in the first part of it (rotating panels). Testing

Re: strange pixel format

2007-09-24 Thread Stefan Dösinger
Am Sonntag, 23. September 2007 05:20:06 schrieb Jose Osvaldo: > The No-CD crack for "The Sims" calls to "IDirectDrawImpl_CreateSurface" > (ddls/ddraw.c) which calls to "IDirectDrawImpl_CreateNewSurface". Is this behavior added by the nocd crack? > The abnormal value is this: > > dwFlags = 0x0