Re: kernel32: fix memory leak (found by Smatch).

2007-10-12 Thread Lionel Debroux
Is there anything wrong with this patch ? I think this one is a real memory leak. WaitNamedPipeW in dlls/kernel32/sync.c gets flagged by Michael Stefaniuc's unfree-wine.pl script for leaking pipe_wait. pipe_wait isn't used anywhere between its allocation and the memory leak in the error

Re: 1.0 Bugs - Microsoft Office 2003

2007-10-12 Thread Francois Gouget
On Sun, 7 Oct 2007, Dan Kegel wrote: [...] Do we want to add Microsoft Word 2003 to the must have apps list for 1.0? It might delay the release. I think the only applications which should block Wine releases should be ones which are freely downloadable and for which automated tests exist

Re: defining and revamping our bugzilla categories

2007-10-12 Thread Francois Gouget
On Thu, 11 Oct 2007, Steven Edwards wrote: [...] gdi printing [...] Yes I second this motion. The components should be named as simply as possible. Users are going to be the ones filing the reports and whoever is doing triage is going to have to move it around if its in the wrong area.

Re: [2/5] WineD3D: Add support for other ps 3.0 varyings

2007-10-12 Thread Alexandre Julliard
Stefan Dösinger [EMAIL PROTECTED] writes: +usage = (usage_token WINED3DSP_DCL_USAGE_MASK) WINED3DSP_DCL_USAGE_SHIFT; +usage_idx = (usage_token WINED3DSP_DCL_USAGEINDEX_MASK) WINED3DSP_DCL_USAGEINDEX_SHIFT; +//shader_glsl_get_write_mask(register_token, reg_mask);

Re: kernel32/locale.c: partially implement GetUserGeoID() (try2)

2007-10-12 Thread Alexandre Julliard
EA Durbin [EMAIL PROTECTED] writes: GEOID WINAPI GetUserGeoID( GEOCLASS GeoClass ) { -FIXME(%d\n,GeoClass); -return GEOID_NOT_AVAILABLE; +GEOID ret = GEOID_NOT_AVAILABLE; +static const WCHAR geoW[] = {'G','e','o',0}; +static const WCHAR nationW[] =

Re: Translations

2007-10-12 Thread Daniel Nylander
fre 2007-10-12 klockan 14:02 +0200 skrev Marcus Meissner: I would really like to translate the graphical tools (such as winecfg) but as I can see it, it's not possible at the moment. Have you thought about implementing some sort of i18n/l10n framework? This is done via the Windows

Re: defining and revamping our bugzilla categories

2007-10-12 Thread Jan Zerebecki
On Fri, Oct 12, 2007 at 11:09:53AM -0500, James Hawkins wrote: On 10/12/07, Francois Gouget [EMAIL PROTECTED] wrote: On Thu, 11 Oct 2007, Steven Edwards wrote: One more issue to raise: is the reason why we have 'wine-' as the prefix to avoid conflicts between different products? That is,

Re: server: Use the security descriptor passed in when creating events.

2007-10-12 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman [EMAIL PROTECTED] writes: Use a new object_attributes struct for passing the information about whether a security descriptor is specified or not to the server. This breaks Photoshop CS2, we segfault while trying to access a security

Re: Support GCOV for Wine 1.0?

2007-10-12 Thread Dan Kegel
On 10/12/07, Dimi Paun [EMAIL PROTECTED] wrote: This is developer's info, and I think most developers rather use the wiki than the other types of documentation. I think the real problem is that the website uses a template system that is hard to preview. The advantage of the wiki is that

Re: Support GCOV for Wine 1.0?

2007-10-12 Thread Dimi Paun
On Fri, 2007-10-12 at 10:47 -0700, Dan Kegel wrote: It'd be nice to have the best of both worlds, i.e. a wiki backed by git, and written in such a way that users who preferred to avoid online editing could use git to edit it locally, using an easy local preview tool, with strong formatting

Re: Support GCOV for Wine 1.0?

2007-10-12 Thread Dimi Paun
On Fri, 2007-10-12 at 10:01 -0700, Dan Kegel wrote: Yes, we should remove all web pages from the entire web and put them in a wiki. I think he meant that at least a link should be made from the Wiki :) This is developer's info, and I think most developers rather use the wiki than the other

AW: tools/wineprefixcreate.in: create default w32x86 path underspool/drivers

2007-10-12 Thread Markus Gömmel
Hi Detlef, ah, I understand... I'm a Windows software developer trying to make our products running as smooth as possible under Wine. One of our products includes a fax printer driver and port monitor for faxing over ISDN boards. The setup routine of our product will not use an .inf file to

Re: What happened to the Wine Newsletters?

2007-10-12 Thread Alex Waite
Juan Lang wrote: Ok, I'll get working on this soon. I have midterms this week, and then I'll start looking at it. Would you guys prefer if I tried to cover all the major news since the last WWN (thus less specific detail on each) or just the recent stuff in more detail? Personally, I

Re: Support GCOV for Wine 1.0?

2007-10-12 Thread Dan Kegel
On 10/12/07, James Hawkins [EMAIL PROTECTED] wrote: http://www.winehq.org/site/docs/winedev-guide/x1374 This information should be in the Wiki somewhere. Yes, we should remove all web pages from the entire web and put them in a wiki. - Dan

Re: 1.0 Bugs - Microsoft Office 2003

2007-10-12 Thread Dan Kegel
On 10/12/07, Francois Gouget [EMAIL PROTECTED] wrote: I think the only applications which should block Wine releases should be ones which are freely downloadable and for which automated tests exist (with cxtest, yawt or something). The rational is that everyone should be able to run the tests

Re: defining and revamping our bugzilla categories

2007-10-12 Thread James Hawkins
On 10/12/07, Francois Gouget [EMAIL PROTECTED] wrote: On Thu, 11 Oct 2007, Steven Edwards wrote: [...] gdi printing [...] Yes I second this motion. The components should be named as simply as possible. Users are going to be the ones filing the reports and whoever is doing triage is

Re: Translations

2007-10-12 Thread Marcus Meissner
On Fri, Oct 12, 2007 at 01:44:45PM +0200, Daniel Nylander wrote: I would like to contribute to the Wine project by submitting Swedish translations. I would really like to translate the graphical tools (such as winecfg) but as I can see it, it's not possible at the moment. Have you

Re: make test drill

2007-10-12 Thread Marcus Meissner
On Fri, Oct 12, 2007 at 12:22:43PM +0200, Francois Gouget wrote: On Tue, 9 Oct 2007, Jeremy White wrote: [...] I think a test that fails, or crashes a system because of a driver bug is a broken test. It's admittedly hard to write a test that will detect a vmware situation or driver

Re: defining and revamping our bugzilla categories

2007-10-12 Thread Detlef Riekenberg
On Do, 2007-10-11 at 14:24 -0500, James Hawkins wrote: wine-gdi-(printing) - gdi I vote for printing next to gdi What's wrong with having a new printing component? That was my vote above. I asked for a printing component over 1 year ago, but only wine-gdi was changes to

Re: make test drill

2007-10-12 Thread Francois Gouget
On Wed, 10 Oct 2007, Steven Edwards wrote: [...] Just to be clear, what I mean is a whitelist rather than a blacklist. The problem with whitelists is that they will stop us from finding where there are issues. They may be ok when running the tests on Windows as we don't really care if our

Re: make test drill

2007-10-12 Thread Francois Gouget
On Tue, 9 Oct 2007, Jeremy White wrote: [...] I think a test that fails, or crashes a system because of a driver bug is a broken test. It's admittedly hard to write a test that will detect a vmware situation or driver bug and work around it, but I think that is what we should do. It's

Re: server: Use the security descriptor passed in when creating events.

2007-10-12 Thread Alexandre Julliard
Robert Shearman [EMAIL PROTECTED] writes: Use a new object_attributes struct for passing the information about whether a security descriptor is specified or not to the server. This breaks Photoshop CS2, we segfault while trying to access a security descriptor it gives us. -- Alexandre

Re: Support GCOV for Wine 1.0?

2007-10-12 Thread James Hawkins
On 10/12/07, Dan Kegel [EMAIL PROTECTED] wrote: On 10/12/07, Detlef Riekenberg [EMAIL PROTECTED] wrote: A while ago (2004), there was some work about wine with gcov, with the focus on Picassa 2: ( http://www.cs.hmc.edu/clinic/projects/2004/google/ ) Final Report: (

Re: Support GCOV for Wine 1.0?

2007-10-12 Thread Dan Kegel
On 10/12/07, Detlef Riekenberg [EMAIL PROTECTED] wrote: A while ago (2004), there was some work about wine with gcov, with the focus on Picassa 2: ( http://www.cs.hmc.edu/clinic/projects/2004/google/ ) Final Report: ( http://www.cs.hmc.edu/clinic/projects/2004/google/final_report/main.pdf )

Re: defining and revamping our bugzilla categories

2007-10-12 Thread Detlef Riekenberg
On Do, 2007-10-11 at 16:32 -0600, Jesse Allen wrote: How about gdi-printing and gdi-video? No. GDI is more than printing and for printing, you need GDI, but also much more out of GDI Whe the bug-creator set the component to printing, we can change it later to the more specific component, when

Re: WineD3D: p8 improvements 2/2

2007-10-12 Thread H. Verbeet
On 11/10/2007, Roderick Colenbrander [EMAIL PROTECTED] wrote: +MUL index.x, index.x, constants.x;\n /* Scale the index by 255/256 */ +ADD index.x, index.x, constants.y;\n /* Add a bias of '0.5' in order to sample in the middle */ Why not use a MAD there?

Re: Support GCOV for Wine 1.0?

2007-10-12 Thread Dimi Paun
On Fri, 2007-10-12 at 12:00 -0700, Scott Ritchie wrote: Make no mistake, what we have now is crap. It's a shame we show it to users when it's so laden with display bugs. I'm afraid I don't understand -- what is crap, and where are the display bugs? -- Dimi Paun [EMAIL PROTECTED] Lattica,

Translations

2007-10-12 Thread Daniel Nylander
I would like to contribute to the Wine project by submitting Swedish translations. I would really like to translate the graphical tools (such as winecfg) but as I can see it, it's not possible at the moment. Have you thought about implementing some sort of i18n/l10n framework? Regards, Daniel

Re: tools/wineprefixcreate.in: create default w32x86 path under spool/drivers

2007-10-12 Thread Detlef Riekenberg
On Mi, 2007-10-10 at 13:10 +0200, Markus Gömmel wrote: +$CROOT/windows/system32/spool/drivers/w32x86 \ The above Path is created, when we add a Printer Driver in wine. Please update your wine. When you do not start with a clean ~/wine, you need to remove the wine printers below

Re: request for kernel32/toolhelp windows testrun

2007-10-12 Thread Detlef Riekenberg
On Do, 2007-10-11 at 08:45 +0200, Marcus Meissner wrote: int num = 0; +intpos1 = -1 , pos2 = -1; You mix SPACE and TAB. Thanks (The updated test works in w2k here) -- By by ... Detlef

Re: CSS changes to the Wiki

2007-10-12 Thread Kai Blin
On Wednesday 10 October 2007 11:35:57 Kai Blin wrote: Hi folks, I seem to remember that someone posted a patch to the wiki's CSS that will stop the lists from looking ugly. I can't find that patch, though. Can someone point me at it? John Klehm pointed me at a post from Mitchell Mebane (at

Re: Support GCOV for Wine 1.0?

2007-10-12 Thread Scott Ritchie
Dimi Paun wrote: On Fri, 2007-10-12 at 10:47 -0700, Dan Kegel wrote: It'd be nice to have the best of both worlds, i.e. a wiki backed by git, and written in such a way that users who preferred to avoid online editing could use git to edit it locally, using an easy local preview tool, with

Re: Support GCOV for Wine 1.0?

2007-10-12 Thread Dan Kegel
On 10/12/07, Dimi Paun [EMAIL PROTECTED] wrote: On Fri, 2007-10-12 at 12:00 -0700, Scott Ritchie wrote: Make no mistake, what we have now is crap. It's a shame we show it to users when it's so laden with display bugs. I'm afraid I don't understand -- what is crap, and where are the

Re: Support GCOV for Wine 1.0?

2007-10-12 Thread Dimi Paun
On Fri, 2007-10-12 at 13:11 -0700, Dan Kegel wrote: Font sizes change randomly based on previous lines. It's unpredictable. True, but I'd argue that total crap is a bit harsh. In any event, this has nothing to do with the Wiki. It generates correct HTML (if anyone notices any problems, I'd be

Re: imm32: Avoid spamming the debug output.

2007-10-12 Thread EA Durbin
Imm is disabled by default on North American Windows installations. That's a behavior I think should be mimicked in wine. http://msdn2.microsoft.com/en-us/library/ms776161.aspx IMM is only enabled on East Asian (Chinese, Japanese, Korean) localized Windows operating systems. On these systems,

stdout for win16 tests

2007-10-12 Thread Dan Kegel
win16 doesn't have the notion of stdout/stderr, so 16 bit C compilers like watcom tend to simulate stdout by putting up a window. http://win16test.googlecode.com/svn/trunk/src/test.h (a port of the 32 bit test.h) uses freopen to open a log file to receive all the ok() and trace() output from the

Re: CSS changes to the Wiki

2007-10-12 Thread Dimi Paun
On Fri, 2007-10-12 at 21:29 +0200, Kai Blin wrote: John Klehm pointed me at a post from Mitchell Mebane (at http://www.winehq.org/pipermail/wine-devel/2007-August/058622.html) Someone care to give that a spin? I've implemented the feature, but I don't think it helps. Can someone test it

Re: CSS changes to the Wiki

2007-10-12 Thread Kai Blin
On Saturday 13 October 2007 00:44:46 Dimi Paun wrote: On Fri, 2007-10-12 at 21:29 +0200, Kai Blin wrote: John Klehm pointed me at a post from Mitchell Mebane (at http://www.winehq.org/pipermail/wine-devel/2007-August/058622.html) Someone care to give that a spin? I've implemented the

Call of Dutty 4 works!!

2007-10-12 Thread Mirek Slugeň
Hi, I just tried Call of Dutty 4 Demo in latest wine, and it is working, there are some problems with graphic (gun or units are not visible), but it works, good work!!! Here are some screenshots: http://78.108.96.64/wine/ Mirek

Re: CSS changes to the Wiki

2007-10-12 Thread Scott Ritchie
Dimi Paun wrote: On Fri, 2007-10-12 at 21:29 +0200, Kai Blin wrote: John Klehm pointed me at a post from Mitchell Mebane (at http://www.winehq.org/pipermail/wine-devel/2007-August/058622.html) Someone care to give that a spin? I've implemented the feature, but I don't think it helps. Can