Re: widl [3/4]: Remove printf format strings that aren't really format strings.

2007-10-18 Thread Michael Stefaniuc
Dan Hipschman wrote: This is just a minor cleanup patch. Even if we're definitely sure a string doesn't contain any % signs, it's still better not to use it as a printf format string. fputs() would be a faster alternative to that. Though i doubt that matters in this case. bye michael

Re: mshtml: Added support for installing Gecko from build dir.

2007-10-18 Thread Alexandre Julliard
Jacek Caban [EMAIL PROTECTED] writes: -static const char gecko_dir[] = /gecko/; - -data_dir = wine_get_data_dir(); -if(!data_dir) return FALSE; +if((data_dir = wine_get_data_dir())) +subdir = /gecko/; +else if((data_dir = wine_get_build_dir())) +subdir

Re: Priority/severity of test suite hangs

2007-10-18 Thread Jakob Eriksson
Dan Kegel wrote: I'm going to start filing bugs for anything that makes the test suite hang, and I'm going to lash out and give them unreasonably high priority and severity. There's just no excuse for a test suite that can't run to completion. +1

Re: [PATCH] wininet: Substitute strchrW with memchrW in InternetCrackUrlW (try 2)

2007-10-18 Thread Alexandre Julliard
Nigel Liang [EMAIL PROTECTED] writes: Previous patch had incorrect bounds for memchrW. There are other places in that function that assume that the string is null-terminated, please fix those too. -- Alexandre Julliard [EMAIL PROTECTED]

Re: inkobj: Implement IClassFactory

2007-10-18 Thread Alexandre Julliard
John Klehm [EMAIL PROTECTED] writes: This patch is largely based on the code found in mshtml. What I did was separate it into its own file and restyle it to my liking. Restyling it wasn't such a good idea I'm afraid, the original code is better without these ugly casts, and the Release

Re: widl [4/4]: Detect conformant arrays of user types correctly.

2007-10-18 Thread Robert Shearman
Dan Hipschman wrote: @@ -1859,6 +1859,7 @@ static int get_struct_type(var_list_t *fields) case RPC_FC_OP: case RPC_FC_CARRAY: case RPC_FC_CVARRAY: +case RPC_FC_BOGUS_ARRAY: has_pointer = 1; break; @@ -1897,15 +1898,9 @@ static int

Re: Priority/severity of test suite hangs

2007-10-18 Thread Maarten Lankhorst
Dan Kegel schreef: I'm going to start filing bugs for anything that makes the test suite hang, and I'm going to lash out and give them unreasonably high priority and severity. There's just no excuse for a test suite that can't run to completion. You might want to run the tests with

Re: widl [3/4]: Remove printf format strings that aren't really format strings.

2007-10-18 Thread Dan Hipschman
On Thu, Oct 18, 2007 at 11:12:23AM +0200, Michael Stefaniuc wrote: Dan Hipschman wrote: This is just a minor cleanup patch. Even if we're definitely sure a string doesn't contain any % signs, it's still better not to use it as a printf format string. fputs() would be a faster alternative

Re: widl [4/4]: Detect conformant arrays of user types correctly.

2007-10-18 Thread Dan Hipschman
On Thu, Oct 18, 2007 at 04:02:40PM +0100, Robert Shearman wrote: Dan Hipschman wrote: @@ -1859,6 +1859,7 @@ static int get_struct_type(var_list_t *fields) case RPC_FC_OP: case RPC_FC_CARRAY: case RPC_FC_CVARRAY: +case RPC_FC_BOGUS_ARRAY: has_pointer = 1;

Re: widl [3/4]: Remove printf format strings that aren't really format strings.

2007-10-18 Thread Michael Stefaniuc
Dan Hipschman wrote: On Thu, Oct 18, 2007 at 11:12:23AM +0200, Michael Stefaniuc wrote: Dan Hipschman wrote: This is just a minor cleanup patch. Even if we're definitely sure a string doesn't contain any % signs, it's still better not to use it as a printf format string. fputs() would be a

Re: [PATCH] wininet: Conformance test for InternetCrackUrlA (try 2)

2007-10-18 Thread Detlef Riekenberg
On Mi, 2007-10-17 at 13:17 -0700, Nigel Liang wrote: + urlCompa.dwStructSize = sizeof(urlCompa); + bRet = InternetCrackUrlA(sUrl, 11, 0, urlCompa); + ZeroMemory(urlCompa, sizeof(urlCompa)); + ZeroMemory(szBuf, sizeof(char)*1024); + urlCompa.dwUserNameLength = 1024; It looks much

notepad: Dangling pointer fix

2007-10-18 Thread Andrew Talbot
Please ignore this patch. Thanks, -- Andy.

iexplore text input

2007-10-18 Thread Luke Bratch
Hi all As you probably know, text input in iexplore isn't working at the moment, and hasn't worked since this commmit: http://source.winehq.org/git/wine.git/?a=commit;h=92b3cab7916445d79d2559e4b580f99e3b0de479 (Found by Simon in this bug: http://bugs.winehq.org/show_bug.cgi?id=9746) I've

Photoshop Elements 5 Tryout?

2007-10-18 Thread Dan Kegel
Anyone have a URL for PSE 5 trial version? I'm updating http://wiki.winehq.org/AdobePhotoshop Thanks, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

Re: winmm test runs forever?

2007-10-18 Thread Maarten Lankhorst
Dan Kegel schreef: Today I'm starting to see winmm_test spew an infinite series of failures on line 467 of mixer.c: ../../../tools/runtest -q -P wine -M winmm.dll -T ../../.. -p winmm_test.exe.so mixer.c touch mixer.ok ALSA lib seq_hw.c:456:(snd_seq_hw_open) open /dev/snd/seq failed: No

winmm test runs forever?

2007-10-18 Thread Dan Kegel
Today I'm starting to see winmm_test spew an infinite series of failures on line 467 of mixer.c: ../../../tools/runtest -q -P wine -M winmm.dll -T ../../.. -p winmm_test.exe.so mixer.c touch mixer.ok ALSA lib seq_hw.c:456:(snd_seq_hw_open) open /dev/snd/seq failed: No such file or directory

Use warn+heap when running 'make test'

2007-10-18 Thread Dan Kegel
As noted in http://bugs.winehq.org/show_bug.cgi?id=9916 using warn+heap poisons free memory, and finds a few more bugs. People who run 'make test' should consider running WINEDEBUG=warn+heap make test instead. (I don't know whether we should make that the default, though. Anyone have an