Re: [3/5] shell32: fix buffer sizes

2007-12-05 Thread Alexandre Julliard
Vitaly Lipatov [EMAIL PROTECTED] writes: lstrcpynW needs size in TCHARS RegEnumKey needs size in TCHARS It would be better to change the HCR_GetDefaultVerbW function to take a len in WCHARs since it's returning a string in all cases. -- Alexandre Julliard [EMAIL PROTECTED]

Re: Wine Weekly News

2007-12-05 Thread Alexander Nicolaysen Sørnes
On Wednesday 05 December 2007 16:08:27 Zachary Goldberg wrote: Hmmm interesting idea. I don't actually know just yet who the maintainer of the AppDB is, but he/she may respond in this thread (I'll attempt to find out their email anyway) as to whether or not its possible to generate a weekly

Re: wined3d:context.c Check for a context is added

2007-12-05 Thread Roderick Colenbrander
We need to check context before than refer it. Changelog: Check for a context is added -- Best regards Anatoly Lyutin. Hi, I'm not sure if your patch is correct. The block of code in front of the if-statement you added should have found or else created a context. If

Re: Wine Weekly News

2007-12-05 Thread Brian Vincent
On Dec 5, 2007 8:20 AM, Alexander Nicolaysen Sørnes [EMAIL PROTECTED] wrote: Their e-mail is [EMAIL PROTECTED] They'll have to decide how to track the changes, but in any case the code should be in soon. What about downgrades? Regressions happen. It'd be terrible one week to promise

Re: d3dx8 [2/2]: add basic functions for MatrixStack

2007-12-05 Thread Stefan Dösinger
Am Mittwoch, 5. Dezember 2007 18:13:30 schrieb [EMAIL PROTECTED]: This is my first attempt with ICOM objects. So, all the advices are welcome. A few suggestions: +HRESULT WINAPI ID3DXMatrixStackImpl_QueryInterface(ID3DXMatrixStack *iface, REFIID riid, void **ppvObject) + ... +

Re: wined3d:context.c Check for a context is added

2007-12-05 Thread Anatoly Lyutin
Roderick Colenbrander wrote: Hi, Hi! I'm not sure if your patch is correct. The block of code in front of the if-statement you added should have found or else created a context. If afterwards there is no context it sounds like something went wrong. Returning NULL isn't correct then.

Re: Wine Weekly News

2007-12-05 Thread Zachary Goldberg
Brian, Yep -- i'll be tracking downgrades too. I'm actually writing the code myself, you'll likely see the results in next weeks issue --Zach On Dec 5, 2007 3:30 PM, Brian Vincent [EMAIL PROTECTED] wrote: On Dec 5, 2007 8:20 AM, Alexander Nicolaysen Sørnes [EMAIL PROTECTED] wrote: Their

Re: wined3d:context.c Check for a context is added

2007-12-05 Thread Stefan Dösinger
Am Mittwoch, 5. Dezember 2007 17:25:55 schrieb Anatoly Lyutin: We need to check context before than refer it. Changelog: Check for a context is added Does that happen to fix any game? The idea was that the activeContext pointer never points to NULL, so a check like that only workaround a

A small question regarding cpuid

2007-12-05 Thread Vijay Kiran Kamuju
Hi, I was going through dlls/kernel32/cpu.c and stumbled upon the functions do_cpuid and have_cpuid. It seems the assembly code for both the Intel and AMD 64 bit processors. Is it possible to remove the ifdefs or add the x86_64 ifdef. And one more question does this change help 64 bit windows

Re: Wine Weekly News

2007-12-05 Thread Ben Hodgetts (Enverex)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Possibly, but on the other hand it could just as easily become Garbage in the next release of Wine ;) (sorry, I already sent this once at the start of the day but emailed it directly to the previous person rather than back to the list) Ben H. Tomas

Re: secur32: Remove the SECUR32_ALLOC() macro around HeapAlloc().

2007-12-05 Thread Michael Stefaniuc
Juan Lang wrote: On Dec 5, 2007 12:52 PM, Michael Stefaniuc [EMAIL PROTECTED] wrote: Checked with Kai and Dmitry and there is nothing special about SECUR32_ALLOC(). There are more direct usages of HeapAlloc() than of the macro so instead of replacing SECUR32_ALLOC() with heap_alloc() just

Re: Wine Weekly News

2007-12-05 Thread Zachary Goldberg
I've finished coding a script which runs the necessary query to generate data (I download a database backup and run the queries on my local machine.). As a sampling (if anybody feels like tripple checking that the data is correct) of Upgrades (and some downgrades) from 11-27-2007 to 12-04-2007:

Re: dlls/icmp/icmp_main.c -- attempt at fixing regression in r1.30 (RESEND)

2007-12-05 Thread Michael Stefaniuc
Gerald Pfeifer wrote: On Wed, 5 Dec 2007, Alexandre Julliard wrote: Looks ok, please submit the patch with a proper Changelog entry. Thanks for looking into this! Here we go! :-) ChangeLog: Correctly handle underflow in IcmpSendEcho(); bug introduced in rev 1.30. Still using cvs? I guess

Re: system.sfd: make 18 pixel strike with Japanese jvgasys glyphs

2007-12-05 Thread Dmitry Timoshkov
Aric Stewart [EMAIL PROTECTED] wrote: fonts/system.sfd | 1407 ++ 1 files changed, 1213 insertions(+), 194 deletions(-) For some reason widths of many glyphs are changed by this patch, that doesn't look correct. -- Dmitry.

Re: Wine Weekly News

2007-12-05 Thread Zachary Goldberg
Hmmm interesting idea. I don't actually know just yet who the maintainer of the AppDB is, but he/she may respond in this thread (I'll attempt to find out their email anyway) as to whether or not its possible to generate a weekly summary of applications which have been upgraded through the week?

Re: Wine Weekly News

2007-12-05 Thread Alexander Nicolaysen Sørnes
The problem of using test results as background for this is that they are very dependent on the experience of each user. For instance some might be unable to run a game because they have execshield or other stuff that mess up Wine, or simply because they are not following the how-to

Re: Wine Weekly News

2007-12-05 Thread Tomas Zijdemans
This is great :) Would it be a good idea to include major news from the appDB? Ex: Photoshop cs2 has now reached Gold status I think this would be very inspiring to users. Tomas Triton wrote: On Tue, 4 Dec 2007 18:23:10 -0500 Zachary Goldberg [EMAIL PROTECTED] wrote: Kai, It was my

Re: dlls/icmp/icmp_main.c -- attempt at fixing regression in r1.30 (RESEND)

2007-12-05 Thread Alexandre Julliard
Gerald Pfeifer [EMAIL PROTECTED] writes: Since Alexandre has asked me to take care of overflow in some other context, I figured I could ping this underflow patch in return. ;-) Looks ok, please submit the patch with a proper Changelog entry. -- Alexandre Julliard [EMAIL PROTECTED]

replying to wine-devel?

2007-12-05 Thread King InuYasha
I have noticed some unusual behavior in the wine-devel mailing list compared to others (e.g. fedora's, etc.). Wine's wine-devel mailing list does not automatically set the reply to [EMAIL PROTECTED] Why is that? If other mailing lists do so, how come Wine's doesn't? Personally, I find myself

Re: Wine Weekly News

2007-12-05 Thread Alexander Nicolaysen Sørnes
On Thursday 06 December 2007 00:44:03 Zachary Goldberg wrote: Here are the updated results for when we only look at updates from App Maintainers. It also just so happens that that age of empires case you mentioned is in fact by a maintainer. Please respond and leave your opinion as to which

Re: replying to wine-devel?

2007-12-05 Thread Mihai Donțu
On Thursday 06 December 2007, King InuYasha wrote: I have noticed some unusual behavior in the wine-devel mailing list compared to others (e.g. fedora's, etc.). Wine's wine-devel mailing list does not automatically set the reply to [EMAIL PROTECTED] I think it's a client problem. I'm using

Re: Wine Weekly News

2007-12-05 Thread Zachary Goldberg
Here are the updated results for when we only look at updates from App Maintainers. It also just so happens that that age of empires case you mentioned is in fact by a maintainer. Please respond and leave your opinion as to which is more worthwhile in the WWN. Perhaps i'll put both in different

Re: Wine Weekly News

2007-12-05 Thread Zachary Goldberg
Do you feel apps get updated enough that there are enough instances of an app being reviewed more than once per release to change these results? On Dec 5, 2007 6:52 PM, Alexander Nicolaysen Sørnes [EMAIL PROTECTED] wrote: On Thursday 06 December 2007 00:44:03 Zachary Goldberg wrote: Here are

Re: replying to wine-devel?

2007-12-05 Thread James McKenzie
Mihai Donțu wrote: On Thursday 06 December 2007, King InuYasha wrote: I have noticed some unusual behavior in the wine-devel mailing list compared to others (e.g. fedora's, etc.). Wine's wine-devel mailing list does not automatically set the reply to [EMAIL PROTECTED] I think it's

Re: system.sfd: make 18 pixel strike with Japanese jvgasys glyphs

2007-12-05 Thread Aric Stewart
Ahh, too late at night and my attempts to get the widths for the 18 pixel strikes had side effects. I have resubmitted. Hand checked the widths of the glyphs for both 16 and 18 pixles to make sure they are correct. Had to redraw many of the 18 pixel strikes (The capitals) to get them to fit

Re: replying to wine-devel?

2007-12-05 Thread James McKenzie
James Hawkins wrote: On Dec 5, 2007, at 7:05 PM, King InuYasha [EMAIL PROTECTED] wrote: I have noticed some unusual behavior in the wine-devel mailing list compared to others (e.g. fedora's, etc.). Wine's wine-devel mailing list does not automatically set the reply to [EMAIL PROTECTED]

Re: Wine Weekly News

2007-12-05 Thread Chris Morgan
i'd argue that this means we need to be smarter about how we process the test results. We need both a confidence and a rating and some way to reflect this in the results. Your other point about configuration, if users have problems with configuration then while it may be their fault its not

Re: replying to wine-devel?

2007-12-05 Thread James Hawkins
On Dec 5, 2007, at 7:05 PM, King InuYasha [EMAIL PROTECTED] wrote: I have noticed some unusual behavior in the wine-devel mailing list compared to others (e.g. fedora's, etc.). Wine's wine-devel mailing list does not automatically set the reply to [EMAIL PROTECTED] Why is that? If other

Re: system.sfd: make 18 pixel strike with Japanese jvgasys glyphs

2007-12-05 Thread Dmitry Timoshkov
Aric Stewart [EMAIL PROTECTED] wrote: Ahh, too late at night and my attempts to get the widths for the 18 pixel strikes had side effects. I have resubmitted. Hand checked the widths of the glyphs for both 16 and 18 pixles to make sure they are correct. Had to redraw many of the 18

Re: replying to wine-devel?

2007-12-05 Thread Kai Blin
On Thursday 06 December 2007 02:05:59 King InuYasha wrote: I have noticed some unusual behavior in the wine-devel mailing list compared to others (e.g. fedora's, etc.). Wine's wine-devel mailing list does not automatically set the reply to [EMAIL PROTECTED] Why is that? If other mailing lists

Re: quartz: move current tests into its own test case [1/5]

2007-12-05 Thread James Hawkins
On Dec 5, 2007 10:35 PM, Lei Zhang [EMAIL PROTECTED] wrote: Hi, I'm moving the current tests into their own function in preparation to write more tests. When submitting a numbered patch series, can you put the numbers [x/y] right after the module name? That makes it easier to spot the