kernel32: Implement ReplaceFileW

I have read this patch sent in several times and have realised that every time it contains a large number of goto's. I certainly do not like goto in structured code. My question to the forum is if it is allowed to use goto in wine or if you prefer not to use it. Even when this will make the code

Re: Patch tracking system - again...

On Friday 08 February 2008 08:51:15 Steven Edwards wrote: I'll skip the technical discussion and go right to the beef. Is there even still the desire to have a graphical patch tracking system? Personally I tend to use feature branches in git that I rebase on the top of Alexandre's tree.

Re: War on conformance test suite failures!

On 05/02/2008, Stefan Dösinger [EMAIL PROTECTED] wrote: Am Dienstag, 5. Februar 2008 07:59:58 schrieb Reece Dunn: On 05/02/2008, Stefan Dösinger [EMAIL PROTECTED] wrote: Am Dienstag, 5. Februar 2008 00:50:55 schrieb Dan Kegel: Great progress was made at Wineconf last year on getting

Re: Code quality (was Re: comctl32: Fix invalid syntax)

On Fri, 8 Feb 2008, Bang Jun-young wrote: [...] In fact, this is a well known mistake many newbie Win32 developers make (and fix in minutes). It shouldn't have been in the tree in the first place if he actually have read the patch. News flash!!! You too are allowed to review patches posted to

Re: kernel32: Implement ReplaceFileW

[EMAIL PROTECTED] wrote: I have read this patch sent in several times and have realised that every time it contains a large number of goto's. I certainly do not like goto in structured code. My question to the forum is if it is allowed to use goto in wine or if you prefer not to use it.

Re: user32: Implement GetWindowModuleFileName with tests

+hproc = OpenProcess(PROCESS_QUERY_INFORMATION, 0, pid); After reading MSDN and guessing from the API name shouldn't it simply fetch GWL_HINSTANCE and call GetModuleFileName on it? -- Dmitry.

Re: user32: Implement GetWindowModuleFileName with tests

Reece Dunn [EMAIL PROTECTED] wrote: +retval = GetWindowModuleFileNameW(hwnd, filenameW, cchFileNameMax); +if (retval) +{ +DWORD lasterror = GetLastError(); +WideCharToMultiByte(CP_ACP, 0, filenameW, -1, lpszFileName, cchFileNameMax, NULL, NULL); +

Re: Fixing make test - progress update

I don't want to spoil your enthusiasm but how does that differ from for example (old one though) http://test.winehq.org/data/200801301937/#Wine ? The main difference is that I ran it from my Wine tree, and getting it built and ready to go was completely under my control. That is, this is as

Re: user32: Implement GetWindowModuleFileName with tests

On 08/02/2008, Dmitry Timoshkov [EMAIL PROTECTED] wrote: Maarten Lankhorst [EMAIL PROTECTED] wrote: +retval = GetWindowModuleFileNameW(hwnd, filenameW, cchFileNameMax); +if (retval) +{ +DWORD lasterror = GetLastError(); +WideCharToMultiByte(CP_ACP, 0,

Re: Fixing make test - progress update

Jeremy White wrote: I believe that we have an easy way to find out the 'state of the art' wrt to make test. That is, my patch + request of a few days ago: http://www.winehq.org/pipermail/wine-devel/2008-February/062303.html resulted in a very nice, easy to digest report

Re: Fixing make test - progress update

On 08/02/2008, Jeremy White [EMAIL PROTECTED] wrote: That data has five test runs and shows clear across the board failures in msi:install, shell32:shellink, user32:listbox, and user32:msg. The user32:listbox tests fail everywhere when not run from the dlls/user32/tests directory! I have a

Re: More correctly handle the presence of the default ime inputwindow on Ime open and close

Aric Stewart [EMAIL PROTECTED] wrote: diff --git a/dlls/imm32/imm.c b/dlls/imm32/imm.c index 4acbde3..f3ed6f9 100644 --- a/dlls/imm32/imm.c +++ b/dlls/imm32/imm.c @@ -190,19 +190,17 @@ static LRESULT ImmInternalSendIMENotify(WPARAM notify, LPARAM lParam) static void

re: msvcrt: Fix EOF behavior on read from pipe

Damjan wrote The problem is more general: consoles *also* break on short reads (Java 1.4.1's gdb takes 1 command then quits because it thinks it's the end of file) Try my patch, it should help that case. I'm sure short read != end of file for ordinary files either, especially in *nix where

Re: user32: Implement GetWindowModuleFileName with tests

Dmitry Timoshkov [EMAIL PROTECTED] wrote: +hproc = OpenProcess(PROCESS_QUERY_INFORMATION, 0, pid); After reading MSDN and guessing from the API name shouldn't it simply fetch GWL_HINSTANCE and call GetModuleFileName on it? And after looking at GetModuleFileNameW implementation,

AppDB Issues

As many of you have noticed we've been having a bit of server trauma this past month. The issue boils down to a bug somewhere in mysqld. We are still trying to find the exact cause of the bug. We do have some leads. I just wanted to do a brain dump on wine-devel here before I go on Vacation

Re: user32: Implement GetWindowModuleFileName with tests

Hi folks, 2008/2/8, Dmitry Timoshkov [EMAIL PROTECTED]: Dmitry Timoshkov [EMAIL PROTECTED] wrote: +hproc = OpenProcess(PROCESS_QUERY_INFORMATION, 0, pid); After reading MSDN and guessing from the API name shouldn't it simply fetch GWL_HINSTANCE and call GetModuleFileName on it?

Re: user32: Implement GetWindowModuleFileName with tests

Maarten Lankhorst [EMAIL PROTECTED] wrote: UINT WINAPI GetWindowModuleFileNameA( HWND hwnd, LPSTR lpszFileName, UINT cchFileNameMax) { -FIXME(GetWindowModuleFileNameA(hwnd %p, lpszFileName %p, cchFileNameMax %u) stub!\n, - hwnd, lpszFileName, cchFileNameMax); -return

Re: Code quality (was Re: comctl32: Fix invalid syntax)

hi base, If winehq.org is Alexandre's own property, this is something fundametally wrong again. Well.. then 'something' must be wrong with the linux kernel aswell.. how comes noone forked? hmmm.. You may try to learn how things work in the Wine project by reading the following thread:

Fixing make test - progress update

I believe that we have an easy way to find out the 'state of the art' wrt to make test. That is, my patch + request of a few days ago: http://www.winehq.org/pipermail/wine-devel/2008-February/062303.html resulted in a very nice, easy to digest report http://test.winehq.org/data/20080205/

Re: More correctly handle the presence of the default ime inputwindow on Ime open and close

Good point, resending. thanks, -aric Dmitry Timoshkov wrote: Aric Stewart [EMAIL PROTECTED] wrote: diff --git a/dlls/imm32/imm.c b/dlls/imm32/imm.c index 4acbde3..f3ed6f9 100644 --- a/dlls/imm32/imm.c +++ b/dlls/imm32/imm.c @@ -190,19 +190,17 @@ static LRESULT

re: [PATCH] msvcrt: Fix early pipe closing

On Sat Feb 2, Nguyễn Thái Ngọc Duy wrote: Pipes are not like other normal files. If we do not read enough bytes, it does not mean it reaches EOF ... fixes broken pipe on git-fetch-pack (MinGW port) This is the same problem as http://bugs.winehq.org/show_bug.cgi?id=11187 so it's my fault.

Re: msvcrt: Fix EOF behavior on read from pipe

On Feb 8, 2008 4:31 PM, Dan Kegel [EMAIL PROTECTED] wrote: Nguyễn Thái Ngọc Duy's patch was almost right, he forgot a test case, and he neglected to move where EOF is detected for pipes instead of just removing it. Should fix http://bugs.winehq.org/show_bug.cgi?id=11187 The problem is

Re: user32:scroll.c: Compulsory enabling/disabling scrollbars after setting scrollbar`s flags.

Oh, Sorry! It crashes some another scrollbars. :( -- Best regards Anatoly Lyutin.

Re: Code quality (was Re: comctl32: Fix invalid syntax)

On Friday February 8 2008 04:41:28 Bang Jun-young wrote: That's the main reason why Wine keeps crashing every time I give it a try with my Windows apps. ... I see something fundamentally wrong with development process. I think that current development process isn't a problem at all.

Re: user32: Implement GetWindowModuleFileName with tests

Maarten Lankhorst [EMAIL PROTECTED] wrote: I've tried to do the GetWindowLongPtr GWLP_HINSTANCE thing but it seems to always return 0 in wine, which according to msdn means error, but it could just be not set in wine. Perhaps GWLP_HINSTANCE needs to be set when the window is being created?