Implementing a new Direct3D function

2008-03-09 Thread Jérôme Gardou
I'm trying to implement some direct3d functions, more precisely the GetImageInfoFromFile* ones. These are present in directX 8 and in d3dx9_xx.dll I wondered what is the best way to do this : 1)Implementing it in d3dx8.dll and forward everything to this one. 2) Make some useful functions in

Re: [PATCH 4/6] wined3d: Make code safe if there are no device palettes.

2008-03-09 Thread Roderick Colenbrander
There are two types of palettes in wined3d: directx = 7 style palettes as separate interface and d3d = 8 style device palettes. Some code was defaulting to device palettes in several places if there's no old style palette and using device palettes to store ddraw primary surface's palette.

Re: [comctl32/tests #3] Use GetModuleHandleA instead of LoadLibraryA

2008-03-09 Thread Mikołaj Zalewski
I've changed GetModuleHandle to LoadLibrary because when I compiled only tests/rebar.c as standalone, the comctl32 wasn't loaded and GetModuleHandle returned NULL. Are there advantages from using GetModuleHandle? Mikołaj Zalewski

Re: [comctl32/tests #3] Use GetModuleHandleA instead of LoadLibraryA

2008-03-09 Thread Paul Vriens
Mikołaj Zalewski wrote: I've changed GetModuleHandle to LoadLibrary because when I compiled only tests/rebar.c as standalone, the comctl32 wasn't loaded and GetModuleHandle returned NULL. Are there advantages from using GetModuleHandle? Mikołaj Zalewski Well, I was checking whether

Re: [PATCH 4/6] wined3d: Make code safe if there are no device palettes.

2008-03-09 Thread Alexander Dorofeyev
Roderick Colenbrander wrote: First of all it appears that this patch contains multiple patches (e.g. the direct3d9 getdc p8 check is one). I'll mention some others below. The p8 code is very sensitive to bugs and those are most of the time very hard to fix, so I'm quite strict. Various

Re: [PATCH 6/6] wined3d: Dirtify p8 textures when device palettes change.

2008-03-09 Thread Stefan Dösinger
Am Sonntag, 9. März 2008 15:10:54 schrieb Alexander Dorofeyev: Fixes problems with properly updating wine's P8 textures, when it is required because of device palette change. Instead of iterating over all resources and finding P8 textures I think it would be nicer to store the palette the

Re: Implementing a new Direct3D function

2008-03-09 Thread Stefan Dösinger
Am Sonntag, 9. März 2008 11:48:08 schrieb Jérôme Gardou: I'm trying to implement some direct3d functions, more precisely the GetImageInfoFromFile* ones. These are present in directX 8 and in d3dx9_xx.dll I wondered what is the best way to do this : 1)Implementing it in d3dx8.dll and forward

Re: Implementing a new Direct3D function

2008-03-09 Thread Jérôme Gardou
Le Sunday 09 March 2008 18:35:16 [EMAIL PROTECTED], vous avez écrit : D3DXGetImageInfoFromFile takes the D3DXIMAGE_INFO structure as parameter, which has changed between d3dx8 an dd3dx9_36 though. This means you can't forward the D3DXGetImageInfoFromFile calls from d3dx9 to d3dx8, (even if it

Re: [PATCH 6/6] wined3d: Dirtify p8 textures when device palettes change.

2008-03-09 Thread Alexander Dorofeyev
Hi Stefan, About implementing ddraw-style palette on top of device palettes - I think this way we would create more issues than we solve by it. As far as I'm concerned, I don't feel like there's a lot of confusion coming from the fact there are two palette interfaces, although there is some

Re: oleacc: add GetOleaccVersionInfo

2008-03-09 Thread Reece Dunn
On 09/03/2008, Louis. Lenders [EMAIL PROTECTED] wrote: Hi, this fixes crash in DietPower: http://bugs.winehq.org/show_bug.cgi?id=10102 +@ stdcall GetOleaccVersionInfo(long long) Since both these arguments are DWORD*, they need to be ptr, not long. - Reece

Re: oleacc: add GetOleaccVersionInfo

2008-03-09 Thread Reece Dunn
On 09/03/2008, Reece Dunn [EMAIL PROTECTED] wrote: On 09/03/2008, Louis. Lenders [EMAIL PROTECTED] wrote: Hi, this fixes crash in DietPower: http://bugs.winehq.org/show_bug.cgi?id=10102 +@ stdcall GetOleaccVersionInfo(long long) Since both these arguments are DWORD*, they need to

Re: [PATCH 6/6] wined3d: Dirtify p8 textures when device palettes change.

2008-03-09 Thread Roderick Colenbrander
Hi Stefan, About implementing ddraw-style palette on top of device palettes - I think this way we would create more issues than we solve by it. As far as I'm concerned, I don't feel like there's a lot of confusion coming from the fact there are two palette interfaces, although there

Fwd: Re: RegOverridePredefKey stub - Take 2

2008-03-09 Thread Jens Nestler
Hello, six weeks ago I've sent this patch for a basic implementation of the RegOverridePredefKey function. Unfortunately the patch was not considered till now. Can everybody help me ? Jens ---BeginMessage--- Am Dienstag, 29. Januar 2008 14:44:35 schrieb Dmitry Timoshkov: Jens Nestler [EMAIL

Re: Fwd: Re: RegOverridePredefKey stub - Take 2

2008-03-09 Thread Vitaliy Margolen
Jens Nestler wrote: Hello, six weeks ago I've sent this patch for a basic implementation of the RegOverridePredefKey function. Unfortunately the patch was not considered till now. Can everybody help me ? You have some extra pieces in this patch. When you are submitting patch - make sure

Re: [PATCH] qedit: use skip in MediaDet test

2008-03-09 Thread Lei Zhang
On Thu, Feb 21, 2008 at 5:15 PM, Lei Zhang [EMAIL PROTECTED] wrote: Hi, Dank pointed out the qedit test crashes with an old .wine directory. Adding a skip(). Any reason why this wasn't committed?

Processes and ioctl's

2008-03-09 Thread Maarten Lankhorst
Hi all, I am hitting a snag with moving ioctl handling into mount manager. I got the ioctl's working and itunes fairly satisfied, but now I'm hitting another problem: The mount manager is not in the same process any more as the application. This is an issue because one of the ioctl's is passing a

Please remove/block DARKGuy user from the forum and user mailing list!

2008-03-09 Thread Vitaliy Margolen
What the subject say.