Re: hhctrl.ocx: Parse HTML entities in the table of contents.

2008-04-16 Thread Hin-Tak Leung
--- On Wed, 16/4/08, Tomasz Jezierski - Tefnet <[EMAIL PROTECTED]> wrote: > If you won't find entity in table and change ampersand > to another char, > you won't get infinite loop, but I'm not sure what > will happen if you > have & in help, that might trigger loop too. Do you > know any free >

Re: [PATCH] [WinHelp]: fix regression introduced by Dmitry's Win64 warning fixes

2008-04-16 Thread Eric Pouech
> > > This won't work on 64-bit. If the hash really needs to be signed (why?) > you need some extra casts. signed comparison is needed below for finding the key in the btree currently, most of the navigation in hlp files is broken because of this patch A+ > -- > Alexandre Julliard > [EMAIL PROT

Re: dinput: Implement DIPROP_KEYNAME property for keyboard device

2008-04-16 Thread Vitaliy Margolen
Sergey Khodych wrote: >> No, there are 2 separate implementations - one ascii another unicode. During >> the object creation one would specify either ascii or unicode RIID. > > Objects IDirectInputDevice8W and IDirectInputDevice8A has function > GetProperty. This function get struct of type DIPRO

Re: dinput/tests: Add test to show dinput does not use user defined data format for keyboard.

2008-04-16 Thread Vitaliy Margolen
Sergey Khodych wrote: > > +hr = IDirectInputDevice_GetDeviceState(pKeyboard, sizeof(custom_state), > custom_state); > +ok(SUCCEEDED(hr), "IDirectInputDevice_GetDeviceState(4,) failed: %s\n", > DXGetErrorString8(hr)); > +hr = IDirectInputDevice_GetDeviceState(pKeyboard, sizeof(kbd_sta

Re: dinput: Implement DIPROP_KEYNAME property for keyboard device

2008-04-16 Thread Sergey Khodych
> No, there are 2 separate implementations - one ascii another unicode. During > the object creation one would specify either ascii or unicode RIID. Objects IDirectInputDevice8W and IDirectInputDevice8A has function GetProperty. This function get struct of type DIPROPSTRING as input/output parame

Re: msxml3: Implement transformNode (try 3)

2008-04-16 Thread Alistair Leslie-Hughes
"Alistair Leslie-Hughes" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Hi, > Corrected issue with tests > > Changelog: > msxml3: Implement transformNode > > Best Regards > Alistair Leslie-Hughes > Anything wrong with this patch? Best Regards Alistair Leslie-Hughes

Re: dlls/fusion/assembly.c -- no-op error checks

2008-04-16 Thread Gerald Pfeifer
On Wed, 16 Apr 2008, James Hawkins wrote: > Beat ya to the punch :) Better twice than not at all, to paraphrase a German saying. :-) Gerald

Re: fusion: Explicitly check for -1 for a missing table

2008-04-16 Thread Robert Shearman
James Hawkins wrote: > It works just fine. -1 is 4294967295 in ULONG (32bit), which is > exactly the same as offset on error (because we assigned it -1, but > the representation in memory is the same). Then use ~0 so that the purpose is clearer. Adding a define for this value would probably furt

Re: dlls/fusion/assembly.c -- no-op error checks

2008-04-16 Thread James Hawkins
On Wed, Apr 16, 2008 at 12:47 PM, Gerald Pfeifer <[EMAIL PROTECTED]> wrote: > On Wed, 16 Apr 2008, James Hawkins wrote: > > The offsets are explicity set to -1 on line 242, so the check needs to > > be for -1. It won't work at all otherwise. > > Thanks, James! I was looking for this, but must

Re: fusion: Explicitly check for -1 for a missing table

2008-04-16 Thread James Hawkins
On Wed, Apr 16, 2008 at 11:51 AM, Marcus Meissner <[EMAIL PROTECTED]> wrote: > > On Wed, Apr 16, 2008 at 11:48:31AM -0500, James Hawkins wrote: > > Hi, > > > > Changelog: > > * Explicitly check for -1 for a missing table. > > > > dlls/fusion/assembly.c |4 ++-- > > 1 files changed, 2 in

Re: fusion: Explicitly check for -1 for a missing table

2008-04-16 Thread Marcus Meissner
On Wed, Apr 16, 2008 at 11:48:31AM -0500, James Hawkins wrote: > Hi, > > Changelog: > * Explicitly check for -1 for a missing table. > > dlls/fusion/assembly.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > -- > James Hawkins > diff --git a/dlls/fusion/assembly.c b/dlls/f

Re: dlls/fusion/assembly.c -- no-op error checks

2008-04-16 Thread James Hawkins
On Wed, Apr 16, 2008 at 9:28 AM, Gerald Pfeifer <[EMAIL PROTECTED]> wrote: > Both offset and tables[].offset are of unsigned types, so these two > checks for errors will never trigger. > The offsets are explicity set to -1 on line 242, so the check needs to be for -1. It won't work at all otherw

Re: .NET 2.0 problematic DLL loading.

2008-04-16 Thread Rhys McGuckin
Stefan Dösinger <[EMAIL PROTECTED]> wrote:Many applications behave that way, and we create fake .DLL files in system32. They are real PE files from their file header, but they do not contain the implementation. When an app tries to LoadLibrary this DLL we load the builtin one instead So we j

Re: Including Mono within a Wine package - should Wine expect this?

2008-04-16 Thread Ove Kaaven
Stephan Hermann skrev: > When there are people interested in going a hard way of fixing todays > situation in debian/ubuntu and other distris, please let's do it > , sane and with a plan. There's already work going on to try to get a better solution into Debian lenny. There's a new "ia32-libs-too

imm32: Implement the ImmSetConversionStatus.

2008-04-16 Thread ByeongSik Jeon
Tested with "MS IME 2002(imekr61.ime)", "MS IME 2003(imekr70.ime)", and "Saenaru(saenaru.ime, Korean Free IME)". --- dlls/imm32/imm.c | 29 - 1 files changed, 20 insertions(+), 9 deletions(-) diff --git a/dlls/imm32/imm.c b/dlls/imm32/imm.c index c03d6fd..6fb73d2 100

Re: Including Mono within a Wine package - should Wine expect this?

2008-04-16 Thread Stephan Hermann
On Wed, 16 Apr 2008 06:52:49 -0700 Scott Ritchie <[EMAIL PROTECTED]> wrote: > Ove Kaaven wrote: > > Debian's ia32-libs package isn't an example of a whole lot. It grabs > > compiled binaries from the official Debian archive, and nowhere > > else. It isn't built on a 32-bit system. If ia32-libs had

Re: Trouble in compiling Wine 0.9.57 and 0.9.58 on Solaris 10 08/07

2008-04-16 Thread Petr Sumbera
Stefan Dösinger wrote: Am Sonntag, 13. April 2008 22:28:16 schrieb Rolf Kalbermatter: Following link might give some details about Sun Solaris support of infinintes and also ideas how to solve that problem. Yes, that would work. Any build system guru who could implement that? I think it is not

Re: .NET 2.0 problematic DLL loading.

2008-04-16 Thread Stefan Dösinger
Am Mittwoch, 16. April 2008 16:43:13 schrieb Rhys McGuckin: > There are two possible ways currently that I can think of, which would > potentially solve this problem: 1. Have symbolic links within the system > directory (I find this to be bad method, for multiple reasons) 2. Have some > interceptio

Re: Strange waveOutGetDevCaps calls in winmm/tests/wave.c

2008-04-16 Thread Juan Lang
> The CapsA test doesn't fail, probably since winmm wraps CapsA calls with > CapsW calls and then does memcpy. In either case, calling > waveOutGetDevCaps sith size=4 is not valid, as far as I can tell. > Theoretically, it might be in the future, though, if some small caps > structure is inven

.NET 2.0 problematic DLL loading.

2008-04-16 Thread Rhys McGuckin
In reference to bug #11973, I've the following observation. Using the native .NET 2.0 installed via winetricks, I located what is potentially a problem with the method that .NET is using to locate the DLLs that it wishes to load. The problem seems to be that .NET is attempting to locate the var

Re: Help with configure option

2008-04-16 Thread Robert Shearman
Alistair Leslie-Hughes wrote: > I need to add an option, HAS_TEXTCONCAT_BUG to the configure script > to check for a bug in libxml. What file(s) do I have to change? > > The file attached is an example to test for this issue. (returns -1 if > the error exists) The trouble is that because msxm

Re: Including Mono within a Wine package - should Wine expect this?

2008-04-16 Thread Scott Ritchie
Ove Kaaven wrote: > Debian's ia32-libs package isn't an example of a whole lot. It grabs > compiled binaries from the official Debian archive, and nowhere else. It > isn't built on a 32-bit system. If ia32-libs had contained binaries that > could not be built 100% automatically using Debian's offic

Re: [Fwd: Bug#476232: winebuild fails to build for powerpc]

2008-04-16 Thread Alexandre Julliard
Ove Kaaven <[EMAIL PROTECTED]> writes: > @@ -368,7 +368,7 @@ void BuildSpec32File( DLLSPEC *spec ) > else > { > output( "\n\t.section \".init\",\"ax\"\n" ); > -output( "\tjmp 1f\n" ); > +output( "\t%s 1f\n", get_asm_branch_mnemonic() ); > output( "__wine

Re: [PATCH] [WinHelp]: fix regression introduced by Dmitry's Win64 warning fixes

2008-04-16 Thread Alexandre Julliard
Eric Pouech <[EMAIL PROTECTED]> writes: > index 8181469..bf942a4 100644 > --- a/programs/winhelp/hlpfile.c > +++ b/programs/winhelp/hlpfile.c > @@ -158,8 +158,8 @@ HLPFILE_PAGE *HLPFILE_PageByOffset(HLPFILE* hlpfile, LONG > offset) > static int comp_PageByHash(void *p, const void *key, >

Strange waveOutGetDevCaps calls in winmm/tests/wave.c

2008-04-16 Thread Peter Åstrand
winmm/tests/wave.c currently contains: rc=waveOutGetDevCapsA(device,&capsA,4); ok(rc==MMSYSERR_NOERROR, "waveOutGetDevCapsA(%s): MMSYSERR_NOERROR expected, got %s\n", dev_name(device),wave_out_error(rc)); rc=waveOutGetDevCapsW(device,&capsW,4); ok(rc==MMSYSERR_NOERR

Re: IMM / IME work

2008-04-16 Thread Aric Stewart
Wonderful! I am glad you have this working for you as well. I think this will make it much easier to test and greatly improve our IME support in WINE. -aric ByeongSik Jeon wrote: > Aric Stewart wrote: >> I have tested with windows ATOK20 (a popular Japanese IME) and >> successfully had text

Re: Including Mono within a Wine package - should Wine expect this?

2008-04-16 Thread Kornél Pál
Hi, I am almost complete with implementing mixed-mode support for Mono only some code cleanup is remaining. Note that however this still will not support MSVCRT becuase that assumes that is running on .NET Framework. Also note that applications using unmanaged API (COM interfaces and DLL export

Re: hhctrl.ocx: Parse HTML entities in the table of contents.

2008-04-16 Thread Tomasz Jezierski - Tefnet
Dnia 16-04-2008, śro o godzinie 00:49 +, Hin-Tak Leung pisze: > > > --- On Tue, 15/4/08, Tomasz Jezierski - Tefnet <[EMAIL PROTECTED]> wrote: > > > While reading this patch I found another bug: > > > > +if (i == > > sizeof(char_refs)/sizeof(char_refs[0])) > > +{ > >