Re: dbghelp: Fix stabs_pts_read_type_def() for when typename is NULL

2008-06-22 Thread Eric Pouech
Andrew Talbot a écrit : Changelog: dbghelp: Fix stabs_pts_read_type_def() for when typename is NULL. diff --git a/dlls/dbghelp/stabs.c b/dlls/dbghelp/stabs.c index d550633..3c69eec 100644 --- a/dlls/dbghelp/stabs.c +++ b/dlls/dbghelp/stabs.c @@ -896,10 +896,10 @@ static int

Re: Valgrind regression in rpcrt4: Use abrtitrary pointer identifiers when marshalling pointers instead of using pointer values.?

2008-06-22 Thread Rob Shearman
2008/6/22 Dan Kegel [EMAIL PROTECTED]: Syscall param socketcall.send(msg) points to uninitialised byte(s) at 0x40007F2: (within /lib/ld-2.7.so) by 0x4CEA13A: rpcrt4_conn_write (rpc_binding.h:171) by 0x4CEA006: RPCRT4_SendWithAuth (rpc_message.c:533) by 0x4CEA784: RPCRT4_Send

Re: dbghelp: Fix stabs_pts_read_type_def() for when typename is NULL

2008-06-22 Thread Andrew Talbot
Eric Pouech wrote: looks like a bit strange to me that you get a null typename here can you send me the DLL/.so file on which you get the seg fault A+ No known segfaults; I'm just doing static analysis. But stabs_pts_read_type_def() is called several times within stabs.c passing NULL as a

Re: 'Interactive' tests on Windows 2003

2008-06-22 Thread Detlef Riekenberg
On Fr, 2008-06-13 at 13:04 -0500, James Hawkins wrote: Do you think we should add a check for winetest_interactive Possible, but that skip the test before the calls that bring up the permission dialog? If anyone else knows of a better way, let us know. Add a CBT-Hook and force the

Re: msi [6/6]: Rewrite the PublishProduct test to only check the registry changes

2008-06-22 Thread Paul Vriens
James Hawkins wrote: Hi, Changelog: * Rewrite the PublishProduct test to only check the registry changes. dlls/msi/tests/install.c | 148 +++--- 1 files changed, 87 insertions(+), 61 deletions(-)

Re: dbghelp: Fix stabs_pts_read_type_def() for when typename is NULL

2008-06-22 Thread Eric Pouech
Andrew Talbot a écrit : Eric Pouech wrote: looks like a bit strange to me that you get a null typename here can you send me the DLL/.so file on which you get the seg fault A+ No known segfaults; I'm just doing static analysis. But stabs_pts_read_type_def() is called several

Re: implement MsiSetExternalUIRecord

2008-06-22 Thread Paolo Abeni
hello, On Sat, Jun 21, 2008 at 5:08 AM, Dmitry Timoshkov [EMAIL PROTECTED] wrote: The only place where new stuff is used is package.c, why did you add it to msi_main.c and msipriv.h? I followed the example of the current implementation of the text-based external UI handler. It also define

Re: dbghelp: Fix stabs_pts_read_type_def() for when typename is NULL

2008-06-22 Thread Andrew Talbot
Eric Pouech wrote: however the last trace should be protected (and debugstr_a is a better choice than testing for a null string) A+ Thanks, Eric. I've sent a replacement patch (with a revised title). -- Andy.

Re: README: Add Russian translation

2008-06-22 Thread Dmitry Timoshkov
Vladimir Pankratov [EMAIL PROTECTED] wrote: --- /dev/null +++ b/documentation/README.ru @@ -0,0 +1,187 @@ +1. ВВЕДЕНИЕ + +Wine это программа которая позволяет запускать программы Microsoft Windows +(включая DOS, Windows 3.x и Win32) на Unix. Она состоит из программы загрузки +которая

Re: README: Add Russian translation

2008-06-22 Thread Nikolay Sivov
Well done! It's a good starting point, but this translation is rather awry. It contains a lot of punctuation mistakes and inaccurately translated words, but I still hope it'll be committed to work on it further..

Re: msi [6/6]: Rewrite the PublishProduct test to only check the registry changes

2008-06-22 Thread James Hawkins
On Sun, Jun 22, 2008 at 7:52 AM, Paul Vriens [EMAIL PROTECTED] wrote: James Hawkins wrote: Hi, Changelog: * Rewrite the PublishProduct test to only check the registry changes. dlls/msi/tests/install.c | 148 +++--- 1 files changed, 87

Re: Website down

2008-06-22 Thread Detlef Riekenberg
On Mi, 2008-06-18 at 09:51 -0600, Brian Vincent wrote: Sure: http://www.winehq.org/webalizer -Brian On Tue, Jun 17, 2008 at 8:27 PM, Hin-Tak Leung [EMAIL PROTECTED] wrote: Just for geek value, is it possible to have a graph of how the slashdot effect look like? I

RPC questions

2008-06-22 Thread Kai Blin
Hi folks, hey Rob, I've been wanting to get into Wine RPC development for ages, and now I finally got myself to start reading through some of the code in dlls/rpcrt4. Now, after going over rpc_bindings.c, tests/rpc.c and tests/server.c, I've got a couple of questions about that code. I'd like

Re: programs: add calc.exe

2008-06-22 Thread Steven Edwards
On Sun, Jun 22, 2008 at 10:32 AM, Louis. Lenders [EMAIL PROTECTED] wrote: Hi, i noticed this while running Log Book Pro (http://logbookpro.com/): That program has a menuentry to start Windows calculator, but it does nothing, as wine does not implement this. With the attached patch at least a

Re: programs: add calc.exe

2008-06-22 Thread Steven Edwards
On Sun, Jun 22, 2008 at 11:32 PM, Steven Edwards [EMAIL PROTECTED] wrote: On Sun, Jun 22, 2008 at 10:32 AM, Louis. Lenders [EMAIL PROTECTED] wrote: Hi, i noticed this while running Log Book Pro (http://logbookpro.com/): That program has a menuentry to start Windows calculator, but it does

re: programs: add calc.exe

2008-06-22 Thread Dan Kegel
I see he has taken the page down. Maybe drop the guy an email and see if he still has the sources laying around. A little google searching found it's still there, just moved: http://jebriggs.com/winecalc/ Source is all there, about 5KLOC. - Dan

Re: msxml3/tests: VT_EMPTY is not a string (resend 2)

2008-06-22 Thread Paul Vriens
Dan Kegel wrote: This time using NULL instead of (void *) 0. Hi Dan, -ok(lstrlenW(V_BSTR(vValue)) == 0, Expected empty value\n); +ok(V_BSTR(vValue) == (void *)0, Expected null value\n); Still using (void *)0 though. -- Cheers, Paul.

re: richedit: WM_SETTEXT must immediately autodetect URLs, without waiting for a WM_CHAR.

2008-06-22 Thread Dan Kegel
Hi Alex! I just noticed a valgrind warning in richedit that might have something to do with your new test code in http://source.winehq.org/git/wine.git/?a=commit;h=38d7ba6eff6757b83b54b0485b3452a41de25470 The warning is: Conditional jump or move depends on uninitialised value(s) at