New winetricks 20080710: new verb ogg, fixes for firefox and divx. Schroedinger support!

2008-07-10 Thread Dan Kegel
Another week, another winetricks. The big news is that Maarten now has a good directshow filter for the Schroedinger codec, and that it runs on Wine finally. To see it in action, do rm winetricks wget http://kegel.com/wine/winetricks wget http://kegel.com/wine/codecdemo bash codecdemo then

New winetricks 20080710: new verb ogg, fixes for firefox and divx.

2008-07-10 Thread Dan Kegel
Another week, another winetricks. The big news is that Maarten now has a good directshow filter for the Schroedinger codec, and that it runs on Wine finally. To see it in action, do rm winetricks wget http://kegel.com/wine/winetricks wget http://kegel.com/wine/codecdemo bash codecdemo then

Re: What's the holdup with RegisterHotKey and UnregisterHotKey??

2008-07-10 Thread James Keane
The supplied patch does work across process On Thu, Jul 10, 2008 at 6:12 PM, H. Verbeet <[EMAIL PROTECTED]> wrote: > 2008/7/10 James Hawkins <[EMAIL PROTECTED]>: >> If more people knew the answer to your question, it would probably be >> implemented by now :-) Usually the reason to move something

Re: winhttp: main.c: Add stub implementation for WinHttpGetDefaultProxyConfiguration

2008-07-10 Thread Zac Brown
Zac Brown wrote: > Add stub implementation for WinHttpGetDefaultProxyConfiguration > > Ignore this, formatting is wrong.

re: gdiplus: Test for CharacterRange.

2008-07-10 Thread Dan Kegel
Hi Adam, http://source.winehq.org/git/wine.git/?a=commit;h=2f7bb7c5385c86dced1c7e1d183c8a2a38699a50 seems to trigger a valgrind warning in your test code. http://kegel.com/wine/valgrind/logs-2008-07-10-07.15/vg-gdiplus_stringformat-diff.txt + Conditional jump or move depends on uninitialised valu

Re: msxml3/tests: Added more tests to ISAXXMLReader_putContentHandler and ISAXXMLReader_getContentHandler, added todo test for ISAXXMLReader_parse

2008-07-10 Thread Piotr Caban
Hi Alistair, On Thursday 10 of July 2008 22:51:20 you wrote: >You might want to add the test. > hr = ISAXXMLReader_getContentHandler(reader, NULL); I have added the test and fixed ISAXXMLReader_getContentHandler and ISAXXMLReader_getErrorHandler functions. Thanks for your help. Regards, Pio

Re: How do I write an exception filter?

2008-07-10 Thread Rob Shearman
2008/7/10 Stefan Kuhr <[EMAIL PROTECTED]>: > Now that we all know that I cannot contribute anymore to improving > NdrClientCall2 and that I also failed to properly write a code snippet > that obeys variable scope rules, could someone give an answer to my > original problem? Hi Stefan, There is al

Re: winhttp: tests/winhttp.c[new]: Add test for WinHttpOpenRequest

2008-07-10 Thread Zac Brown
Zac Brown wrote: > Add test for WinHttpOpenRequest. This test is modeled after > wininet/tests/http.c's InternetOpenRequest_test function. > > This is the first of many tests for getting Bug 14381 > (http://bugs.winehq.org/show_bug.cgi?id=14381) fixed with regard to > WinHTTP. > > > -

Re: How do I write an exception filter?

2008-07-10 Thread Ove Kaaven
Stefan Kuhr wrote: > This is something quite common in Win32, as far as I can tell. Yes, like I said, MSVC has special compiler support. In MSVC, __try, __except, etc, are compiler builtins (not macros as in Wine). But they are Microsoft extensions, they can't be implemented using standard C. >

Re: What's the holdup with RegisterHotKey and UnregisterHotKey??

2008-07-10 Thread H. Verbeet
2008/7/10 James Hawkins <[EMAIL PROTECTED]>: > If more people knew the answer to your question, it would probably be > implemented by now :-) Usually the reason to move something into the > server is to share common functionality, with each frontend (X11, > quartz) augmenting that common backend w

Re: winhttp: main.c: Add stub implementation for WinHttpGetDefaultProxyConfiguration

2008-07-10 Thread James Hawkins
On Thu, Jul 10, 2008 at 4:58 PM, Zac Brown <[EMAIL PROTECTED]> wrote: > Add stub implementation for WinHttpGetDefaultProxyConfiguration > +BOOL WINAPI WinHttpGetDefaultProxyConfiguration (WINHTTP_PROXY_INFO* pProxyInfo) +{ +FIXME("(%p): stub\n", pProxyInfo); + +SetLastError(ERROR_NOT_SUPPO

Re: winhttp: tests/winhttp.c[new]: Add test for WinHttpOpenRequest

2008-07-10 Thread Zac Brown
Zac Brown wrote: > Add test for WinHttpOpenRequest. This test is modeled after > wininet/tests/http.c's InternetOpenRequest_test function. > > This is the first of many tests for getting Bug 14381 > (http://bugs.winehq.org/show_bug.cgi?id=14381) fixed with regard to > WinHTTP. > > > -

Re: [dplayx 02/29] Tests for DirectPlayCreate

2008-07-10 Thread Michael Karcher
Am Donnerstag, den 10.07.2008, 22:04 +0300 schrieb Ismael Barros: > >> >> +heap = HeapCreate( 0, 0, 0 ); > >> > Do you have any reason to create your own heap? Each windows process > >> > already comes equipped with a standard heap you can obtain using the API > >> > function GetProcessHeap, so

Re: How do I write an exception filter?

2008-07-10 Thread Juan Lang
> Now that we all know that I cannot contribute anymore to improving > NdrClientCall2 and that I also failed to properly write a code snippet > that obeys variable scope rules, could someone give an answer to my > original problem? I think Ove answered it already: basically you can't access a loc

Re: How do I write an exception filter?

2008-07-10 Thread Stefan Kuhr
Hello everyone, On Thu, Jul 10, 2008 at 10:30 PM, Stefan Kuhr <[EMAIL PROTECTED]> wrote: >> >> __try >> { >> PDWORD pdwCommStatus = ; >> PDWORD pdwFaultStatus = ; >> doSomething(); >> } >> __except(MySpecialFilter(GetExceptionCode(),pdwCommStatus, pdwFaultStatus) ) >> { >> // handle t

Re: What's the holdup with RegisterHotKey and UnregisterHotKey??

2008-07-10 Thread James Hawkins
On Thu, Jul 10, 2008 at 4:01 PM, James Keane <[EMAIL PROTECTED]> wrote: > Yes that makes complete sense, but in this case how would the > implementation be better if we moved it into the wineserver? Isn't > the point of having seperate drivers for X11 and quartz etc, is to > take advantage of expo

Re: What's the holdup with RegisterHotKey and UnregisterHotKey??

2008-07-10 Thread James Keane
Yes that makes complete sense, but in this case how would the implementation be better if we moved it into the wineserver? Isn't the point of having seperate drivers for X11 and quartz etc, is to take advantage of exposed interfaces ie Hotkeys? Also, how am I as a wine outsider suppose to impleme

Re: msxml3/tests: Added more tests to ISAXXMLReader_putContentHandler and ISAXXMLReader_getContentHandler, added todo test for ISAXXMLReader_parse

2008-07-10 Thread Alistair Leslie-Hughes
Piotr Caban wrote: > --- > +hr = ISAXXMLReader_getContentHandler(reader, &lpContentHandler); Hi Piotr, You might want to add the test. hr = ISAXXMLReader_getContentHandler(reader, NULL); Best Regards Alistair Leslie-Hughes

Re: How do I write an exception filter?

2008-07-10 Thread Juan Lang
> I need that. I would like to implement comm status and fault status > awareness in WINE's rpcrt4, because my applications crash in WINE > because of the lack of proper comm status and fault status awareness > in WINE's RPC implementation. From debugging NdClientCall2 in XP I > deduce I need this.

Re: How do I write an exception filter?

2008-07-10 Thread Juan Lang
> Stupid me. How could I have prevented that? Is there some sort of > 'Code of Ethics' of the WINE project that I should have read before > and that tells me not to debug a binary from MS in order to improve a > WINE implementation? It's on the Developers' FAQ on the wiki: http://wiki.winehq.org/D

Re: What's the holdup with RegisterHotKey and UnregisterHotKey??

2008-07-10 Thread James Hawkins
On Thu, Jul 10, 2008 at 2:13 PM, James Keane <[EMAIL PROTECTED]> wrote: > Hey everyone! > > Just wanted to bring to your attention > http://bugs.winehq.org/show_bug.cgi?id=1348 again, and ask what is the > holdup? As far as I can see it appears a solution and working patch > has been posted. I am

Re: msxml3: oldChild in xmlnode_removeChild may be NULL

2008-07-10 Thread Alistair Leslie-Hughes
Piotr Caban wrote: > --- > IXMLDOMNode_Release(child); > IXMLDOMNode_AddRef(childNode); >- *oldChild = childNode; >+ >+ if(oldChild) >+ *oldChild = childNode; >return S_OK; > Hi Piotr, Your leaking childNode, it should be destroyed in this case. Best Regards Alistair Leslie-Hughes

Re: How do I write an exception filter?

2008-07-10 Thread Stefan Kuhr
H everyone, On Thu, Jul 10, 2008 at 10:34 PM, Juan Lang <[EMAIL PROTECTED]> wrote: >> Oh, I did not know that. What should I do now? Does that mean I can >> never ever contribute something to improve that function? > > I'm afraid so. > --Juan > Stupid me. How could I have prevented that? Is there

Re: How do I write an exception filter?

2008-07-10 Thread Juan Lang
> Oh, I did not know that. What should I do now? Does that mean I can > never ever contribute something to improve that function? I'm afraid so. --Juan

Re: How do I write an exception filter?

2008-07-10 Thread Stefan Kuhr
Hi Juan, On Thu, Jul 10, 2008 at 10:28 PM, Juan Lang <[EMAIL PROTECTED]> wrote: >> I need that. I would like to implement comm status and fault status >> awareness in WINE's rpcrt4, because my applications crash in WINE >> because of the lack of proper comm status and fault status awareness >> in

Re: How do I write an exception filter?

2008-07-10 Thread Stefan Kuhr
Hi everyone, On Thu, Jul 10, 2008 at 10:24 PM, Stefan Kuhr <[EMAIL PROTECTED]> wrote: > Hello Ove, > > On Thu, Jul 10, 2008 at 9:55 PM, Ove Kaaven <[EMAIL PROTECTED]> wrote: >> >> In general, within Wine code, it's impossible. In standard C, a function >> cannot reference a local variable of anot

Re: How do I write an exception filter?

2008-07-10 Thread Juan Lang
> I need that. I would like to implement comm status and fault status > awareness in WINE's rpcrt4, because my applications crash in WINE > because of the lack of proper comm status and fault status awareness > in WINE's RPC implementation. From debugging NdClientCall2 in XP I > deduce I need this.

Re: How do I write an exception filter?

2008-07-10 Thread Stefan Kuhr
Hello Ove, On Thu, Jul 10, 2008 at 9:55 PM, Ove Kaaven <[EMAIL PROTECTED]> wrote: > > In general, within Wine code, it's impossible. In standard C, a function > cannot reference a local variable of another function. It might be possible > with some trickery (e.g. declaring explicit register/volat

Re: How do I write an exception filter?

2008-07-10 Thread Ove Kaaven
Stefan Kuhr wrote: > In include/wine/exception.h, a comment from AJ says that > "__EXCEPT(filter_func,param)" is the proper way to do it but "param" > is not explained at all I think that comment must be very old, the macros don't implement any "param". > So, how do I do these things in WINE pro

How do I write an exception filter?

2008-07-10 Thread Stefan Kuhr
Hello everyone, I would like to know what the proper way is to write an exception filter function for WINE code. Most of the WINE exception filtering seems to be done with the __EXCEPT_PAGE_FAULT macro, for whatever reason. In all other places I see the macro __EXCEPT with a filter function of thi

What's the holdup with RegisterHotKey and UnregisterHotKey??

2008-07-10 Thread James Keane
Hey everyone! Just wanted to bring to your attention http://bugs.winehq.org/show_bug.cgi?id=1348 again, and ask what is the holdup? As far as I can see it appears a solution and working patch has been posted. I am interested in getting this into the main tree and wondering what kind of modificat

Re: [dplayx 02/29] Tests for DirectPlayCreate

2008-07-10 Thread Ismael Barros
>> > And last but not >> > least: As I see it, a static inline would do the job too, and is always >> > preferrable to macros. >> The main reason of using ditry macros instead of functions was to >> preserve the __LINE__ number, otherwise the debug information provided >> is pretty much useless. >

Re: Fallback from RPC_C_AUTHN_GSS_NEGOTIATE to RPC_C_AUTHN_WINNT if no SPNEGO package available

2008-07-10 Thread Stefan Kuhr
Hi Rob, On Thu, Jul 3, 2008 at 10:20 AM, Stefan Kuhr <[EMAIL PROTECTED]> wrote: > > Ok, I'll do that and resend the modified patch. It probably also needs > a fixme for an entire different reason: Once a Negotiate provider is > available in WINE, my patch won't do any harm, but it is going to be

Re: [PATCH 2/2] user32: Set WM_NOSIZE for windows smaller than SM_CXMINTRACK/SM_CYMINTRACK.

2008-07-10 Thread Alexandre Julliard
"Lei Zhang" <[EMAIL PROTECTED]> writes: > I added more tests for this and also looked at the trace log from the > tests. My last patch was definitely wrong because it prevents the > window/client size from changing, whereas they do change on Windows. I > check for this in the tests now. > > I look

Re: regedit: Implement deleting multiple values (resend)

2008-07-10 Thread John Klehm
On Thu, Jul 10, 2008 at 8:20 AM, Andre Wisplinghoff <[EMAIL PROTECTED]> wrote: > Changelog: > Regedit: Implement deleting multiple values > > Changes from first send as suggested @ wine-devel: > - Use standard MessageBox instead of making the messagebox function from > edit.c non-static > - Real na

Re: New winetricks 20080704: added firefox3, kde verbs (and a whole lot of other stuff)

2008-07-10 Thread Dan Kegel
2008/7/6 Vitaly Lipatov <[EMAIL PROTECTED]>: > Please check attached patch with fixes agains 20080704 version of winetricks. > > Changes: > - introduce WINDIR variable with Unix path to windows dir (and use it > instead "$WINEPREFIX"/drive_c/windows) That, along with Vitaliy's suggestion of not ha

Feedback for "Regedit: Implement deleting multiple values"

2008-07-10 Thread Andre Wisplinghoff
Hallo, thanks for your help. I just resend my patch, with these issues considered. The standard MessageBox function is now used. The localized message is read in framewnd.c and errors treated the same way as it was with the messagebox function in edit.c. Best Regards - Andre Wisplinghoff

Re: winequartz.drv Mac OS X UI discontinued?

2008-07-10 Thread Adam Strzelecki
> Is it really technically impossible to access the Quartz APIs or write > Mac applications using C? Well it is possible, for example iTunes is non Objective-C Carbon (API) app AFAIK. Problem is that Carbon (pure C interface) is considered as deprecated by Apple and may disappear from future

RE: [PATCH] RE: user32: Problem using SetClassLongW to subclass built-in control (Edit)

2008-07-10 Thread Hongbo Ni
Dear Reece, Thanks for your comments. > > I have write a patch for the problem, please comment.> > + if( unicode && > > class->winproc == EDIT_winproc_handle )> > Is it just the EDIT window > > procedure that is affected? I suspect that> this will apply to all classes > > that have A and W var

Re: winequartz.drv Mac OS X UI discontinued?

2008-07-10 Thread Francois Gouget
On Mon, 7 Jul 2008, Adam Strzelecki wrote: [...] > It was just said once that winequartz.drv won't go into official Wine, > and the top reason was Objective-C and this was just a bizarre > decision for me. Objective-C is almost as old as C++ and it was just > chosen for an object model of OSX

Re: user32: Problem using SetClassLongW to subclass built-in control (Edit)

2008-07-10 Thread Mikołaj Zalewski
As it was written, you need to write some more tests for such changes. It required a few iterations before we got SetWindowLongPtr(GWLP_WNDPROC, ...) right, so this might be also not easy. The tests for SetWindowLongPtr are in dlls/user32/tests/class.c. Some things I can think of that require

Re: [dplayx 02/29] Tests for DirectPlayCreate

2008-07-10 Thread Francois Gouget
On Wed, 9 Jul 2008, Kai Blin wrote: > On Wednesday 09 July 2008 19:15:34 Ismael Barros wrote: > > > > >> +heap = HeapCreate( 0, 0, 0 ); > > > > > > Do you have any reason to create your own heap? Each windows process > > > already comes equipped with a standard heap you can obtain using the AP

Re: regedit: 3/7 Convert the rest of setValue to unicode

2008-07-10 Thread Alexandre Julliard
Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> writes: > @@ -185,13 +199,16 @@ static DWORD getDataType(LPSTR *lpValue, DWORD* > parse_type) > *lpValue+=ptr->len; > if (type == -1) { > char* end; > +char* buf = HeapAlloc(GetProcessHeap(), 0, > (lstrlen

Re: [PATCH] RE: user32: Problem using SetClassLongW to subclass built-in control (Edit)

2008-07-10 Thread Reece Dunn
2008/7/10 Hongbo Ni <[EMAIL PROTECTED]>: > I have write a patch for the problem, please comment. > +if( unicode && class->winproc == EDIT_winproc_handle ) Is it just the EDIT window procedure that is affected? I suspect that this will apply to all classes that have A and W variants. I als

Re: [Gdiplus 2/3] Add a test for a floating-point triangle

2008-07-10 Thread Huw Davies
Hi Adam, This is mainly a brain-dump, there's nothing wrong the patch. On Thu, Jul 10, 2008 at 12:44:55AM -0400, Adam Petaccia wrote: > --- > dlls/gdiplus/tests/region.c | 38 ++ > 1 files changed, 38 insertions(+), 0 deletions(-) > > diff --git a/dlls/gdi

Re: gdiplus: Add a trailing '\n' to Wine traces.

2008-07-10 Thread Francois Gouget
On Thu, 10 Jul 2008, Nikolay Sivov wrote: [...] > > dlls/gdiplus/font.c |2 +- > > dlls/gdiplus/image.c |2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > I think you should just remove a bracket here: > > -FIXME("%p (%s), %f, %p\n)", font, > +FIXME("%p (%s), %f, %p\n"

Re: Support of USB hardware tokens

2008-07-10 Thread Steven Edwards
On Tue, Jul 8, 2008 at 10:05 AM, Alexander Morozov <[EMAIL PROTECTED]> wrote: > Conformance tests should consist of a driver and a program to load > it. I do not know other method to call functions from ntoskrnl.exe and > usbd.sys on Windows. But I have a problem with building drivers with MinGW. I

[PATCH] RE: user32: Problem using SetClassLongW to subclass built-in control (Edit)

2008-07-10 Thread Hongbo Ni
Hi, I have write a patch for the problem, please comment. === --- wine-1.1.0-orig/dlls/user32/class.c 2008-06-28 00:24:42.0 +1000 +++ wine-1.1.0/dlls/user32/class.c 2008-07-10 17:35:11.0 +1000 @@ -906,9