I haven't heard anything about this patch.
I know it is large, but the function headers and wrappers are necessary.
Is there anything in particular wrong with it?
Is there anything that could make it more obviously correct?
2008/7/7 Austin Lund <[EMAIL PROTECTED]>:
> Changes from previously sen
Hi Nikolay,
Tests you added in the following two commits fail on all platforms.
Did you run the tests in Windows? Please do not send any more test
patches before testing on Windows first.
commit d93ad02216d28851b2be07d8ee89671a7354761f
Author: Nikolay Sivov <[EMAIL PROTECTED]>
Date: Thu Jul 3
Hi Nikolay,
Tests you added in the following commit fail on all platforms. Did
you run the tests in Windows?
commit d7999a008be5d7e95fcd86019adc79b0359ae8d4
Author: Nikolay Sivov <[EMAIL PROTECTED]>
Date: Tue Jul 8 01:32:36 2008 +0400
gdiplus: GdipInvertMatrix implementation with tests.
Hi Adam,
Tests you added in the following commit rely on the Arial font being
installed, which is not necessarily the case. You can check out [1]
for the test output of a system that does not have the Arial font.
You should either test a font that is guaranteed to be installed
(Tahoma?) or use so
Scott Ritchie wrote:
> After being partially inspired by Ubuntu brainstorm, it occurred to me
> that some of our fonts would be useful everywhere, but the current Wine
> package keeps its fonts to itself. Tahoma, for instance, could be
> useful if someone tries to open a Word document in Open Offi
Hin-Tak Leung wrote:
> Scott Ritchie wrote:
>> After being partially inspired by Ubuntu brainstorm, it occurred to me
>> that some of our fonts would be useful everywhere, but the current Wine
>> package keeps its fonts to itself. Tahoma, for instance, could be
>> useful if someone tries to open a
> Seems to be a copy-paste
Well spotted, apparently both my mentor and I managed to miss this! Shall
get that sorted now...
--
Owen Rudge
http://www.owenrudge.net/
Owen Rudge wrote:
+while (iter)
+{
+if (iter->title)
+HeapFree(hHeap, 0, iter->title);
+
+if (iter->path)
+HeapFree(hHeap, 0, iter->path);
+
+if (iter->icon)
+HeapFree(hHeap, 0, iter->icon);
+
+if (iter->publisher)
+
After being partially inspired by Ubuntu brainstorm, it occurred to me
that some of our fonts would be useful everywhere, but the current Wine
package keeps its fonts to itself. Tahoma, for instance, could be
useful if someone tries to open a Word document in Open Office.
The solution varies acro
Am Freitag, den 11.07.2008, 18:11 +0300 schrieb Ismael Barros:
> On 7/11/08, Michael Karcher <[EMAIL PROTECTED]> wrote:
> If it's not that bad, would it be okay to leave it with the deadbeef
> solution, with a TODO comment to do it the right way later? Right now
> I would like to focus on other fun
On 7/11/08, Michael Karcher <[EMAIL PROTECTED]> wrote:
> Am Donnerstag, den 10.07.2008, 22:04 +0300 schrieb Ismael Barros:
>> I've been checking how this is done in other tests, and it's
>> particularly interesting how they do it in ddraw/tests/refcount.c:81:
>> hr = IDirectDraw7_CreatePalette(DD
Hi Pieter, overall your patch looks good, but it has some minor errors
that get in the way:
-struct DeviceInfo *devInfo = SETUPDI_AllocateDeviceInfo(set, set->cDevices,
-instanceId, phantom);
+struct DeviceInfo *devInfo;
TRACE("%p, %s, %d, %s, %d\n", set, debugstr_guid(gu
"Lei Zhang" <[EMAIL PROTECTED]> writes:
> +static UINT sequence_contains(UINT msg)
> +{
> +static const struct message end_of_sequence = { 0, 0, 0, 0 };
> +const struct message *actual;
> +UINT num = 0;
> +
> +add_message(&end_of_sequence);
> +actual = sequence;
> +
> +whil
"Maarten Lankhorst" <[EMAIL PROTECTED]> writes:
> ---
> mtCurrent is cleared when connecting, so this may cause weird bugs
> during connection.
This doesn't work:
../../../tools/runtest -q -P wine -M qedit.dll -T ../../.. -p qedit_test.exe.so
mediadet.c && touch mediadet.ok
err:quartz:OutputPin
14 matches
Mail list logo
