Re: [8/11] kernel32: Implement the timer queue thread.

2008-07-19 Thread Dan Hipschman
Thanks for these especially good comments, Rob! On Sat, Jul 19, 2008 at 07:08:17PM +0100, Rob Shearman wrote: > 2008/7/19 Dan Hipschman <[EMAIL PROTECTED]>: > > > > This patch implements the timer thread, running callbacks, cleaning up > > timers, and all that good stuff. It should be very effic

Re: Problem compiling wine tests with msvc in standalone mode.

2008-07-19 Thread Reece Dunn
2008/7/19 Mikołaj Zalewski <[EMAIL PROTECTED]>: > Where does the ../../../include\rpc.h file come from? If you are mixing > Wine and Windows headers then conflicts are quite possible. I copy only > wine/test.h from the Wine headers. Often, I also need a #include > at the top of the file for it t

Re: [8/11] kernel32: Implement the timer queue thread.

2008-07-19 Thread Rob Shearman
2008/7/19 Dan Hipschman <[EMAIL PROTECTED]>: > > This patch implements the timer thread, running callbacks, cleaning up > timers, and all that good stuff. It should be very efficient, using mostly > atomic operations and one critical section for thread safety. It would be more efficient for queue

Re: gdi32: "StretchDIBits" seems to use the wrong picture offset

2008-07-19 Thread Mathias Kosch
> I provided a screenshot as attachment for you to see. I wasn't able to send it to this mailing list. I think this is by intention. So please ask me if you want to see. -- Mathias Kosch <[EMAIL PROTECTED]> | http://www.mkosch.de/ RSA Public Key: http://www.mkosch.de/pubkey Internet-Links ganz k

Re: [Gdiplus 02/15] Implement GdipCreateRegion

2008-07-19 Thread Adam Petaccia
On Sat, 2008-07-19 at 12:20 +0100, Huw Davies wrote: > Adam Petaccia wrote: > > @@ -226,6 +277,11 @@ GpStatus WINGDIPAPI GdipSetEmpty(GpRegion*region) > > > > if(!(calls++)) > > FIXME("not implemented\n"); > > +TRACE("%p\n", region); > > + > > +GdipDeleteRegion(region);

gdi32: "StretchDIBits" seems to use the wrong picture offset

2008-07-19 Thread Mathias Kosch
Currently I'm trying to fix Bug#13344. I figured out that the problems seems to be caused by the function "StretchDIBits" inside "dlls/gdi32/dib.c". When I run "Digital Photo Professional 3.4.1.1" and open images in the editor window in "fit to window" mode all images are shifted to top so that I

Re: [5/11] kernel32: Implement Create/DeleteTimerQueue[Ex].

2008-07-19 Thread Rob Shearman
2008/7/19 Dan Hipschman <[EMAIL PROTECTED]>: > --- > dlls/kernel32/sync.c | 40 ++-- > dlls/kernel32/tests/sync.c | 11 +++ > 2 files changed, 37 insertions(+), 14 deletions(-) These functions should be implemented in ntdll instead of kernel32

Re: [3/11] kernel32/tests: Add tests for Change/DeleteTimerQueueTimer.

2008-07-19 Thread Rob Shearman
2008/7/19 Dan Hipschman <[EMAIL PROTECTED]>: > +static void CALLBACK timer_queue_cb2(PVOID p, BOOLEAN timedOut) > +{ > +struct timer_queue_data1 *d = (struct timer_queue_data1 *) p; > +ok(timedOut, "Timer callbacks should always time out\n"); > +/* Wait until our own timer handle is set

Re: oleaut32: fixed the safearray tests for Vista.

2008-07-19 Thread Rob Shearman
2008/7/18 Reece Dunn <[EMAIL PROTECTED]>: > Seems like Vista has fixed the bug in the Windows version of > SafeArrayGetVarType, as indicated by > http://test.winehq.org/data/80ee225f23ea8093f57f1e7b29b7fb60e6f6cdda/vista_VistaSP1/oleaut32:safearray.html, > so update the tests accordingly. How abou

Re: [2 of 2] ole32: always return false when asked if NULL is the current clipboard

2008-07-19 Thread Rob Shearman
2008/7/17 Vincent Povirk <[EMAIL PROTECTED]>: > @@ -583,6 +583,9 @@ HRESULT WINAPI OleIsCurrentClipboard(IDataObject > *pDataObject) >if (!theOleClipboard) > return E_OUTOFMEMORY; > > + if (pDataObject == NULL) > +return S_FALSE; > + Functionally, the patch is good, but one small ni

Re: [PATCH 3/3] mstask: Implement ClassFactory, DllGetClassObject, and DllCanUnloadNow

2008-07-19 Thread Rob Shearman
2008/7/18 Roy Shea <[EMAIL PROTECTED]>: > +static HRESULT WINAPI MSTASK_IClassFactory_QueryInterface( > +LPCLASSFACTORY iface, > +REFIID riid, > +LPVOID *ppvObj) > +{ > +ClassFactoryImpl *This = (ClassFactoryImpl *)iface; > + > +TRACE("\n\tIID:\t%s\n",debugstr_guid(r

Re: [1/2] server: fix async read on mailslot

2008-07-19 Thread Michael Karcher
Am Freitag, den 18.07.2008, 20:37 +0400 schrieb Andrey Turkin: > Also, please attach patches with disposition inline, not attachment > (git can do that) - this make review somehow easier. If this is an official wine policy (I do see your point), please update http://www.winehq.org/site/sending_patc

Re: CUDA wrapper

2008-07-19 Thread Seth Shelnutt
It seems when using this wrapper and a cuda enabled program, it causes the program/wine to use 100% of a CPU core, while running in windows the FaH GPU client only takes around 10-15% at most of a CPU core. Any ideas why the sudden jump to 100% use? It makes the systems most unusable in the normal

Re: Problem compiling wine tests with msvc in standalone mode.

2008-07-19 Thread Mikołaj Zalewski
Where does the ../../../include\rpc.h file come from? If you are mixing Wine and Windows headers then conflicts are quite possible. I copy only wine/test.h from the Wine headers. Often, I also need a #include at the top of the file for it to compile with MS headers, but after this, it works

Re: [Gdiplus 02/15] Implement GdipCreateRegion

2008-07-19 Thread Huw Davies
Adam Petaccia wrote: > @@ -226,6 +277,11 @@ GpStatus WINGDIPAPI GdipSetEmpty(GpRegion*region) > > if(!(calls++)) > FIXME("not implemented\n"); > +TRACE("%p\n", region); > + > +GdipDeleteRegion(region); > +GdipCreateRegion(®ion); > +region->node->type = RegionD

Re: git inconsistency - cannot fetch latest patchset

2008-07-19 Thread Kirill K. Smirnov
В сообщении от Saturday 19 July 2008 14:24:40 Nikolay Sivov написал(а): > This 'missed' commit goes to stable branch. > http://source.winehq.org/git/wine.git/?a=shortlog;h=refs/heads/stable Thanks, I almost forgot about branches! Sorry for nuisance. -- Kirill

Problem compiling wine tests with msvc in standalone mode.

2008-07-19 Thread Reece Dunn
Hi, I am using VS 2008 (9.0) Express in conjunction with the Vista SDK. When compiling the tests, I get: c:\Users\reece\wine\dlls\comctl32\tests>cl -D_X86_ -DSTANDALONE -I../../../inclu de listview.c Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 15.00.21022.08 for 80x86 Copyright (C) Mi

Re: advapi32: "RegGetValue" fails with some correct combinations of "dwFlags"

2008-07-19 Thread Mathias Kosch
Dan Kegel wrote: > You forgot to mention which versions of Windows you > ran the test case on (and whether it passed there). Thank you for telling me. (I'm not yet very familar with the process of publishing patches.) It took me some time, for I first had to install "Windows Server 2003". Testing

Re: dlls/ws2_32/tests/sock.c: Wait on thread handles before closing sockets

2008-07-19 Thread Jon Griffiths
> CloseHandle doesn't wait for the thread to finish, so > this has no effect. In any case there doesn't seem to be any need > to wait in those tests. My bad. There was something hokey with the tests, moving the CloseHandle made them pass consistently. After changing the implementation I can't rep

Re: Uninitialized memory reference in winefile

2008-07-19 Thread Martin Fuchs
Hello Dan, if you change the following line 2711, I think the Valgrind message will disappear: /* no change? */ -if (!memcmp(orgWidths, pane->widths, sizeof(orgWidths))) +if (!anyway && !memcmp(orgWidths, pane->widths, sizeof(orgWidths))) return FALSE; Sorry - I could no

Re: one liner patch to stop crash, everquest2.exe

2008-07-19 Thread Andrew Fenn
Not sure, I just figured it was the program that was doing it? I'll try and figure it out and reply back to you as soon as I can. On Thu, Jul 17, 2008 at 6:49 PM, H. Verbeet <[EMAIL PROTECTED]> wrote: > 2008/7/17 Andrew Fenn <[EMAIL PROTECTED]>: > > I noticed this function gets called twice when

Re: one liner patch to stop crash, everquest2.exe

2008-07-19 Thread Andrew Fenn
Here's what I got from the debug log. Backtrace: =>1 0x7e43e9b3 shader_glsl_free+0x23(iface=0x19c4b8) [/home/andrew/wine/wine/dlls/wined3d/glsl_shader.c:3491] in wined3d (0x0032e918) 2 0x7e41f318 IWineD3DDeviceImpl_Reset+0x198(iface=0x19c4b8, pPresentationParameters=0x32e9c0) [/home/andrew/wine/

Re: git inconsistency - cannot fetch latest patchset

2008-07-19 Thread Nikolay Sivov
Kirill K. Smirnov wrote: > Hello, > According to wine-cvs mailing list, latest patch is > "Vladimir Pankratov : hhctrl.ocx: Update Russian translation.", > but it cannot be fetched, after fetch/rebase the following patch is the > latest: > "Huw Davies : winmm: Only fill in the MIXERLINEA struc

git inconsistency - cannot fetch latest patchset

2008-07-19 Thread Kirill K. Smirnov
Hello, According to wine-cvs mailing list, latest patch is "Vladimir Pankratov : hhctrl.ocx: Update Russian translation.", but it cannot be fetched, after fetch/rebase the following patch is the latest: "Huw Davies : winmm: Only fill in the MIXERLINEA struct if the call to mixerGetLineInfoW s

Re: [8/11] kernel32: Implement the timer queue thread.

2008-07-19 Thread Hans Leidekker
On Saturday 19 July 2008 02:19:11 Dan Hipschman wrote: > It punts on some integer-wrapping issues. If someone runs their wineserver > for 49 days they may run into that issue. I just thought it would distract Have you thought about using GetTickCount64 instead of GetTickCount? -Hans

Re: ntoskrnl tests - where to write them?

2008-07-19 Thread Marcus Meissner
On Fri, Jul 18, 2008 at 10:15:48PM -0500, Stefan Dösinger wrote: > > I have been looking at writing a couple of tests for ntoskrl functions > > but I have had difficulty locating a suitable place. It sort of looks > > like ntdll/tests is the place but it is not clear. Is there a guide > > for l

Re: ntoskrnl tests - where to write them?

2008-07-19 Thread Kai Blin
On Saturday 19 July 2008 05:15:48 Stefan Dösinger wrote: > > I have been looking at writing a couple of tests for ntoskrl functions > > but I have had difficulty locating a suitable place. It sort of looks > > like ntdll/tests is the place but it is not clear. Is there a guide > > for locating