Re: DLL loading prolem when injecting into another process

2008-08-02 Thread Steven Edwards
On Fri, Aug 1, 2008 at 6:25 PM, Rolf Kalbermatter [EMAIL PROTECTED] wrote: Ok I think I understand. You are using a technique I have once read about in Microsoft System Journal back in about 1994. And this is certainly tricky. Its also documented in Inside Windows by Jeffery Richter if you

Re: rsaenh: Test and correct the maximum allowable salt length

2008-08-02 Thread James McKenzie
Juan Lang wrote: Inspired by a patch by Karsten Elfenbein. Who is this and why is this so important? --Juan Per: http://winehq.org/site/sending_patches What in the hell does this patch do? Why is it needed? What does it fix/implement? Doees this change affect any Bugzilla issues?

Re: rsaenh: Test and correct the maximum allowable salt length

2008-08-02 Thread Juan Lang
James, please show a little more courtesy. Who is this and why is this so important? Karsten wrote a patch to address an issue he had with Eve Online. It's important because of attribution: I wanted people to realize that I was indebted to him for thinking of it. I didn't use his code,

Patch checking robot coming

2008-08-02 Thread Dan Kegel
After some discussion with Jeremy and Alexandre about how nice it would be to have some automated way to check patches before Alexandre commits them, I decided to have a go at creating one. What I have so far is a script that watches wine-patches and applies each patch to current git, then

Re: fusion: Use proper function pointer

2008-08-02 Thread James Hawkins
On Sat, Aug 2, 2008 at 4:09 PM, Andrew Talbot [EMAIL PROTECTED] wrote: Changelog: fusion: Use proper function pointer. diff --git a/dlls/fusion/fusion.c b/dlls/fusion/fusion.c index ac01cf4..637346c 100644 --- a/dlls/fusion/fusion.c +++ b/dlls/fusion/fusion.c @@ -32,6 +32,9 @@

Re: Patch checking robot coming

2008-08-02 Thread Ambroz Bizjak
Dan Kegel wrote: What I have so far is a script that watches wine-patches and applies each patch to current git, then builds, Just where are you going to run that? To me, a script that builds just every patch is a serious security flaw; I suppose it wouldn't be very hard for someone to send a

rsaenh: Test and correct the maximum allowable salt length

2008-08-02 Thread Louis. Lenders
Usually i don't feel the need to respond to messages on wine-devel, but now i do: What in the hell does this patch do? Why is it needed? What does it fix/implement? Doees this change affect any Bugzilla issues? Where is the Changelog? This is what I have been trying to get you to do. I

re: Patch checking robot coming

2008-08-02 Thread Dan Kegel
Ambroz wrote: To me, a script that builds just every patch is a serious security flaw; I suppose it wouldn't be very hard for someone to send a naughty patch that would take control of your machine. True. I suggest you make it build patches in a chroot as a regular user, and copy over the

Re: Patch checking robot coming

2008-08-02 Thread Zachary Goldberg
On Sat, Aug 2, 2008 at 8:24 PM, Dan Kegel [EMAIL PROTECTED] wrote: Ambroz wrote: To me, a script that builds just every patch is a serious security flaw; I suppose it wouldn't be very hard for someone to send a naughty patch that would take control of your machine. True. I suggest you

Re: DIB engine status

2008-08-02 Thread Jesse Allen
On Fri, Aug 1, 2008 at 8:23 AM, Сергей Новосёлов [EMAIL PROTECTED] wrote: Did you hear anything about Jesse Allen's version of DIB Engine: http://article.gmane.org/gmane.comp.emulators.wine.devel/53234 (His version - http://repo.or.cz/w/wine/dibdrv.git ) Do you know why it was neccesary to

Re: Patch checking robot coming

2008-08-02 Thread Dan Kegel
On Sat, Aug 2, 2008 at 7:25 PM, Zachary Goldberg [EMAIL PROTECTED] wrote: Its really ironic that you post this today as just yesterday I was contemplating the same thing, and not only doing a compile check but also a run of the test suite and valgrind. Yeah, that's the end goal. Gotta walk

Re: [1/2] mlang: Add implementation of fnIMLangFontLink_GetCharCodePages

2008-08-02 Thread Dmitry Timoshkov
Vitaly Perov [EMAIL PROTECTED] wrote: @@ -1855,8 +1855,56 @@ static HRESULT WINAPI fnIMLangFontLink_GetCharCodePages( WCHAR chSrc, DWORD* pdwCodePages) { -FIXME(\n); -return E_NOTIMPL; +/* codepages, supported by Windows */ +static const unsigned int

Re: [2/2] mlang/tests: add test for fnIMLangFontLink_GetCharCodePages

2008-08-02 Thread Dmitry Timoshkov
Vitaly Perov [EMAIL PROTECTED] wrote: +/* Tests for GetCharCodePages */ +/* Latin 1 */ +ok(IMLangFontLink_GetCharCodePages(iMLFL, 'd', dwCodePages) == S_OK, +IMLangFontLink_GetCharCodePages failed\n); +ok(dwCodePages == 2032127, Incorrect CodePages returned (%i)\n,

Re: ntdll: import dll from dir of referring dll if not found instandard locations

2008-08-02 Thread Dmitry Timoshkov
Hongbo Ni [EMAIL PROTECTED] wrote: This patch fixes bug 14699. It should fix all failed applications which try to load a dll from specific folder, and the dll is link another dll in the same folder. Please add a test case for this behaviour to confirm that your patch is doing a correct thing.

Re: [1/2] mlang: Add implementation offnIMLangFontLink_GetCharCodePages

2008-08-02 Thread Dmitry Timoshkov
Dmitry Timoshkov [EMAIL PROTECTED] wrote: It doesn't really matter what code pages Windows supports, it does matter though what code pages are valid. You need to use Win32 APIs EnumSystemCodePages/GetCPInfo/MultiByteToWideChar instead of accessing Wine internals directly. ... or rather use