Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Kai Blin
On Monday 25 August 2008 23:58:17 Scott Ritchie wrote: > James Hawkins wrote: > > On Sun, Aug 24, 2008 at 5:06 PM, Henri Verbeet <[EMAIL PROTECTED]> wrote: > >> Something else... I sometimes reply to patches, and right now that > >> seems to cause patchwatcher to complain that my mail doesn't conta

Re: winetricks: add ie6 verb

2008-08-25 Thread Steven Edwards
On Sat, Aug 23, 2008 at 11:02 AM, Detlef Riekenberg <[EMAIL PROTECTED]> wrote: > Nice Idea. Thanks, Dan has said he agrees with it from a development perspective and ies4linux already lets enough people do it for free so adding it to winetricks should not hurt major corporate contributors like Cod

ddraw error in Tibia (wine told me to post here)

2008-08-25 Thread Michael Reiley
There's some progress on the MMORPG Tibia since the last wine version, but now there's a new error. before you tell me "This list is for discussions regarding Wine development. It is not for bug reports or user support questions", I'd like to tell you "err:ddraw:IDirectDrawImpl_QueryInterface (0x1

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread James McKenzie
Dan Kegel wrote: > On Mon, Aug 25, 2008 at 2:05 PM, Kai Blin <[EMAIL PROTECTED]> wrote: > #patchwatcher approve Such a directive would only be recognized if it's alone on a line. >>> The usual positive reply is 'ACK'. I believe it would be simplest to >>> grep the r

Re: Add TRACEs to NtCreateFile returns (second try)

2008-08-25 Thread Juan Lang
> So, why not fix this? Please push the patch trough Wine's patch accepting > mechanism yourself, I'm currently somewhat sick of it. It seems your tolerance for reworking patches is rather low. You must be willing to rework patches until they're correct to have many committed around here. I've p

Re: Add TRACEs to NtCreateFile returns (second try)

2008-08-25 Thread Markus Hitter
Am 25.08.2008 um 21:39 schrieb James Hawkins: As the code stands now, regardless of your patch, the check for NULL attr on line 154 of dlls/kernel32/file.c will never be hit because we will crash in the TRACE on line 148 of dlls/kernel32/ file.c. Now I got it. You aren't talking about the

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread James Hawkins
On Mon, Aug 25, 2008 at 4:58 PM, Scott Ritchie <[EMAIL PROTECTED]> wrote: > James Hawkins wrote: >> On Sun, Aug 24, 2008 at 5:06 PM, Henri Verbeet <[EMAIL PROTECTED]> wrote: >>> Something else... I sometimes reply to patches, and right now that >>> seems to cause patchwatcher to complain that my ma

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Scott Ritchie
James Hawkins wrote: > On Sun, Aug 24, 2008 at 5:06 PM, Henri Verbeet <[EMAIL PROTECTED]> wrote: >> Something else... I sometimes reply to patches, and right now that >> seems to cause patchwatcher to complain that my mail doesn't contain a >> patch. Would it be possible to do something about that?

Re: winex11.drv: Fix buffer overflow bug in X11DRV_KeyEvent() andX11DRV_ToUnicodeEx()

2008-08-25 Thread Rob Shearman
2008/8/24 Dmitry Timoshkov <[EMAIL PROTECTED]>: > "Muneyuki Noguchi" <[EMAIL PROTECTED]> wrote: > >> winex11.drv: Fix buffer overflow bug in X11DRV_KeyEvent() and >> X11DRV_ToUnicodeEx() > >> +Str = (char *)malloc(64); >> +if (Str == NULL) >> +ERR("Failed to allocate memory!\n"); >

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Kai Blin
On Monday 25 August 2008 23:20:40 Dan Kegel wrote: > Around where I work, LGTM (looks good to me) is the reply that > denotes approval. And then there's the Apache convention of +1. > Anyway, I'll recognize one or more of those if and when I get around > to adding a wine-devel listener. Might b

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Dan Kegel
On Mon, Aug 25, 2008 at 2:05 PM, Kai Blin <[EMAIL PROTECTED]> wrote: >> > #patchwatcher approve >> > >> > Such a directive would only be recognized if it's alone on a line. >> >> The usual positive reply is 'ACK'. I believe it would be simplest to >> grep the reply message for ACK to see if a repl

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Kai Blin
On Monday 25 August 2008 20:46:51 James Hawkins wrote: > On Mon, Aug 25, 2008 at 1:11 PM, Ken Thomases <[EMAIL PROTECTED]> wrote: > > > > #patchwatcher approve > > > > Such a directive would only be recognized if it's alone on a line. > > The usual positive reply is 'ACK'. I believe it would be si

Re: Using wine directdraw dll on windows?

2008-08-25 Thread Roderick Colenbrander
> Stefan Dösinger wrote: > >> Our d3d implementation works pretty well on Windows(well, as good as it > does > >> on Wine), with the exception of directdraw. The problem with ddraw is > that > >> ddraw.dll needs wined3d.dll, which loads opengl32.dll, and Microsoft's > >> opengl32.dll loads ddraw.dl

Re: New steam survey statistics?

2008-08-25 Thread Sparr
I considered not submitting the survey because it misdetected my CPU as 1GHz (it's an Athlon 64 3400ishiforgotexactly). On Mon, Aug 25, 2008 at 4:12 PM, Scott Ritchie <[EMAIL PROTECTED]> wrote: > Yeah, it would not surprise me if Wine users are much less likely to > follow the survey for whatever

Re: New steam survey statistics?

2008-08-25 Thread Scott Ritchie
Yeah, it would not surprise me if Wine users are much less likely to follow the survey for whatever reason. Thanks, Scott Ritchie Alfred Reynolds wrote: > We recently switched our survey system from a monolithic bi-yearly > survey to a monthly rolling survey with a subset of the userbase each > m

Re: Using wine directdraw dll on windows?

2008-08-25 Thread Joseph Garvin
Stefan Dösinger wrote: >> Our d3d implementation works pretty well on Windows(well, as good as it does >> on Wine), with the exception of directdraw. The problem with ddraw is that >> ddraw.dll needs wined3d.dll, which loads opengl32.dll, and Microsoft's >> opengl32.dll loads ddraw.dll. Oops. >> >>

Re: Add TRACEs to NtCreateFile returns (second try)

2008-08-25 Thread James Hawkins
On Mon, Aug 25, 2008 at 2:29 PM, Markus Hitter <[EMAIL PROTECTED]> wrote: > > Am 25.08.2008 um 17:58 schrieb James Hawkins: > >> On Mon, Aug 25, 2008 at 3:12 AM, Markus Hitter <[EMAIL PROTECTED]> wrote: >>> >>> Am 25.08.2008 um 01:31 schrieb James Hawkins: >>> 2008/8/24 Markus Hitter <[EMAIL P

Re: Add TRACEs to NtCreateFile returns (second try)

2008-08-25 Thread Markus Hitter
Am 25.08.2008 um 17:58 schrieb James Hawkins: > On Mon, Aug 25, 2008 at 3:12 AM, Markus Hitter <[EMAIL PROTECTED]> > wrote: >> >> Am 25.08.2008 um 01:31 schrieb James Hawkins: >> >>> 2008/8/24 Markus Hitter <[EMAIL PROTECTED]>: >>> >>> -if (!attr || !attr->ObjectName) return >>> STATUS_IN

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Chris Morgan
On Mon, Aug 25, 2008 at 2:46 PM, James Hawkins <[EMAIL PROTECTED]> wrote: > On Mon, Aug 25, 2008 at 1:11 PM, Ken Thomases <[EMAIL PROTECTED]> wrote: >> On Aug 25, 2008, at 1:08 PM, Alexandre Julliard wrote: >> >>> "Dan Kegel" <[EMAIL PROTECTED]> writes: >>> On Mon, Aug 25, 2008 at 8:47 AM, Ale

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread James Hawkins
On Mon, Aug 25, 2008 at 1:11 PM, Ken Thomases <[EMAIL PROTECTED]> wrote: > On Aug 25, 2008, at 1:08 PM, Alexandre Julliard wrote: > >> "Dan Kegel" <[EMAIL PROTECTED]> writes: >> >>> On Mon, Aug 25, 2008 at 8:47 AM, Alexandre Julliard >>> <[EMAIL PROTECTED]> wrote: patchwatcher should watch for

Re: cryptnet: Sign-compare warning fix (try 2)

2008-08-25 Thread Juan Lang
> That's the trouble with some warnings: some instances you want to fix and > some you know you can safely ignore. I presumed that we were aiming to turn > this warning on permanently, but that may not be the intention, and maybe > the downside you highlight makes doing so not worthwhile. Turning

Re: cryptnet: Sign-compare warning fix (try 2)

2008-08-25 Thread Andrew Talbot
Juan Lang wrote: > Yes, I know what the value of CRYPT_E_NOT_FOUND is, and what the type > of GetLastError is. My point is, Microsoft confused signed and > unsigned types for their last error values. We have to live with it. > Indeed. (And sorry, I didn't mean to sound patronizing.) > I don't

Re: [3/3] d3dx9: Begin Implementation of ID3DXEffect and D3DXCreateEffectEx

2008-08-25 Thread tony . wasserka
Hi, > +HRESULT WINAPI D3DXCreateEffectEx(LPDIRECT3DDEVICE9 pdevice, LPCVOID psrcdata, UINT srcdatalen, D3DXMACRO *pdefines, > + LPD3DXINCLUDE pinclude, LPCSTR pskipconstants, DWORD flags, LPD3DXEFFECTPOOL ppool, LPD3DXEFFECT * ppeffect, > + LPD3DXBUFFER * ppcompilationerrors) > +{ > +ID3D

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Ken Thomases
On Aug 25, 2008, at 1:08 PM, Alexandre Julliard wrote: > "Dan Kegel" <[EMAIL PROTECTED]> writes: > >> On Mon, Aug 25, 2008 at 8:47 AM, Alexandre Julliard >> <[EMAIL PROTECTED]> wrote: >>> patchwatcher should watch for replies on wine-devel, and >>> link the reply to the patch >> >> Yes. The ot

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Alexandre Julliard
"Dan Kegel" <[EMAIL PROTECTED]> writes: > On Mon, Aug 25, 2008 at 8:47 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: >> patchwatcher should watch for replies on wine-devel, and >> link the reply to the patch > > Yes. The other similar patchwatching systems I found do this, > and ours should,

Re: How should I name the Traditional Chinese resource file ?

2008-08-25 Thread Alexandre Julliard
Hongbo Ni <[EMAIL PROTECTED]> writes: > 1. name it Zh_tw.rc, (but Alexandre seems not like it) > 2. name it Tw.rc > 3. rename all Zh.rc to Cn.rc, then name traditional as Zh.rc > 4. just put both simplified and traditional Chinese in Zh.rc >(not good as they are different encoding). > > My que

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Dan Kegel
On Mon, Aug 25, 2008 at 8:47 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > patchwatcher should watch for replies on wine-devel, and > link the reply to the patch Yes. The other similar patchwatching systems I found do this, and ours should, too. > and mark the patch as needing further act

Re: cryptnet: Sign-compare warning fix (try 2)

2008-08-25 Thread Juan Lang
Hi Andy, > An error code like CRYPT_E_NOT_FOUND is, in essence, a LONG (signed). > Whereas GetLastError() returns a DWORD (unsigned, which does seem > inappropriate to me). Yes, I know what the value of CRYPT_E_NOT_FOUND is, and what the type of GetLastError is. My point is, Microsoft confused s

Re: cryptnet: Sign-compare warning fix (try 2)

2008-08-25 Thread Andrew Talbot
Juan Lang wrote: > Hi Andy, > > +LONG last_error; > > ret = CryptGetObjectUrl(URL_OID_CERTIFICATE_CRL_DIST_POINT, > rgpvContext[i], 0, NULL, &cbUrlArray, NULL, NULL, NULL); > -if (!ret && GetLastError() == CRYPT_E_NOT_FOUND) > +last_

RE: New steam survey statistics?

2008-08-25 Thread Alfred Reynolds
We recently switched our survey system from a monolithic bi-yearly survey to a monthly rolling survey with a subset of the userbase each month, so we can get a continuous view of changes in hardware amongst our users. We have 2 months of good data to date, Wine usage has increased from 0.33 to 0.3

Re: cryptnet: Sign-compare warning fix (try 2)

2008-08-25 Thread Juan Lang
Hi Andy, +LONG last_error; ret = CryptGetObjectUrl(URL_OID_CERTIFICATE_CRL_DIST_POINT, rgpvContext[i], 0, NULL, &cbUrlArray, NULL, NULL, NULL); -if (!ret && GetLastError() == CRYPT_E_NOT_FOUND) +last_error = GetLastError(); +

Re: New steam survey statistics?

2008-08-25 Thread Scott Ritchie
Evil Jay wrote: > I too would be interested in seeing the numbers, but I'm not sure you're > going to see the correlation you expect, Scott. > > While Linux adoption may have grown, Valve has probably been selling > just as many, if not more games to customers who already owned Windows > but had n

Re: Add TRACEs to NtCreateFile returns (second try)

2008-08-25 Thread James Hawkins
On Mon, Aug 25, 2008 at 3:12 AM, Markus Hitter <[EMAIL PROTECTED]> wrote: > > Am 25.08.2008 um 01:31 schrieb James Hawkins: > >> 2008/8/24 Markus Hitter <[EMAIL PROTECTED]>: >>> >> >> +if (!attr || !attr->ObjectName) >> +{ >> +TRACE("returning STATUS_INVALID_PARAMETER\n"); >> +

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Paul Vriens
Alexandre Julliard wrote: > Kai Blin <[EMAIL PROTECTED]> writes: > >> On Monday 25 August 2008 00:06:29 Henri Verbeet wrote: >>> Something else... I sometimes reply to patches, and right now that >>> seems to cause patchwatcher to complain that my mail doesn't contain a >>> patch. Would it be poss

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Alexandre Julliard
Kai Blin <[EMAIL PROTECTED]> writes: > On Monday 25 August 2008 00:06:29 Henri Verbeet wrote: >> Something else... I sometimes reply to patches, and right now that >> seems to cause patchwatcher to complain that my mail doesn't contain a >> patch. Would it be possible to do something about that? >

Re: [Patch] 0001-Support-for-winscard.dll.patch

2008-08-25 Thread frechdachs69
Thanks ... I am going to have a deep look into your sources. Regards Heiko Am Montag, 25. August 2008 10:56:25 schrieb Mounir IDRASSI: > Hi All, > > I have just been informed by one of my contacts that this discussion about > Winscard has started. > As the original author of Winscard for Wine, I'

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Kai Blin
On Monday 25 August 2008 00:06:29 Henri Verbeet wrote: > Something else... I sometimes reply to patches, and right now that > seems to cause patchwatcher to complain that my mail doesn't contain a > patch. Would it be possible to do something about that? I've got to agree with James on that one. R

RE: [try 3][1/2]wined3d: Support clipplanes with GLSL shaders

2008-08-25 Thread Stefan Dösinger
+if(gl_info->max_glsl_varyings > 32) +gl_info->max_glsl_varyings -= 4; +if(!apple && gl_info->gl_vendor == VENDOR_ATI && gl_info->max_glsl_varyings == 40) { +WARN("Hardcoded 32 varyings instead of 44 to avoid crashing the ATI driver\n"); +gl_info->max_glsl_varyings -

Re: [Patch] 0001-Support-for-winscard.dll.patch

2008-08-25 Thread Mounir IDRASSI
Hi All, I have just been informed by one of my contacts that this discussion about Winscard has started. As the original author of Winscard for Wine, I'd like to inform you that I have already posted a fully functional Winscard patch for Wine on April 2007. Here is the link to it : http://www.win

Re: d3dx9: Add stubs for D3DXCreateEffectxx and D3DXCreateEffectFromFilexx

2008-08-25 Thread David Adam
Hello, A few remarks: 1) this patch is too huge You need to split it in several patches. I advice you to do a patch for - d3dx9effect.h -an another one for d3dx9shader.h -an another one for D3DXCreateEffect -an another one for D3DXCreateEffectExW and D3DXCreateEffectExW 2) for the patch D3DXCrea

d3dx9: Effects

2008-08-25 Thread Busquets Pérez Luis C .
What is wrong with the attached patch? __ Correo Yahoo! Espacio para todos tus mensajes, antivirus y antispam ¡gratis! Regístrate ya - http://correo.yahoo.es From f7175ad4963cd16a4a97ccbe442ce087a98aa8e7 Mon Sep 17 00:00:00 2001 From: luiscar2001 y

Re: d3dx8: Implementation of D3DXGetFVFVertexSize with tests try 2

2008-08-25 Thread David Adam
Hello, could you keep the style of the file, please? For instance for (.) { } instead of for (.) { } The same for the if condition and the switch condition? David

Re: Unbreak dlls/winhttp on FreeBSD (and likely other BSDs/Darwin)

2008-08-25 Thread Gerald Pfeifer
On Thu, 21 Aug 2008, Hans Leidekker wrote: > Thanks. I didn't want to copy all of the ifdef blocks from wininet > because I can't verify which ones are actually needed. So I'm counting > on people like you to fix this up, and I'm sure I'll need your help > again :) You're welcome. :-) Wine build

Re: Add TRACEs to NtCreateFile returns (second try)

2008-08-25 Thread Markus Hitter
Am 25.08.2008 um 01:31 schrieb James Hawkins: > 2008/8/24 Markus Hitter <[EMAIL PROTECTED]>: >> > > +if (!attr || !attr->ObjectName) > +{ > +TRACE("returning STATUS_INVALID_PARAMETER\n"); > +return STATUS_INVALID_PARAMETER; > +} > > > These are all very useless TRACES,