Re: winemenubuilder: eliminate wineshelllink

2008-09-05 Thread Alexandre Julliard
Damjan Jovanovic [EMAIL PROTECTED] writes: @@ -169,6 +170,10 @@ MAKE_FUNCPTR(png_write_info); MAKE_FUNCPTR(png_write_row); #undef MAKE_FUNCPTR +static char xdg_config_dir[MAX_PATH]; +static char xdg_data_dir[MAX_PATH]; +static char xdg_desktop_dir[MAX_PATH]; MAX_PATH is not

Re: sane.ds: Workaround for wsprintf does not support floats.

2008-09-05 Thread Alexandre Julliard
Lei Zhang [EMAIL PROTECTED] writes: Float values in sane dialogs show up as f. This is because wsprintf does not support %f. This started occurring in commit 4fd668d01088e82b4639ee2f4f088e0b718e6a88. sprintfW should work. -- Alexandre Julliard [EMAIL PROTECTED]

Re: [5/5] user32: Move character conversion logic to dde_server.d remove todo's

2008-09-05 Thread Alexandre Julliard
Jeff Latimer [EMAIL PROTECTED] writes: @@ -772,12 +774,51 @@ static WDML_QUEUE_STATE WDML_ServerHandleExecute(WDML_CONV* pConv, WDML_XACT* pX if (ptr) { - hDdeData = DdeCreateDataHandle(0, ptr, GlobalSize(pXAct-hMem), +DWORD memSize, ptrSize =

Re: [PATCH] buffer overflow checking for string functions

2008-09-05 Thread Francois Gouget
On Thu, 4 Sep 2008, Marcus Meissner wrote: [...] +#if defined(__GNUC__) (__GNUC__ 4) +# define __builtin_object_size(x,y) -1 +#endif Shouldn't this be: #if !defined(__GNUC__) || (__GNUC__ 4) To preserve compatibility with non-GNU compilers. +static inline INT +WINAPI

Re: winemenubuilder: eliminate wineshelllink

2008-09-05 Thread Francois Gouget
On Thu, 4 Sep 2008, Damjan Jovanovic wrote: Changelog: * moved the functionality of wineshelllink into winemenubuilder, and eliminated wineshelllink What is the rational for eliminating wineshelllink? It seems to me that by eliminating it we are losing a lot of flexibility for handling

Re: winemenubuilder: eliminate wineshelllink

2008-09-05 Thread Damjan Jovanovic
On Fri, Sep 5, 2008 at 1:20 PM, Francois Gouget [EMAIL PROTECTED] wrote: On Thu, 4 Sep 2008, Damjan Jovanovic wrote: Changelog: * moved the functionality of wineshelllink into winemenubuilder, and eliminated wineshelllink What is the rational for eliminating wineshelllink? Alexandre asked

Re: [5/5] user32: Move character conversion logic to dde_server.d remove todo's

2008-09-05 Thread Jeff Latimer
Alexandre Julliard wrote: Jeff Latimer [EMAIL PROTECTED] writes: @@ -772,12 +774,51 @@ static WDML_QUEUE_STATE WDML_ServerHandleExecute(WDML_CONV* pConv, WDML_XACT* pX if (ptr) { -hDdeData = DdeCreateDataHandle(0, ptr, GlobalSize(pXAct-hMem), +DWORD

Re: winemenubuilder: eliminate wineshelllink

2008-09-05 Thread Steven Edwards
On Fri, Sep 5, 2008 at 7:59 AM, Damjan Jovanovic [EMAIL PROTECTED] wrote: There shouldn't be any special setups, fd.o is there just for that reason. Menus and desktop files should be bog standard now, and should have been that way from the very beginning. Amen. -- Steven Edwards There is

Re: notepad: Only append .txt to missing files without a dot in them

2008-09-05 Thread Alexandre Julliard
Alexander Nicolaysen Sørnes [EMAIL PROTECTED] writes: @@ -590,7 +591,8 @@ static void HandleCommandLine(LPWSTR cmdline) static const WCHAR txtW[] = { '.','t','x','t',0 }; /* try to find file with .txt extension */ -if (!lstrcmp(txtW, cmdline +

Re: user32: Resend Check for NULL pData in DdeClientTransaction expecting to be passed a handle

2008-09-05 Thread Alexandre Julliard
Jeff Latimer [EMAIL PROTECTED] writes: @@ -1157,7 +1157,10 @@ HDDEDATA WINAPI DdeClientTransaction(LPBYTE pData, DWORD cbData, HCONV hConv, HS /* Windows simply ignores hszItem and wFmt in this case */ if (pData == NULL) { - pConv-instance-lastError =

1st resend: Can we import MSConfig from ReactOS? (was: autorun perhaps dangerous)

2008-09-05 Thread Jason Spiro
(Hi Alexandre. I sent the below email 2 weeks ago and didn't get a response yet. I know you are busy, but please do try to find the time to reply, even if it's to say I'm not sure. Cheers, --Jason) cc: wine-devel@winehq.org Hi Alexandre, In January 2008, Steven Edwards wondered[1] if you

Re: 1st resend: Can we import MSConfig from ReactOS? (was: autorun perhaps dangerous)

2008-09-05 Thread Alexandre Julliard
Jason Spiro [EMAIL PROTECTED] writes: Hi Alexandre, In January 2008, Steven Edwards wondered[1] if you would let Wine import msconfig (the System Configuration Utility) from ROS. Would you allow it? No, we don't want to import code from ReactOS at this point. -- Alexandre Julliard [EMAIL

RE: wined3d: add missing HeapFree

2008-09-05 Thread Stefan Dösinger
This looks ok to me -Original Message- From: [EMAIL PROTECTED] [mailto:wine-patches- [EMAIL PROTECTED] On Behalf Of Jeff Zaroyko Sent: Friday, September 05, 2008 11:19 AM To: [EMAIL PROTECTED] Subject: wined3d: add missing HeapFree

Patchwatcher online

2008-09-05 Thread Dan Kegel
OK, I've checked in the updated Patchwatcher source http://code.google.com/p/winezeug/source/detail?r=177 and have turned email notifications back on. I also told it to rerun the most recent 11 patches, just to test that it's sending the good patches to

Re: 1st resend: Can we import MSConfig from ReactOS? (was: autorun perhaps dangerous)

2008-09-05 Thread Jason Spiro
2008/9/5 Alexandre Julliard [EMAIL PROTECTED] wrote: No, we don't want to import code from ReactOS at this point. Thanks for your reply. Some more questions: Could the Wine team make up a whitelist of trusted ReactOS developers who won't reverse engineer any Windows code? Or a whitelist of

re: Can we import MSConfig from ReactOS?

2008-09-05 Thread Dan Kegel
Jason Spiro wrote: Could the Wine team make up a whitelist of trusted ReactOS developers who won't reverse engineer any Windows code? There is already a whitelist of sorts; look at whom Alexandre accepts patches from. Or a whitelist of trusted portions of ReactOS...? IMHO it's not worth the

Re: winemenubuilder: eliminate wineshelllink

2008-09-05 Thread Francois Gouget
On Fri, 5 Sep 2008, Damjan Jovanovic wrote: [...] There shouldn't be any special setups, fd.o is there just for that reason. Right. Like that's going to be true any day soon. Already on many distros you need to generate separate .menu files for Gnome and KDE (and yet another one for KDE 4

Re: msi: Reduce destination file name used in the MoveFiles action to the long file name.

2008-09-05 Thread James Hawkins
On Fri, Sep 5, 2008 at 4:18 PM, Rob Shearman [EMAIL PROTECTED] wrote: --- dlls/msi/action.c | 22 -- 1 files changed, 16 insertions(+), 6 deletions(-) There doesn't appear to be any documentation on MSDN suggesting this behaviour but it fixes the following snippet of a

Re: msi: Reduce destination file name used in the MoveFiles action to the long file name.

2008-09-05 Thread Rob Shearman
2008/9/5 James Hawkins [EMAIL PROTECTED]: Can you please add a test case? The test_movefiles already exists, and adding this case shouldn't take more than 5 minutes. Sure, no problem. -- Rob Shearman

Re: oleaut32: Add support for loading typelibs from NE files.

2008-09-05 Thread Rob Shearman
2008/9/4 Huw Davies [EMAIL PROTECTED]: On Wed, Sep 03, 2008 at 12:51:36PM +0100, Rob Shearman wrote: 2008/9/2 Huw Davies [EMAIL PROTECTED]: --- a/dlls/oleaut32/typelib.c +++ b/dlls/oleaut32/typelib.c @@ -64,6 +64,7 @@ #include winnls.h #include winreg.h #include winuser.h

Re: [PATCH] buffer overflow checking for string functions

2008-09-05 Thread Rob Shearman
2008/9/5 Francois Gouget [EMAIL PROTECTED]: I have a few other concerns here: * Why do we need a macro here? I thought it was so that __builtin_object_size() could do its work, but the strcpy() functions above in the patch have no associated macro and they call __builtin_object_size()

Re: 1st resend: Can we import MSConfig from ReactOS? (was: autorun perhaps dangerous)

2008-09-05 Thread Steven Edwards
On Fri, Sep 5, 2008 at 3:04 PM, Jason Spiro [EMAIL PROTECTED] wrote: ^ [1]. msconfig is a simple GUI utility for changing certain Registry settings like AutoRun items and such. I am going to hijack the thread for a sec. I think we do need a msconfig tool, just to make it less trouble for

Re: wined3d: Be more careful when deleting FBOs

2008-09-05 Thread Henri Verbeet
Ignore these, I sent them a few days ago without being subscribed to the list.

Re: wined3d: Add support for updating part of a compressed surface.

2008-09-05 Thread Henri Verbeet
2008/9/5 Christof Sigel [EMAIL PROTECTED]: +/* since DXT compressed formats are specified in 4x4 pixel blocks devide pitch by 4 */ +int srcPitch=srcLockedRect.Pitch2; +int destPitch=destLockedRect.Pitch2; That will break