Re: Coverity and Wine (was: re: Adding Flawfinder to Patchwatcher)

2008-09-07 Thread Paul Vriens
Dan Kegel wrote: > Jason wrote: >> I'm pretty sure Coverity's tool, Prevent, costs money to buy. >> IIRC if the maintainers of an OSS project ask them to, >> they will set their http://scan.coverity.com server to >> run a scan on that project's code and upload >> the scan results to the web at no c

Re: Adding Flawfinder to Patchwatcher

2008-09-07 Thread Juan Lang
> AFAIK "splint" is one of the most popular OSS static analysis tools, but I've > never really used it. Has anyone here used it? On the flawfinder homepage, > it > says that splint does deeper analysis than flawfinder. It says it "...works > somewhat like lint, searching for probable errors; to

Coverity and Wine (was: re: Adding Flawfinder to Patchwatcher)

2008-09-07 Thread Dan Kegel
Jason wrote: > I'm pretty sure Coverity's tool, Prevent, costs money to buy. > IIRC if the maintainers of an OSS project ask them to, > they will set their http://scan.coverity.com server to > run a scan on that project's code and upload > the scan results to the web at no charge And they in fact

Re: crypt32: fixed the testGetCertChain tests on Vista.

2008-09-07 Thread James Hawkins
On Sun, Sep 7, 2008 at 5:59 AM, Reece Dunn <[EMAIL PROTECTED]> wrote: > This fixes these crypt32:chain testGetCertChain tests on Vista and Windows > 2008. > -ok(!ret && GetLastError() == ERROR_INVALID_DATA, - "Expected ERROR_INVALID_DATA, got %d\n", GetLastError()); +ok(!ret, "Expecte

Re: itircl: add a stub for DllUnregisterServer

2008-09-07 Thread Austin English
Please ignore this patch. It's not ready, and not sure why it was sent yet... -Austin On Sun, Sep 7, 2008 at 2:08 PM, Austin English <[EMAIL PROTECTED]> wrote: > >

Re: [PATCH] buffer overflow checking for string functions

2008-09-07 Thread Marcus Meissner
On Fri, Sep 05, 2008 at 10:44:50PM +0100, Rob Shearman wrote: > 2008/9/5 Francois Gouget <[EMAIL PROTECTED]>: > > I have a few other concerns here: > > * Why do we need a macro here? I thought it was so that > > __builtin_object_size() could do its work, but the strcpy() functions > > above in

Re: Changing configure.ac script

2008-09-07 Thread Nikolay Sivov
Vitaliy Margolen wrote: > Nikolay Sivov wrote: > >> Vitaliy Margolen wrote: >> >>> Nikolay Sivov wrote: >>> >>> Is there any way not to include a regenerated 'configure' script into a patch but be able to 'git fetch' it when it's changed remotely in repo? A

Re: Changing configure.ac script

2008-09-07 Thread Vitaliy Margolen
Nikolay Sivov wrote: > Vitaliy Margolen wrote: >> Nikolay Sivov wrote: >> >>> Is there any way not to include a regenerated 'configure' script into >>> a patch but be able to 'git fetch' it when it's changed remotely in >>> repo? >>> >>> As I see there is no need to patch a 'configure' file in re

Re: Changing configure.ac script

2008-09-07 Thread Nikolay Sivov
Vitaliy Margolen wrote: > Nikolay Sivov wrote: > >> Is there any way not to include a regenerated 'configure' script into a >> patch but be able to 'git fetch' it when it's changed remotely in repo? >> >> As I see there is no need to patch a 'configure' file in repository >> since it's always

Re: Changing configure.ac script

2008-09-07 Thread Vitaliy Margolen
Nikolay Sivov wrote: > Is there any way not to include a regenerated 'configure' script into a > patch but be able to 'git fetch' it when it's changed remotely in repo? > > As I see there is no need to patch a 'configure' file in repository > since it's always regenerated when 'configure.ac' cha

Changing configure.ac script

2008-09-07 Thread Nikolay Sivov
Is there any way not to include a regenerated 'configure' script into a patch but be able to 'git fetch' it when it's changed remotely in repo? As I see there is no need to patch a 'configure' file in repository since it's always regenerated when 'configure.ac' changed. Thanks in advance.

Re: 1st resend: Can we import MSConfig from ReactOS? (was: autorun perhaps dangerous)

2008-09-07 Thread Marcel Partap
Jason Spiro wrote: > I wrote: >> [...] msconfig is a simple GUI utility for changing certain Registry >> settings like AutoRun items and such. In the meantime: the autoruns.exe tool from the ingenious Sysinternals Suite (bought by M$) does seem to work on wine, have a look at it.. regards_marcel.

Re: Fixing the conformance tests

2008-09-07 Thread Rico Schüller
Henri Verbeet schrieb: > 2008/9/6 Rico Schüller <[EMAIL PROTECTED]>: > >> Dan Kegel schrieb: >> >>> This aborts for me in just five seconds. Can *anyone* run it for >>> an hour without failure? If so, how can I duplicate your setup? >>> - Dan >>> >>> > > >> d3d9 device: This wo

Re: Adding Flawfinder to Patchwatcher

2008-09-07 Thread Jason Spiro
Rob Shearman gmail.com> wrote: > Coverity and Prefast are both static analysis tools with a bit more > intelligence that identify bad code rather than just using "bad" > functions. I'm pretty sure Coverity's tool, Prevent, costs money to buy. IIRC if the maintainers of an OSS project ask them to

Re: 1st resend: Can we import MSConfig from ReactOS? (was: autorun perhaps dangerous)

2008-09-07 Thread Jason Spiro
I wrote: > [...] msconfig is a simple GUI utility for changing certain Registry > settings like AutoRun items and such. I used the wrong terminology when I said "AutoRun items". I should've said "startup items", i.e. HKLM\Software\Microsoft\Windows\CurrentVersion\Run items and other startup items

Re: Fixing the conformance tests

2008-09-07 Thread Ismael Barros
On 9/6/08, James Hawkins <[EMAIL PROTECTED]> wrote: >> Tests with timeouts >> === >> - dplayx:dplayx fails with a timeout on all windows servers > > According to Ismael, he has a few fixes that cut the time needed in > half. Ismael, what's the status on this? > > http://winehq.org/

Re: wineboot: Basic RunOnceEx support v2 (with patch)

2008-09-07 Thread Dmitry Timoshkov
"Johan Dahlin" <[EMAIL PROTECTED]> wrote: > +typedef HRESULT WINAPI (*DLLREGISTER) (void); > +typedef HRESULT WINAPI (*DLLINSTALL) (BOOL,LPCWSTR); This is still not right, have a look at other places that use pointers to the exported win32 APIs. > +typedef enum { > + ROEF_DIS

Re: Patchwatcher: failed regression tests: [6/10 AcceptEx] Implements sock_close_handle

2008-09-07 Thread Dan Kegel
That test almost always fails, but you managed to get it to fail in two new ways. patchwatcher has a novelty filter, and ignores known failure messages. Since your code triggered new,different failure messages, it got flagged. It's possible that the new failure mode is semirare, so you might hav

Re: user32: Resend Check for NULL pData in DdeClientTransAction expectingto be passed a handle

2008-09-07 Thread Jeff Latimer
Dmitry Timoshkov wrote: >> +if (pData == NULL) >> +{ >> +if (cbData == (DWORD)-1) >> +pConv->instance->lastError = DMLERR_INVALIDPARAMETER; >> +else >> +pConv->instance->lastError = DMLERR_MEMORY_ERROR; >> +return NULL; >> +} > > Alexandre

Re: Fixing the conformance tests

2008-09-07 Thread Paul Vriens
James Hawkins wrote: > On Sat, Sep 6, 2008 at 5:19 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: >> Hi, >> >> As we are slowly progressing towards a more green test.winehq.org there are >> still some conformance tests that fail either on all platforms or with a >> specific configuration (like IE7). >>

Re: [1/2] hlink/tests: display the expected data, as well as the actual data.

2008-09-07 Thread Reece Dunn
2008/9/7 James Hawkins <[EMAIL PROTECTED]>: > On Sun, Sep 7, 2008 at 4:56 AM, Reece Dunn <[EMAIL PROTECTED]> wrote: >> This improves the error reporting for the hlink tests. > > I think you need to think this one over. Why would we care to display > the expected data, when the expected data is in

Re: [1/2] hlink/tests: display the expected data, as well as the actual data.

2008-09-07 Thread James Hawkins
On Sun, Sep 7, 2008 at 4:56 AM, Reece Dunn <[EMAIL PROTECTED]> wrote: > This improves the error reporting for the hlink tests. > I think you need to think this one over. Why would we care to display the expected data, when the expected data is in the tests? For simple tests, e.g. last errors or

Re: Fixing the conformance tests

2008-09-07 Thread Rico Schüller
Henri Verbeet schrieb: > 2008/9/6 Rico Schüller <[EMAIL PROTECTED]>: > >> Dan Kegel schrieb: >> >>> This aborts for me in just five seconds. Can *anyone* run it for >>> an hour without failure? If so, how can I duplicate your setup? >>> - Dan >>> >>> > > >> d3d9 device: This wo

Re: Patchwatcher: failed regression tests: [6/10 AcceptEx] Implements sock_close_handle

2008-09-07 Thread Scott Lindeneau
With regards to the info with patch [7/10] I see that it still fails on patchwatcher, but patchwatcher ignores those. Does this mean that it was causing this regression on patchwatcher before and that i never noticed them because of a different regression? They still don't cause regressions on my s