Re: [2/3] mshtml: Add tests for get_scrollLeft

2008-09-10 Thread Alistair Leslie-Hughes
Alistair Leslie-Hughes [EMAIL PROTECTED] wrote in message news:[EMAIL PROTECTED] Hi, Changelog: mshtml: Add tests for get_scrollLeft Best Regards Alistair Leslie-Hughes Hi, Swap the order of patch 2 and 3 and everything all tests will pass ok. Best Regards Alistair Leslie-Hughes

Re: coverity ... new run finally

2008-09-10 Thread Marcus Meissner
On Tue, Sep 09, 2008 at 09:12:55PM +0300, Alexander Dorofeyev wrote: Dan Kegel wrote: Still a lot of NULL ptr migration issues which suck to fix, but well. 709 DEADCODEDEVENUM_ReadPinTypesdevenum/createdevenum.c 717 FORWARD_NULLDEVENUM_ReadPinTypes

Re: coverity ... new run finally

2008-09-10 Thread Paul Vriens
Marcus Meissner wrote: On Tue, Sep 09, 2008 at 09:12:55PM +0300, Alexander Dorofeyev wrote: Dan Kegel wrote: Still a lot of NULL ptr migration issues which suck to fix, but well. 709 DEADCODEDEVENUM_ReadPinTypesdevenum/createdevenum.c 717 FORWARD_NULL

Re: Praise of sorts for Wine re Softmaker Office 2008

2008-09-10 Thread Kai Blin
On Wednesday 10 September 2008 03:53:12 Dan Kegel wrote: That's praise of sorts... although I hope it doesn't dissuade other vendors from doing native ports. It'd be interesting to know who wrote this. Grammar errors like in the sentence you quoted aside, this article leaves me wondering

Re: include: Define sigset_t in pthread.h if HAVE_SIGSET_T isn't defined.

2008-09-10 Thread Paul Vriens
Rob Shearman wrote: --- include/wine/pthread.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) Hi Rob, MingW has it's own definition of sigset_t (include/sys/types.h) which conflicts with this.

Re: [1/3] mshtml: Implement HTMLElement2 get_scrollLeft (try 2)

2008-09-10 Thread Alexandre Julliard
Alistair Leslie-Hughes [EMAIL PROTECTED] writes: +nsres = nsIDOMHTMLElement_QueryInterface(This-nselem, IID_nsIDOMNSHTMLElement, (void**)nselem); +if(NS_SUCCEEDED(nsres)) +{ +nsres = nsIDOMNSHTMLElement_GetScrollLeft(nselem, left); +

Re: [PATCH] kernel32/test: Test import entries of a core windows DLL (riched20.dll) (Revision)

2008-09-10 Thread Alexandre Julliard
Roy Shea [EMAIL PROTECTED] writes: This revision adds copyright information, removes todo_wine statements to reflect the current wine head, and fixes an implicit typecast warning. --- dlls/kernel32/tests/Makefile.in|1 + dlls/kernel32/tests/loader_image.c | 98

Re: typelib: Implement LoadTypeLib16

2008-09-10 Thread Alexandre Julliard
Detlef Riekenberg [EMAIL PROTECTED] writes: +HRESULT WINAPI LoadTypeLib16(LPSTR szFile, ITypeLib** pptLib) { -FIXME((%s,%p): stub\n,debugstr_a(szFile),pptLib); +LPWSTR nameW = NULL; +HRESULT hr; +DWORD len; -if (pptLib!=0) - *pptLib=0; +TRACE((%s, %p)\n,

Re: include: Define sigset_t in pthread.h if HAVE_SIGSET_T isn't defined.

2008-09-10 Thread Rob Shearman
2008/9/10 Paul Vriens [EMAIL PROTECTED]: Rob Shearman wrote: --- include/wine/pthread.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) Hi Rob, MingW has it's own definition of sigset_t

Re: include: Define sigset_t in pthread.h if HAVE_SIGSET_T isn't defined.

2008-09-10 Thread Paul Vriens
Rob Shearman wrote: 2008/9/10 Paul Vriens [EMAIL PROTECTED]: Rob Shearman wrote: --- include/wine/pthread.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) Hi Rob, MingW has it's own definition of

Re: [2/3] mshtml: Add tests for get_scrollLeft

2008-09-10 Thread Dan Kegel
Did you forget a todo_wine? ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so dom.c ... fixme:mshtml:HTMLTextContainer_get_scrollLeft (0x15371b8)-(0x32fd34) dom.c:1077: Test failed: IHTMLTextContainer::get_scrollLeft failed: -1 dom.c:1078: Test failed: unexpected

Re: Patchwatcher security improvements

2008-09-10 Thread Francois Gouget
On Mon, 8 Sep 2008, Ambroz Bizjak wrote: Hi, I've abandoned my chroot aproach to improving security in patchwatcher. Instead I've implemented the ability to run untrusted code as a user different than the one running patchwatcher. This is because creating a chroot where Wine could be

Re: Praise of sorts for Wine re Softmaker Office 2008

2008-09-10 Thread Zac Brown
Dan Kegel wrote: http://forum.ubuntuusers.de/topic/softmaker-office-2008--eine-alternative--vora/ has a review of an office suite named Softmaker Office 2008, available for Windows and now also Linux. The review says in part Irritiert hat uns, daß die Windows-Version von Office 2008, die

Re: Patchwatcher security improvements

2008-09-10 Thread Vit Hrachovy
Francois Gouget wrote: On Mon, 8 Sep 2008, Ambroz Bizjak wrote: Hi, I've abandoned my chroot aproach to improving security in patchwatcher. Instead I've implemented the ability to run untrusted code as a user different than the one running patchwatcher. This is because creating a chroot

Re: Patchwatcher security improvements

2008-09-10 Thread Dan Kegel
On Wed, Sep 10, 2008 at 4:37 AM, Francois Gouget [EMAIL PROTECTED] wrote: This seems like an almost perfect task for a virtual machine: ... The main issue I see with this is that the OpenGL / DirectSound tests will not run on the real hardware (as usual) I just came off a project (Zumastor)

Re: Patchwatcher security improvements

2008-09-10 Thread Dan Kegel
On Wed, Sep 10, 2008 at 5:06 AM, Vit Hrachovy [EMAIL PROTECTED] wrote: I can see the way how to use pbuilder/pdebuild toolchain on dedicated user account in Debian to automate this in pretty safe and easy way. pbuilder uses fakeroot/chroot for this and its use is a nobrainer, hellish easy and

Re: Patchwatcher security improvements

2008-09-10 Thread Dan Kegel
On Wed, Sep 10, 2008 at 5:02 AM, Dan Kegel [EMAIL PROTECTED] wrote: On Wed, Sep 10, 2008 at 4:37 AM, Francois Gouget [EMAIL PROTECTED] wrote: This seems like an almost perfect task for a virtual machine: Incidentally, I documented how to produce a really small vmware image for Ubuntu at

Re: explorer.exe: Implement SC_SCREENSAVE by starting xdg-screensaver

2008-09-10 Thread Steven Edwards
On Wed, Sep 10, 2008 at 7:28 AM, Paul Chitescu [EMAIL PROTECTED] wrote: Changelog: explorer.exe: Implement SC_SCREENSAVE by starting xdg-screensaver with option to lock the screen. The desktop window reacts to SC_SCREENSAVE by starting the screen saver, just like it happens in

Re: Patchwatcher security improvements

2008-09-10 Thread Ambroz Bizjak
Francois Gouget wrote: This seems like an almost perfect task for a virtual machine: * set up you virtual machine to taste * take a snapshot * to test a patch, fire up the virtual machine * have it test the patch * after the test or when it times out, revert it to the snapshot * rinse

Re: [msi/tests] Create only one log file and delete it afterwards

2008-09-10 Thread James Hawkins
On Wed, Sep 10, 2008 at 7:39 AM, Paul Vriens [EMAIL PROTECTED] wrote: Hi, Instead of having 200 logfiles we now create one that we can delete afterwards as we know the name. This is not to speed up the tests but merely to get rid of the log files. We have to pass something for the log

Re: [msi/tests] Create only one log file and delete it afterwards

2008-09-10 Thread Paul Vriens
James Hawkins wrote: On Wed, Sep 10, 2008 at 7:39 AM, Paul Vriens [EMAIL PROTECTED] wrote: Hi, Instead of having 200 logfiles we now create one that we can delete afterwards as we know the name. This is not to speed up the tests but merely to get rid of the log files. We have to pass

Re: Patchwatcher security improvements

2008-09-10 Thread Dan Kegel
Ambroz wrote: I think I'll try getting a small Gentoo system to run in UML with a read-only root fs and make it boot as fast as possible. To try a patch, I would give it read access to the master Wine tree on the host, it would copy it to a writable temp folder and try it out. After it's

RE: Debugging Wine thoughts

2008-09-10 Thread Stefan Dösinger
You can attach any debugger to a Win32 process running in Wine. This includes Linux debuggers like gdb, or any graphical frontends, as well as Windows debuggers like visual studio. If you built wine from source, the Linux debuggers will see the Wine source. Probably they can also read the Windows

Re: Patchwatcher security improvements

2008-09-10 Thread Ambroz Bizjak
Dan Kegel wrote: So the slave can be in another real machine, another virtual machine, or running as another user; anything as long as it can get read/write access to its subdirectory of the shared directory. The problem with your design right now is that you want to run the slave in some

Re: d3dx9_36: Fix the tests for native Windows.

2008-09-10 Thread Tony
Hi, At least for all Windows versions below Vista, the d3dx9 importlib does exist (and d3dx9_36 does not), so either something is screwed up with your system or Vista is handling it otherwise (in that case we need another solution though). Best regards, Tony

Size of SUBHEAP in heap.c

2008-09-10 Thread Martin Profittlich
Hello, when trying to fix an issue with Guitar Rig 3 on Wine (Bug 10129, Guitar Rig 3 crashes), I found out something odd: The crash is affected by the size of the SUBHEAP structure in dlls/ntdll/heap.c. Just by adding 8 unused bytes to SUBHEAP, GR3 does not crash anymore. Add another 8 bytes,

Re: gdi32: Don't crash when copying to an EMF from a NULL bitmap.

2008-09-10 Thread Austin English
On Mon, Sep 8, 2008 at 3:03 PM, Austin English [EMAIL PROTECTED] wrote: Based on an original patch by Mike McCormack. Rediffed against current git. Testcase included, passes in WinXP. Fixes bug 4543. Anything wrong with this one?

Re: Debugging Wine thoughts

2008-09-10 Thread celticht32
Is there any documentation on the wine site how to set this up stefan???  It may be a start to what I am thinking. chris -Original Message- From: Stefan Dösinger [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: wine-devel@winehq.org Sent: Wed, 10 Sep 2008 11:32 am Subject: RE:

Re: d3dx9_36: Fix the tests for native Windows.

2008-09-10 Thread Tony Wasserka
yeah, but your patch is only semi-correct in that regard. What you are referring to (d3dx9.dll) is an import (IMPORTS) of the test program, i.e. a dll which is needed to run the program. What your patch is doing with that var is correct (i.e. we must use d3dx9_36 instead of d3dx9). However, the

Re: Size of SUBHEAP in heap.c

2008-09-10 Thread celticht32
This sounds like a segment / Boundry issue... how far up does it repeat this action? or have you tried??? is it an even number of blocks that the error does not occur? Chris -Original Message- From: Martin Profittlich [EMAIL PROTECTED] To: wine-devel@winehq.org Sent: Wed, 10

Re: gdi32: Don't crash when copying to an EMF from a NULL bitmap.

2008-09-10 Thread Alexandre Julliard
Austin English [EMAIL PROTECTED] writes: On Mon, Sep 8, 2008 at 3:03 PM, Austin English [EMAIL PROTECTED] wrote: Based on an original patch by Mike McCormack. Rediffed against current git. Testcase included, passes in WinXP. Fixes bug 4543. Anything wrong with this one? Yes, and it has been

Re: Patchwatcher security improvements

2008-09-10 Thread Dan Kegel
Ambroz wrote: The problem with your design right now is that you want to run the slave in some isolated environment and expect it to be secure. The build slave itself is a mission-critical process and putting it in a quarantine to run together with untrusted code allows malicious patches to

Re: [PATCH 1/2] kernel32/test: Test import entries of a core windows DLLs (Revision 2)

2008-09-10 Thread Paul Vriens
Roy Shea wrote: This revision places the new test with the other loader tests in loader.c, and for testing loads kernel32.dll rather than riched20.dll The prior version of this patch is available for reference at: http://www.winehq.org/pipermail/wine-patches/2008-September/061226.html ---

Re: Fixed an infite loop in winedbg: review wanted

2008-09-10 Thread Eric Pouech
Florian Köberle a écrit : Hello This patch address the infinite loop found at bug 15209: http://bugs.winehq.org/show_bug.cgi?id=15209 At least one of the lines I moved in the loop doesn't make sense outsite: count -= min(count, 256); because the value of count will be always 0 after the

Re: [jscript/tests] Prevent a crash on win9x

2008-09-10 Thread Jacek Caban
Paul Vriens wrote: Hi, This at least prevents the crash on win9x. There are still numerous failures on win9x but they are visible now. (I'm not so sure about returning S_FALSE in this case btw). IMO it would be better to return error code and break whole test on win9x or find a way to do

Re: Debugging Wine thoughts

2008-09-10 Thread Eric Pouech
dbghelp supports both linux debug formats (stabs, dwarf) as well as microsoft's one so any debugger using dbghelp as it's debug info provide should debug with all bells whistles native builtin applications I had some success with windbg (with a an 'e' between n d ;-) unfortunately,

Re: [setupapi/tests] Fix a failure on Windows 2000

2008-09-10 Thread James Hawkins
On Wed, Sep 10, 2008 at 10:03 AM, Paul Vriens [EMAIL PROTECTED] wrote: Hi, W2K doesn't fail with ERROR_INVALID_NAME but with ERROR_GENERAL_SYNTAX (setupapi error). That error was added for a reason; it was seen on a win2k box. Please don't remove it. -- James Hawkins

Re: [setupapi/tests] Fix a failure on Windows 2000

2008-09-10 Thread Paul Vriens
On Sep 10, 2008, at 22:11, James Hawkins [EMAIL PROTECTED] wrote: On Wed, Sep 10, 2008 at 10:03 AM, Paul Vriens [EMAIL PROTECTED] wrote: Hi, W2K doesn't fail with ERROR_INVALID_NAME but with ERROR_GENERAL_SYNTAX (setupapi error). That error was added for a reason; it was seen on a

Re: [PATCH] static buffer overflow checking

2008-09-10 Thread Michael Karcher
Am Mittwoch, den 10.09.2008, 22:12 +0200 schrieb Marcus Meissner: This approach will not work with -O0, which might be a problem. If I were to decide, that would kill the patch. I really like to recompile the dlls I am currently debugging with -O0, as that makes following the code flow much

Re: devenum: Fix order of operations bug (Coverity id 709)

2008-09-10 Thread Chris Robinson
On Wednesday 10 September 2008 11:34:03 am Juan Lang wrote: dwMediaTypeSize + (dwMediaTypeSize 2 ? 1 : dwMediaTypeSize / 2) I'm pretty sure this would come out as: dwMediaTypeSize + (dwMediaTypeSize (2 ? 1 : dwMediaTypeSize) / 2) But even if it doesn't, I don't think it'd hurt to be more

Re: devenum: Fix order of operations bug (Coverity id 709)

2008-09-10 Thread Juan Lang
I'm pretty sure this would come out as: dwMediaTypeSize + (dwMediaTypeSize (2 ? 1 : dwMediaTypeSize) / 2) It doesn't, check the order of operations again. But even if it doesn't, I don't think it'd hurt to be more explicit: dwMediaTypeSize + ((dwMediaTypeSize 2) ? 1 : (dwMediaTypeSize/2))

Re: [PATCH] static buffer overflow checking

2008-09-10 Thread Marcus Meissner
On Wed, Sep 10, 2008 at 10:27:06PM +0200, Michael Karcher wrote: Am Mittwoch, den 10.09.2008, 22:12 +0200 schrieb Marcus Meissner: This approach will not work with -O0, which might be a problem. If I were to decide, that would kill the patch. I really like to recompile the dlls I am currently

Re: d3dx9_36: Fix the tests for native Windows.

2008-09-10 Thread Detlef Riekenberg
On Mi, 2008-09-10 at 18:16 +0200, Tony wrote: Hi, At least for all Windows versions below Vista, the d3dx9 importlib does exist (and d3dx9_36 does not), I installed a recent dx9-runtime on my w2k test system, but a d3dx9.dll is not present (d3dx9_36.dll exist). I get always a blocking popup,

Re: [PATCH] static buffer overflow checking

2008-09-10 Thread Michael Karcher
Am Mittwoch, den 10.09.2008, 22:38 +0200 schrieb Marcus Meissner: I just tested some code with -O0 and the functioncall still gets optimized away. This is with gcc 4.1 and gcc 4.3. gcc 2.95 does not. If it's just a performance pessimisation with -O0, I don't care. If I get compiler or linker

Re: devenum: Fix order of operations bug (Coverity id 709)

2008-09-10 Thread David Laight
On Wed, Sep 10, 2008 at 01:38:03PM -0700, Juan Lang wrote: I'm pretty sure this would come out as: dwMediaTypeSize + (dwMediaTypeSize (2 ? 1 : dwMediaTypeSize) / 2) It doesn't, check the order of operations again. But even if it doesn't, I don't think it'd hurt to be more explicit:

Re: [PATCH] static buffer overflow checking

2008-09-10 Thread Marcus Meissner
On Wed, Sep 10, 2008 at 10:50:42PM +0200, Michael Karcher wrote: Am Mittwoch, den 10.09.2008, 22:38 +0200 schrieb Marcus Meissner: I just tested some code with -O0 and the functioncall still gets optimized away. This is with gcc 4.1 and gcc 4.3. gcc 2.95 does not. If it's just a performance

Re: devenum: Fix order of operations bug (Coverity id 709)

2008-09-10 Thread Chris Robinson
On Wednesday 10 September 2008 01:52:02 pm David Laight wrote: On Wed, Sep 10, 2008 at 01:38:03PM -0700, Juan Lang wrote: Why use two parentheses when 6 will do, eh? Sorry, I don't agree that this is clearer. Agreed, if you add too many parenthesis it gets difficult to see where they line

Re: Wine mouse input: Fwd: [RFC] Preliminary XI 2 feature list

2008-09-10 Thread Vitaliy Margolen
Roderick Colenbrander wrote: Hi all, Today Peter Hutterer posted a preliminary feature list of Xinput 2. I have forwarded the email to here so that Vitaly and others can check it out and see if it offers what we need in Wine. If you have comments I would send them to the xorg list.

Re: [PATCH 1/2] kernel32/test: Test import entries of a core windowsDLLs (Revision 2)

2008-09-10 Thread Dmitry Timoshkov
Roy Shea [EMAIL PROTECTED] wrote: This revision places the new test with the other loader tests in loader.c, and for testing loads kernel32.dll rather than riched20.dll Please move an existing and new tests to their own bodies, and use GetModuleHandle instead of LoadLibrary. -- Dmitry.

Re: Debugging Wine thoughts

2008-09-10 Thread Damjan Jovanovic
On Wed, Sep 10, 2008 at 8:17 PM, [EMAIL PROTECTED] wrote: Question : Why does wine have to allocate all its memory at startup? re... the issue that is causing the ATI drivers to have such a fuss why not just allocate as needed? or have the ability (if its not there already) to specify