Re: What to do when size of the struct differs on 32 and 64 bit?

2008-09-21 Thread Anssi Hannula
Marcus Meissner wrote: On Tue, Aug 12, 2008 at 11:44:20PM -0600, Vitaliy Margolen wrote: While debugging some force-feedback issues ran into an interesting problem. The size of one struct from include/linux differs between 32-bit and 64-bit. That wouldn't be a major problem except that size

Re: msvcrt: scanf fix a typo

2008-09-21 Thread Alexandre Julliard
Michael Karcher [EMAIL PROTECTED] writes: OK. Thanks for the pointer. I have a configure test ready that checks whether the global -fno-builtin is really needed., and uses separate flags otherwise. I am planning to submit it in series with a second patch that checks for whether

Re: kernel32: fix PROFILE_Load to handle mac line endings (try 3)

2008-09-21 Thread Michael Karcher
Am Sonntag, den 21.09.2008, 02:15 +0200 schrieb Erik Inge Bolsø: +ok(1, %s\n, content); Please use trace(...) instead of ok(1,...). Also, outputting a string with newline characters might be irritating, especially as one might need a hex viewer to see the difference between the CR-only and

Re: [PATCH] [WinHelp]: fix for 5314

2008-09-21 Thread Eric Pouech
Dmitry Timoshkov a écrit : From: Eric Pouech [EMAIL PROTECTED] wrote: +#include ctype.h ... +if (!ch || !isalpha(ch)) break; Since that's apparently a Windows encoding shouldn't this be GetStringType() instead of isalpha()? no, the issue (here) is

Re: msvcrt: scanf fix a typo

2008-09-21 Thread Michael Karcher
Am Sonntag, den 21.09.2008, 11:25 +0200 schrieb Alexandre Julliard: Michael Karcher [EMAIL PROTECTED] writes: OK. Thanks for the pointer. I have a configure test ready that checks whether the global -fno-builtin is really needed., and uses separate flags otherwise. I am planning to submit

Re: msvcrt: scanf fix a typo

2008-09-21 Thread Michael Karcher
Am Sonntag, den 21.09.2008, 13:07 +0200 schrieb Alexandre Julliard: Michael Karcher [EMAIL PROTECTED] writes: Sure I can, this was approach b I suggested. But that may be harmful to performance, as it forbids gcc to use any knowledge about the standard library (includes inlining of memcpy

Re: msvcrt: scanf fix a typo

2008-09-21 Thread Alexandre Julliard
Michael Karcher [EMAIL PROTECTED] writes: Am Sonntag, den 21.09.2008, 13:07 +0200 schrieb Alexandre Julliard: If performance is an issue you most likely don't want to use msvcrt at all, native Unix libc will always be faster. And knowing MS, they are capable of adding an exception handler in

Re: msvcrt: scanf fix a typo

2008-09-21 Thread Michael Karcher
Am Sonntag, den 21.09.2008, 13:46 +0200 schrieb Alexandre Julliard: Michael Karcher [EMAIL PROTECTED] writes: Am Sonntag, den 21.09.2008, 13:07 +0200 schrieb Alexandre Julliard: If performance is an issue you most likely don't want to use msvcrt at all, native Unix libc will always be

Re: kernel32: fix PROFILE_Load to handle mac line endings (try 3)

2008-09-21 Thread Michael Karcher
Am Sonntag, den 21.09.2008, 15:13 +0200 schrieb Erik Inge Bolsø: -ok(ret == 18, Expected 18, got %d\n, ret); +ok(ret == 18, Run %d: Expected 18, got %d\n, run, ret); Questions to everyone: I suppose if the trace above indicates the run number, these modifications are unneded. Do

Re: msvcrt: scanf fix a typo

2008-09-21 Thread Alexandre Julliard
Michael Karcher [EMAIL PROTECTED] writes: Sorry, I didn't manage to write what I mean. The only dll modules in the wine tree that currently use @BUILTINFLAG@ (and include msvcrt headers) are the two I listed. And after examing the little amount of C code they contain, I see no problem to

Re: msvcrt: scanf fix a typo

2008-09-21 Thread David Laight
On Fri, Sep 19, 2008 at 03:51:00PM -0700, Dan Kegel wrote: Here's the gcc error: scanf.c:66: warning: unknown conversion type character `P' in format I'm not a programmer, but I play one on TV. And here's what I came up with in five minutes of typing and not enough thinking: That

What broken in ubuntu Wine packages?

2008-09-21 Thread Vitaliy Margolen
Almost all bugs that come from Ubuntu users don't have usable backtraces. Instead they have this: Process of pid=0008 has terminated No process loaded, cannot execute 'echo Modules:' Cannot get info on module while no process is loaded Needless to say this doesn't help with troubleshooting the

Re: What broken in ubuntu Wine packages?

2008-09-21 Thread Andrew Fenn
Needless to say this doesn't help with troubleshooting the problem. Does anyone have a clue what might be the problem? I looked up the maintainer of the package.. Ubuntu MOTU Developers [EMAIL PROTECTED] You could try asking there?