Re: [2/2] oleacc: implemented GetRoleText[A/W] with tests

2008-10-04 Thread Nikolay Sivov
Dmitry Timoshkov wrote: > "Nikolay Sivov" <[EMAIL PROTECTED]> wrote: > >> +UINT WINAPI GetRoleTextA(DWORD role, LPSTR lpRole, UINT rolemax) >> +{ >> +UINT length; >> +WCHAR *roletextW; >> +CHAR *roletextA; >> + >> +TRACE("%u %p %u\n", role, lpRole, rolemax); >> + >> +length = Ge

Re: [2/2] oleacc: implemented GetRoleText[A/W] with tests

2008-10-04 Thread Dmitry Timoshkov
"Nikolay Sivov" <[EMAIL PROTECTED]> wrote: > +UINT WINAPI GetRoleTextA(DWORD role, LPSTR lpRole, UINT rolemax) > +{ > +UINT length; > +WCHAR *roletextW; > +CHAR *roletextA; > + > +TRACE("%u %p %u\n", role, lpRole, rolemax); > + > +length = GetRoleTextW(role, NULL, 0); > +if

Re: gdi32: Fix for capella problem with codepages in symbol fonts

2008-10-04 Thread Dmitry Timoshkov
"Stefan Ziel" <[EMAIL PROTECTED]> wrote: > Ignore characterset bit for symbol fonts > -if(!TranslateCharsetInfo((DWORD*)(INT_PTR)lf.lfCharSet, &csi, > TCI_SRCCHARSET)) { > +if (lf.lfCharSet == SYMBOL_CHARSET){ > +/* codepage for symbol is not definied -> ignore it */ > +c

Re: [try 4][PATCH 1/2] user32/tests: Added test about minimal child windowsizes.

2008-10-04 Thread Dmitry Timoshkov
"Florian Köberle" <[EMAIL PROTECTED]> wrote: > Changes since try 3: > + I found out that the minimal child window size is "4 + 2*borderWidth" > by testing multiple values for some registery keys like > "HKEY_CURRENT_USER\Control Panel\Desktop\WindowMetrics\BorderWidth" on a > Windows XP machine. I

Re: Wine: Possible typo in dll/msxml3/tests/domdoc.c

2008-10-04 Thread Michael Karcher
Am Samstag, den 04.10.2008, 21:00 +0200 schrieb Michael Karcher: > > it looks like test_removeChild (introduced by you in commit 187ab1c0) > > contains a typo. > Ugh. Please disregard the previous mail. The test after "fixing" the > typo does *not* succeed in WinXP, only in wine. Last followup on t

Re: Wine: Possible typo in dll/msxml3/tests/domdoc.c

2008-10-04 Thread Michael Karcher
[resend, as I used a non-subscribed From: in the first try] Am Samstag, den 04.10.2008, 20:44 +0200 schrieb Michael Karcher: > Hello Huw Davies, > > it looks like test_removeChild (introduced by you in commit 187ab1c0) > contains a typo. Ugh. Please disregard the previous mail. The test after "f

Wine: Possible typo in dll/msxml3/tests/domdoc.c

2008-10-04 Thread Michael Karcher
Hello Huw Davies, it looks like test_removeChild (introduced by you in commit 187ab1c0) contains a typo. The test passes both ways, but from the code flow I suspect that node_list2 was obtained for a reason, namely using it. Regards, Michael Karcher This patch fixes the type, if it turn out to