Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests

2008-10-10 Thread Andrey Turkin
James Hawkins wrote: On Thu, Oct 9, 2008 at 4:14 PM, Andrey Turkin [EMAIL PROTECTED] wrote: [now with tests, fixed and reformatted as per James' suggestions] Implement CredReadDomainCredentialsA and CredReadDomainCredentialsW stubs and few tests for them. Required for MSN Messenger 7.0

Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests

2008-10-10 Thread James Hawkins
On Fri, Oct 10, 2008 at 12:59 AM, Andrey Turkin [EMAIL PROTECTED] wrote: James Hawkins wrote: On Thu, Oct 9, 2008 at 4:14 PM, Andrey Turkin [EMAIL PROTECTED] wrote: [now with tests, fixed and reformatted as per James' suggestions] Implement CredReadDomainCredentialsA and

Re: Opengl32: add a test case for WGL_ARB_create_context/opengl3 [try2]

2008-10-10 Thread Christoph Frick
On Fri, Oct 10, 2008 at 10:42:05AM +0200, Roderick Colenbrander wrote: +/* Try to create an OpenGL 3.0 contet */ content? context? -- cu pgpP3eMPpyjbs.pgp Description: PGP signature

Re: Adding timestamps to log output

2008-10-10 Thread Rob Shearman
2008/10/8 Michael Karcher [EMAIL PROTECTED]: In http://www.winehq.org/pipermail/wine-patches/2008-June/056508.html Peter Urbanec sent a patch I like, that adds timing information to the log. It has been critized for having the wrong indentation style. As I would like to give that patch a

Re: Adding timestamps to log output

2008-10-10 Thread Michael Karcher
Am Freitag, den 10.10.2008, 14:26 +0100 schrieb Rob Shearman: 2008/10/8 Michael Karcher [EMAIL PROTECTED]: In http://www.winehq.org/pipermail/wine-patches/2008-June/056508.html Peter Urbanec sent a patch I like, that adds timing information to the log. It has been critized for having the

Re: Opengl32: add a test case for WGL_ARB_create_context/opengl3 [try2]

2008-10-10 Thread Roderick Colenbrander
Roderick Colenbrander wrote: Hi, This is a resubmit of the same patch but not part of a series which contained a failing patch, so it should pass patchwatcher. Regards, Roderick Colenbrander

Re: d3d: Bug in handling of depth-stencil surfaces, and potential patch

2008-10-10 Thread Henri Verbeet
2008/10/9 Jim Cameron [EMAIL PROTECTED]: See bug 10758. If you create a depth-stencil surface with Direct3D 9 on Windows, select it into a D3D9 device with SetDepthStencilSurface() and then release it (so its reference count goes to zero), the surface will not be deleted. It will persist

Re: rpcrt4: Use pseudo-random numbers to generate UUIDs rather than using the (old, deprecated) MAC-address-and-time generation algorithm (try 2)

2008-10-10 Thread Rob Shearman
Hi Juan, 2008/10/9 Juan Lang [EMAIL PROTECTED]: +RtlGenRandom(Uuid, sizeof(*Uuid)); +/* Clear the version bits and set the version (4) */ +Uuid-Data3 = 0x0fff; +Uuid-Data3 |= (4 12); The RFC recommends the following: o Set the two most significant bits (bits 6 and 7) of

Re: rpcrt4: Use pseudo-random numbers to generate UUIDs rather than using the (old, deprecated) MAC-address-and-time generation algorithm (try 2)

2008-10-10 Thread Juan Lang
Hi Rob, The RFC recommends the following: o Set the two most significant bits (bits 6 and 7) of the clock_seq_hi_and_reserved to zero and one, respectively. However, I don't see that done in your patch. Thanks, I missed that. Have you checked which algorithm recent versions of

Re: Opengl32: add a test case for WGL_ARB_create_context/opengl3 [try2]

2008-10-10 Thread Paul Vriens
Roderick Colenbrander wrote: Hi, This is a resubmit of the same patch but not part of a series which contained a failing patch, so it should pass patchwatcher. Regards, Roderick Colenbrander Hi

Re: Resend: mshtml.dll:Add implementation HTMLDocument_get_referrer

2008-10-10 Thread Jacek Caban
Ivan Sinitsin wrote: Add implementation of HTMLDocument_get_referrer function, in unit `htmldoc.c` (mshtml.dll). Changelog: Add implementation of HTMLDocument_get_referrer function. +if(!This-nscontainer) +return E_FAIL; + +nsres =

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-10 Thread Kai Blin
On Thursday 09 October 2008 22:06:55 Chris Ahrendt wrote: Whew, long post. I'll tackle this as I go. My wish list would be: 1) Some form of a Standard Gui Debugger GDB integration / eclipse etc.. gdb has a standard GUI? Which would that be in your case? I hear Eclipse is useable for C

Fwd: WWN 353

2008-10-10 Thread Zachary Goldberg
I'm forwarding (with permission) to Wine-Devel an email I got about the most recent WWN and 'Other Platforms' support. --Zach -- Forwarded message -- From: Rodney Sparapani [EMAIL PROTECTED] Date: Wed, Oct 8, 2008 at 1:02 PM Subject: WWN 353 To: [EMAIL PROTECTED] Hi Zachary: I

Help testing a test on Win9x/NT4

2008-10-10 Thread Juan Lang
Hi folks, could someone who has Win9x or NT4 and is capable of building the tests try the attached patch and email me the results if it fails? Also please tell me the Windows version if it's failing. Thanks, --Juan From 7f2554ff251f34a338c1dc40bc0e8362b00c3243 Mon Sep 17 00:00:00 2001 From: Juan

Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests

2008-10-10 Thread James Hawkins
On Fri, Oct 10, 2008 at 3:17 PM, Andrey Turkin [EMAIL PROTECTED] wrote: Imagine broken application which for some reason, e.g. non-allocated memory, supply NULL to this function, and then catch, eat and spew an exception somewhere in different place. Joe the Developer start searching for root

Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests

2008-10-10 Thread Andrey Turkin
James Hawkins wrote: On Fri, Oct 10, 2008 at 3:17 PM, Andrey Turkin [EMAIL PROTECTED] wrote: Imagine broken application which for some reason, e.g. non-allocated memory, supply NULL to this function, and then catch, eat and spew an exception somewhere in different place. Joe the Developer

Re: mshtml: avoid dereferencing a potental NULL (Coverity 633)

2008-10-10 Thread Jacek Caban
Austin English wrote: ret++; -if(bound_pos dompos_cmp(tmp, bound_pos)) { +if(bounded bound_pos dompos_cmp(tmp, bound_pos)) { *bounded = TRUE; It's a false error. bounded is never NULL if bound_pos is not NULL. Jacek

Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests

2008-10-10 Thread James Hawkins
On Fri, Oct 10, 2008 at 2:51 PM, Andrey Turkin [EMAIL PROTECTED] wrote: James Hawkins wrote: On Fri, Oct 10, 2008 at 12:59 AM, Andrey Turkin [EMAIL PROTECTED] wrote: I can't see any value in commented out test or sort-of-meaningless code comment. The tests serve as documentation of the

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-10 Thread Chris Ahrendt
Kai Blin wrote: On Thursday 09 October 2008 22:06:55 Chris Ahrendt wrote: Whew, long post. I'll tackle this as I go. Yes I am sorry for the long post =) but he did ask for some of my thoughts =) My wish list would be: 1) Some form of a Standard Gui Debugger GDB integration / eclipse

Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests

2008-10-10 Thread Andrey Turkin
James Hawkins wrote: On Fri, Oct 10, 2008 at 2:51 PM, Andrey Turkin [EMAIL PROTECTED] wrote: James Hawkins wrote: On Fri, Oct 10, 2008 at 12:59 AM, Andrey Turkin [EMAIL PROTECTED] wrote: I can't see any value in commented out test or sort-of-meaningless code comment. The tests

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-10 Thread James Hawkins
On Fri, Oct 10, 2008 at 4:00 PM, Chris Ahrendt [EMAIL PROTECTED] wrote: Yes I am sorry for the long post =) but he did ask for some of my thoughts =) Most debugger GUIs on Linux are (somewhat sucky) frontends to gdb. I'm pretty sure it's possible to create something similar for winedbg.

Re: [try3] advapi32: Implement CredReadDomainCredentials stub and tests

2008-10-10 Thread James Hawkins
On Fri, Oct 10, 2008 at 2:52 PM, Andrey Turkin [EMAIL PROTECTED] wrote: [few comments added as per James' suggestion] Implement CredReadDomainCredentialsA and CredReadDomainCredentialsW stubs and few tests for them. Required for MSN Messenger 7.0 --- dlls/advapi32/advapi32.spec |4 +-

Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests

2008-10-10 Thread James Hawkins
On Fri, Oct 10, 2008 at 3:49 PM, Andrey Turkin [EMAIL PROTECTED] wrote: We know my implementation and Windows implementation behave identically and this is documented in tests. At this point you and me both happy about the comment in tests and tests in general, right? Now back to the

Re: Help testing a test on Win9x/NT4

2008-10-10 Thread Dmitry Timoshkov
Juan Lang [EMAIL PROTECTED] wrote: Hi folks, could someone who has Win9x or NT4 and is capable of building the tests try the attached patch and email me the results if it fails? Also please tell me the Windows version if it's failing. The test passes for me under Win98, XP SP3, and Vista

Sugared Wine

2008-10-10 Thread Vincent Povirk
For those of you just tuning in, CodeWeavers has had me working on a project called Sugared Wine. The plan was that I would implement a taskbar (complete with start menu, window switcher, and system tray) in explorer for Wine's virtual desktop and fix some virtual desktop bugs. Jeremy White would

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-10 Thread Austin English
On Fri, Oct 10, 2008 at 4:14 PM, James Hawkins [EMAIL PROTECTED] wrote: On Fri, Oct 10, 2008 at 4:00 PM, Chris Ahrendt [EMAIL PROTECTED] wrote: Yes I am sorry for the long post =) but he did ask for some of my thoughts =) Most debugger GUIs on Linux are (somewhat sucky) frontends to gdb.

Re: (try 2) gdi32: if a font substitution is given then only match tothat substitution not to the original family name.

2008-10-10 Thread Dmitry Timoshkov
Aric Stewart [EMAIL PROTECTED] wrote: You are mostly correct. It looks like windows totally ignores the font substitute if it finds the correct font. So this patch is incorrect. Is there a good mechanic to get wine to force a substitution for a broken font? If the user has FontX however

Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests

2008-10-10 Thread James McKenzie
James Hawkins wrote: On Fri, Oct 10, 2008 at 3:49 PM, Andrey Turkin [EMAIL PROTECTED] wrote: We know my implementation and Windows implementation behave identically and this is documented in tests. At this point you and me both happy about the comment in tests and tests in general, right?