Re: Splitting the appdb Top 25 list

2008-10-17 Thread chris ahrendt
MY $.02 cp on the issue agrees with the others... I would say split it up.. but more possibly than applications and games.. Say : games Utils Development Tools Applications Chris __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam pr

RE: Splitting the appdb Top 25 list

2008-10-17 Thread ricardo filipe
i think that list could prove useful, although i agree it could be split on to apps and games, makes all sense. even if devs don't look at it right now maybe someone does and wants to hack on top voters. the MTGO 3 example is interesting, i'm the maintainer of the game, and that surge in the f

Re: Splitting the appdb Top 25 list

2008-10-17 Thread Susan Cragin
-Original Message- >> I'm not a developer, but I joined to make a humble suggestion in a place >> where someone might actually have the power to act on it. >> >> Does anyone think it would be a good idea to split the Top 25 into two >> lists, one for games, and one for applications/other? >

Re: Splitting the appdb Top 25 list

2008-10-17 Thread Jeff Davis
Do developers set priorities based on what's on the voting list anyway? I mean, does any developer ever really say 'Wow, Bioshock has 42 votes, maybe I should work on that tomorrow'? That's almost certainly not the case. For the longest time as a user I had the impression that wine developers sp

Re: gdi32: Add job name field into CreateSpoolFile

2008-10-17 Thread Detlef Riekenberg
On Mo, 2008-10-13 at 12:29 +0400, Konstantin Kondratyuk wrote: > -sprintf(psCmd,"|lpr -P'%s'",pszOutput+4); > +sprintf(psCmd,"|lpr -T %s -P'%s'",pszTitle,pszOutput+4); This is broken, when there is a space in the Title. -- By by ... Detlef

Re: Splitting the appdb Top 25 list

2008-10-17 Thread Alexander Nicolaysen Sørnes
On Saturday 18 October 2008 00:18:24 Jeff Davis wrote: > I'm not a developer, but I joined to make a humble suggestion in a place > where someone might actually have the power to act on it. > > Does anyone think it would be a good idea to split the Top 25 into two > lists, one for games, and one fo

Splitting the appdb Top 25 list

2008-10-17 Thread Jeff Davis
I'm not a developer, but I joined to make a humble suggestion in a place where someone might actually have the power to act on it. Does anyone think it would be a good idea to split the Top 25 into two lists, one for games, and one for applications/other? By my count, every item of the top 10 is

Re: dlls/shlwapi/assoc.c:fix ASSOC_GetExecutable not to use uninitialised variable

2008-10-17 Thread Austin English
On Fri, Oct 17, 2008 at 5:57 AM, Joris Huizer <[EMAIL PROTECTED]> wrote: > --- On Thu, 10/16/08, Austin English <[EMAIL PROTECTED]> wrote: >> >> "From: Joris Huizer >> <[EMAIL PROTECTED](none)>" >> >> Minor, but please fix your e-mail in the patch: >> >> Also, please set patch extensions to .txt, i

Re: mscvrt: updated use of pmode flag in _s_open - set permissions of thefile after it's been created.

2008-10-17 Thread Ivan Peevski
Thanks Dmitry, I'll update the patch (again) and resubmit it. This is my first time submitting a patch to wine, so still getting used with how things work ... thanks for the help and patience everyone :) ivan 2008/10/17 Dmitry Timoshkov <[EMAIL PROTECTED]>: > "Ivan Peevski" <[EMAIL PROTECTED]>

Re: dlls/shlwapi/assoc.c:fix ASSOC_GetExecutable not to use uninitialised variable

2008-10-17 Thread Joris Huizer
--- On Thu, 10/16/08, Austin English <[EMAIL PROTECTED]> wrote: > > "From: Joris Huizer > <[EMAIL PROTECTED](none)>" > > Minor, but please fix your e-mail in the patch: > > Also, please set patch extensions to .txt, it makes it > easier to read > in browser. > Alright, I did a resent with the

Re: mscms: quiet a noisy fixme (1/3)

2008-10-17 Thread Austin English
On Fri, Oct 17, 2008 at 12:09 PM, Detlef Riekenberg <[EMAIL PROTECTED]> wrote: > On Do, 2008-10-16 at 19:44 -0500, Austin English wrote: > >> +if (quietfixme == 0) >> +{ >> +FIXME("unhandled bitmap format\n"); > Such a FIXME has no useful information. > You should also d

Wine and LSB development kit?

2008-10-17 Thread Dan Kegel
Two years ago I tried building wine with the LSB development kit, http://www.winehq.org/pipermail/wine-devel/2006-August/050554.html They've released a snazzy new beta of LSB 4.0, see https://www.linuxfoundation.org/en/LSB_4.0_Beta Could somebody try building and running Wine with it to give them

Re: kernel32: quiet a noisy err (try 2)

2008-10-17 Thread Austin English
On Fri, Oct 17, 2008 at 2:03 PM, Henri Verbeet <[EMAIL PROTECTED]> wrote: > 2008/10/17 Austin English <[EMAIL PROTECTED]>: >> On Fri, Oct 17, 2008 at 1:52 PM, Henri Verbeet <[EMAIL PROTECTED]> wrote: >>> Actually, what are you doing that you even see this ERR at all? >>> >>> >>> >> >> http://bugs.w

Re: kernel32: quiet a noisy err (try 2)

2008-10-17 Thread Henri Verbeet
2008/10/17 Austin English <[EMAIL PROTECTED]>: > On Fri, Oct 17, 2008 at 1:52 PM, Henri Verbeet <[EMAIL PROTECTED]> wrote: >> Actually, what are you doing that you even see this ERR at all? >> >> >> > > http://bugs.winehq.org/show_bug.cgi?id=4020 > > Printed a little over 1500 times. > The applicat

Re: kernel32: quiet a noisy err (try 2)

2008-10-17 Thread Austin English
On Fri, Oct 17, 2008 at 1:52 PM, Henri Verbeet <[EMAIL PROTECTED]> wrote: > Actually, what are you doing that you even see this ERR at all? > > > http://bugs.winehq.org/show_bug.cgi?id=4020 Printed a little over 1500 times. -- -Austin

Re: kernel32: quiet a noisy err (try 2)

2008-10-17 Thread Henri Verbeet
Actually, what are you doing that you even see this ERR at all?

Re: comdlg32/tests: Windows XP cannot do a CreateViewWindow2 twice in rapid seccesion. handle this error.

2008-10-17 Thread Aric Stewart
Not sure. I tried all sorts of changes to get the second test to succeed. It is not the test itself. If i comment out the first set it works fine. If i reverse the order the new second one fails. and the error code is totally unhelpful. -aric Henri Verbeet wrote: > Any idea why it can't do th

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-17 Thread James Hawkins
2008/10/17 Vitaly Perov <[EMAIL PROTECTED]>: > > > From e2eec69ff86960bd6729a3105747310ce9c256fd Mon Sep 17 00:00:00 2001 > From: Vitaly Perov <[EMAIL PROTECTED]> > Date: Fri, 17 Oct 2008 16:56:46 +0400 > Subject: [PATCH] shell32: FOF_MULTIDESTFILES must be set when copying files > into directory

Re: mscms: quiet a noisy fixme (1/3)

2008-10-17 Thread Detlef Riekenberg
On Do, 2008-10-16 at 19:44 -0500, Austin English wrote: > +if (quietfixme == 0) > +{ > +FIXME("unhandled bitmap format\n"); Such a FIXME has no useful information. You should also dump the unhandled bitmap format in the FIXME > +quietfixme = 1; > +

Re: DirectX DLL 36?

2008-10-17 Thread Henri Verbeet
2008/10/17 Warren Dumortier <[EMAIL PROTECTED]>: > Hi! > > A lot of games currently doesn't start 'out-of-the-box' by missing > d3dx9_36.dll, wouldn't it a good idea to have this dll in wine, is it > possible, difficult? Wine does have that dll, but large parts of it are still unimplemented.

DirectX DLL 36?

2008-10-17 Thread Warren Dumortier
Hi! A lot of games currently doesn't start 'out-of-the-box' by missing d3dx9_36.dll, wouldn't it a good idea to have this dll in wine, is it possible, difficult? I'm not a programmer, just a wine user proposing this idea (would be nice). Thanks, kind regards dear devs! :)

Re: mscms: quiet a noisy fixme (1/3)

2008-10-17 Thread Austin English
On Fri, Oct 17, 2008 at 2:11 AM, Henri Verbeet <[EMAIL PROTECTED]> wrote: > I don't think you want to change the return code based on whether the > FIXME is shown or not. > > > Without the return code, gcc gives a compiler warning: [EMAIL PROTECTED]:~/wine-git/dlls/mscms$ make ccache gcc -c -I. -I

Re: kernel32: quiet a noisy err (2/3)

2008-10-17 Thread Austin English
On Fri, Oct 17, 2008 at 10:28 AM, Vincent Povirk <[EMAIL PROTECTED]> wrote: > You're setting quieterr to 0 initially, and the if condition will only > be true if it is 1. The ERR will never be printed. > > Also, I think you should move the test for quieterr into the for loop, > since all the loop d

Re: kernel32: quiet a noisy err (2/3)

2008-10-17 Thread Vincent Povirk
You're setting quieterr to 0 initially, and the if condition will only be true if it is 1. The ERR will never be printed. Also, I think you should move the test for quieterr into the for loop, since all the loop does is print the ERR. Vincent Povirk On Thu, Oct 16, 2008 at 7:46 PM, Austin Engl

Re: mscvrt: updated use of pmode flag in _s_open - set permissions of thefile after it's been created.

2008-10-17 Thread Dmitry Timoshkov
"Ivan Peevski" <[EMAIL PROTECTED]> wrote: > +/* Ignore _S_IREAD and _S_IWRITE if file exists. */ > +if (stat(path, &buf) != 0) > + pmode = pmode & (MSVCRT__S_IREAD | MSVCRT__S_IWRITE); /*relevant > flags*/ You need to use MSVCRT__stat(), not the system stat(), and appropriately type

Re: comdlg32/tests: Windows XP cannot do a CreateViewWindow2 twice in rapid seccesion. handle this error.

2008-10-17 Thread Henri Verbeet
Any idea why it can't do that? Looking at the test results it looks like 2003 and 2008 fail as well, although 2008 fails on the first call, with a different error. The second CreateViewWindow2 call is more important than the first, so it probably makes sense to swap them if we're going to skip one

Re: dsound: Add typedefs for uint8_t, uint16_t and uint32_t for systems that don't have stdint.h.

2008-10-17 Thread Dmitry Timoshkov
"Rob Shearman" <[EMAIL PROTECTED]> wrote: > --- > dlls/dsound/dsound_convert.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) I'd argue that dsound_convert.c should use win32 types instead. -- Dmitry.

Re: dsound: Add typedefs for uint8_t, uint16_t and uint32_t for systems that don't have stdint.h.

2008-10-17 Thread Michael Karcher
Am Freitag, den 17.10.2008, 11:06 +0100 schrieb Rob Shearman: > +typedef unsigned char uint8_t; > +typedef unsigned short uint16_t; > +typedef unsigned int uint32_t; This probably works on all platforms Wine is designed for, but why don't you use the autoconf provision for these types called AC_CR

Re: [PATCH 03/10] jscript: Added NaN value implementation.

2008-10-17 Thread Rob Shearman
2008/10/16 David Laight <[EMAIL PROTECTED]>: > On Wed, Oct 15, 2008 at 04:50:30PM -0500, Jacek Caban wrote: >> Alexandre Julliard wrote: >> >I'd suggest to take advantage of the variant union instead of copying >> >all these glibc definitions. Something like >> > >> >#ifdef NAN >> >V_R8(&vt) =

Re: Kernel32: 3GB UserSpace boot option

2008-10-17 Thread Alexandre Julliard
"Stefan Reimer" <[EMAIL PROTECTED]> writes: > I reverted my changes to mmap.c mmap_init back to > char *user_space_limit = (char *)0x7ffe; > but keeping the 0xBFFE in GetSystemInfo. > > Everquest2 crashes after some minutes. I got following errors in log: > err:d3d:CreateIndexBufferVBO Fai

Re: [1/3] netapi32/tests: Add a test for well known account RIDs

2008-10-17 Thread Nicolas Le Cam
Its obvious but don't apply, third patch is missing comment and unused variables cleaning. I will submit a new patch later. regards, Nicolas Le Cam 2008/10/17 Nicolas Le Cam <[EMAIL PROTECTED]>: > Hi, > > This path series intend to fix a failing test on localized windows > version. > The first tw

Re: mscms: quiet a noisy fixme (1/3)

2008-10-17 Thread Henri Verbeet
I don't think you want to change the return code based on whether the FIXME is shown or not.