Re: Wine integration with native (Gtk, Qt, Cocoa/Carbon) themes

2008-11-18 Thread Frank Richter
On 02.11.2008 23:28, Steven Edwards wrote: > I agree. I simply think any outside tools we develop should be used in > conjunction with a proposed formal standard. I've just seen this: http://www.andreasn.se/blog/?p=91 In short, there is work being done on a GTK+ theming engine that uses CSS(!) f

Re: Contribute to wine

2008-11-18 Thread Andrew Fenn
You could add the type definition D3DXMESH. I want to implement the function D3DXCleanMesh however I don't want to have to implement LPD3DXMESH because it's too much effort. Regards, Andrew On Tue, Nov 18, 2008 at 11:34 PM, Krzysztof Drewniak <[EMAIL PROTECTED]> wrote: > I'd like to contribute s

Re: dead stores in msxml3

2008-11-18 Thread Piotr Caban
Hi Ricardo, There are few things that needs to be changed in 'dlls/msxml3: check dead stores (llvm/clang)' patch. Some of the 'hr != S_OK' should not be replaced with 'FAILED(hr)'. Sometimes the parser should stop if user returns anything except S_OK. Changes in following functions are incorrec

Re: Contribute to wine

2008-11-18 Thread James Hawkins
On Tue, Nov 18, 2008 at 5:34 PM, Krzysztof Drewniak <[EMAIL PROTECTED]> wrote: > I'd like to contribute something to wine, but I don't know what? Can I > get a list? > http://wiki.winehq.org/TodoList -- James Hawkins

Contribute to wine

2008-11-18 Thread Krzysztof Drewniak
I'd like to contribute something to wine, but I don't know what? Can I get a list? Krzys D. P.S. The audio is choppy on Ubuntu 8.10 with latest git.

Re: dlls/ntdll: fixed dead store (llvm/clang)

2008-11-18 Thread Austin English
On Tue, Nov 18, 2008 at 4:22 PM, ricardo filipe <[EMAIL PROTECTED]> wrote: > > > > Conheça já o Windows Live Spaces, o site de relacionamentos do Messenger! > Crie já o seu! > > > You forgot the patch. -- -Austin

Re: dead stores in netapi32

2008-11-18 Thread Juan Lang
> Does that netbios code actually work? IIRC you need to bind to port 137 to do > netbios requests. That's not strictly true, you can be a client without binding to port 137. You just can't advertise any services. I haven't tried it myself in a long, long time, though I did hear from a couple pe

Re: dead stores in netapi32

2008-11-18 Thread Kai Blin
On Tuesday 18 November 2008 23:13:38 ricardo filipe wrote: > hi juan! > > i'm tracking some dead stores with Clang and i've found some in files you > created that i'm not comfortable messing with. Does that netbios code actually work? IIRC you need to bind to port 137 to do netbios requests. I ca

dead stores in msxml3

2008-11-18 Thread ricardo filipe
hi leslie. i'm tracking some dead stores with Clang and there are some in dlls/msxml3/saxreader.c i'm hoping you can tell me if the stores are to be removed for performance or if they should be checked in each iteration for correctness: file dlls/msxml3/saxreader.c lines: 1163 1166 1213 1216 re

dead stores in netapi32

2008-11-18 Thread ricardo filipe
hi juan! i'm tracking some dead stores with Clang and i've found some in files you created that i'm not comfortable messing with. file dlls/netapi32/nbt.c: lines: 419 839 1185 1192 1201 file dlls/netapi32/netbios.c: lines: 634 636 i thought you might want to have a look at it :) regards,

Fedora 9 and MingW

2008-11-18 Thread Paul Vriens
Hi, I was still using the rpm's that Hans provided in the past. Some searching shows: https://fcp.surfsite.org/modules/newbb/viewtopic.php?topic_id=61801&forum=11 I've installed these rpm's but the executables use a different naming convention: i686-pc-mingw32* instead of what we check for: i6

Re: dlls/oleaut32: add tests for OleLoadPictureFile(Ex)

2008-11-18 Thread Michael Karcher
Am Dienstag, den 18.11.2008, 08:51 -0800 schrieb Jeremy Drake: > On Tue, 18 Nov 2008, Michael Karcher wrote: > > > Looks OK to me, but what happened to your finding about > > INET_E_RESOURCE_NOT_FOUND? Was it a red herring? > I saw that on XP, but I couldn't reproduce it on Windows 2000. I need t

Re: cryptdlg(2/2): Implement FormatVerisignExtension

2008-11-18 Thread Alexandre Julliard
"Juan Lang" <[EMAIL PROTECTED]> writes: >> There's no need to store a copy of the string. You should load it >> directly into the destination buffer. > > LoadStringW doesn't do what FormatVerisignExtension does: it doesn't > SetLastError(ERROR_MORE_DATA) if the buffer is too small. The callers >

Re: cryptdlg(2/2): Implement FormatVerisignExtension

2008-11-18 Thread Juan Lang
> There's no need to store a copy of the string. You should load it > directly into the destination buffer. LoadStringW doesn't do what FormatVerisignExtension does: it doesn't SetLastError(ERROR_MORE_DATA) if the buffer is too small. The callers of FormatVerisignExtension call it with a NULL po

Re: cryptdlg(2/2): Implement FormatVerisignExtension

2008-11-18 Thread Alexandre Julliard
"Juan Lang" <[EMAIL PROTECTED]> writes: > +if (dwFormatStrType & CRYPT_FORMAT_STR_NO_HEX) > +{ > +static BOOL stringLoaded = FALSE; > +DWORD bytesNeeded; > + > +if (!stringLoaded) > +{ > +LoadStringW(hInstance, IDS_VERISIGN_STATEMENT, > verisign

Another source of hardware statistics!

2008-11-18 Thread Dan Kegel
Unity3d is a game engine for casual gaming (not hardcore gaming). They have some good data on their user base's hardware at http://unity3d.com/webplayer/hwstats e.g. their breakdown of video cards for this quarter is at http://unity3d.com/webplayer/hwstats/pages/web-2008Q4-gfxcard.html Their top

Re: fix a crash in widl on Vista x86

2008-11-18 Thread Rob Shearman
2008/11/17 <[EMAIL PROTECTED]>: > Changelog: > Add a FIXME for the crash in widl on Vista x86. > > diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c > index fcb141e..45467e5 100644 > --- a/tools/widl/typegen.c > +++ b/tools/widl/typegen.c > @@ -3137,7 +3137,7 @@ size_t get_size_procformats

NT driver address space

2008-11-18 Thread Alexander Morozov
Hi, Under Wine NT drivers are running in user address space. Some drivers do not work correctly because of this. For example Guardant USB token driver crashes when loading but this problem can be fixed with such patch (really I tested with our wine fork): diff --git a/dlls/ntdll/virtual.c b/dl

Re: Patch for [Bug 16087] wine spews innumerable "Unable to check compatibility for Format..." errors in some games

2008-11-18 Thread Henri Verbeet
2008/11/18 Stefan Dösinger <[EMAIL PROTECTED]>: > I think it would be better f getColorBits returned a proper error to the > caller, and the caller handles these errors without spamming the FIXME or > ERR channel. That would seem better to me than prefiltering the parameters > It does, it returns F

RE: dlls/cabinet: fix dead stores (llvm/clang)

2008-11-18 Thread ricardo filipe
> Date: Tue, 18 Nov 2008 10:17:46 +0100> From: [EMAIL PROTECTED]> To: [EMAIL > PROTECTED]> CC: [EMAIL PROTECTED]; wine-devel@winehq.org> Subject: Re: > dlls/cabinet: fix dead stores (llvm/clang)> > On Tue, Nov 18, 2008 at > 03:11:52PM +0800, Dmitry Timoshkov wrote:> > "ricardo filipe" <[EMAIL

Re: dlls/cabinet: fix dead stores (llvm/clang)

2008-11-18 Thread Marcus Meissner
On Tue, Nov 18, 2008 at 03:11:52PM +0800, Dmitry Timoshkov wrote: > "ricardo filipe" <[EMAIL PROTECTED]> wrote: > > > --- a/dlls/cabinet/fci.c > > +++ b/dlls/cabinet/fci.c > > @@ -462,7 +462,7 @@ static cab_ULONG fci_get_checksum(const void *pv, UINT > > cb, CHECKSUM seed) > > case 2: > >

Re: Patch for [Bug 16087] wine spews innumerable "Unable to check compatibility for Format..." errors in some games

2008-11-18 Thread Henri Verbeet
> +switch(Format) > +{ > +case WINED3DFMT_X8R8G8B8: > +case WINED3DFMT_R8G8B8: > +case WINED3DFMT_A8R8G8B8: > +case WINED3DFMT_A2R10G10B10: > +case WINED3DFMT_X1R5G5B5: > +case WINED3DFMT_A1R5G5B5: > +

Re: implement OleLoadPictureFile

2008-11-18 Thread Jeremy Drake
On Tue, 18 Nov 2008, Michael Karcher wrote: > > Note that the IDL defines the VARIANT parameter as "optional". If the > > filename is not specified, you should pass a NULL stream to > > OleLoadPicture. > How do I know? I think you shouldn't have told these detail. I might > know what happens if I