Re: oleaut32/tests: add tests for OleLoadPictureFile(Ex) and OleLoadPicurePath (resend) [3/3]

2008-12-16 Thread Paul Vriens
Jeremy Drake wrote: This integrates the scenarios that I wasn't testing from Nikolay Sivov's patch to the tests of 12/7. Also works around some issues I was running into trying to write wide strings as Lfoo. --- dlls/oleaut32/tests/olepicture.c | 311

Re: [resend5] gdi32/tests: Add a test fot GdiGetCodePage().

2008-12-16 Thread Paul Vriens
ByeongSik Jeon wrote: --- dlls/gdi32/tests/Makefile.in |2 +- dlls/gdi32/tests/font.c | 156 ++ 2 files changed, 157 insertions(+), 1 deletions(-) Hi, I

Re: wineps: clipping bug; clipping performance

2008-12-16 Thread Kai Blin
On Tuesday 16 December 2008 11:42:55 Wolfgang Walter wrote: I have not received any comment yet. That's probably because not too many people know much about this. Detlef Riekenberg is probably the person who should comment on this, I've CCed him. Cheers, Kai -- Kai Blin WorldForge developer

Re: wineps: clipping bug; clipping performance

2008-12-16 Thread Wolfgang Walter
Am Dienstag, 16. Dezember 2008 11:51 schrieb Kai Blin: On Tuesday 16 December 2008 11:42:55 Wolfgang Walter wrote: I have not received any comment yet. That's probably because not too many people know much about this. Detlef Riekenberg is probably the person who should comment on this, I've

Re: Unused vtables and debug channels

2008-12-16 Thread Christian Costa
Hi Andrew, BTW, if the vtable are removed, there may be some unused functions. Will they be removed as well ? Bye, Christian Message du 16/12/08 11:11 De : Maarten Lankhorst A : Andrew Talbot Copie à : wine-devel@winehq.org Objet : Re: Unused vtables and debug channels Hi Andrew,

Re: [1/5] jscript: Implement the String.anchor() method (resend).

2008-12-16 Thread Jacek Caban
Hi Andrew, Andrew Nguyen wrote: This revision incorporates Jacek Caban's suggestions. --- dlls/jscript/string.c | 55 +++- dlls/jscript/tests/api.js | 17 ++ 2 files changed, 70 insertions(+), 2 deletions(-) +if(ret) {

wineps: clipping bug; clipping performance

2008-12-16 Thread Wolfgang Walter
Hello, as I wrote clipping in wineps.drv has a bug. Wine does only consider the clipping region and not the meta region. It should combine them. This is a bug which hurts us with a real windows application. I sent a patch which which corrects this. My patch also addressed a general

Re: Unused vtables and debug channels

2008-12-16 Thread Maarten Lankhorst
Hi Andrew, Andrew Talbot schreef: It appears that the following vtables and Wine debug channels are not being used, so I am considering removing them. Please let me know, therefore, if you have plans for any of them and want them kept. Vtables: MemInputPin_Vtbl

Use show instead of glyphshow: gylphshow very slow on kyocera

2008-12-16 Thread Wolfgang Walter
Hello, wineps.drv uses the postscript operator glyphshow to print glyphs. This operator is very slow on all Kyocera postscript printers. To get an idea: its generally only 1/6 to 1/10 of the performance compared to the same document printed with the windows xp postscript driver (which does not

Re: jscript: api.js, added test routines for Math functions

2008-12-16 Thread Jacek Caban
Hi Patrick, First of all, tests must pass on Wine and Windows. Your test won't pass on any of them! When you have a test that passes on Windows, please send one function implementation and tests in one patch. Patrick Rudolph wrote: From c43e52c3446fb846a760002f0222f697075fad1b Mon Sep 17

Re: AppDB rating definitions, was: Re: Canonical and wine

2008-12-16 Thread M.Kiesel
On Mon, 15 Dec 2008, Austin English wrote: What about clarifying the wording on http://appdb.winehq.org/help/?sTopic=maintainer_ratings ? My suggestion for Platinum: Application installs and runs flawlessly completely/at highest settings 'out of the box'. No changes required in winecfg.

Re: Another machine passing tests

2008-12-16 Thread Austin English
On Mon, Dec 15, 2008 at 6:38 PM, Alasdair Sinclair alasda...@dsl.pipex.com wrote: Austin English wrote: On Mon, Dec 15, 2008 at 2:04 PM, Zachary Goldberg zg...@bluesata.com wrote: All, It seems we have another machine which passes all tests on Wine

fixing all the not-properly-displaying characters that have suddenly appeared in the appdb

2008-12-16 Thread Rosanne DiMesio
Since the change to the new design, AppDB entries have been displaying either a ? (Firefox, Konqueror, Opera) or a blank rectangle (IE in Windows) in place of a variety of special characters, including anything with an umlaut (bug 16514). I've played around with it a bit, and the entries can be

Re: MSI: fix some NULL checking in MSI_RecordGetStringA

2008-12-16 Thread Aric Stewart
Ok, Though it mirrors what is happening over in MSI_RecordGetStringW so i assumed it was just a few check that had been accidentally forgotten. -aric James Hawkins wrote: On Tue, Dec 16, 2008 at 9:11 AM, Aric Stewart a...@codeweavers.com wrote: --- dlls/msi/record.c |7 --- 1

Re: MSI: fix some NULL checking in MSI_RecordGetStringA

2008-12-16 Thread James Hawkins
On Tue, Dec 16, 2008 at 9:11 AM, Aric Stewart a...@codeweavers.com wrote: --- dlls/msi/record.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) Can you add tests for this please? Thanks, James Hawkins

Re: MSI: fix some NULL checking in MSI_RecordGetStringA

2008-12-16 Thread James Hawkins
On Tue, Dec 16, 2008 at 11:59 AM, Aric Stewart a...@codeweavers.com wrote: Ok, Though it mirrors what is happening over in MSI_RecordGetStringW so i assumed it was just a few check that had been accidentally forgotten. Yea, I'm sure it's right, but it's nice to verify those changes with tests

Re: Unused vtables and debug channels

2008-12-16 Thread Andrew Talbot
Christian Costa wrote: Hi Andrew, BTW, if the vtable are removed, there may be some unused functions. Will they be removed as well ? Bye, Christian Hi Christian, Because I was mindful not to remove such things lightly, that is why I sought feedback from the community, and I shall

Re: Another machine passing tests

2008-12-16 Thread Alasdair Sinclair
Austin English wrote: On Mon, Dec 15, 2008 at 6:38 PM, Alasdair Sinclair alasda...@dsl.pipex.com wrote: Austin English wrote: On Mon, Dec 15, 2008 at 2:04 PM, Zachary Goldberg zg...@bluesata.com wrote: All, It seems we have another machine which passes all tests on Wine

Better user feedback and better user experience (idea)

2008-12-16 Thread Sander Devrieze
Hi, One of the reasons why Linux distributions do not want to include Wine by default is because compatibility issues may result a bad impression of the quality of the OS. Users think Linux sucks because their Windows application does not run (as good) under Wine as it does under Windows.

Re: Wine t-shirts?

2008-12-16 Thread Ismael Barros²
On Thu, Dec 4, 2008 at 5:47 AM, Steven Edwards winehac...@gmail.com wrote: Heh sorry for all the spam, it would help if I used gmail for everything, in the original thread Jer already gave blanket permission for Wine to that logo: fromJeremy White jwh...@winehq.org to Dan Kegel

Re: Wine t-shirts?

2008-12-16 Thread Andrew Fenn
On Tue, Dec 16, 2008 at 11:25 PM, Ismael Barros² razielm...@gmail.com wrote: Which model and T-shirt do you like better? Any suggestion to improve them? Maybe in a future we can sell more than one Wine design, but right now we'd rather offer only one, to avoid logistic problems. Shouldn't you

Re: Wine t-shirts?

2008-12-16 Thread Jeff Zaroyko
On Wed, Dec 17, 2008 at 10:58 AM, Andrew Fenn andrewf...@gmail.com wrote: On Tue, Dec 16, 2008 at 11:25 PM, Ismael Barros² razielm...@gmail.com wrote: Which model and T-shirt do you like better? Any suggestion to improve them? Maybe in a future we can sell more than one Wine design, but right

Re: Wine t-shirts?

2008-12-16 Thread Ismael Barros²
On Wed, Dec 17, 2008 at 12:58 AM, Andrew Fenn andrewf...@gmail.com wrote: Shouldn't you take off the hq part of the name? Indeed, I forgot to tell the arts team that. I don't know how exactly you could do what I am about to suggest, but is there a way to make the graphics tell a little more

Re: server: implement move/rename change notifications and support for multiple change notification in one reply

2008-12-16 Thread Dan Kegel
On Tue, Dec 16, 2008 at 5:21 PM, Michael Pujos pujos.mich...@laposte.net wrote: I don't see an attachment to http://www.winehq.org/pipermail/wine-patches/2008-December/066224.html or rather, there's only a zero-length one. I just attached (In thunderbird) the file outputted by git

Re: server: implement move/rename change notifications and support for multiple change notification in one reply

2008-12-16 Thread Dan Kegel
On Tue, Dec 16, 2008 at 5:40 PM, Michael Pujos pujos.mich...@laposte.net wrote: The protocol is slightly changed between read_changes_apc() in ntdll and the server to support return of multiple FILE_NOTIFY_INFORMATION structs at a time. This is transparent to win32 programs (is that what you

Re: Better user feedback and better user experience (idea)

2008-12-16 Thread Zachary Goldberg
2008/12/16 Sander Devrieze s.devri...@linux.be: Hi, One of the reasons why Linux distributions do not want to include Wine by default is because compatibility issues may result a bad impression of the quality of the OS. Users think Linux sucks because their Windows application does not run

Re: Better user feedback and better user experience (idea)

2008-12-16 Thread Scott Ritchie
Sander Devrieze wrote: Hi, One of the reasons why Linux distributions do not want to include Wine by default is because compatibility issues may result a bad impression of the quality of the OS. Users think Linux sucks because their Windows application does not run (as good) under Wine as

Re: gdi32/winex11.drv: Change all gdi/opengl declarations to use __cdecl

2008-12-16 Thread Dmitry Timoshkov
Maarten Lankhorst m.b.lankho...@gmail.com wrote: Needed to get +relay working in wine64 You should have used CDECL instead of __cdecl, have a look how it's done in msvcrt.dll. -- Dmitry.