Re: Are OpenBSD bugs worth filing?

2008-12-27 Thread Kai Blin
On Friday 26 December 2008 21:16:58 David Gerard wrote: Some of us on wine-users are trying to get Wine to install on OpenBSD. First, of course, we need to get it to compile on OpenBSD ... Are bugs on this platform considered valid reportable bugs? I couldn't find any OpenBSD bugs on a quick

Re: winecfg: Add dll override on return key press in combobox [resend]

2008-12-27 Thread Andre Wisplinghoff
2008/12/27 Dmitry Timoshkov dmi...@codeweavers.com: Andre Wisplinghoff andre.wisplingh...@gmail.com wrote: +INT_PTR CALLBACK +comboedit_wndproc (HWND hEdit, UINT uMsg, WPARAM wParam, LPARAM lParam) INT_PTR is wrong return value type for a window proc. so it should be HRESULT? INT_PTR is

Re: winecfg: Add dll override on return key press in combobox [resend]

2008-12-27 Thread Reece Dunn
2008/12/27 Andre Wisplinghoff andre.wisplingh...@gmail.com: 2008/12/27 Dmitry Timoshkov dmi...@codeweavers.com: Andre Wisplinghoff andre.wisplingh...@gmail.com wrote: +INT_PTR CALLBACK +comboedit_wndproc (HWND hEdit, UINT uMsg, WPARAM wParam, LPARAM lParam) INT_PTR is wrong return value

Re: winecfg: Add dll override on return key press in combobox [resend]

2008-12-27 Thread Dmitry Timoshkov
Andre Wisplinghoff andre.wisplingh...@gmail.com wrote: +INT_PTR CALLBACK +comboedit_wndproc (HWND hEdit, UINT uMsg, WPARAM wParam, LPARAM lParam) INT_PTR is wrong return value type for a window proc. so it should be HRESULT? No. INT_PTR is used for other window procs in

Re: [2/2] mshtml: Add VT_INT support in IHTMLElementCollection_item

2008-12-27 Thread Jacek Caban
Hi Konstantin, Konstantin Kondratyuk wrote: Hi, Jacek! On Friday 19 December 2008 18:04:45 Jacek Caban wrote: You're duplicating the code that handles VT_I4 case. Please avoid it. Do you think, this code will be better? And can I truncate VT_I4 from trace? Yes, it looks better,

Re: [PATCH 5/6] dinput: Fix usage of HeapReAlloc.

2008-12-27 Thread Alexandre Julliard
Vitaliy Margolen wine-patc...@kievinfo.com writes: +if (!have_joydevs) +joydevs = HeapAlloc(GetProcessHeap(), 0, sizeof(struct JoyDev)); +else +joydevs = HeapReAlloc(GetProcessHeap(), 0, joydevs, (1 + have_joydevs) * sizeof(struct JoyDev)); + +

RE: Simplify dlls/comctl32/nativefont.c

2008-12-27 Thread ricardo filipe
are you sure windows doesn't call those functions with those parameters? you have to check that before sending patches like these ... Date: Sat, 27 Dec 2008 08:57:44 +0100 From: ger...@pfeifer.com To: wine-patc...@winehq.org Subject: Simplify

Re: Wine build failed

2008-12-27 Thread Stefan Leichter
Am Tuesday 23 December 2008 20:48 schrieb Austin English: On Tue, Dec 23, 2008 at 3:43 AM, Stefan Leichter sle85...@gmx.de wrote: make[2]: Leaving directory `/usr/src/wine/wine-build/dlls/gdi32' make[1]: *** [gdi32] Fehler 2 make[1]: Leaving directory `/usr/src/wine/wine-build/dlls' make:

Re: Simplify dlls/comctl32/nativefont.c

2008-12-27 Thread Nikolay Sivov
ricardo filipe wrote: are you sure windows doesn't call those functions with those parameters? you have to check that before sending patches like these ... Date: Sat, 27 Dec 2008 08:57:44 +0100 From: ger...@pfeifer.com To:

Minimal patches to try win64?

2008-12-27 Thread Dan Kegel
Out of curiosity, I finally bit the bullet, installed 64 bit Ubuntu 8.10, updated http://wiki.winehq.org/Wine64 to show how to build gcc, and built wine with win64 support enabled. It built successfully on the first try, but starting any conformance test or win64 app fails with wineserver:

Re: [RFC] wined3d: Avoid triggering OPENGL errors when setting point size

2008-12-27 Thread Vincent Pelletier
Le Friday 26 December 2008 22:35:18 Vincent Pelletier, vous avez écrit : As I guess IWineD3DDeviceImpl_CreateTexture should then return a failure code, I patched it and made the test give up if texture allocation failed. (patch attached) Updated to test previous return code, instead of

260 tests passing on win64!

2008-12-27 Thread Dan Kegel
I updated http://wiki.winehq.org/Wine64 with easy instructions (thanks, Maarten!) for how to build wine's 64 bit support and try 64 bit pacman (which works!). And then I ran make -k test. Surprisingly, I got 260 passing tests according to find . -name '*.ok' | wc and only 128 failed tests

RE: Simplify dlls/comctl32/nativefont.c

2008-12-27 Thread Gerald Pfeifer
On Sat, 27 Dec 2008, ricardo filipe wrote: are you sure windows doesn't call those functions with those parameters? you have to check that before sending patches like these ... Yes, I am. Looking at the patch... static LRESULT -NATIVEFONT_Create (HWND hwnd, WPARAM wParam, LPARAM lParam)

Status of dxdiagn?

2008-12-27 Thread Dan Kegel
Hi Markus, what's the status of dxdiagn these days? I see a number of games that say they need a native copy: http://www.google.com/search?q=dxdiagn+site%3Aappdb.winehq.org Do you know what needs doing before we can get native dxdiag working, http://bugs.winehq.org/show_bug.cgi?id=1429 ? Also,

Re: Combining Fuse and Wine - What's the best way?

2008-12-27 Thread Richard Stitz
So would the best way to do this be to have a separate process for the Wine program that loads the DLL, and then have the Fuse process communicate over pipes or some other IPC method?

Implementing dxdiag as student project?

2008-12-27 Thread Dan Kegel
Hi folks, it seems odd to me that Wine doesn't have a tool like dxdiag yet. We often have people complain that graphics aren't working, and we have to ask them to do things like run glxgears as diagnostics. Would it make sense to implement our own dxdiag.exe program? This seems like it might be