Am Samstag, den 10.01.2009, 23:10 + schrieb Rob Shearman:
> >
> > +int is_var_declptr(const var_t *v)
> > +{
> > + return is_declptr(v->type);
> > +}
> > +
> Again, this function doesn't seem to improve readability of the code.
> I would just move the checking of the type of v into cant_be_nul
2009/1/10 Michael Karcher :
> This matches midl behaviour. In
>
> void test1([out,size_is(x)] char str[], [in] int x);
> void test2([size_is(x), out] char* str, [in] int x);
>
> the parameter to test1 is not NULL-checked, but the one to test2 is.
> ---
> tools/widl/client.c|2 +-
> tools
Am Samstag, den 10.01.2009, 22:41 + schrieb Rob Shearman:
> 2009/1/10 Michael Karcher :
> > If we take MIDL 6.00.0366 as reference, the following method type is
> > legal:
> >
> >void frobnicate([size_is(x),in,out] int * bar1,
> >[size_is(*bar1),out] int * bar2,
2009/1/10 Michael Karcher :
> ---
> tools/widl/header.c | 24
> tools/widl/header.h |2 ++
> tools/widl/typegen.c | 24
> tools/widl/typegen.h |1 -
> 4 files changed, 26 insertions(+), 25 deletions(-)
Although there are a lot of hel
Am Samstag, den 10.01.2009, 22:32 + schrieb Rob Shearman:
> 2009/1/10 Michael Karcher :
> > get_deref_type yields the type of array elements for arrays or the
> > pointed-to type of pointers. Most important, it works on anything
> > is_declptr returns true for.
> I don't believe that this type
2009/1/10 Michael Karcher :
> typdef [wire_marshal(wirefoo)] foo * pfoo;
> made widl incorrectly set the RPC_FC_P_DEREF bit for pfoo. But this
> declares a user-marshalled pointer, so the RPC runtime must not dereference
> it before passing it on to the UserFoo functions.
> ---
> tools/widl/header
2009/1/10 Michael Karcher :
> If we take MIDL 6.00.0366 as reference, the following method type is
> legal:
>
>void frobnicate([size_is(x),in,out] int * bar1,
>[size_is(*bar1),out] int * bar2,
>[in] int x);
>
> Without this patch, size_is(*bar
Am Samstag, den 10.01.2009, 22:21 + schrieb Reece Dunn:
> 2009/1/10 Michael Karcher :
> > Output NULL pointers into proxy table and STUB_FORWARDING_FUNCTION into
> > stub tables if a local function has no call_as function associated, just
> > as MIDL does.
> Shouldn't these go to wine-patches?
2009/1/10 Michael Karcher :
> get_deref_type yields the type of array elements for arrays or the
> pointed-to type of pointers. Most important, it works on anything
> is_declptr returns true for.
I don't believe that this type of helper function improves the
readability of the code, given that it
2009/1/10 Michael Karcher :
> ---
> tools/widl/proxy.c |5 +
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/tools/widl/proxy.c b/tools/widl/proxy.c
> index 4e69190..bb16b72 100644
> --- a/tools/widl/proxy.c
> +++ b/tools/widl/proxy.c
> @@ -182,6 +182,11 @@ int cant_be_
2009/1/10 Michael Karcher :
> ---
> tools/widl/typegen.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c
> index 2b0e414..7dfa0b2 100644
> --- a/tools/widl/typegen.c
> +++ b/tools/widl/typegen.c
> @@ -3046,7 +3046,7 @@ stat
2009/1/10 Michael Karcher :
> Output NULL pointers into proxy table and STUB_FORWARDING_FUNCTION into
> stub tables if a local function has no call_as function associated, just
> as MIDL does.
Shouldn't these go to wine-patches?
- Reece
2009/1/10 Michael Karcher :
> Output NULL pointers into proxy table and STUB_FORWARDING_FUNCTION into
> stub tables if a local function has no call_as function associated, just
> as MIDL does.
Looks fine to me.
--
Rob Shearman
---
tools/widl/proxy.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/tools/widl/proxy.c b/tools/widl/proxy.c
index 4e69190..bb16b72 100644
--- a/tools/widl/proxy.c
+++ b/tools/widl/proxy.c
@@ -182,6 +182,11 @@ int cant_be_null(const var_t *v)
if (is_ptr(type))
---
tools/widl/typegen.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c
index 2b0e414..7dfa0b2 100644
--- a/tools/widl/typegen.c
+++ b/tools/widl/typegen.c
@@ -3046,7 +3046,7 @@ static void write_parameter_conf_or_var_exprs(FIL
get_deref_type yields the type of array elements for arrays or the
pointed-to type of pointers. Most important, it works on anything
is_declptr returns true for.
---
tools/widl/header.h |1 +
tools/widl/typegen.c| 15 +++
tools/widl/write_msft.c |3 +--
3 files change
If we take MIDL 6.00.0366 as reference, the following method type is
legal:
void frobnicate([size_is(x),in,out] int * bar1,
[size_is(*bar1),out] int * bar2,
[in] int x);
Without this patch, size_is(*bar1) would be rejected.
---
tools/widl/e
---
tools/widl/header.c | 24
tools/widl/header.h |2 ++
tools/widl/typegen.c | 24
tools/widl/typegen.h |1 -
4 files changed, 26 insertions(+), 25 deletions(-)
diff --git a/tools/widl/header.c b/tools/widl/header.c
index a3d2250..d
This matches midl behaviour. In
void test1([out,size_is(x)] char str[], [in] int x);
void test2([size_is(x), out] char* str, [in] int x);
the parameter to test1 is not NULL-checked, but the one to test2 is.
---
tools/widl/client.c|2 +-
tools/widl/proxy.c | 15 ++-
typdef [wire_marshal(wirefoo)] foo * pfoo;
made widl incorrectly set the RPC_FC_P_DEREF bit for pfoo. But this
declares a user-marshalled pointer, so the RPC runtime must not dereference
it before passing it on to the UserFoo functions.
---
tools/widl/header.h |3 ++-
1 files changed, 2 insert
Output NULL pointers into proxy table and STUB_FORWARDING_FUNCTION into
stub tables if a local function has no call_as function associated, just
as MIDL does.
try 2: Fix various mistakes (one of them found by Rob Shearman)
try 3: Rebased to current git
---
tools/widl/proxy.c | 51 ++
On Fri, Jan 09, 2009 at 07:39:33PM +0100, Francois Gouget wrote:
>
>
> And as far as I know, in the 10 years since LWN started, there has been
> exactly one LWN article about Wine. For the 1.0 release, in the
> Development section.
>
> Sure they carry the Wine announcements, and occasionally m
"Jeff Zaroyko" writes:
> From 5f8813a25338ce88a150dac09e5811dd1246383f Mon Sep 17 00:00:00 2001
> From: Jeff Zaroyko
> Date: Sat, 10 Jan 2009 20:16:44 +1100
> Subject: advapi32: fix failing tests for Windows 2007
I don't think it makes sense to fix the tests for a beta version. We
need to wait
"Austin English" writes:
> Alexandre fixed most of it in
> 13df062d3686a9b1961f0877aa8aaccd1fdc7332, but missed these. Tested on
> Linux with PPC/i386.
Please don't add extra ifdefs to work around missing implementations.
FormatMessage needs to be implemented on other platforms, and the
warning
On Sat, Jan 10, 2009 at 10:23:49AM +0100, Ambroz Bizjak wrote:
> I don't think this is true. When the shell forks to create a child, it doesn't
> have to give the child the same standard file descriptors - rather it creates
> pipes, and it passes stdin to the child by reading its own stdin than wr
On Wed, Jan 07, 2009 at 07:24:07PM +1100, Paul TBBle Hampson wrote:
> Resend, removing C++-style comments
> --
> Paul "TBBle" Hampson, paul.hamp...@pobox.com
> Shorter .sig for a more eco-friendly paperless office.
Any comments on this patch series? The only thing I've had for this
resend of the
On Sat, Jan 10, 2009 at 12:05 AM, David Laight wrote:
> On Fri, Jan 09, 2009 at 06:39:27PM +, Luke Kenneth Casson Leighton wrote:
>>
>> further up the strace files, i'm looking at the biggest offender and
>> it looks like it's reading files one byte at a time.
>
> Certainly a normal unix shell
On Saturday 10 January 2009 01:05:07 David Laight wrote:
> On Fri, Jan 09, 2009 at 06:39:27PM +, Luke Kenneth Casson Leighton
wrote:
> > further up the strace files, i'm looking at the biggest offender and
> > it looks like it's reading files one byte at a time.
>
> Certainly a normal unix she
28 matches
Mail list logo
