Re: [PATCH] cryptui: check NULL ptr differently (Coverity)

2009-02-04 Thread Paul Vriens
Marcus Meissner wrote: > Hi, > > CID 829, cryptui fails to handle data being NULL > correctly after the if (data) branch. > > Since it is a allocation error, just return on failure. > > Ciao, Marcus > --- > dlls/cryptui/main.c | 35 +-- > 1 files changed, 17 in

Re: Stub DDE interface for Progman.exe

2009-02-04 Thread Dmitry Timoshkov
"Jeremiah Flerchinger" wrote: >> > Stubs basic DDE interface of Progman.exe. Similar to Progman stub in >> > shell32.dll. Both will need to be extended and a 3rd progman interface >> > will need to be added in user32. >> >> Progman DDE interface should be implemented by shell32.dll, nowhere else

Re: New Wine Gecko package

2009-02-04 Thread Scott Ritchie
Jacek Caban wrote: > Hi all, > > The last release of Wine Gecko caused a few regressions. Thanks to > Alexandre, we've found the reason. The bad news is that the fix requires > a new package. I've uploaded RC build to: > > http://gerwazy.lo3.wroc.pl/~jcaban/wine/wine_gecko-0.9.1.cab > > I'd appr

Re: ideas and questions for implementation of MessageMode in Named Pipes

2009-02-04 Thread Juan Lang
Hi Luke, > how about: ripping out the use of unix-pipes altogether, and replacing > them with tdb (trivial database) in a mmap'd file? the nice thing > about tdb is that it's LGPL'd. the messages could be saved and > transferred via shared memory; tdb is multi-readable / > multi-writeable, and i

New Wine Gecko package

2009-02-04 Thread Jacek Caban
Hi all, The last release of Wine Gecko caused a few regressions. Thanks to Alexandre, we've found the reason. The bad news is that the fix requires a new package. I've uploaded RC build to: http://gerwazy.lo3.wroc.pl/~jcaban/wine/wine_gecko-0.9.1.cab I'd appreciate if people that observe the

Re: Quick and dirty testcases for MS-DOS API?

2009-02-04 Thread Dan Kegel
On Wed, Feb 4, 2009 at 3:24 PM, Detlef Riekenberg wrote: > On Do, 2009-01-29 at 14:30 -0800, Dan Kegel wrote: >> but that requires the Watcom C compiler, and >> "apt-cache search watcom" still comes up empty > > There is a package with an installer: > > http://www.openwatcom.org/ftp/open-watcom-c-

Re: Quick and dirty testcases for MS-DOS API?

2009-02-04 Thread Detlef Riekenberg
On Do, 2009-01-29 at 14:30 -0800, Dan Kegel wrote: > but that requires the Watcom C compiler, and > "apt-cache search watcom" still comes up empty There is a package with an installer: http://www.openwatcom.org/ftp/open-watcom-c-linux-1.8RC3 THe release link in the near feature might be: http://

Re: Fixing AppDB once and for all

2009-02-04 Thread nicholas . g . lawrence
How about determining how well an individual app is represented by the test suite? The better the test suite replicates the behaviour of the app, the more likely wine is to support the app. nick *** WARNING: This e-mail (includ

Re: [PATCH] mshtml: fixed second buffer argument to MultiByteToWideChar

2009-02-04 Thread Marcus Meissner
On Wed, Feb 04, 2009 at 02:15:04PM -0600, Austin English wrote: > On Wed, Feb 4, 2009 at 2:11 PM, Marcus Meissner wrote: > > Hi, > > > > Targetbuffer length must not be -1. > > > > Ciao, Marcus > > --- > > dlls/mshtml/editor.c |2 +- > > dlls/mshtml/navigate.c |2 +- > > 2 files changed

Re: [PATCH] mshtml: fixed second buffer argument to MultiByteToWideChar

2009-02-04 Thread Austin English
On Wed, Feb 4, 2009 at 2:11 PM, Marcus Meissner wrote: > Hi, > > Targetbuffer length must not be -1. > > Ciao, Marcus > --- > dlls/mshtml/editor.c |2 +- > dlls/mshtml/navigate.c |2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/mshtml/editor.c b/dlls/mshtm

Re: mshtml: Implement IHTMLStyle_put_backgroundColor

2009-02-04 Thread Alistair Leslie-Hughes
Hi Ricardo, > hi alistair, > you say it implements the put method but the patch has only the get > method... typo? > Thanks for picking this up. It's a typo, Ill resend shortly. Best Regards Alistair Leslie-Hughes

Re: [PATCH] mshtml: call install_cab_file() with name directly on non-Wine

2009-02-04 Thread Steven Edwards
On Wed, Feb 4, 2009 at 1:11 PM, Marcus Meissner wrote: > Hi, > > A ReactOS developer told me that if the wine_get_dos_file_name() does > not return a function, we should just pass in the current filename > to install_cab_file. > > So I coded it, but the non-UNIX path is untested. > > Wonder why

Re: bugzilla stuck?

2009-02-04 Thread Austin English
On Wed, Feb 4, 2009 at 11:36 AM, Dan Kegel wrote: > It seems hung to me at the moment... > > > Back up now. -- -Austin

Re: bugzilla stuck?

2009-02-04 Thread Jeremy Newman
Bugzilla is freaking out quite a bit lately. I think this is due to how much busier Bugzilla and the AppDB has become. It will usually clear up on it's own, but it takes 5 to 10 minutes. It is pretty clear that the current box can no longer handle the load. Dan Kegel wrote: > It seems hung to m

bugzilla stuck?

2009-02-04 Thread Dan Kegel
It seems hung to me at the moment...

Re: X11DRV_XRandR_Cleanup() is not used

2009-02-04 Thread Alexandre Julliard
Francois Gouget writes: > So my question is: should this function be removed? Or should I simply > send a patch calling it from x11drv_main.c:process_detach(), enclosed > with the appropriate SONAME_LIBXRANDR? You can remove it, it doesn't do anything useful. -- Alexandre Julliard julli...@w

IPinImpl_QueryInternalConnections() is unused

2009-02-04 Thread Francois Gouget
dlls/qcap/pin.c defines an IPinImpl_QueryInternalConnections() function but it is not actually used anywhere. Is there any reason to keep it? It sort of looks like IPin is a virtual class and that IPin::QueryInternalConnections() is going to be implemented in its descendents like VfwPin as is

X11DRV_XRandR_Cleanup() is not used

2009-02-04 Thread Francois Gouget
dlls/x11drv/xrandr.c defines a X11DRV_XRandR_Cleanup() function but it is not actually used anywhere. If I remember correctly past wine-devel emails, restoring the right XRandR mode when an application exits can be tricky (especially in case of a crash). So maybe this is why the function is no

Re: Fixing AppDB once and for all

2009-02-04 Thread Zachary Goldberg
If you have interest in the future of the AppDB please make sure your ideas are in or referenced by the agenda on the wiki. I think things will go much smoother if we discuss line items from the agenda one by one rather than a random chaos. http://wiki.winehq.org/AppDBUpgrades

Re: [2/3] Add initial "write text" support for VGA graphic modes. Requires mode info unify patch

2009-02-04 Thread Alexandre Julliard
Jeremiah Flerchinger writes: > else > { > - FIXME("Write %c at (%i,%i) - not yet supported in graphic modes.\n", > (char)ascii, x, y); > + dat = vga_fb_window_data; > + /* get attribute values */ > + fgColor = attr & 0x0F; > + bgColor = (attr & 0x70)>>4; >

Re: comctl32: Save and restore colours when adding masked images

2009-02-04 Thread Peter Urbanec
Hans Leidekker wrote: > Some lines in this patch were wrapped, please attach it like you do in > your other mails. Hans, thanks for alerting me to the problem. I resent the patch as an attachment - hopefully all is well now. Best regards, Peter Urbanec

Re: comctl32: Save and restore colours when adding masked images

2009-02-04 Thread Hans Leidekker
Hi Peter, > This patch will save and restore the colours when adding a masked image > to ImageList. Some lines in this patch were wrapped, please attach it like you do in your other mails. -Hans

Re: mshtml: Implement IHTMLStyle_put_backgroundColor

2009-02-04 Thread ricardo_barbano
hi alistair, you say it implements the put method but the patch has only the get method... typo? regards, ricardo -- From: "Alistair Leslie-Hughes" Sent: Wednesday, February 04, 2009 5:02 AM To: Subject: mshtml: Implement IHTMLStyle_put_backgroun

Need help for D3DXComputeSphereBounding

2009-02-04 Thread paulo lesgaz
Hello, I am trying to implement D3DXComputerSphereBounding. The attached test cases success with a native d3dx9 but fail with a native d3dx8. Can anyone could explain why? Thanks in advance 0002-Try-of-implementation-of-D3DXComputeSphereBounding.patch Description: Binary data

Re: Fixing AppDB once and for all

2009-02-04 Thread IneedAname
On Tue, 3 Feb 2009 23:02:12 +0100 Alexander Nicolaysen Sørnes wrote: > What if we add a small questionnaire which will then pick the approprite > Gold/Silver ... rating? That what I like to see.

Re: kernel32/tests: Add a CreateMutex test. (Win9X todo)

2009-02-04 Thread Florian Tobias Schandinat
Dmitry Timoshkov schrieb: > "Florian Tobias Schandinat" wrote: > >> this test shows a difference between Win9X and NT. (tested on Win98SE >> and WinXP) Some apps expect the Win9X behaviour to work. I don't know >> what's the right way to fix it. Any advice or patch is welcome. > > How do that ap

Re: winedos: Improve PIT emulation.

2009-02-04 Thread Florian Tobias Schandinat
Alexandre Julliard schrieb: > Florian Tobias Schandinat writes: > >> +/* Convert: time counter -> PIT counter >> + * GetSystemTimeAsFileTime:1000 Hz >> + * PIT frequency: 1193182 Hz */ >> +val = (DWORD)(val - delta*1193182./1000.) % (maxval + 1); > > You

Re: ideas and questions for implementation of MessageMode in Named Pipes

2009-02-04 Thread Luke Kenneth Casson Leighton
mwhaaahahah, i just came up with a _horrible_ idea :) how about: ripping out the use of unix-pipes altogether, and replacing them with tdb (trivial database) in a mmap'd file? the nice thing about tdb is that it's LGPL'd. the messages could be saved and transferred via shared memory; tdb is mult