ntdll: Avoid Potential Infinite Loop

2009-02-12 Thread Paul Bryan Roberts
Hi, I expect this patch will be accepted due to precedent - a few months ago I submitted the same patch for the same problem in a different routine in a different compilation unit of ntdll. Yes, I guess the infinite loop does not occur in practice (someone would have noticed) and I guess it

Re: Wine64 : Trying to load PE image for unsupported architecture (I386)

2009-02-12 Thread Joel Holdsworth
On Wed, 2009-02-11 at 23:34 +0100, Alexandre Julliard wrote: Not really, you'll of course still need to build a full 32-bit version of Wine, the 64-bit Wine will never be able to run 32-bit apps. What needs to be improved is that the 64-bit loader should be able to forward automatically to

Re: Wine64 : Trying to load PE image for unsupported architecture (I386)

2009-02-12 Thread Alexandre Julliard
Erik de Castro Lopo mle+...@mega-nerd.com writes: So there will need to be two executables wine and wine64 and if either is started with the wrong kind of binary, it will need to run the binary with the other version? Would it not be possible to have a single light weight binary that has

Re: Wine64 : Trying to load PE image for unsupported architecture (I386)

2009-02-12 Thread Ben Klein
2009/2/12 Joel Holdsworth j...@airwebreathe.org.uk: On Wed, 2009-02-11 at 23:34 +0100, Alexandre Julliard wrote: Not really, you'll of course still need to build a full 32-bit version of Wine, the 64-bit Wine will never be able to run 32-bit apps. What needs to be improved is that the 64-bit

Re: Download page requires too much scrolling...

2009-02-12 Thread Scott Ritchie
Dan Kegel wrote: While I was generating screenshots for my presentation, I noticed that http://www.winehq.org/download/ has too much clutter at the top. I don't mind the Codeweavers ad, but it's not good that users have to scroll down to see the useful part of the page... Good point,

Re: gdi32/tests: Use the ANSI text metrics so the tests work on win9x.

2009-02-12 Thread Paul Vriens
Huw Davies wrote: --- dlls/gdi32/tests/font.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) Looks a lot like:

Re: gdi32/tests: Use the ANSI text metrics so the tests work on win9x.

2009-02-12 Thread Huw Davies
On Thu, Feb 12, 2009 at 01:40:54PM +0100, Paul Vriens wrote: Huw Davies wrote: --- dlls/gdi32/tests/font.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) Looks a lot like:

Fwd: Need Your Help about dll on linux

2009-02-12 Thread Jigar Joshi
-- Forwarded message -- From: Jigar Joshi jiga...@gmail.com Date: Mon, Feb 9, 2009 at 6:53 PM Subject: Need Your Help about dll on linux To: wine-devel@winehq.org Respected sir, i refered your post at http://www.winehq.org/pipermail/wine-devel/2007-April/055855.html i want to

Re: Is the test.winehq.org front page too pessimistic?

2009-02-12 Thread Paul Vriens
John Klehm wrote: On Wed, Feb 11, 2009 at 3:58 PM, Juan Lang juan.l...@gmail.com wrote: My own feeling is that there are far fewer failing tests now than there used to be, and I'd sure like to see that reflected somewhere at a quick glance. Thoughts? Maybe a test.winehq.org/trends page

Re: ntdll: Avoid Potential Infinite Loop

2009-02-12 Thread John Klehm
On Thu, Feb 12, 2009 at 2:30 AM, Paul Bryan Roberts pbronline-w...@yahoo.co.uk wrote: Something like We think your product is superlative but someone may wonder if your code not finding this bug in our code might be a bug in your code. Well I don't think coverity claims 100% of bugs will

Re: mshtml: Implement IHTMLStyle_put_textDecorationUnderline (resend)

2009-02-12 Thread Jacek Caban
Alistair Leslie-Hughes wrote: Hi, Changelog: mshtml: Implement IHTMLStyle_put_textDecorationUnderline + +return set_style_attr(This, STYLEID_TEXT_DECORATION, v == VARIANT_TRUE ? valUnderline : emptyW, 0); You shouldn't compare v to VARIANT_TRUE. The correct way to deal with bool

Re: Is the test.winehq.org front page too pessimistic?

2009-02-12 Thread John Klehm
On Thu, Feb 12, 2009 at 8:27 AM, Paul Vriens paul.vriens.w...@gmail.com wrote: I do it for my own boxes (see attachment). The spikes (up and down) are mainly when I didn't run the tests on all my boxes. But you can see the overall trend. Nice. :) What are you using to generate that? --John

Re: Is the test.winehq.org front page too pessimistic?

2009-02-12 Thread Paul Vriens
John Klehm wrote: On Thu, Feb 12, 2009 at 8:27 AM, Paul Vriens paul.vriens.w...@gmail.com wrote: I do it for my own boxes (see attachment). The spikes (up and down) are mainly when I didn't run the tests on all my boxes. But you can see the overall trend. Nice. :) What are you using to

Re: mshtml: Implement IHTMLStyle get/put minHeight (resend)

2009-02-12 Thread Jacek Caban
Hi Alistair, Alistair Leslie-Hughes wrote: Hi, Changelog: mshtml: Implement IHTMLStyle get/put minHeight [get|set]_nsstyle_attr_var functions were introduces to avoid the code duplication like you do. You should use them (and probably implement VT_I4 handling in set_nsstyle_attr_var).

Re: wintrust(2/3): Remove a couple tests that fail on a variety of systems (try 2)

2009-02-12 Thread Paul Vriens
Juan Lang wrote: This removes the unused variables in the last version. --Juan I think that these failures are also because of not enough rights (people running winetest as a normal user). So just removing them is

Re: wintrust(2/3): Remove a couple tests that fail on a variety of systems (try 2)

2009-02-12 Thread Paul Vriens
Paul Vriens wrote: Juan Lang wrote: This removes the unused variables in the last version. --Juan I think that these failures are also because of not enough rights (people running winetest as a normal user). So

Re: wintrust(3/3): Fix a couple tests on a variety of systems

2009-02-12 Thread Juan Lang
Hi Paul, This is of course on boxes where people dont' run winetest as a administrator. I'm not sure if ERROR_ACCESS_DENIED is thus actually an acceptable failure. In other tests we have used skip() for this. Of course that's the reason, but not running as administrator is an acceptable

Re: wintrust(3/3): Fix a couple tests on a variety of systems

2009-02-12 Thread Paul Vriens
Juan Lang wrote: Hi Paul, This is of course on boxes where people dont' run winetest as a administrator. I'm not sure if ERROR_ACCESS_DENIED is thus actually an acceptable failure. In other tests we have used skip() for this. Of course that's the reason, but not running as administrator

Re: wintrust(2/3): Remove a couple tests that fail on a variety of systems (try 2)

2009-02-12 Thread Juan Lang
I think that these failures are also because of not enough rights (people running winetest as a normal user). So just removing them is probably not the best approach? Maybe it's not that there are not enough rights. The common denominator that I see is that all reports/boxes that produce

Re: wintrust(2/3): Remove a couple tests that fail on a variety of systems (try 2)

2009-02-12 Thread Paul Vriens
Juan Lang wrote: I think that these failures are also because of not enough rights (people running winetest as a normal user). So just removing them is probably not the best approach? Maybe it's not that there are not enough rights. The common denominator that I see is that all reports/boxes

Re: wintrust(2/3): Remove a couple tests that fail on a variety of systems (try 2)

2009-02-12 Thread Juan Lang
What we maybe need in the header of the report is more information: - The locale - The screen dimensions - Do we have admin rights (just brainstorming here). That would make it easier to decide if it's a misconfiguration or a real acceptable configuration. Maybe you're right. To that

Re: wintrust(2/3): Remove a couple tests that fail on a variety of systems (try 2)

2009-02-12 Thread Paul Vriens
Juan Lang wrote: What we maybe need in the header of the report is more information: - The locale - The screen dimensions - Do we have admin rights (just brainstorming here). That would make it easier to decide if it's a misconfiguration or a real acceptable configuration. Maybe

Re: wintrust(2/3): Remove a couple tests that fail on a variety of systems (try 2)

2009-02-12 Thread Reece Dunn
2009/2/12 Paul Vriens paul.vriens.w...@gmail.com: Juan Lang wrote: I think that these failures are also because of not enough rights (people running winetest as a normal user). So just removing them is probably not the best approach? Maybe it's not that there are not enough rights. The

RE: wintrust(2/3): Remove a couple tests that fail on a variety of systems (try 2)

2009-02-12 Thread Ge van Geldorp
From: Paul Vriens [mailto:paul.vriens.w...@gmail.com] Paul Vriens wrote: Juan Lang wrote: This removes the unused variables in the last version. --Juan - --- I think that these failures are also because

Re: gdiplus: in GdipDrawString only NULL terminate if we have room in the buffer.

2009-02-12 Thread Nikolay Sivov
Aric Stewart wrote: --- dlls/gdiplus/graphics.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c index 2673042..c276a43 100644 --- a/dlls/gdiplus/graphics.c +++ b/dlls/gdiplus/graphics.c @@ -1901,7 +1901,8 @@

Re: [2/2] tools/winemaker.man.in: update man-page

2009-02-12 Thread Nikolay Sivov
André Hentschel wrote: sorry, had the wrong mail-account last time. updating the man-page of winemaker. there were such old things, there was dust on it! No attachment here...

Re: gdiplus: in GdipDrawString only NULL terminate if we have room in the buffer.

2009-02-12 Thread Aric Stewart
if we do this call with a string of XX and a length of 2. then we create a 2 WCHAR buffer to store the string in. then i == 0; j == 0 on the first look i++ and j++ so i == 1, j == 1 and length is 2. then we loop again and i++ and j++ so i == 2, j == 2 and length == 2. so then when we do the

Re: [sane.ds 1/3] Get resolution from sane, instead of hard coding -1.

2009-02-12 Thread Jeremy White
I'm sorry; I failed to do a git-add options.c prior to this commit. Please use this patch instead. Cheers, Jeremy From d0c4a185b93a8b3040f4b7ffc001fa3f8f7b0199 Mon Sep 17 00:00:00 2001 From: Jeremy White jwh...@codeweavers.com Date: Thu, 12 Feb 2009 16:22:46 -0600 Subject: [PATCH] Get

Proposed goal for website: happily usable at 800x600?

2009-02-12 Thread Dan Kegel
What with netbooks with small screens abounding, it might make sense to review our web site and make sure its most important parts are usable in an 800x600 screen (easy to simulate, just resize your browser until xwininfo says it's 800x550, those gnome top and bottom bars chew 25 pixels each).