Re: [1/5] fusion: Assembly version must be taken from the metadata, not the file version.

2009-02-13 Thread James Hawkins
On Fri, Feb 13, 2009 at 12:12 AM, Hans Leidekker h...@meelstraat.net wrote: Office 2007 SP1 installer depends on this. Please write a test case. -- James Hawkins

Re: [3/5] fusion: Assembly version numbers are WORDs.

2009-02-13 Thread James Hawkins
This definitely needs a test. -- James Hawkins On Fri, Feb 13, 2009 at 12:14 AM, Hans Leidekker h...@meelstraat.net wrote: diff --git a/dlls/fusion/asmname.c b/dlls/fusion/asmname.c index acf0411..ebf76af 100644 --- a/dlls/fusion/asmname.c +++ b/dlls/fusion/asmname.c @@ -45,7 +45,7 @@

Re: [5/5] fusion: Implement IAssemblyCache::QueryAssemblyInfo.

2009-02-13 Thread James Hawkins
It would be a lot easier if you just took over my patches that implement this properly: [PATCH 1/3] fusion: Implement the IAssemblyEnum interface. [try4] http://winehq.org/pipermail/wine-patches/2009-January/066994.html [PATCH 2/3] fusion: Add tests for the IAssemblyEnum interface. [try4]

Re: msi: Fix case of assembly field names.

2009-02-13 Thread James Hawkins
Fix how? Both cases should be accepted... -- James Hawkins 2009/2/13 Hans Leidekker h...@meelstraat.net: diff --git a/dlls/msi/action.c b/dlls/msi/action.c index fd38f7a..38d2484 100644 --- a/dlls/msi/action.c +++ b/dlls/msi/action.c @@ -5870,11 +5870,11 @@ static UINT

Re: [1/5] fusion: Assembly version must be taken from the metadata, not the file version.

2009-02-13 Thread Hans Leidekker
On Friday 13 February 2009 09:22:31 James Hawkins wrote: Office 2007 SP1 installer depends on this. Please write a test case. Sure. Note that it's documented here http://support.microsoft.com/kb/556041 -Hans

Re: [1/5] fusion: Assembly version must be taken from the metadata, not the file version.

2009-02-13 Thread James Hawkins
On Fri, Feb 13, 2009 at 12:34 AM, Hans Leidekker h...@codeweavers.com wrote: On Friday 13 February 2009 09:22:31 James Hawkins wrote: Office 2007 SP1 installer depends on this. Please write a test case. Sure. Note that it's documented here http://support.microsoft.com/kb/556041 No

Re: [3/5] fusion: Assembly version numbers are WORDs.

2009-02-13 Thread Hans Leidekker
On Friday 13 February 2009 09:26:03 James Hawkins wrote: This definitely needs a test. Patch [5/5] has a test that depends on this. -Hans

Re: [5/5] fusion: Implement IAssemblyCache::QueryAssemblyInfo.

2009-02-13 Thread Hans Leidekker
On Friday 13 February 2009 09:31:54 James Hawkins wrote: It would be a lot easier if you just took over my patches that implement this properly: Hmm, I missed those. I'll integrate them with mine. -Hans

Re: [5/5] fusion: Implement IAssemblyCache::QueryAssemblyInfo.

2009-02-13 Thread James Hawkins
On Fri, Feb 13, 2009 at 12:43 AM, Hans Leidekker h...@codeweavers.com wrote: On Friday 13 February 2009 09:31:54 James Hawkins wrote: It would be a lot easier if you just took over my patches that implement this properly: Hmm, I missed those. I'll integrate them with mine. Thanks! --

Re: wintrust(2/3): Remove a couple tests that fail on a variety of systems (try 2)

2009-02-13 Thread Paul Vriens
Juan Lang wrote: I think that these failures are also because of not enough rights (people running winetest as a normal user). So just removing them is probably not the best approach? Maybe it's not that there are not enough rights. The common denominator that I see is that all reports/boxes

Re: Start DDE interface from Explorer Process. Add DDE stubs.

2009-02-13 Thread Dmitry Timoshkov
Jeremiah Flerchinger jeremiah.flerchin...@gmail.com wrote: Explorer.exe now calls ShellDdeInit. Progman stubs will now be started/used in Shell32. Amazingly any apps with a Progman DDE interface will also be called. Shell32 can handle all major functionality, but a running progman.exe (for

Problem with compiling ole32 crosstest

2009-02-13 Thread Vitaly Perov
Hi! Does anybody have a problem compilling the crosstest of ole32? Or maybe it's only my fault? I have: usrmarshal.cross.o: In function `func_usrmarshal': /srv/vitperov/Projects/wine-dev/dlls/ole32/tests/usrmarshal.c:445: undefined reference to `_wdtpinterfacepointer_users...@20'

Re: Proposed goal for website: happily usable at 800x600?

2009-02-13 Thread Francois Gouget
On Thu, 12 Feb 2009, Dan Kegel wrote: What with netbooks with small screens abounding, it might make sense to review our web site and make sure its most important parts are usable in an 800x600 screen (easy to simulate, just resize your browser until xwininfo says it's 800x550, those gnome

Re: Problem with compiling ole32 crosstest

2009-02-13 Thread Huw Davies
On Fri, Feb 13, 2009 at 02:01:35PM +0300, Vitaly Perov wrote: Hi! Does anybody have a problem compilling the crosstest of ole32? Or maybe it's only my fault? I have: usrmarshal.cross.o: In function `func_usrmarshal': /srv/vitperov/Projects/wine-dev/dlls/ole32/tests/usrmarshal.c:445:

Re: Problem with compiling ole32 crosstest

2009-02-13 Thread Vitaly Perov
On Friday 13 February 2009 14:18:17 Huw Davies wrote: On Fri, Feb 13, 2009 at 02:01:35PM +0300, Vitaly Perov wrote: Hi! Does anybody have a problem compilling the crosstest of ole32? Or maybe it's only my fault? I have: usrmarshal.cross.o: In function `func_usrmarshal':

Re: Proposed goal for website: happily usable at 800x600?

2009-02-13 Thread Ben Klein
2009/2/13 Francois Gouget fgou...@free.fr: On Thu, 12 Feb 2009, Dan Kegel wrote: What with netbooks with small screens abounding, it might make sense to review our web site and make sure its most important parts are usable in an 800x600 screen (easy to simulate, just resize your browser

Re: Proposed goal for website: happily usable at 800x600?

2009-02-13 Thread SorinN
( sorry for re-post - first response go only to Dan Kegel ) on short - that means a lot of scroll OR to split too big contents like : Title Content asdfsdaf sadfsadf sadfsadfs sad 4545 fsdf sadf sdfsdfsadf part 1 link, part 2 link ( page bottom ) it could be done with jQuery also for 800x600

Re: Proposed goal for website: happily usable at 800x600?

2009-02-13 Thread Ben Klein
2009/2/13 SorinN nemes.so...@gmail.com: it could be done with jQuery I hear this a lot. Is it really such a good idea? I'd argue a site not requiring Javascript to function is much cleaner, friendlier and more accessible.

Re: Proposed goal for website: happily usable at 800x600?

2009-02-13 Thread Seth Shelnutt
On Fri, Feb 13, 2009 at 8:15 AM, Ben Klein shackl...@gmail.com wrote: 2009/2/13 SorinN nemes.so...@gmail.com: it could be done with jQuery I hear this a lot. Is it really such a good idea? I'd argue a site not requiring Javascript to function is much cleaner, friendlier and more

Re: Proposed goal for website: happily usable at 800x600?

2009-02-13 Thread Remco
On Fri, Feb 13, 2009 at 2:15 PM, Ben Klein shackl...@gmail.com wrote: 2009/2/13 SorinN nemes.so...@gmail.com: it could be done with jQuery I hear this a lot. Is it really such a good idea? I'd argue a site not requiring Javascript to function is much cleaner, friendlier and more accessible.

Re: lz32: Fix several test failures on Windows 9x systems

2009-02-13 Thread Alexandre Julliard
Juan Lang juan.l...@gmail.com writes: @@ -231,7 +231,9 @@ static void test_LZOpenFileA_existing_compressed(void) file = LZOpenFileA(_terminated, test, OF_EXIST); ok(file = 0, LZOpenFileA failed on switching to a compressed file name\n); ok(test.cBytes == sizeof(OFSTRUCT) || -

Re: Proposed goal for website: happily usable at 800x600?

2009-02-13 Thread SorinN
Years ago I was a happy CLI user - but for nornal browsers Javascript is OK - for non JS browsers - a noscript version of the website can be generated - and long page content can be arranged in part1, part2, etc - accessible via bottom links 2009/2/13 Seth Shelnutt shelnu...@gmail.com: On Fri,

Re: gdi32: Fixed a couple of Win64 pointer cast compiler warnings

2009-02-13 Thread Alexandre Julliard
Eddie Leung eddie.leung.2...@anderson.ucla.edu writes: diff --git a/dlls/gdi32/dc.c b/dlls/gdi32/dc.c index c8a3c4c..44a9a6f 100644 --- a/dlls/gdi32/dc.c +++ b/dlls/gdi32/dc.c @@ -1433,7 +1433,7 @@ static BOOL WINAPI call_dc_hook16( HDC hdc, WORD code, DWORD_PTR data, LPARAM lP

Re: urlmon: Corrected tests (resend)

2009-02-13 Thread Alexandre Julliard
Alistair Leslie-Hughes leslie_alist...@hotmail.com writes: Hi, Changelog: urlmon: Corrected tests Please write a better description. Corrected tests applies to every test commit. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH] comdlg32: check for lfs NULL ptr (Coverity)

2009-02-13 Thread Alexandre Julliard
Marcus Meissner mar...@jet.franken.de writes: CID 119, 188, resubmit with working patch from earlier round. I guess we could also just let it crash if this happens, but I am not feeling comfortable. These are internal functions, it doesn't make sense to call them with NULL. -- Alexandre

Re: wintrust(3/3): Fix a couple tests on a variety of systems

2009-02-13 Thread Rob Shearman
2009/2/12 Juan Lang juan.l...@gmail.com: Hi Paul, This is of course on boxes where people dont' run winetest as a administrator. I'm not sure if ERROR_ACCESS_DENIED is thus actually an acceptable failure. In other tests we have used skip() for this. Of course that's the reason, but not

Re: Proposed goal for website: happily usable at 800x600?

2009-02-13 Thread Rob Shearman
2009/2/13 Ben Klein shackl...@gmail.com: 2009/2/13 Francois Gouget fgou...@free.fr: On Thu, 12 Feb 2009, Dan Kegel wrote: What with netbooks with small screens abounding, it might make sense to review our web site and make sure its most important parts are usable in an 800x600 screen (easy

Re: Proposed goal for website: happily usable at 800x600?

2009-02-13 Thread Dan Kegel
Francois Gouget fgou...@free.fr wrote: What with netbooks with small screens abounding, it might make sense to review our web site and make sure its most important parts are usable in an 800x600 screen For what it's worth, most netbooks have a 1024x600 resolution (all the 9 and 10 ones as

Re: wintrust(3/3): Fix a couple tests on a variety of systems

2009-02-13 Thread Paul Vriens
Rob Shearman wrote: 2009/2/12 Juan Lang juan.l...@gmail.com: Hi Paul, This is of course on boxes where people dont' run winetest as a administrator. I'm not sure if ERROR_ACCESS_DENIED is thus actually an acceptable failure. In other tests we have used skip() for this. Of course that's the

Re: wintrust(3/3): Fix a couple tests on a variety of systems

2009-02-13 Thread Alexandre Julliard
Paul Vriens paul.vriens.w...@gmail.com writes: I sent out an email earlier to ask if we should include more information in the header of the report. We could use that information, if this change will be accepted by AJ, to limit the reporting only to boxes were we have admin rights. As

Firefox 3 runs faster on Linux+Wine than on Linux -- comparative to running on Windows

2009-02-13 Thread Reece Dunn
Hi, For those not monitoring slashdot [1], there is an article [2] that is comparing the Google V8 benchmark on Windows and Linux versions of Firefox 3. The result of this is that the Windows and Wine runs are pretty close (241 vs 227) when compared to the Linux run (181) and Opera (155). I

RE: [1/2] gdiplus/tests: Some tests for Image raw format value

2009-02-13 Thread Nikolay Sivov
Anything wrong with that? http://www.winehq.org/pipermail/wine-patches/2009-February/069267.html http://www.winehq.org/pipermail/wine-patches/2009-February/069273.html

Re: Firefox 3 runs faster on Linux+Wine than on Linux -- comparative to running on Windows

2009-02-13 Thread Austin English
On Fri, Feb 13, 2009 at 10:00 AM, Reece Dunn mscl...@googlemail.com wrote: Hi, For those not monitoring slashdot [1], there is an article [2] that is comparing the Google V8 benchmark on Windows and Linux versions of Firefox 3. The result of this is that the Windows and Wine runs are pretty

Re: Firefox 3 runs faster on Linux+Wine than on Linux -- comparative to running on Windows

2009-02-13 Thread Zachary Goldberg
2009/2/13 Austin English austinengl...@gmail.com: On Fri, Feb 13, 2009 at 10:00 AM, Reece Dunn mscl...@googlemail.com wrote: Hi, For those not monitoring slashdot [1], there is an article [2] that is comparing the Google V8 benchmark on Windows and Linux versions of Firefox 3. The result

Re: Firefox 3 runs faster on Linux+Wine than on Linux -- comparative to running on Windows

2009-02-13 Thread Susan Cragin
Hi, For those not monitoring slashdot [1], there is an article [2] that is comparing the Google V8 benchmark on Windows and Linux versions of Firefox 3. The result of this is that the Windows and Wine runs are pretty close (241 vs 227) when compared to the Linux run (181) and Opera (155). I

Re: How to get more info on timed out/crashed tests?

2009-02-13 Thread Rob Shearman
2009/2/11 Juan Lang juan.l...@gmail.com: Hi all, there are a number of tests at test.winehq.org that indicate that they're timed out or crashed. The difficulty is, I have no access to machines running the version of Windows on which the test is timing out or failing, and the data about the

Re: How to get more info on timed out/crashed tests?

2009-02-13 Thread Juan Lang
Something like the attached patch? Hoo, that'd be worlds better. Thanks, Rob! --Juan

RFC: patch to advapi32's cred tests

2009-02-13 Thread Juan Lang
Hi all, I've written a patch which should fix the failing advapi32 cred tests that mirrors the skips in the existing tests: diff --git a/dlls/advapi32/tests/cred.c b/dlls/advapi32/tests/cred.c index 58103c6..bb6935b 100644 --- a/dlls/advapi32/tests/cred.c +++ b/dlls/advapi32/tests/cred.c @@

Re: RFC: patch to advapi32's cred tests

2009-02-13 Thread Rob Shearman
2009/2/13 Juan Lang juan.l...@gmail.com: Hi all, I've written a patch which should fix the failing advapi32 cred tests that mirrors the skips in the existing tests: diff --git a/dlls/advapi32/tests/cred.c b/dlls/advapi32/tests/cred.c index 58103c6..bb6935b 100644 ---

Re: Firefox 3 runs faster on Linux+Wine than on Linux -- comparative to running on Windows

2009-02-13 Thread Reece Dunn
2009/2/13 Susan Cragin susancra...@earthlink.net: Hi, For those not monitoring slashdot [1], there is an article [2] that is comparing the Google V8 benchmark on Windows and Linux versions of Firefox 3. The result of this is that the Windows and Wine runs are pretty close (241 vs 227) when

Re: RFC: patch to advapi32's cred tests

2009-02-13 Thread Juan Lang
No, CRED_PERSIST_LOCAL_MACHINE should be fine but does this change make any difference? I believe the ERROR_NO_SUCH_LOGON_SESSION is returned when the tests are being run as a user that doesn't have a profile, and therefore the credentials manager doesn't have anywhere to store the

Re: [sane.ds try2 1/3] Get resolution from sane, instead of hard coding -1.

2009-02-13 Thread Juan Lang
Hi Jeremy, a couple comments: -pImageInfo-XResolution.Whole = -1; +if (sane_option_get_int(activeDS.deviceHandle, resolution, resolution) == SANE_STATUS_GOOD) +pImageInfo-XResolution.Whole = pImageInfo-YResolution.Whole = resolution; (snip) +/* Option functions */

Re: [sane.ds try2 1/3] Get resolution from sane, instead of hard coding -1.

2009-02-13 Thread Juan Lang
Hi again, Jeremy, With this change, sane.ds will not compile unless SONAME_LIBSANE is defined. This remark is incorrect, sorry. I only read the patch, I didn't read ds_image.c first. This change is correct. The other comment is, is adding a new file (option.c) really necessary? If you're

Re: [sane.ds try2 1/3] Get resolution from sane, instead of hard coding -1.

2009-02-13 Thread Jeremy White
Hi Juan, The other comment is, is adding a new file (option.c) really necessary? If you're planning to expand it a lot, perhaps, but just for this one small function it looks like overkill to me. This remark still stands. Yes, I am planning on expanding options.c a fair amount, and I'm

Re: mshtml: allow REG_EXPAND_SZ values for GeckoCabDir

2009-02-13 Thread Juan Lang
Hi Christoph, -/* @@ Wine registry key: HKCU\Software\Wine\MSHTML */ -res = RegOpenKeyW(HKEY_CURRENT_USER, mshtml_keyW, hkey); -if(res != ERROR_SUCCESS) -return FALSE; - file_name = heap_alloc(size+sizeof(GECKO_FILE_NAME)); -res = RegQueryValueExA(hkey, GeckoCabDir,

Re: wintrust(3/3): Fix a couple tests on a variety of systems

2009-02-13 Thread Ge van Geldorp
From: Alexandre Julliard julli...@winehq.org Paul Vriens paul.vriens.w...@gmail.com writes: I sent out an email earlier to ask if we should include more information in the header of the report. We could use that information, if this change will be accepted by AJ, to limit the

Re: atmlib: add stub dll

2009-02-13 Thread Nikolay Sivov
Austin English wrote: Needed by photoshop cs4. See bug 16385. diff --git a/dlls/atmlib/atmlib_main.c b/dlls/atmlib/atmlib_main.c new file mode 100644 index 000..bb17989 --- /dev/null +++ b/dlls/atmlib/atmlib_main.c @@ -0,0 +1,45 @@ +/* + * MSSIGN32 implementation + * + *

Re: atmlib: add stub dll

2009-02-13 Thread Austin English
On Fri, Feb 13, 2009 at 4:27 PM, Nikolay Sivov bungleh...@gmail.com wrote: Austin English wrote: Needed by photoshop cs4. See bug 16385. diff --git a/dlls/atmlib/atmlib_main.c b/dlls/atmlib/atmlib_main.c new file mode 100644 index 000..bb17989 --- /dev/null +++

Re: atmlib: add stub dll

2009-02-13 Thread Austin English
On Fri, Feb 13, 2009 at 4:37 PM, Austin English austinengl...@gmail.com wrote: On Fri, Feb 13, 2009 at 4:27 PM, Nikolay Sivov bungleh...@gmail.com wrote: Austin English wrote: Needed by photoshop cs4. See bug 16385. diff --git a/dlls/atmlib/atmlib_main.c b/dlls/atmlib/atmlib_main.c new file

Re: wininet: parse cookie information from cookie value

2009-02-13 Thread Rob Shearman
2009/2/13 Aric Stewart a...@codeweavers.com: +if (CompareStringW(GetThreadLocale(), NORM_IGNORECASE, ptr, 6, + szDomain, 6) == 2) LOCALE_INVARIANT should be used when comparing with a constant string. See here for the reasons why:

Re: Firefox 3 runs faster on Linux+Wine than on Linux -- comparative to running on Windows

2009-02-13 Thread Reece Dunn
2009/2/13 Reece Dunn mscl...@googlemail.com: Hi, For those not monitoring slashdot [1], there is an article [2] that is comparing the Google V8 benchmark on Windows and Linux versions of Firefox 3. The result of this is that the Windows and Wine runs are pretty close (241 vs 227) when

WINEGATE.DLL: Wine gateway to native Unix libraries

2009-02-13 Thread Martin Hinner
Hello, I have created a small library to allow Win32 applications running under Wine to load native Unix shared libraries (.so). First (one-hour hack) version is available at http://martin.hinner.info/tmp/winegate.tar.gz ; Please consider inclusion in WINE tree (dll/ directory). Please note

Re: WINEGATE.DLL: Wine gateway to native Unix libraries

2009-02-13 Thread Ben Klein
2009/2/14 Martin Hinner mar...@hinner.info: Purpose of this Wine DLL is to allow Windows applications to use directly Unix library functions. This is useful for example for applications which talk to specific drivers and it's not efficient/possible to create system native DLL for such

Proposal: put Winetricks into Wine menu

2009-02-13 Thread Dan Kegel
I know, when I wrote Winetricks, I meant it as a developers' tool only. But... then... people started using it, and it made sense to provide it as a way to download missing visual C++ runtimes etc. for average users. Quite a few newbies trip over the fact that it needs cabextract installed.

Re: WINEGATE.DLL: Wine gateway to native Unix libraries

2009-02-13 Thread Martin Hinner
Hi, On Sat, Feb 14, 2009 at 6:31 AM, Ben Klein shackl...@gmail.com wrote: 2009/2/14 Martin Hinner mar...@hinner.info: Purpose of this Wine DLL is to allow Windows applications to use directly Unix library functions. This is useful for example for applications which talk to specific drivers

Re: WINEGATE.DLL: Wine gateway to native Unix libraries

2009-02-13 Thread Ben Klein
2009/2/14 Martin Hinner mar...@hinner.info: Hi, On Sat, Feb 14, 2009 at 6:31 AM, Ben Klein shackl...@gmail.com wrote: 2009/2/14 Martin Hinner mar...@hinner.info: Purpose of this Wine DLL is to allow Windows applications to use directly Unix library functions. This is useful for example for

re: WINEGATE.DLL: Wine gateway to native Unix libraries

2009-02-13 Thread Dan Kegel
Very interesting. I'd been suggesting to ISVs that they create a single winelib dll and conditionally load that if present, but winegate.dll might be an appealing alternative. I don't think this really brings up any security considerations but it is a reminder that Windows programs under Wine