Re: SOC 2009: Application Test Suite

2009-03-25 Thread Austin English
On Wed, Mar 25, 2009 at 7:42 PM, Vincent Povirk wrote: > On Wed, Mar 25, 2009 at 6:37 PM, Austin English > wrote: >> From the looks of things, we could do just about everything in >> autohotkey with enough elbow grease. It would only take a small >> wrapper script to run it under wine, or, if so

Re: [PATCH 00/10] Support for dumb picture keychain

2009-03-25 Thread Guy Albertelli
On Tue, 2009-03-24 at 11:32 +0100, Alexandre Julliard wrote: > Guy Albertelli writes: > > > 1/10 server: Implement FILE_NO_INTERMEDIATE_BUFFERING with O_DIRECT > > 2/10 kernel32/tests: First test for CreateFile on NT unique volume name > > 3/10 ntdll: Implement conversion of NT unique volume

Re: SOC 2009: Application Test Suite

2009-03-25 Thread Vincent Povirk
On Wed, Mar 25, 2009 at 6:37 PM, Austin English wrote: > From the looks of things, we could do just about everything in > autohotkey with enough elbow grease. It would only take a small > wrapper script to run it under wine, or, if someone wanted to later > extend it, to windows. Your current scri

IOCTL_DISK_GET_DRIVE_GEOMETRY in mountmgr.sys

2009-03-25 Thread Michael Ost
Hi, The ioctl handler for IOCTL_DISK_GET_DRIVE_GEOMETRY on .\\c: in mountmgr.sys doesn't work. The call returns incorrect values that change at random intervals. Since the ioctl is defined as METHOD_BUFFERED I think it should be putting DRIVE_GEOMETRY data in IRP->AssociatedIrp.SystemBuf

Re: SOC 2009: Application Test Suite

2009-03-25 Thread Austin English
On Wed, Mar 25, 2009 at 11:47 AM, Austin English wrote: Here's a quick thrown together script to test firefox3. >From the looks of things, we could do just about everything in autohotkey with enough elbow grease. It would only take a small wrapper script to run it under wine, or, if someone want

Re: programs/dxdiag: Create dummy application

2009-03-25 Thread Austin English
On Wed, Mar 25, 2009 at 5:09 PM, Allen Hair wrote: Howdy Allen Glad to see y'all are finally trying to get this committed. Couple minor things: diff --git a/programs/dxdiag/En.rc b/programs/dxdiag/En.rc new file mode 100644 index 000..76e93ff --- /dev/null +++ b/programs/dxdiag/En.rc @@ -0

Re: programs/dxdiag: Create dummy application

2009-03-25 Thread Austin English
On Wed, Mar 25, 2009 at 5:09 PM, Allen Hair wrote: Howdy Allen Glad to see y'all are finally trying to get this committed. Couple minor things: diff --git a/programs/dxdiag/En.rc b/programs/dxdiag/En.rc new file mode 100644 index 000..76e93ff --- /dev/null +++ b/programs/dxdiag/En.rc @@ -0

Re: [kernel32] Fix inf file parsing

2009-03-25 Thread James Hawkins
On Wed, Mar 25, 2009 at 1:09 PM, Paul Vriens wrote: > On Mar 25, 2009, at 20:44, James Hawkins wrote: > >> On Wed, Mar 25, 2009 at 11:50 AM, Paul Vriens >> wrote: >>> >>> James Hawkins wrote: On Wed, Mar 25, 2009 at 8:25 AM, Paul Vriens wrote: > > Hi, > > Thi

Re: [kernel32] Fix inf file parsing

2009-03-25 Thread Paul Vriens
On Mar 25, 2009, at 20:44, James Hawkins wrote: On Wed, Mar 25, 2009 at 11:50 AM, Paul Vriens wrote: James Hawkins wrote: On Wed, Mar 25, 2009 at 8:25 AM, Paul Vriens > wrote: Hi, This fixes bug 17843 but I'm not sure it's a 100% correct. James didn't change this just for the fun of

Re: [kernel32] Fix inf file parsing

2009-03-25 Thread James Hawkins
On Wed, Mar 25, 2009 at 11:50 AM, Paul Vriens wrote: > James Hawkins wrote: >> >> On Wed, Mar 25, 2009 at 8:25 AM, Paul Vriens >> wrote: >>> >>> Hi, >>> >>> This fixes bug 17843 but I'm not sure it's a 100% correct. James didn't >>> change >>> this just for the fun of it. >>> >> >> If you're unsu

Re: [kernel32] Fix inf file parsing

2009-03-25 Thread Paul Vriens
James Hawkins wrote: On Wed, Mar 25, 2009 at 8:25 AM, Paul Vriens wrote: Hi, This fixes bug 17843 but I'm not sure it's a 100% correct. James didn't change this just for the fun of it. If you're unsure of the correct fix, you should write a test case that fails without your patch and succee

Re: msi: avoid negative index in TABLE_insert_row

2009-03-25 Thread James Hawkins
On Wed, Mar 25, 2009 at 11:15 AM, James Hawkins wrote: > On Wed, Mar 25, 2009 at 11:14 AM, James Hawkins wrote: >> On Wed, Mar 25, 2009 at 11:14 AM, James Hawkins wrote: >>> On Wed, Mar 25, 2009 at 10:39 AM, Aric Stewart wrote: fixes bug Bug 17600 ---  dlls/msi/table.c |    

Re: msi: avoid negative index in TABLE_insert_row

2009-03-25 Thread James Hawkins
On Wed, Mar 25, 2009 at 11:18 AM, Aric Stewart wrote: > What appears to be happening is There is an existing table (I am unsure how > many rows it has) > > Then the office installer is doing an Insert on the table as TEMPORARY. > > r = table_create_new_row( view, &row, temporary ); > > returns a r

Re: msi: avoid negative index in TABLE_insert_row

2009-03-25 Thread Aric Stewart
What appears to be happening is There is an existing table (I am unsure how many rows it has) Then the office installer is doing an Insert on the table as TEMPORARY. r = table_create_new_row( view, &row, temporary ); returns a row of 0 then under the temporary case we do idx -= tv->table->row

Re: msi: avoid negative index in TABLE_insert_row

2009-03-25 Thread James Hawkins
On Wed, Mar 25, 2009 at 11:14 AM, James Hawkins wrote: > On Wed, Mar 25, 2009 at 11:14 AM, James Hawkins wrote: >> On Wed, Mar 25, 2009 at 10:39 AM, Aric Stewart wrote: >>> >>> fixes bug Bug 17600 >>> --- >>>  dlls/msi/table.c |    3 ++- >>>  1 files changed, 2 insertions(+), 1 deletions(-) >>>

Re: msi: avoid negative index in TABLE_insert_row

2009-03-25 Thread James Hawkins
On Wed, Mar 25, 2009 at 11:14 AM, James Hawkins wrote: > On Wed, Mar 25, 2009 at 10:39 AM, Aric Stewart wrote: >> >> fixes bug Bug 17600 >> --- >>  dlls/msi/table.c |    3 ++- >>  1 files changed, 2 insertions(+), 1 deletions(-) >> > > Please add a test case that demonstrates what you're trying t

Re: msi: avoid negative index in TABLE_insert_row

2009-03-25 Thread James Hawkins
On Wed, Mar 25, 2009 at 10:39 AM, Aric Stewart wrote: > > fixes bug Bug 17600 > --- >  dlls/msi/table.c |    3 ++- >  1 files changed, 2 insertions(+), 1 deletions(-) > Please add a test case that demonstrates what you're trying to fix. If an internal msi function is sending in a negative index,

Re: [kernel32] Fix inf file parsing

2009-03-25 Thread James Hawkins
On Wed, Mar 25, 2009 at 8:25 AM, Paul Vriens wrote: > Hi, > > This fixes bug 17843 but I'm not sure it's a 100% correct. James didn't > change > this just for the fun of it. > If you're unsure of the correct fix, you should write a test case that fails without your patch and succeeds with your pa

Re: [4/4] [wined3d] trigger constant reloading when RECT textures change

2009-03-25 Thread Stefan Dösinger
Am Mittwoch, 25. März 2009 14:52:15 schrieb Tobias Jakobi: A few comments on all the patches. I am a bit busy at university right now, so I didn't have a chance to answer earlier: >From patch 4/4: > +if (!use_ps(stateblock)) { > +TRACE("Non power two matrix multiply fixup\n")

Re: SOC 2009: Application Test Suite

2009-03-25 Thread Austin English
On Wed, Mar 25, 2009 at 9:47 AM, Francois Gouget wrote: > On Tue, 24 Mar 2009, Austin English wrote: > [...] >> I'd like to implement an application test suite. It's something that's >> been discussed for Wine for quite a while, but has never been put into >> place. > > As mentioned before, check

Re: comctl32: CCS_VERT flips toolbar separators' orientation

2009-03-25 Thread Igor Tarasov
Well, I see that patches older and newer than the two mine were already approved, but mine -not. Does this mean I need something more to do? -- Igor

Re: [1/5] resend include: bring in6_addr into line with the MS definition

2009-03-25 Thread Alexandre Julliard
Jeff Latimer writes: > diff --git a/include/ws2tcpip.h b/include/ws2tcpip.h > index a38ccda..9ddb3d1 100644 > --- a/include/ws2tcpip.h > +++ b/include/ws2tcpip.h > @@ -85,26 +85,41 @@ struct WS(ip_msfilter) { > struct WS(in_addr) imsf_slist[1]; > }; > > -typedef struct WS(in_addr6) > -{ >

Re: SOC 2009: Application Test Suite

2009-03-25 Thread Francois Gouget
On Tue, 24 Mar 2009, Austin English wrote: [...] > I'd like to implement an application test suite. It's something that's > been discussed for Wine for quite a while, but has never been put into > place. As mentioned before, check out cxtest. In particular the way they are structured, with one sc

Re: SOC 2009: Application Test Suite

2009-03-25 Thread Vincent Povirk
AutoHotkey is a Windows program so any tests written in it can also be run on Windows. In fact, if you wrote everything in AHK, the entire framework would be portable to any win32 system. But that may be more crazy than you're going for. I'm told cxtest does not work on Windows. Vincent Povirk

Re: SOC 2009: Application Test Suite

2009-03-25 Thread Jeremy White
Roderick Colenbrander wrote: > Hi Austin, > > Not sure if you are aware of it but there is also cxtest which was > written by codeweavers under the gpl. See http://cxtest.ifne.eu:82/ it > seems they (still?) use it regulary to track regressions. I haven't > looked at it and don't know that autohot

Re: [PATCH 3/6] kernel32: Handle writing empty sections and keys in WritePrivateProfileString.

2009-03-25 Thread Paul Vriens
James Hawkins wrote: --- dlls/kernel32/profile.c | 32 dlls/kernel32/tests/profile.c |5 + 2 files changed, 21 insertions(+), 16 deletions(-) Hi James, Sorry if you've

Re: winex11.drv: SetDIBits fails when startscan != 0

2009-03-25 Thread Massimo Del Fedele
Massimo Del Fedele ha scritto: p.s.: of course, it needs also widthBytes * (.) I just shorted it to show the problem :-) Ciao Max

Re: winex11.drv: SetDIBits fails when startscan != 0

2009-03-25 Thread Massimo Del Fedele
Alexandre Julliard ha scritto: Massimo Del Fedele writes: - descr.bits = bits; + descr.bits = (BYTE *)bits + widthBytes * (tmpheight > 0 ? (height - startscan - lines) : startscan); You shouldn't need to change the bits address. Well, original code was descr.bits =

Re: advapi32: stub TreeResetNamedSecurityInfo for the IE8 installer

2009-03-25 Thread Aric Stewart
I will admit I do not have access to the latest headers but my impression from MSDN and a web search is that FN_PROGRESS is not defined in a header. I will keep looking but that is why i did it that way. -aric Alexandre Julliard wrote: Aric Stewart writes: diff --git a/dlls/advapi32/secur

Re: winex11.drv: SetDIBits fails when startscan != 0

2009-03-25 Thread Alexandre Julliard
Massimo Del Fedele writes: > diff --git a/dlls/winex11.drv/dib.c b/dlls/winex11.drv/dib.c > index 6df4137..42d9082 100644 > --- a/dlls/winex11.drv/dib.c > +++ b/dlls/winex11.drv/dib.c > @@ -3927,6 +3927,7 @@ INT CDECL X11DRV_SetDIBits( X11DRV_PDEVICE *physDev, > HBITMAP hbitmap, UINT start >

Re: advapi32: stub TreeResetNamedSecurityInfo for the IE8 installer

2009-03-25 Thread Alexandre Julliard
Aric Stewart writes: > diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c > index b6d51d8..4013171 100644 > --- a/dlls/advapi32/security.c > +++ b/dlls/advapi32/security.c > @@ -58,6 +58,9 @@ static BOOL > ParseStringSecurityDescriptorToSecurityDescriptor( > LPDWORD cBytes); >

Re: gdi32: don't compile printdtv16 on 64-bit

2009-03-25 Thread Alexandre Julliard
Austin English writes: > diff --git a/dlls/gdi32/gdi32.spec b/dlls/gdi32/gdi32.spec > index 36a8fb1..da77ad5 100644 > --- a/dlls/gdi32/gdi32.spec > +++ b/dlls/gdi32/gdi32.spec > @@ -512,15 +512,15 @@ > > # Wine extensions: Win16 f

Re: libwine: Only partially reserve memory beyond 0x80000000 on FreeBSD.

2009-03-25 Thread Francois Gouget
Francois Gouget a écrit : [...] Unfortunately I couldn't reproduce this problem as I only have a FreeBSD virtual machine. I attached a test application to bug 13335 to reproduce this issue without needing OpenGL support. Here's the corresponding comment: http://bugs.winehq.org/show_bug.cgi?id

Re: SOC 2009: Application Test Suite

2009-03-25 Thread Roderick Colenbrander
Hi Austin, Not sure if you are aware of it but there is also cxtest which was written by codeweavers under the gpl. See http://cxtest.ifne.eu:82/ it seems they (still?) use it regulary to track regressions. I haven't looked at it and don't know that autohotkey stuff but how do both differ? Wouldn'