Re: DIB Engine - first set of fixings agains wine test suite

2009-05-13 Thread Giuseppe Bilotta
On Thursday 14 May 2009 02:02, Massimo Del Fedele wrote: > I started fixing failures against test suite. > Most of bitmap ones are fixed, remaining are due > to still stubbed funcs. > > Now the problem is that it fixed also most todo_wines on bitmap suite > > As usual, on bug 421 page for wh

DIB Engine - first set of fixings agains wine test suite

2009-05-13 Thread Massimo Del Fedele
I started fixing failures against test suite. Most of bitmap ones are fixed, remaining are due to still stubbed funcs. Now the problem is that it fixed also most todo_wines on bitmap suite As usual, on bug 421 page for who wants to test it. Ciao Max

Re: Dynamically adding debug channels (__wine_dbg_set_channel_flags)

2009-05-13 Thread Daniel Santos
ooh! shiny! thank you!  Too bad it doesn't work with +all.  I suppose I can just list them out individually in my WINEDEBUG though. --- On Wed, 5/13/09, Roderick Colenbrander wrote: From: Roderick Colenbrander Subject: Re: Dynamically adding debug channels (__wine_dbg_set_channel_flags) To: da

Re: Wine policy question: What is considered "reverse engineering"/what is acceptable?

2009-05-13 Thread Daniel Santos
Thank you all very much for the clarification, it is exceedingly helpful!  I don't care to look at microsoft's code because I doubt I have the stomach for it!  But now I feel much better, that I wasn't doing anything wrong by examining the program state of the misbehaving app (it was on wine any

Re: Wine policy question: What is considered "reverse engineering"/what is acceptable?

2009-05-13 Thread Roderick Colenbrander
On Wed, May 13, 2009 at 10:02 PM, Jerome Leclanche wrote: > I thought reverse engineering was only relevant to MS code? As in > reverse engineering of windows dlls and so on; another application > would be irrelevant. > > That's what I understood from it anyway. First of all I'm not a lawyer ;)

Re: Wine policy question: What is considered "reverse engineering"/what is acceptable?

2009-05-13 Thread Ricardo Filipe
2009/5/13 Daniel Santos > I was recently attempting to isolate the cause of a hang in Lord of the > Rings Online and had it in a debugger. I mentioned this on IRC and was told > that I was "reverse engineering" and any patch I came up with would not be > accepted. I find this rather confusing a

Re: Dynamically adding debug channels (__wine_dbg_set_channel_flags)

2009-05-13 Thread Roderick Colenbrander
On Wed, May 13, 2009 at 9:15 PM, Daniel Santos wrote: > Steven, sorry for the slow response, I got tied up in some other stuff.  But > now back to fun. =)  And thanks for your response! > > The application is Lord of the Rings Online.  They don't use normal version > numbers, so this bug actually

Re: Wine policy question: What is considered "reverse engineering"/what is acceptable?

2009-05-13 Thread Jerome Leclanche
I thought reverse engineering was only relevant to MS code? As in reverse engineering of windows dlls and so on; another application would be irrelevant. That's what I understood from it anyway. J. On Wed, May 13, 2009 at 10:20 PM, Daniel Santos wrote: > I was recently attempting to isolate the

Wine policy question: What is considered "reverse engineering"/what is acceptable?

2009-05-13 Thread Daniel Santos
I was recently attempting to isolate the cause of a hang in Lord of the Rings Online and had it in a debugger.  I mentioned this on IRC and was told that I was "reverse engineering" and any patch I came up with would not be accepted.  I find this rather confusing and would like to better underst

Re: Dynamically adding debug channels (__wine_dbg_set_channel_flags)

2009-05-13 Thread Daniel Santos
Steven, sorry for the slow response, I got tied up in some other stuff.  But now back to fun. =)  And thanks for your response! The application is Lord of the Rings Online.  They don't use normal version numbers, so this bug actually started with "Book 14".  In Book 14, the problem would manife

Re: SoC 2009 / Application Test Suite Update

2009-05-13 Thread Austin English
On Wed, May 13, 2009 at 1:01 PM, James Hawkins wrote: > On Wed, May 13, 2009 at 10:27 AM, Austin English > wrote: >> Howdy all, >> >> I've been working on the test suite. I've got a few basic tests set up >> with notepad, and I'm currently working on setting up the framework, >> using AutoHotKey

Re: SoC 2009 / Application Test Suite Update

2009-05-13 Thread James Hawkins
On Wed, May 13, 2009 at 10:27 AM, Austin English wrote: > Howdy all, > > I've been working on the test suite. I've got a few basic tests set up > with notepad, and I'm currently working on setting up the framework, > using AutoHotKey to both run all the tests and parse the logs for > failures/pass

SoC 2009 / Application Test Suite Update

2009-05-13 Thread Austin English
Howdy all, I've been working on the test suite. I've got a few basic tests set up with notepad, and I'm currently working on setting up the framework, using AutoHotKey to both run all the tests and parse the logs for failures/passing todo's. For those interested, here's the first 'real' script I'

Adding broken() information to the test output

2009-05-13 Thread Paul Vriens
Hi, While going over some just committed patches of mine I saw (again) that we now have some tests that do: ok(ret || broken(!ret), "call failed") The good thing is that tests succeed on all Windows versions and will fail if Wine returns !ret. The bad thing is that changes in the Windows implem

Re: dplayx: Enclose NS_GetOtherMagic() in #if 0 since it's only used from code enclosed in #if 0.

2009-05-13 Thread Ismael Barros²
NS_GetOtherMagic is probably safe to remove. NS_GetNsMagic was only used in some hackish code that tried to reverse engineer dplay protocol. I removed that code that used it, but don't know if it'll be needed in a future. On Wed, May 13, 2009 at 12:10 PM, Kai Blin wrote: > On Wednesday 13 May 2

Fiddling with EnumServicesStatusExW

2009-05-13 Thread Paul Vriens
(I accidentally only sent this message to Rob only) Hi, To get away from the tests stuff I thought I'd resurrect my plans to implement EnumServiceStatusExW (the A-version is needed by SysInternal's Process Explorer amongst others). I have most of the stuff ready: - Added svcctl_EnumServicesSta

Re: C_ASSERT portability fixes and simplification [PATCH 1/2]

2009-05-13 Thread Gerald Pfeifer
On Mon, 11 May 2009, Alexandre Julliard wrote: > I don't have gcc 4.5 to test this, but you could try using a function > instead, something like this: > > diff --git a/include/winnt.h b/include/winnt.h > index abcc502..aaa4112 100644 > --- a/include/winnt.h > +++ b/include/winnt.h > @@ -292,7 +292

Re: dplayx: Enclose NS_GetOtherMagic() in #if 0 since it's only used from code enclosed in #if 0.

2009-05-13 Thread Kai Blin
On Wednesday 13 May 2009 10:38:08 Francois Gouget wrote: Personally I think we should just kill all that unused code and be done with it. Currently the only way to get a working dplay implementation is to use the native dlls anyway. Our version has been bit-rotting for quite some time. Cheers,

Re: [1/2] wininet: Implement GetDiskInfoA.

2009-05-13 Thread Alexandre Julliard
Hans Leidekker writes: > +if ((ret = GetDiskFreeSpaceA(path, &cluster_sectors, §or_bytes, > &free_clusters, &total_clusters))) > +{ > +if (cluster_size) *cluster_size = 1; > +if (free) *free = free_clusters * cluster_sectors * sector_bytes; > +if (total) *total =