Re: [Bugzilla]: Refuse to accept comments with big number of logs / back traces

2009-06-10 Thread Vitaliy Margolen
Vitaliy Margolen wrote: > The limits are: > 20 lines for logs (fixme, trace, err, warn) > 10 lines for back traces > --- > Bugzilla/Bug.pm |7 +++ > template/en/default/global/user-error.html.tmpl |4 > 2 files changed, 11 insertions(+), 0 deletions

Re: [2/5] WineD3D: Implement loops with the NV extensions

2009-06-10 Thread Stefan Dösinger
Maybe I'm missing something here, but I would have thought that shader_arb_generate_vshader should have something along the lines of: Hmm, indeed, that ended up in my texldl patch. It should not matter too much because we don't advertise SM 3.0 yet. I might send the texldl patch today. I gue

Re: [2/5] WineD3D: Implement loops with the NV extensions

2009-06-10 Thread Allan Tong
On Wed, Jun 10, 2009 at 6:45 PM, Stefan Dösinger wrote: > > Am 10.06.2009 um 15:20 schrieb Allan Tong: > >>> +    if(vshader) >>> +    { >>> +        struct shader_arb_ctx_priv *priv = ins->ctx->backend_data; >>> +        struct list *e = list_head(&priv->control_frames); >>> +        struct contro

dlls/winedos/int10.c

2009-06-10 Thread Gerald Pfeifer
In dlls/winedos/int10.c we currently have the following code VGA_SetBright((BL_reg(context) & 0x10) && 1); which I am not sure I understand. Is the purpose of this to only pass one of 0 or 1 to VGA_SetBright? If so, I guess I'd find "... ? 1 : 0" more intuitive, and it's only three characters

Re: opengl32: get rid of glext.h

2009-06-10 Thread Austin English
On Wed, Jun 10, 2009 at 2:56 PM, Roderick Colenbrander wrote: > Hi, > > Since opengl32 doesn't export opengl 1.2 functions anymore from the > spec file we don't need glext.h anymore. This also helps compilation > on OSX. > > Roderick Works great. Thanks for the quick work Roderick! -- -Austin

Re: [2/5] WineD3D: Implement loops with the NV extensions

2009-06-10 Thread Stefan Dösinger
Am 10.06.2009 um 15:20 schrieb Allan Tong: +if(vshader) +{ +struct shader_arb_ctx_priv *priv = ins->ctx->backend_data; +struct list *e = list_head(&priv->control_frames); +struct control_frame *control_frame = LIST_ENTRY(e, struct control_frame, entry); + +

Re: [2/5] WineD3D: Implement loops with the NV extensions

2009-06-10 Thread Allan Tong
> +if(vshader) > +{ > +struct shader_arb_ctx_priv *priv = ins->ctx->backend_data; > +struct list *e = list_head(&priv->control_frames); > +struct control_frame *control_frame = LIST_ENTRY(e, struct > control_frame, entry); > + > +if(priv->loop_depth > 1) sha

Re: wldap32: fix a compiler warning on Mac OS X

2009-06-10 Thread Michael Stefaniuc
Austin English wrote: On Tue, Jun 9, 2009 at 4:51 PM, Stefan Leichter wrote: Am Tuesday 09 June 2009 23:46:51 schrieb Austin English: Cast was removed by d576c2d9342e769c01fb99c0cc200a0bc4b9cded, but causes a compiler warning on OS X. The same cast is used ~20 lines later. You forgot the patch

Re: windowscodecs: add stub implementation of IWICImagingFactory

2009-06-10 Thread Vincent Povirk
This is wrong. Don't commit it. Vincent Povirk On Wed, Jun 10, 2009 at 3:08 PM, Vincent Povirk wrote: > > > >

RDo we still need the regression test for 1.1.23 ?

2009-06-10 Thread chris ahrendt
to see what patch caused the failure on non NVIDIA cards? Chris

Re: [4/4] ddraw: Add lock/unlock test.

2009-06-10 Thread Rico Schüller
Stefan Dösinger schrieb: Am 10.06.2009 um 11:06 schrieb Rico Schüller: +/* See comment in dlls/d3d9/tests/visual.c for general guidelines */ I guess this was copied from dlls/ddraw/tests/visual.c, but doesn't make sense for tests that don't read back rendering results. Otherwise the patches

Re: [4/4] ddraw: Add lock/unlock test.

2009-06-10 Thread Stefan Dösinger
Am 10.06.2009 um 11:06 schrieb Rico Schüller: +/* See comment in dlls/d3d9/tests/visual.c for general guidelines */ I guess this was copied from dlls/ddraw/tests/visual.c, but doesn't make sense for tests that don't read back rendering results. Otherwise the patches look ok to me.

Re: Default Bugzilla search does not show resolved bugs

2009-06-10 Thread Austin English
On Wed, Jun 10, 2009 at 10:29 AM, Juan Lang wrote: > Hi Ken, > >> "The default search (the search box at the top of this page) does not >> include closed bugs (rightly so), but it also does not include resolved bugs. >> This leads to duplicates that could be avoided." > > Avoiding duplicates is a g

Re: Default Bugzilla search does not show resolved bugs

2009-06-10 Thread Juan Lang
Hi Ken, > "The default search (the search box at the top of this page) does not > include closed bugs (rightly so), but it also does not include resolved bugs. > This leads to duplicates that could be avoided." Avoiding duplicates is a good idea, but I'm not sure this will help. The usual scenari

Default Bugzilla search does not show resolved bugs

2009-06-10 Thread Ken Sharp
From http://bugs.winehq.org/show_bug.cgi?id=18790 "The default search (the search box at the top of this page) does not include closed bugs (rightly so), but it also does not include resolved bugs. This leads to duplicates that could be avoided." "This is for admin to configure in Administrat

Re: Add stable Wine versions back to the AppDB

2009-06-10 Thread Ken Sharp
I doubt I could do that. As I said, what I know about PHP I could teach George Bush. I don't really have the time to figure it out right now. I'll happily look at it later, but it could be months from now! Unless someone else wants to? :) A quick-fix would do for now, but as you say, there

Re: Add stable Wine versions back to the AppDB

2009-06-10 Thread Alexander Nicolaysen Sørnes
Thanks for working on this issue! We should probably add a mechanism that would require less maintainance, by declaring a set of stable branches that should be included in the version list, such as 1.0 and 1.2. Do you think you could do that? Alexander N. Sørnes Onsdag 10 juni 2009 13:13:16

Add stable Wine versions back to the AppDB

2009-06-10 Thread Ken Sharp
See http://bugs.winehq.org/show_bug.cgi?id=15419 The AppDB is currently set up to query Bugzilla for its six latest Wine versions. Unfortunately this does not include the latest stable version of Wine (currently 1.0.1, and in the future 1.2 will also be omitted). A change to how the AppDB wo

Re: (resend, 2nd) kernel32: Implement QueryFullProcessImageNameA (3rd try)

2009-06-10 Thread Alexandre Julliard
Stefan Leichter writes: > Am Thursday 04 June 2009 12:49:58 schrieb Alexandre Julliard: >> >> I'd expect that error to be a side effect of WideCharToMultiByte, which >> is most likely what you want to use here. Also you have to handle buffer >> overflows correctly, with test cases. > > If you lik

Re: opengl32: fix a compiler warning on Mac OS X

2009-06-10 Thread Roderick Colenbrander
Normally it is very easy to do (2 minutes of work) but the opengl.spec files of which the opengl32 code is generated have been changed a lot in opengl 3.1 (the old versions are offline). I need to rewrite the scripts and some code, so it is quite a bit of work. Roderick On Wed, Jun 10, 2009 at 10

Re: opengl32: fix a compiler warning on Mac OS X

2009-06-10 Thread Austin English
On Wed, Jun 10, 2009 at 1:30 AM, Roderick Colenbrander wrote: > Actually I need to fix opengl32 properly. For some reason opengl32 is > opengl 1.2 while it should be 1.1. Then GL_GLEXT_PROTOTYPES is not > needed at all for compiling opengl32. Even better. Any idea how close that is on your todo li