Re: DxDiag Demo Patch

2009-08-07 Thread Henri Verbeet
2009/8/7 Austin English austinengl...@gmail.com: +void D3DTest_initD3D(); This needs to be void D3DTest_initD3D(void); in C. The same goes for a couple of other functions. I received mixed feedback on #winehackers about this. So currently left as is...is there a CFLAG/gcc switch to detect

Building inkscape for Windows using mingw under wine

2009-08-07 Thread Dan Kegel
http://bugs.winehq.org/show_bug.cgi?id=19615 shows that wine is very nearly in good enough shape to run the fetch-all-the-libs-and-sources script with cygwin, and run the inkscape win32 build system, and pop out a working inkscape.exe. We're just one little leak away from full success, I think.

Re: profile.c (kernel32): API broken

2009-08-07 Thread Claudio Fontana
On Thu, Aug 6, 2009 at 9:38 AM, Paul Vrienspaul.vriens.w...@gmail.com wrote: Claudio Fontana wrote: Just a reminder to everyone involved with profile.c: I have watched the git log of the somewhat recent changes to kernel32/profile.c. The profile API does not work that way. The current

Re: [lostwages] Set about page to use h3 instead of h2 as text is too large

2009-08-07 Thread Yuri Khan
On Thu, Aug 6, 2009 at 19:50, Scott Ritchiesc...@open-vote.org wrote: -h2Open Source and User Driven/h2 +h3Open Source and User Driven/h3 Font size is not a valid excuse for skipping heading levels. Presentation issues should be handled in CSS.

Re: [lostwages] Set about page to use h3 instead of h2 as text is too large

2009-08-07 Thread Scott Ritchie
Yuri Khan wrote: On Thu, Aug 6, 2009 at 19:50, Scott Ritchiesc...@open-vote.org wrote: -h2Open Source and User Driven/h2 +h3Open Source and User Driven/h3 Font size is not a valid excuse for skipping heading levels. Presentation issues should be handled in CSS. I agree with this in

Re: secur32: Implement QueryContextAttributes for SECPKG_ATTR_CONNECTION_INFO

2009-08-07 Thread Henri Verbeet
2009/8/7 Juan Lang juan.l...@gmail.com: +return SEC_E_UNSUPPORTED_FUNCTION; Is this return value intentional?

Re: Building inkscape for Windows using mingw under wine

2009-08-07 Thread Dan Kegel
On Thu, Aug 6, 2009 at 11:28 PM, Dan Kegeld...@kegel.com wrote: http://bugs.winehq.org/show_bug.cgi?id=19615 shows that wine is very nearly in good enough shape to run the fetch-all-the-libs-and-sources script with cygwin, and run the inkscape win32 build system, and pop out a working

Re: DxDiag Demo Patch

2009-08-07 Thread Henri Verbeet
2009/8/7 Henri Verbeet hverb...@gmail.com: 2009/8/7 Austin English austinengl...@gmail.com: I received mixed feedback on #winehackers about this. So currently left as is...is there a CFLAG/gcc switch to detect this, without using -ansi (which gives a crapton of other warnings). You really

Re: [PATCH 3/5] wined3d: Merge the context-current_rt check for rendertarget readback with the code above.

2009-08-07 Thread Stefan Dösinger
Am Friday 07 August 2009 08:51:20 schrieb Henri Verbeet: - * 3) lastActiveRenderTarget != target oldTid != newTid: - *This is tricky. We have to get a context with the old drawable I don't see anything wrong with this patch in particular(so go ahead and apply it), but I am

Re: profile.c (kernel32): API broken

2009-08-07 Thread Paul Vriens
Claudio Fontana wrote: On Thu, Aug 6, 2009 at 11:47 AM, Paul Vrienspaul.vriens.w...@gmail.com wrote: Claudio Fontana wrote: On Thu, Aug 6, 2009 at 9:38 AM, Paul Vrienspaul.vriens.w...@gmail.com wrote: Claudio Fontana wrote: Just a reminder to everyone involved with profile.c: I have watched

Re: [1/3] winex11.drv: Support KEYEVENTF_UNICODE in SendInput

2009-08-07 Thread Vitaliy Margolen
Andrew Eikum wrote: --- Why did you swapped setting internal key state and calling hook in X11DRV_send_keyboard_input()? Do you have a test to check that state is being updated _before_ calling hook, and not after? Vitaliy.

Re: comctl32: fix pressed button theming

2009-08-07 Thread Dmitry Timoshkov
André Hentschel n...@dawncrow.de wrote: --- a/dlls/comctl32/theme_button.c +++ b/dlls/comctl32/theme_button.c @@ -30,8 +30,22 @@ #include uxtheme.h #include tmschema.h #include comctl32.h +#include wine/winuser16.h I very much doubt that win16 apps have an idea about theming, or BM_SETSTATE16

Re: [PATCH 3/5] wined3d: Merge the context-current_rt check for rendertarget readback with the code above.

2009-08-07 Thread Henri Verbeet
2009/8/7 Stefan Dösinger stefandoesin...@gmx.at: Am Friday 07 August 2009 08:51:20 schrieb Henri Verbeet: -     * 3) lastActiveRenderTarget != target oldTid != newTid: -     *    This is tricky. We have to get a context with the old drawable I don't see anything wrong with this patch in

Re: secur32: Implement QueryContextAttributes for SECPKG_ATTR_CONNECTION_INFO

2009-08-07 Thread Juan Lang
+            return SEC_E_UNSUPPORTED_FUNCTION; Is this return value intentional? Whoops, thanks Henri. Fixing post-haste :) --Juan

Re: [1/3] winex11.drv: Support KEYEVENTF_UNICODE in SendInput

2009-08-07 Thread Andrew Eikum
Vitaliy Margolen wrote: Andrew Eikum wrote: --- Why did you swapped setting internal key state and calling hook in X11DRV_send_keyboard_input()? Do you have a test to check that state is being updated _before_ calling hook, and not after? Vitaliy. Good point. The MSDN hook documentation

Re: [3/3] user32/tests: Add tests for SendInput with unicode

2009-08-07 Thread Andrew Eikum
Dmitry Timoshkov wrote: Andrew Eikum aei...@codeweavers.com wrote: --- dlls/user32/tests/input.c | 210 + 1 files changed, 210 insertions(+), 0 deletions(-) It would be more natural and would simplify the code to add these tests to msg.c. I

Re: winemp3: a fix for security alert CVE-2006-1655

2009-08-07 Thread Juan Lang
Hi Aric, I'm not trying to correct you here, I just don't understand a comment, so I'm asking for clarification: + int idx; + if(sfb 21) return; /* similarity fix related to CVE-2006-1655 */ What is a similarity fix? Or did you mean similar to fix for CVE... instead?

Re: winemp3: a fix for security alert CVE-2006-1655

2009-08-07 Thread Juan Lang
It means similar fix... however that wording appears in the original patch to libmpg123 that corrects this problem and so in the layer3.c implementation in modern libmpg123 So i debated changing the wording or keeping the original wording and decided to keep it the same as layer3.c in

Re: winemp3: a fix for security alert CVE-2006-1655

2009-08-07 Thread Aric Stewart
It means similar fix... however that wording appears in the original patch to libmpg123 that corrects this problem and so in the layer3.c implementation in modern libmpg123 So i debated changing the wording or keeping the original wording and decided to keep it the same as layer3.c in

Crash in riched20 caused by cryptui

2009-08-07 Thread Juan Lang
Hi Dylan, I wonder if you might be able to shed insight into this. cryptui uses riched20 to display some text, and inserting an icon into a richedit control causes a crash: Assertion failed: (~para-member.para.nFlags MEPF_REWRAP), function ME_GetCursorCoordinates, file caret.c, line 183. If I

Re: [1/3] winex11.drv: Support KEYEVENTF_UNICODE in SendInput

2009-08-07 Thread Vitaliy Margolen
Andrew Eikum wrote: Vitaliy Margolen wrote: Andrew Eikum wrote: --- Why did you swapped setting internal key state and calling hook in X11DRV_send_keyboard_input()? Do you have a test to check that state is being updated _before_ calling hook, and not after? Vitaliy. Good point. The

cppcheck run against 1.27

2009-08-07 Thread chris ahrendt
[../wine-git/dlls/msvcrt/tests/file.c:997]: (error) Resource leak: stream1 [../wine-git/dlls/msvcrt/tests/file.c:997]: (error) Resource leak: stream4 [../wine-git/dlls/msvcrt/tests/heap.c:424]: (error) Deallocating a deallocated pointer: mem [../wine-git/dlls/ntdll/server.c:802]: (error)

re: DxDiag Demo Patch

2009-08-07 Thread Dan Kegel
Henri wrote: However, what really needs clarification is the copyright status of this. The web page about the project http://kegel.com/wine/sweng/2009/ makes it clear that the work had to be LGPL, and the students were fine with that. The final presentation about that code,