Re: [PATCH 2/2] fonts: .gitignore += *.fnt (autogenerated)

2009-08-26 Thread Francois Gouget
On Tue, 25 Aug 2009, Paul Chitescu wrote: [...] +courier-1250-96-13.fnt [...] +system-950-96-16.fnt Git knows shell glob patterns so why not just a line: *.fnt Because that's less accurate. In particular, if we remove a font, the corresponding .fnt file would still be ignored. --

Re: oleview initial italian translation

2009-08-26 Thread Henri Verbeet
2009/8/25 Davide Pizzetti erpi...@alice.it: @@ -1,6 +1,6 @@ /* - * OleView (En.rc) - * English Language Support + * OleView (It.rc) + * Italian Language Support * * Copyright 2006 Piotr Caban * That doesn't look right. How did you create these patches?

Re: winecfg - italian translation update

2009-08-26 Thread Henri Verbeet
2009/8/25 Davide Pizzetti erpi...@alice.it: -LTEXT Wine può simulare diverse versioni e stili di Windows per ogni applicazione, +LTEXT Wine può simulare diverse versioni e stili di Windows per ogni applicazione, Looks like you messed up the encoding of the

Re: dxdiag: add basic command line parsing

2009-08-26 Thread Henri Verbeet
2009/8/26 Austin English austinengl...@gmail.com: Based on Dan Kegel's patch he wrote for Louis Lenders old implementation. It probably doesn't make much of a difference for command line parsing, but I think you want to make dxdiag explicitly unicode from the start (new programs in general,

Re: [RFC] Adding an OpenAL DLL thunk

2009-08-26 Thread Henri Verbeet
2009/8/26 Chris Robinson chris.k...@gmail.com: On Tuesday 25 August 2009 6:40:30 am Stefan Dösinger wrote: I'll give it a try with my games. The old thunk from a while ago already worked very will with those games. OpenAL seems to have an extension system like opengl. If there is a function

Re: [PATCH 1/2] gdiplus: Implement GdipIsVisibleRegionPoint

2009-08-26 Thread Henri Verbeet
2009/8/25 Andrew Eikum aei...@codeweavers.com: +GpStatus WINGDIPAPI GdipIsVisibleRegionPointI(GpRegion* region, INT x, INT y, GpGraphics *graphics, BOOL *res) +{ +TRACE((%p, %d, %d, %p, %p)\n, region, x, y, graphics, res); + +if(!region || !res) +return InvalidParameter;

Re: wrc: Fix a memory leak on output file name (Smatch)

2009-08-26 Thread Alexandre Julliard
Frédéric Delanoy frederic.dela...@gmail.com writes: The memory is released just thereafter (process end), but this is a leak anyway It's not a leak. There's no point in wasting time freeing memory in main(). -- Alexandre Julliard julli...@winehq.org

d3dx9: Implement converting and copying surface data in D3DXLoadSurfaceFromMemory (review please)

2009-08-26 Thread Tony Wasserka
Hi everyone, D3DXLoadSurfaceFromMemory is used to load a chunk of pixel data into a surface, performing any pixel format conversion from signed/unsigned ARGB, floating point or FourCC formats to any other format and also performs various types of filtering actions (one of copying, point filtering,

Re: d3d10core/tests: Add acceptable error code for Win7

2009-08-26 Thread Henri Verbeet
2009/8/26 Ge van Geldorp ggeld...@vmware.com: hr = IDXGIFactory_EnumAdapters(factory, 0, adapter); -ok(SUCCEEDED(hr), EnumAdapters failed, hr %#x\n, hr); +ok(SUCCEEDED(hr) || hr == DXGI_ERROR_NOT_FOUND, EnumAdapters failed, hr %#x\n, hr); Is that in a VM? It's fine to skip the

Re: dxdiag: add basic command line parsing

2009-08-26 Thread Michael Stefaniuc
Henri Verbeet wrote: 2009/8/26 Austin English austinengl...@gmail.com: Based on Dan Kegel's patch he wrote for Louis Lenders old implementation. It probably doesn't make much of a difference for command line parsing, but I think you want to make dxdiag explicitly unicode from the start (new

Re: [RFC] Adding an OpenAL DLL thunk

2009-08-26 Thread Vitaliy Margolen
Chris Robinson wrote: Attached is a set of patches that adds an openal32.dll thunk, allowing an app using OpenAL to use the system's lib instead of Creative's software driver. The advantages of using the system lib include: Strange, doesn't compile here: ccache gcc -m32 -m32 -c

Re: libs/port: Use the gcc interlocked code also for pcc

2009-08-26 Thread Alexandre Julliard
Detlef Riekenberg wine@web.de writes: @@ -24,7 +24,7 @@ #ifdef __i386__ -#ifdef __GNUC__ +#if defined(__GNUC__) || defined(__PCC__) A better way would be to make this case the default, it's not all that gcc-specific. -- Alexandre Julliard julli...@winehq.org

Re: [RFC] Adding an OpenAL DLL thunk

2009-08-26 Thread Vitaliy Margolen
Vitaliy Margolen wrote: Chris Robinson wrote: Attached is a set of patches that adds an openal32.dll thunk, allowing an app using OpenAL to use the system's lib instead of Creative's software driver. The advantages of using the system lib include: Strange, doesn't compile here: Never

Re: dxdiag: add basic command line parsing

2009-08-26 Thread Austin English
On Wed, Aug 26, 2009 at 3:34 AM, Henri Verbeethverb...@gmail.com wrote: 2009/8/26 Austin English austinengl...@gmail.com: Based on Dan Kegel's patch he wrote for Louis Lenders old implementation. It probably doesn't make much of a difference for command line parsing, but I think you want to

Re: d3dx9: Implement converting and copying surface data in D3DXLoadSurfaceFromMemory (review please)

2009-08-26 Thread Henri Verbeet
2009/8/26 Tony Wasserka tony.wasse...@freenet.de: I hope the code is understandable in the other parts, my few main questions are: Do you agree that the architecture is the best approach or can you think of a better one? would using macros be legal here since it could really help reduce code

Re: wined3d: delete meaningless UNIX GL driver version parsing

2009-08-26 Thread Henri Verbeet
2009/8/26 joerg-cyril.hoe...@t-systems.com: Hi, Please excuse my previous patch. It was against 1.1.27. Here it is against 1.1.28. Ah, those were the times when I patched areas nobody else would touch ;-) This one does happen to apply, but please send patches against current git in the

Re: d3dx9: Implement converting and copying surface data in D3DXLoadSurfaceFromMemory (review please)

2009-08-26 Thread Philip Nilsson
On Wed, Aug 26, 2009 at 12:10:36PM +0200, Tony Wasserka wrote: +BYTE abits, rbits, gbits, bbits; +BYTE ashift, rshift, gshift, bshift; +DWORD amask, rmask, gmask, bmask; If you make those into arrays you will be able to cut down on the code size, and the compiler might like it

Re: Towards leveraging app build and unit tests as a way to test wine

2009-08-26 Thread Dan Kegel
On Tue, Aug 18, 2009 at 7:51 PM, Dan Kegeld...@kegel.com wrote: On Mon, Aug 10, 2009 at 1:42 AM, Dan Kegeld...@kegel.com wrote: Wine is far enough along that it ought to be able to build and run unit test suites from apps like Inkscape, Firefox, and OpenOffice ... Next step: grabbing firefox

Re: Towards leveraging app build and unit tests as a way to test wine

2009-08-26 Thread Austin English
On Wed, Aug 26, 2009 at 11:29 AM, Dan Kegeld...@kegel.com wrote: I'd like to add a new keyword in bugzilla for bugs that block running an automated build script.  appbuild, maybe? FWIW, I filed a bunch of bugs found while testing with Appinstall, and put (Appinstall) in the title. But a

Re: dxdiag: add basic command line parsing

2009-08-26 Thread Austin English
On Wed, Aug 26, 2009 at 9:43 AM, Austin Englishaustinengl...@gmail.com wrote: On Wed, Aug 26, 2009 at 3:34 AM, Henri Verbeethverb...@gmail.com wrote: 2009/8/26 Austin English austinengl...@gmail.com: Based on Dan Kegel's patch he wrote for Louis Lenders old implementation. It probably doesn't

Re: Towards leveraging app build and unit tests as a way to test wine

2009-08-26 Thread Dan Kegel
On Wed, Aug 26, 2009 at 9:41 AM, Austin Englishaustinengl...@gmail.com wrote: I'd like to add a new keyword in bugzilla for bugs that block running an automated build script.  appbuild, maybe? FWIW, I filed a bunch of bugs found while testing with Appinstall, and put (Appinstall) in the

new winetricks 20090826: new verbs vc2005express, psdk2003, mono24

2009-08-26 Thread Dan Kegel
Another fortnight, another winetricks. Main changes are: new verbs vc2005express, psdk2003, mono24 plus some bug fixes. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes since 20090815:

Re: dxdiag: add basic commandline parsing (try 2)

2009-08-26 Thread Jacek Caban
Hi Austin, Austin English wrote: Please apply after the first dxdiag patch (unicode-ify). Based on a patch by Dan Kegel. case 'w': +opt_given = TRUE; +while (isalpha(*s) || *s == ':') + You can't use isalpha on WCHAR. Use isalphaW instead. Jacek

Re: dxdiag: add basic commandline parsing (try 2)

2009-08-26 Thread Austin English
On Wed, Aug 26, 2009 at 3:26 PM, Jacek Cabanja...@codeweavers.com wrote: Hi Austin, Austin English wrote: Please apply after the first dxdiag patch (unicode-ify). Based on a patch by Dan Kegel.       case 'w': +            opt_given = TRUE; +            while (isalpha(*s) || *s == ':')

submitted AppDB links to bugzilla not working anymore?

2009-08-26 Thread Joerg-Cyril.Hoehle
Hi, Several recent link proposals between AppDB and Buzilla acknowledged by The bug link you submitted between Bug NNN and XYZ has been accepted. have nevertheless produced no visible bug # in AppDB nor Show Apps affected in Bugzilla. E.g. Bug #19773 among others. Did some recent changes to the

Re: mshtml: Make create_nsstream() static.

2009-08-26 Thread Jacek Caban
Hi Francois, It should be completely removed as it's not used anymore. Also nsIStringInputStream may be removed. I've sent a patch, thanks for catching it. Jacek

Re: configure: Detect and use tools executable extensions for makefiles.

2009-08-26 Thread Steven Edwards
On Wed, Aug 26, 2009 at 2:21 PM, Dylan Smithdylan.ah.sm...@gmail.com wrote: When compiling Wine on windows, the non-script tools will have an .exe extension, but the makefiles assumed that the tools never have an extention.  Naturally this caused problems with the build, causing it to fail on

Re: configure: Detect and use tools executable extensions for makefiles.

2009-08-26 Thread Dylan Smith
On Wed, Aug 26, 2009 at 5:26 PM, Steven Edwards winehac...@gmail.com wrote: I've never had a problem building most of Wine with cygwin or msys+mingw before. Is this new behaviour? What do you mean by most of Wine?  I am trying to easily build all of Wine from Windows. I was able to build the

Re: reg initial italian translation

2009-08-26 Thread James McKenzie
Davide Pizzetti wrote: Here's the initial italian translation for reg. Hope it works now If this were truly a new translation the input file would be a/dev/null This is not the case in your patches. Are you trying to update existing code? This goes for all of your initial translation

Re: [RFC] Adding an OpenAL DLL thunk

2009-08-26 Thread Vitaliy Margolen
Vitaliy Margolen wrote: Vitaliy Margolen wrote: Chris Robinson wrote: Attached is a set of patches that adds an openal32.dll thunk, allowing an app using OpenAL to use the system's lib instead of Creative's software driver. The advantages of using the system lib include: Strange,

Re: [RFC] Adding an OpenAL DLL thunk

2009-08-26 Thread Chris Robinson
On Wednesday 26 August 2009 9:27:42 pm Vitaliy Margolen wrote: Tested few games that had issues with native OpenAL from Creative (both windows dll and thunked old Linux version): STALKER SoC, STALKER CS, Psychonauts. So far so good! Great job. Thanks Chris, greatly appreciate your work on