Re: [PATCH 1/3] dpwsockx: Stub implementation

2009-08-29 Thread Stefan Dösinger
Yay, Dplay work! A few suggestions though: From patch 1: +static HRESULT WINAPI DPWSCB_GetCaps( LPDPSP_GETCAPSDATA data ) +{ +TRACE( (%d,%p,0x%08x,%p)\n, + data-idPlayer, data-lpCaps, data-dwFlags, data-lpISP ); +return DP_OK; +} Is there any reason this one writes a TRACE

Re: [PATCH 1/3] dpwsockx: Stub implementation

2009-08-29 Thread Ismael Barros²
On Sat, Aug 29, 2009 at 12:25 PM, Stefan Dösingerstefandoesin...@gmx.at wrote: Yay, Dplay work! A few suggestions though: From patch 1: +static HRESULT WINAPI DPWSCB_GetCaps( LPDPSP_GETCAPSDATA data ) +{ +    TRACE( (%d,%p,0x%08x,%p)\n, +           data-idPlayer, data-lpCaps, data-dwFlags,

Re: programs/clock: Corrected a small lexical error in the italian translation (Corrected)

2009-08-29 Thread Henri Verbeet
2009/8/29 Riccardo Loti con...@gmail.com: P.S.: For some reason the previous mail attachment showed up empty in the archives list, even if sent mail is correct, and using Thunderbird I prefer not to paste it int he message body. Sorry for double sending. The archives are a bit flawed, and

Re: include: Add missing definitions in af_irda.h. (try 2)

2009-08-29 Thread Alexandre Julliard
Thomas Trummer th.trum...@gmail.com writes: @@ -97,4 +100,159 @@ typedef struct _SOCKADDR_IRDA #define LmCharSetISO_8859_9 0x09 #define LmCharSetUNICODE0xff +#define SIO_LAZY_DISCOVERY _IOR('t', 127, ULONG) + +#define WINDOWS_AF_IRDA 26 +#define

Re: wordpad - initial italian translation

2009-08-29 Thread James Mckenzie
Here's the initial italian translation for wordpad. This is STILL WRONG! You are not listening. If this is an initial translation, the input file should be /dev/null, not en_US.rc which is what you are using. Please correct and resubmit. James McKenzie

Re: write initial italian translation

2009-08-29 Thread James Mckenzie
Here's the initial italian translation for write. Again, this is not acceptable. The input file should be /dev/null with the difference against your file. You are running a difference against the en_US.rc file after renaming it. Please correct and resubmit. This is the same problem that

Re: programs/clock: Corrected a small lexical error in the italian translation (Corrected)

2009-08-29 Thread James Mckenzie
Fixed a small typing error in the italian translation of clock.exe in the property menu label (Properietà - Proprietà). Compiled and tested correctly on Ubuntu 9.04 64bit. (My first patch I send, so please be kind for any error, I'll be happy to correct it if pointed to, thanks) P.S.: For

Re: PATCH[1/6] user32.dll:SwitchDesktop API Implementation

2009-08-29 Thread Mike Kaplinskiy
On Sat, Aug 29, 2009 at 1:51 AM, shanmukha sainath addepallisainath.addepa...@gmail.com wrote: Hi,    These are the series of patches for SwitchDesktop and OpenInputDesktop API implementation in user32.dll    SwitchDesktop API when called switches to another desktop and makes it

re: PATCH[1/6] user32.dll:SwitchDesktop API Implementation

2009-08-29 Thread Dan Kegel
It'd be cool if you mentioned what this patch series does for users. Does it fix some app that's broken? You probably need to include conformance tests for the new functions you implement. You may find that the maintainer is very picky about changes to wineserver. Don't be discouraged if your

Re: Weekly cppcheck run against Aug 27 Git Tree

2009-08-29 Thread James McKenzie
Juan Lang wrote: Changing these to single constant values would make it much harder for the casual observer to read. That's what comments are for. Actually, comments are for code that's not understandable without them. The code is more readable as it is, IMHO, than it would be