From: Reece Dunn
> Does anyone understand what these are doing and (in a general sense)
> what the changes to Vista are?
When you specify the MAP_FOLDCZONE flag, FoldStringW() on Vista will try to
return a "simple" presentation for the Unicode characters. For example, if you
pass in 0x01c7 ("LAT
Riccardo Loti wrote:
> Il Sat, 29 Aug 2009 11:56:46 -0700, James Mckenzie ha scritto:
>
>
>
>>> Fixed a small typing error in the italian translation of clock.exe in
>>> the property menu label (Properietà -> Proprietà). Compiled and tested
>>> correctly on Ubuntu 9.04 64bit.
>>>
>>> (My first p
2009/8/30 James McKenzie :
> Greg Geldorp wrote:
>> From: James McKenzie [mailto:jjmckenzi...@earthlink.net]
>>
>>> I would mark the tests broken for Vista and Windows7 but I would not
>>> eliminate them for Windows 2003 and lower. Right now, the conformance
>>> is to WindowsXP SP3. Do the tests
Greg Geldorp wrote:
> From: James McKenzie [mailto:jjmckenzi...@earthlink.net]
>
>> I would mark the tests broken for Vista and Windows7 but I would not
>> eliminate them for Windows 2003 and lower. Right now, the conformance
>> is to WindowsXP SP3. Do the tests work there?
>>
>
> There a
From: James McKenzie [mailto:jjmckenzi...@earthlink.net]
> I would mark the tests broken for Vista and Windows7 but I would not
> eliminate them for Windows 2003 and lower. Right now, the conformance
> is to WindowsXP SP3. Do the tests work there?
There are no failures at all on NT4/2000/XP/2003
Ge van Geldorp wrote:
> Now, it is possible to fix all those failures. However, doing so would
> require us to duplicate the tables that Microsoft uses. This is basically
> the same problem that we have with the collation tables. To work around
> this, I simply skip the test on Vista+, just like we
Henri Verbeet wrote:
> I suspect having branches at all inside the loop hurts, but just see
> what you can come up with.
>
I don't think that branching inside the loop is a bad thing, branching
outside of the loop might cause some serious issues if not handled properly.
James McKenzie
There are quite a few failures in kernel32:locale on Vista+. The attached
patch tries to address those. Although any comment on the patch is
welcome, I'm particularly interested in feedback on the changes to
test_FoldStringW() (the part that starts at "@@ -2081,43 +2136,49 @@
static void test_FoldS
2009/8/30 Tony Wasserka :
> Good point. Not sure whether that eliminates the need for both the
> 'if(DestFormat.bits[x])' AND 'if(SrcFormat.bits[x])', but I can merge
> them into one 'if' at least.
>
You'd need an AND mask for the DestFormat bits, but it's the same
basic principle.
>> As for the s
Il Sat, 29 Aug 2009 11:56:46 -0700, James Mckenzie ha scritto:
>>Fixed a small typing error in the italian translation of clock.exe in
>>the property menu label (Properietà -> Proprietà). Compiled and tested
>>correctly on Ubuntu 9.04 64bit.
>>
>>(My first patch I send, so please be kind for any
Hi,
> If you make those into arrays you will be able to cut down on the code size,
> and the compiler might like it better.
>
While I didn't notice any speedups in the code itself, it's a bit
cleaner (especially the format table) now, thanks!
(Come to think about it, it wouldn't have made much
Hi,
thanks for the feedback, I agree with most of what you said. Just a few
comments:
> I think the main thing is that you really don't want branches inside the
> inner loop. You can handle the cases where a component is unused
> by building a mask before entering the loop and just or'ing with th
12 matches
Mail list logo
