Missing libxml2 - msxml3 compilation error

2009-08-31 Thread Francois Gouget
It turns out I was missing libxml2 in one of my environments and this lead to the following compilation error: $ gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wwrite-strings -Wpointer-arith -g -O2 -o

Re: Missing libxml2 - msxml3 compilation error

2009-08-31 Thread Jacek Caban
Francois Gouget wrote: It turns out I was missing libxml2 in one of my environments and this lead to the following compilation error: $ gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wwrite-strings

Re: RFC: Fixing kernel32:locale tests on Vista and higher

2009-08-31 Thread Alexandre Julliard
Ge van Geldorp ggeld...@vmware.com writes: Now, it is possible to fix all those failures. However, doing so would require us to duplicate the tables that Microsoft uses. This is basically the same problem that we have with the collation tables. To work around this, I simply skip the test on

Re: d3dx9: Implement converting and copying surface data in D3DXLoadSurfaceFromMemory (review please)

2009-08-31 Thread Philip Nilsson
On Sun, Aug 30, 2009 at 12:56:26PM +0200, Tony Wasserka wrote: I think it would be better to store this in surface.c since I can't think of anything else that would need this. D3DXCheckTextureRequirements in texture.c will make use of the format table, since it also needs information

Re: d3dx9: Implement converting and copying surface data in D3DXLoadSurfaceFromMemory (review please)

2009-08-31 Thread Tony Wasserka
You are right, but it would be neat to have them all grouped like they are in d3dx9tex.h. Not sure about that, assuming we ever support all possible filters and conversions in D3DXLoadSurfaceFromMemory, we probably don't want to have the texture stuff starting suddenly at line 3k or

Re: programs/clock: Corrected a small lexical error in the italian translation (Corrected)

2009-08-31 Thread Riccardo Loti
Il Sun, 30 Aug 2009 15:23:40 -0700, James McKenzie ha scritto: Riccardo Loti wrote: Il Sat, 29 Aug 2009 11:56:46 -0700, James Mckenzie ha scritto: Fixed a small typing error in the italian translation of clock.exe in the property menu label (Properietà - Proprietà). Compiled and tested

Re: [PATCH] [Msvcrt]: fixing errno handling in strtol and strtoul (#18151)

2009-08-31 Thread Alexandre Julliard
Eric Pouech eric.pou...@orange.fr writes: @@ -250,3 +250,25 @@ int CDECL __STRINGTOLD( MSVCRT__LDOUBLE *value, char **endptr, const char *str, #endif return 0; } + +/** + * strtol (MSVCRT.@) + */ +long int

Re: msxml3: Add IDispatchEx support to IXMLDOMElement

2009-08-31 Thread Jacek Caban
Hi Alistair, Alistair Leslie-Hughes wrote: Hi, Changelog: msxml3: Add IDispatchEx support to IXMLDOMElement +static const tid_t domelem_iface_tids[] = { +IXMLDOMNode_tid, +IXMLDOMElement_tid, IXMLDOMElement inherits from IXMLDOMNode, so there is not need to add IXMLDOMNode

Re: [1/7] [try 2] mapi32: Add stub functions for loading/unloading MAPI providers

2009-08-31 Thread Henri Verbeet
2009/8/31 Owen Rudge oru...@codeweavers.com: +BOOL load_mapi_providers(); +void unload_mapi_providers(); That doesn't do what you think it does. Also, a return value isn't very useful if you're just going to ignore it.

Re: [4/7] [try 2] mapi32: Load and store MAPI function pointers after loading MAPI providers

2009-08-31 Thread Henri Verbeet
2009/8/31 Owen Rudge oru...@codeweavers.com: +mapiFunctions.MAPIAddress = (void*) get_mapi_function(MAPIAddress); That's redundant now. Since you load the pointers all at once, you don't need get_mapi_function() to do the NULL check on the module. You can just enclose the entire block in an

Re: [PATCH] [Msvcrt]: fixing errno handling in strtol and strtoul (#18151)

2009-08-31 Thread Eric Pouech
You can't simply use long here, you need to handle the difference in the size of long between Win32 and Unix. but that's what we currently do ! A+ -- Eric Pouech

Re: [PATCH] [Msvcrt]: fixing errno handling in strtol and strtoul (#18151)

2009-08-31 Thread Alexandre Julliard
Eric Pouech eric.pou...@orange.fr writes: You can't simply use long here, you need to handle the difference in the size of long between Win32 and Unix. but that's what we currently do ! A+ Sure, but that needs to be fixed. Since you are reimplementing it you should do it right. --

Re: [PATCH] [Msvcrt]: fixing errno handling in strtol and strtoul (#18151)

2009-08-31 Thread David Laight
On Mon, Aug 31, 2009 at 12:03:11PM +0200, Alexandre Julliard wrote: Eric Pouech eric.pou...@orange.fr writes: @@ -250,3 +250,25 @@ int CDECL __STRINGTOLD( MSVCRT__LDOUBLE *value, char **endptr, const char *str, #endif return 0; } +

What's wrong with my patch?

2009-08-31 Thread Jan de Mooij
Hello. Subject says it all. I suppose the tests I added may fail on other locales, but there is no other way to test my patch? Should i send it without the tests? Thanks in advance. Jan -- Forwarded message -- From: Jan de Mooij jandemo...@gmail.com Date: Mon, Aug 31, 2009 at

Re: What's wrong with my patch?

2009-08-31 Thread Juan Lang
Hi Jan, Subject says it all. Well, you haven't waited nearly long enough. Sending it in today and expecting it to be committed the same day is a bit much. --Juan

Re: What's wrong with my patch?

2009-08-31 Thread Andrew Eikum
Jan de Mooij wrote: Hello. Subject says it all. I suppose the tests I added may fail on other locales, but there is no other way to test my patch? Should i send it without the tests? Thanks in advance. Jan I can't speak much to the patch itself, but the patch file you attached has an

Re: What's wrong with my patch?

2009-08-31 Thread Jan de Mooij
On Mon, Aug 31, 2009 at 6:25 PM, Juan Langjuan.l...@gmail.com wrote: Well, you haven't waited nearly long enough.  Sending it in today and expecting it to be committed the same day is a bit much. I saw that AJ committed patches sent before and after my email, so I assumed he goes through them

Re: What's wrong with my patch?

2009-08-31 Thread Juan Lang
I saw that AJ committed patches sent before and after my email, so I assumed he goes through them in order. It also depends on whether your patch is obviously correct, and your Julliard rank. Since you're new around here, it's likely your patch will be subject to more scrutiny. Plus Andrew

Re: oleaut32: use WIC to decode JPEG images

2009-08-31 Thread Vincent Povirk
Of course it would probably help if I remembered to attach the patch. On Mon, Aug 31, 2009 at 5:08 PM, Vincent Povirkvinc...@codeweavers.com wrote: This needs an updated prefix to work. -- Vincent Povirk

Re: [PATCH] [WineDbg]: fix backend prototypes for PowerPC and Alpha

2009-08-31 Thread Austin English
On Mon, Aug 31, 2009 at 3:02 PM, Eric Pouecheric.pou...@orange.fr wrote: A+ ---  programs/winedbg/be_alpha.c |    8  programs/winedbg/be_ppc.c   |    8  2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/programs/winedbg/be_alpha.c

Re: programs/clock: Corrected a small lexical error in the italian translation (Corrected)

2009-08-31 Thread James McKenzie
Riccardo Loti wrote: Il Sun, 30 Aug 2009 15:23:40 -0700, James McKenzie ha scritto: Riccardo Loti wrote: Il Sat, 29 Aug 2009 11:56:46 -0700, James Mckenzie ha scritto: Fixed a small typing error in the italian translation of clock.exe in the property menu label

Re: shlwapi: Implement stubs for missing functions required by IE6

2009-08-31 Thread Dmitry Timoshkov
Owen Rudge oru...@codeweavers.com wrote: +HRESULT WINAPI IUnknown_UIActivateIO(IUnknown *lpUnknown, BOOL fActivate, LPMSG lpMsg) +HRESULT WINAPI SHCreatePropertyBagOnRegKey (HKEY hKey, LPCWSTR pszSubKey, +DWORD grfMode, REFIID riid, void **ppv) +HRESULT WINAPI