Re: Help with a native Windows test program needed (CreateFileW).

2009-09-11 Thread Markus Stockhausen
Am Samstag, den 12.09.2009, 01:39 +0200 schrieb Thomas Trummer: > Actually, forget about the password and give the file without > extension a .exe extension... > > 2009/9/12 Thomas Trummer > pw: wine > > 2009/9/11 Markus Stockhausen > > >

Re: Help with a native Windows test program needed (CreateFileW).

2009-09-11 Thread Thomas Trummer
Actually, forget about the password and give the file without extension a .exe extension... 2009/9/12 Thomas Trummer > pw: wine > > 2009/9/11 Markus Stockhausen > > Hi, >> >> as I have no Windows machine and cannot test this. I'm in need for >> someone who can build a small exe that gives furth

RE: Help with a native Windows test program needed (CreateFileW)

2009-09-11 Thread Greg Geldorp
Hi Markus, > From: Markus Stockhausen > > as I have no Windows machine and cannot test this: I'm in need for > someone who can build a small exe that gives further hints to my > observations in bug #9575. The following is needed: > > call CreateFileW( 'testfile.txt', ..., dwShareMode = 0, ...) >

Help with a native Windows test program needed (CreateFileW).

2009-09-11 Thread Markus Stockhausen
Hi, as I have no Windows machine and cannot test this. I'm in need for someone who can build a small exe that gives further hints to my observations in bug #9575. The following is needed: call CreateFileW( 'testfile.txt', ..., dwShareMode = 0, ...) call CreateFileW( 'testfile.txt', ..., dwShareM

Re: fixing ReadDirectoryChangesW()

2009-09-11 Thread Mike Kaplinskiy
On Fri, Sep 11, 2009 at 5:42 PM, Dan Kegel wrote: > Michael Pujos wrote: >> I'm willing to resubmit this patch with updated tests >> against current Wine, but before I procceed >> I need to be sure it won't be rejected simply because it changes the >> protocol. > > Server changes are tricky to ge

Re: RFC: registry keys of serial ports

2009-09-11 Thread Christian Gmeiner
2009/9/11 Stefan Leichter : > Am Friday 11 September 2009 12:30:01 schrieb Christian Gmeiner: >> Hi Stefan, >> >> I like the idea of adding more registry keys for hardware components. >> I want some registry keys for usb devices >> so I had a look at your patch. I don't like the mess with the added

re: fixing ReadDirectoryChangesW()

2009-09-11 Thread Dan Kegel
Michael Pujos wrote: > I'm willing to resubmit this patch with updated tests > against current Wine, but before I procceed > I need to be sure it won't be rejected simply because it changes the protocol. Server changes are tricky to get in. You have to be patient and persistent. I think your best

Re: Help with a native Windows test program needed (CreateFileW)

2009-09-11 Thread Nikolay Sivov
Markus Stockhausen wrote: Hi, as I have no Windows machine and cannot test this: I'm in need for someone who can build a small exe that gives further hints to my observations in bug #9575. The following is needed: call CreateFileW( 'testfile.txt', ..., dwShareMode = 0, ...) call CreateFileW( 't

Help with a native Windows test program needed (CreateFileW)

2009-09-11 Thread Markus Stockhausen
Hi, as I have no Windows machine and cannot test this: I'm in need for someone who can build a small exe that gives further hints to my observations in bug #9575. The following is needed: call CreateFileW( 'testfile.txt', ..., dwShareMode = 0, ...) call CreateFileW( 'testfile.txt', ..., dwShareMo

Re: RFC: registry keys of serial ports

2009-09-11 Thread Stefan Leichter
Am Friday 11 September 2009 12:30:01 schrieb Christian Gmeiner: > Hi Stefan, > > I like the idea of adding more registry keys for hardware components. > I want some registry keys for usb devices > so I had a look at your patch. I don't like the mess with the added > goto serial. If in future there

Re: bitblt.c - GdiAlphaBlend : Check for NULL Pointer

2009-09-11 Thread Markus Stockhausen
Am Freitag, den 11.09.2009, 09:04 +0200 schrieb Paul Vriens: > Hi Markus, > > One I see is a style issue with the if statement. There shouldn't be a > space after the opening and before the closing bracket. > > Another thing (style again) is that maybe it's nicer to return FALSE > instead of re

fixing ReadDirectoryChangesW()

2009-09-11 Thread Michael Pujos
A few months ago I wrote a patch that addressed the following issues with ReadDirectoryChangesW(): "1. move and rename of files and directories in a monitored directory are not notified 2. the current implementation allow to only get one change (FILE_NOTIFY_INFORMATION structure) at a time. N

Re: [PATCH 2/4] mshtml: Added http loading test.

2009-09-11 Thread Jacek Caban
Hi Paul, Paul Vriens wrote: On 09/02/2009 12:27 PM, Jacek Caban wrote: --- dlls/mshtml/tests/htmldoc.c | 270 +-- 1 files changed, 182 insertions(+), 88 deletions(-) Hi Jacek,

Re: now OSS driver emulation -- and other drivers too -- works as well as OSS HW mode; block size error gone?

2009-09-11 Thread Joerg-Cyril.Hoehle
Juan Lang wrote: >> - Is there some central place in dsound for enforcing the >>invariant instead of identical code in the half dozen >>OSS/ALSA/CoreAudio/Jack etc. drivers? >No, or, not to my knowledge. This is unfortunate. Wine's dsound needs a channel back from winmm (which eventually calls wi

Re: [ntdll] Add tests for NtQueryInformationFile

2009-09-11 Thread Paul Vriens
On 09/10/2009 10:49 PM, Dan Kegel wrote: On Thu, Sep 10, 2009 at 1:35 PM, Paul Vriens wrote: Passes on both Wine and Vista. This patch introduces some issues on NT4 and higher. Attached patch fixes it but I'm not sure if you are already chasing these failures. Weird that it doesn't fail on yo

Re: [ntdll] Add tests for NtQueryInformationFile

2009-09-11 Thread Dan Kegel
On Thu, Sep 10, 2009 at 1:37 PM, Paul Vriens wrote: >> It also looks like Vista/Win7 has either 2 or 4 failures (most likely >> related to indexing being disabled, if so that could also happen on >> other platforms). Not sure if we should explicitly check for attributes >> being 2020, ignore FILE_

Re: Mirror Space

2009-09-11 Thread Vitaliy Margolen
Scott Ritchie wrote: > It should be up for good now, so this won't be necessary. It should but it isn't ... again. Were you able to setup mirror yet? Vitaliy.

Fixing the user32/dde tests on Win9x/WinMe

2009-09-11 Thread Paul Vriens
Hi, DdeInitializeW is not implemented on the mentioned platforms but it's not just a matter of skipping some tests when that W-function is found to be not implemented. Any idea what the best way would be to fix these tests? -- Cheers, Paul.

Re: [PATCH 2/3] winex11.drv: set global key state

2009-09-11 Thread Alexandre Julliard
Rafał Miłecki writes: > @@ -1250,6 +1250,21 @@ void X11DRV_send_keyboard_input( WORD wVk, WORD wScan, > DWORD event_flags, DWORD > key_state_table[wVkStripped] = key_state_table[wVkL] | > key_state_table[wVkR]; > } > > +SERVER_START_REQ( set_global_key_state ) >

Re: RFC: registry keys of serial ports

2009-09-11 Thread Christian Gmeiner
Hi Stefan, I like the idea of adding more registry keys for hardware components. I want some registry keys for usb devices so I had a look at your patch. I don't like the mess with the added goto serial. If in future there will be support for usb and the whole source will be quite hard to follow.

Re: registry keys of serial ports

2009-09-11 Thread Stefan Leichter
Hello Dmitry, Thank You for your review, but Am Friday 11 September 2009 10:31:14 schrieb Dmitry Timoshkov: > "Stefan Leichter" wrote: > > i like to know what modifikations the attached patch needs to go into > > git. > > 1. patch needs to be created with git Next time you will tell me what edit

Re: registry keys of serial ports

2009-09-11 Thread Dmitry Timoshkov
"Stefan Leichter" wrote: i like to know what modifikations the attached patch needs to go into git. 1. patch needs to be created with git 2. there is no need to create a new file @@ -175,6 +180,16 @@ p_libhal_device_add_property_watch( ctx, udi, &error ); } else if (guid_

RFC: registry keys of serial ports

2009-09-11 Thread Stefan Leichter
Hi, i like to know what modifikations the attached patch needs to go into git. More things need to be done in this area. I know of: - more registry keys [1] - remove the registry keys when a serial port disappears (USB) - the links in the dosdevice directory needs to be created Patches for the i

Re: bitblt.c - GdiAlphaBlend : Check for NULL Pointer

2009-09-11 Thread Paul Vriens
On 09/11/2009 09:13 AM, Markus Stockhausen wrote: Am Freitag, den 11.09.2009, 09:04 +0200 schrieb Paul Vriens: Hi Markus, One I see is a style issue with the if statement. There shouldn't be a space after the opening and before the closing bracket. Another thing (style again) is that maybe it'

Re: bitblt.c - GdiAlphaBlend : Check for NULL Pointer

2009-09-11 Thread Paul Vriens
On 09/11/2009 12:47 AM, Markus Stockhausen wrote: Am Freitag, den 11.09.2009, 01:56 +0400 schrieb Nikolay Sivov: Just correct your patch (as you mentioned before), include simple testcase and resend. So nothing to wait for. Basic test shows it doesn't crash on Windows and doesn't change last er