Re: Wine in Tango

2009-09-20 Thread Scott Ritchie
King InuYasha wrote: > On Sat, Sep 19, 2009 at 2:55 PM, Joel > Holdsworth > wrote: > > shortcut.ico - the icon is oriented improperly. It needs to be > > bottom-left and oriented so the arrow points towards the center. > > This is the orientation from

Re: cppcheck Sept 18

2009-09-20 Thread Ben Klein
2009/9/21 James Mckenzie : > > > -Original Message- >>From: Henri Verbeet >>Sent: Sep 20, 2009 12:19 PM >>To: Pauli Nieminen >>Cc: wine-devel@winehq.org, Joris Huizer >>Subject: Re: cppcheck Sept 18 >> >>Not quite. For one, the ca[5] that's being used here isn't the local >>variable ca[5

Re: cppcheck Sept 18

2009-09-20 Thread James Mckenzie
-Original Message- >From: Henri Verbeet >Sent: Sep 20, 2009 12:19 PM >To: Pauli Nieminen >Cc: wine-devel@winehq.org, Joris Huizer >Subject: Re: cppcheck Sept 18 > >2009/9/20 Pauli Nieminen >> >> On Sat, Sep 19, 2009 at 1:59 PM, Joris Huizer wrote: >>> >>> [/home/cahrendt/wine-git/dll

Re: [PATCH 4/6] d3d9: Limit "NumSimultaneousRTs" to 4.

2009-09-20 Thread Stefan Dösinger
Am Sunday 20 September 2009 20:09:25 schrieb Henri Verbeet: > pCaps->MaxVertexShaderConst = min(D3D9_MAX_VERTEX_SHADER_CONSTANTF, > pCaps->MaxVertexShaderConst); +pCaps->NumSimultaneousRTs = > min(D3D9_MAX_SIMULTANEOUS_RENDERTARGETS, pCaps->NumSimultaneousRTs); } I think you also have to m

Re: cppcheck Sept 18

2009-09-20 Thread Henri Verbeet
2009/9/20 Pauli Nieminen > > On Sat, Sep 19, 2009 at 1:59 PM, Joris Huizer wrote: >> >> [/home/cahrendt/wine-git/dlls/rpcrt4/tests/server.c:1189]: (possible >> error) Array index out of bounds >> >> This one is a false positive, it uses FIELD_OFFSET(cs_t, ca[5]), >> and it found an array: >> int

Re: dlls/comctl32/tests/tab.c: Transform CheckSize from a macro to a function.

2009-09-20 Thread Nikolay Sivov
Gerald Pfeifer wrote: This not only avoids a 12+ line macro, it also sheds a couple of compiler warnings with GCC 4.4 (though not the forthcoming 4.5). Gerald ChangeLog: Transform CheckSize from a macro to a function. Hi, Gerald. This patch breaks line trace for tests. You should pass __L

Re: cppcheck Sept 18

2009-09-20 Thread James Mckenzie
>[/home/cahrendt/wine-git/dlls/rpcrt4/tests/server.c:1189]: (possible >error) Array index out of bounds > >This one is a false positive, it uses FIELD_OFFSET(cs_t, ca[5]), >and it found an array: >int ca[5]; > Actually, if this is a zero offset array, this is out of bounds. It might be better t

Re: cppcheck Sept 18

2009-09-20 Thread Pauli Nieminen
On Sat, Sep 19, 2009 at 1:59 PM, Joris Huizer wrote: > [/home/cahrendt/wine-git/dlls/rpcrt4/tests/server.c:1189]: (possible > error) Array index out of bounds > > This one is a false positive, it uses FIELD_OFFSET(cs_t, ca[5]), > and it found an array: > int ca[5]; > > int ca[5]; has only entries

Re: cppcheck Sept 18

2009-09-20 Thread Nicolas Le Cam
2009/9/19 Joris Huizer > [/home/cahrendt/wine-git/dlls/wineps.drv/init.c:270]: (error) Possible > null pointer dereference: dmW - otherwise it is redundant to check if > dmW is null at line 272 > > That is a bug, sent a patch > > HTH, > > Joris > Joris, As explained in a previous mail, there's no

cppcheck Sept 18

2009-09-20 Thread Joris Huizer
[/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd These two are false positives, as the process ends (calling exit(1) [/home/cahrendt/wine-git/dlls/rpcrt4/tests/server.c:1189]: (possible