Re: [PATCH 1/4] comctl32/tooltips: Fix an obviously wrong structure size check

2009-10-14 Thread Paul Vriens
On 10/15/2009 07:54 AM, Paul Vriens wrote: On 10/15/2009 01:36 AM, Nikolay Sivov wrote: Changelog: - fix an obviously wrong structure size check Hi Nikolay, +static void test_ttm_gettoolinfo(void) +{ + TTTOOLINFOA ti; + TTTOOLINFOW tiW; + HWND hwnd; + DWORD r; + + hwnd = CreateWindowExA(0,

Re: [PATCH 2/4] comctl32/tooltips: Test the way structure size field is validated

2009-10-14 Thread Paul Vriens
On 10/15/2009 01:36 AM, Nikolay Sivov wrote: Changelog: - test the way structure size field is validated Hi Nikolay, Some more W-calls that won't suceed on Win9x/WinMe in the added tests. -- Cheers, Paul.

Re: [PATCH 1/4] comctl32/tooltips: Fix an obviously wrong structure size check

2009-10-14 Thread Paul Vriens
On 10/15/2009 01:36 AM, Nikolay Sivov wrote: Changelog: - fix an obviously wrong structure size check Hi Nikolay, +static void test_ttm_gettoolinfo(void) +{ +TTTOOLINFOA ti; +TTTOOLINFOW tiW; +HWND hwnd; +DWORD r; + +hwnd = CreateWindowExA(0, TOOLTIPS_CLASSA, NULL, 0

Re: [Fwd: [Bug 20285] cmd.exe does not treat tabs as parameter delimiters]

2009-10-14 Thread Juan Lang
Hi Colin, > As requested by Austin, I'm forwarding this patch to > wine-patches at winehq.org. Please see the bug report for a test case. You just forwarded the wine-bugs email. This isn't the same as sending the patch. You must include the patch in your email. See http://wiki.winehq.org/Submi

Re: Help me get a patch into Wine -> Mac cdrom issue

2009-10-14 Thread Juan Lang
> I know. I have patches for all that. Did I not just write an email back > to Roderick talking about the SCSITaskDevice? Easy now. I didn't get your reply to Roderick until after Emmanuel's response. Not only that, but with pretty large differences in time zone, it's normal to have delayed resp

Re: Help me get a patch into Wine -> Mac cdrom issue

2009-10-14 Thread Charles Davis
Emmanuel Maillard wrote: > Hi, > > For peoples interested with cd-rom support on Mac OS X, i think that you > need to investigated in IOKit, > especially in SCSITaskDeviceInterface and MMCDeviceInterface. > > Emmanuel I know. I have patches for all that. Did I not just write an email back to Rode

Re: Mac cdrom issue

2009-10-14 Thread Charles Davis
Roderick Colenbrander wrote: > Hi, > > I don't know much about the cd-rom stuff on osx but I expect there are > much more issues of which some are more severe than this (and the > solution might fix all the issues). I believe that on osx there is no > such thing as direct cd-rom access (anymore) a

Re: Mac cdrom issue (was: Help me get a patch into Wine)

2009-10-14 Thread Charles Davis
joerg-cyril.hoe...@t-systems.com wrote: > Chip, > > I had hoped that your patch would allow mcicda to work, > cf. bug #20323, alas it is not so. Instead I get to see > > ERR("This version of Mac OS X does not support IOCDAudioControl" > on Leopard. > > I googled slightly and found a message fro

Re: secur32: check for variable before freeing it

2009-10-14 Thread Austin English
On Wed, Oct 14, 2009 at 4:07 AM, Henri Verbeet wrote: > 2009/10/14 Austin English : >> >> static void *schan_free_handle(ULONG_PTR handle_idx, enum >> schan_handle_type type) >> { >>    struct schan_handle *handle; >>    void *object; >> >>    if (handle_idx == SCHAN_INVALID_HANDLE) return NULL; >

Re: Help me get a patch into Wine -> Mac cdrom issue

2009-10-14 Thread Emmanuel Maillard
Hi, For peoples interested with cd-rom support on Mac OS X, i think that you need to investigated in IOKit, especially in SCSITaskDeviceInterface and MMCDeviceInterface. Emmanuel Le 14 oct. 2009 à 17:50, Roderick Colenbrander a écrit : Hi, I don't know much about the cd-rom stuff on osx

Locale related test request on Win7

2009-10-14 Thread Nikolay Sivov
Hi. Could anyone with Win7 access run this for me and send a log back? This test requires Russian localization support to be installed. Thanks. diff --git a/dlls/kernel32/tests/locale.c b/dlls/kernel32/tests/locale.c index fe54907..27da991 100644 --- a/dlls/kernel32/tests/locale.c +++ b/dlls/ker

Re: Help me get a patch into Wine -> Mac cdrom issue

2009-10-14 Thread Roderick Colenbrander
Hi, I don't know much about the cd-rom stuff on osx but I expect there are much more issues of which some are more severe than this (and the solution might fix all the issues). I believe that on osx there is no such thing as direct cd-rom access (anymore) and due to this I think wine can't read au

Help me get a patch into Wine -> Mac cdrom issue

2009-10-14 Thread Joerg-Cyril.Hoehle
Chip, I had hoped that your patch would allow mcicda to work, cf. bug #20323, alas it is not so. Instead I get to see ERR("This version of Mac OS X does not support IOCDAudioControl" on Leopard. I googled slightly and found a message from 2004: http://lists.apple.com/archives/darwin-drivers/200

Re: [1/3] (resend) mshtml: Add test suite for IHTMLLocation

2009-10-14 Thread Alexandre Julliard
"Andrew Eikum" writes: > +if(hres == S_OK){ > +if(test->hostname_ok) > +ok(str_eq_wa(str, test->hostname), "%s: expected retrieved > hostname to be L\"%s\", was: %s\n", test->name, test->hostname, > wine_dbgstr_w(str)); > +else > +todo_wine ok(str_eq_

Re: [1/10] Check for ms_hook_prologue attribute support, make a first function hookable

2009-10-14 Thread Stefan Dösinger
Am 14.10.2009 um 05:42 schrieb Dmitry Timoshkov: "Stefan Dösinger" wrote: -HRESULT WINAPI DirectInput8Create(HINSTANCE hinst, DWORD dwVersion, REFIID riid, LPVOID *ppDI, LPUNKNOWN punkOuter) { +HRESULT WINAPI DECLSPEC_HOTPATCH DirectInput8Create(HINSTANCE hinst, DWORD dwVersion, REFIID ri

Re: [4/10] OpenGL32: Give wglSwapBuffer a real function, make it hookable

2009-10-14 Thread Stefan Dösinger
Am 14.10.2009 um 01:44 schrieb Roderick Colenbrander: You should also patch make_opengl because openg32.spec is automatically generated. Ooops, I'll resend. This shouldn't break patches 5-10 though. Just skip this one for now.

Re: secur32: check for variable before freeing it

2009-10-14 Thread Henri Verbeet
2009/10/14 Austin English : > > static void *schan_free_handle(ULONG_PTR handle_idx, enum > schan_handle_type type) > { >    struct schan_handle *handle; >    void *object; > >    if (handle_idx == SCHAN_INVALID_HANDLE) return NULL; >    if (handle_idx >= schan_handle_count) return NULL; > > Seems