Re: winmm/tests: Don't complain for Wine drivers that allow multiple wave-out opens.

2009-10-16 Thread Paul Vriens
On 10/16/2009 02:19 AM, Ken Thomases wrote: -todo_wine ok(ret == MMSYSERR_NOERROR || broken(ret == MMSYSERR_ALLOCATED), /* winME */ - waveOutOpen returns: %x\n, ret); -if (ret == MMSYSERR_NOERROR) +if (ret != MMSYSERR_NOERROR) +{ +todo_wine ok(ret ==

Re: winmm/tests: Don't complain for Wine drivers that allow multiple wave-out opens.

2009-10-16 Thread Ken Thomases
On Oct 16, 2009, at 2:09 AM, Paul Vriens wrote: On 10/16/2009 02:19 AM, Ken Thomases wrote: -todo_wine ok(ret == MMSYSERR_NOERROR || broken(ret == MMSYSERR_ALLOCATED), /* winME */ - waveOutOpen returns: %x\n, ret); -if (ret == MMSYSERR_NOERROR) +if (ret !=

Re: [1/2] oleaut32/tests: Testcase for IPicture_Render with icons, check for drawing size and position

2009-10-16 Thread Paul Vriens
On 10/14/2009 07:08 PM, Wilfried Pasquazzo wrote: Yet another testcase+fix for a regression introduced by one of my previous patches. --- [1/2] oleaut32/tests: ... modified files: oleaut32/tests/olepicture.c Draws a icon and checks if it is scaled and positioned correctly. Windows XP passes

Re: winspool/tests: [Patch 3] Add tests for EnumPrintProcessors

2009-10-16 Thread Paul Vriens
On 10/14/2009 11:56 PM, Detlef Riekenberg wrote: Hi Detlef, This one introduces a test failure on NT4 (all?) Could you have a look? -- Cheers, Paul.

Re: winmm/tests: Don't complain for Wine drivers that allow multiple wave-out opens.

2009-10-16 Thread Paul Vriens
On 10/16/2009 09:43 AM, Ken Thomases wrote: On Oct 16, 2009, at 2:09 AM, Paul Vriens wrote: On 10/16/2009 02:19 AM, Ken Thomases wrote: - todo_wine ok(ret == MMSYSERR_NOERROR || broken(ret == MMSYSERR_ALLOCATED), /* winME */ - waveOutOpen returns: %x\n, ret); - if (ret == MMSYSERR_NOERROR) +

Re: winmm/tests: Don't complain for Wine drivers that allow multiple wave-out opens.

2009-10-16 Thread Alexandre Julliard
Ken Thomases k...@codeweavers.com writes: On Oct 16, 2009, at 2:09 AM, Paul Vriens wrote: On 10/16/2009 02:19 AM, Ken Thomases wrote: -todo_wine ok(ret == MMSYSERR_NOERROR || broken(ret == MMSYSERR_ALLOCATED), /* winME */ - waveOutOpen returns: %x\n, ret); -if (ret

Re: DirectX Emulation Question

2009-10-16 Thread Roderick Colenbrander
It might work for some basic tasks but it is mostly incomplete. Roderick On Friday, October 16, 2009, Paul Janoski pjano...@janotech.com wrote: Can anybody please tell me how complete the DirectMusic wine emulation is on Linux. Thank You, Paul Janoski

Re: winmm/tests: Don't complain for Wine drivers that allow multiple wave-out opens.

2009-10-16 Thread Ken Thomases
On Oct 16, 2009, at 3:46 AM, Alexandre Julliard wrote: Ken Thomases k...@codeweavers.com writes: On Oct 16, 2009, at 2:09 AM, Paul Vriens wrote: On 10/16/2009 02:19 AM, Ken Thomases wrote: -todo_wine ok(ret == MMSYSERR_NOERROR || broken(ret == MMSYSERR_ALLOCATED), /* winME */ -

DirectMusic emulation (Was: DirectX Emulation Question)

2009-10-16 Thread Saulius Krasuckas
* On Thu, 15 Oct 2009, Paul Janoski wrote: Can anybody please tell me how complete the DirectMusic wine emulation is on Linux. The main contributor seems to be Rok Mandeljc (judging from the filtered output of git-blame): $ time (for fn in dlls/dm*/*.c dlls/dswave/*.c; do \ git-blame

Re: Betamax VoIP programs - a new try

2009-10-16 Thread Juan Lang
Hi Pavel,  Is there a chance to find, what's fatal for the logon process, eventually to make a quick-and-dirty fix? No. Sometimes the fixme doesn't even say what's wrong. It can be a hint, that's all. I see lots of shdocvw messages, so I'd try overriding that first. There was also this

Re: winmm/tests: Don't complain for Wine drivers that allow multiple wave-out opens. (try 2)

2009-10-16 Thread Allan Tong
-todo_wine ok(ret == MMSYSERR_NOERROR || broken(ret == MMSYSERR_ALLOCATED), /* winME */ - waveOutOpen returns: %x\n, ret); -if (ret == MMSYSERR_NOERROR) +if (ret != MMSYSERR_NOERROR) +{ +todo_wine ok(ret == MMSYSERR_NOERROR || broken(ret ==

Re: comctl32: Ensure listview control has focus when marquee dragging

2009-10-16 Thread Nikolay Sivov
Owen Rudge wrote: This patch fixes an issue whereby a selection marquee would not function correctly when the listview hadn't first been clicked on. --- dlls/comctl32/listview.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) @@ -3631,6 +3631,9 @@ static LRESULT

Re: comctl32: Ensure listview control has focus when marquee dragging

2009-10-16 Thread Owen Rudge
Hi Nikolay, This doesn't look right. Try with ControlSpy and you'll see WM_SETFOCUS sent just after LButton pressed on client area (not on item, that's important). LButtonUp event used to set focus item was under mouse pointer and it's released without any mouse movements (or maybe drag

Re: comctl32: Ensure listview control has focus when marquee dragging

2009-10-16 Thread Nikolay Sivov
Owen Rudge wrote: Hi Nikolay, This doesn't look right. Try with ControlSpy and you'll see WM_SETFOCUS sent just after LButton pressed on client area (not on item, that's important). LButtonUp event used to set focus item was under mouse pointer and it's released without any mouse movements

Re: [1/2] oleaut32/tests: Testcase for IPicture_Render with icons, check for drawing size and position

2009-10-16 Thread Wilfried Pasquazzo
2009/10/16 Paul Vriens paul.vriens.w...@gmail.com: On 10/14/2009 07:08 PM, Wilfried Pasquazzo wrote: Yet another testcase+fix for a regression introduced by one of my previous patches. --- [1/2] oleaut32/tests: ... modified files: oleaut32/tests/olepicture.c Draws a icon and checks if

Re: [1/1]oleaut32: Fix Testcases on NT4 and lower

2009-10-16 Thread Nikolay Sivov
Wilfried Pasquazzo wrote: A fix for my testcases of IPicture_Render method. affected files: oleaut32/tests/olepicture.c On older OS than Win2000 the testcase produces different results. The method IPicture_Render isn't officially supported on those old OS, therefore I just used the broken()

Re: [PATCH 1/2] mshtml: Reimplement IHTMLLocation::get_href

2009-10-16 Thread Jacek Caban
Hi Andrew, Andrew Eikum wrote: --- dlls/mshtml/htmllocation.c | 93 +++-- dlls/mshtml/tests/htmllocation.c |4 +- 2 files changed, 90 insertions(+), 7 deletions(-) What's IHTMLDocument2::URL value in these cases? I'd expect it to be the same,

Re: [PATCH 2/2] mshtml: Reimplement HTMLLocation::get_pathname

2009-10-16 Thread Jacek Caban
Andrew Eikum wrote: --- dlls/mshtml/htmllocation.c | 27 ++- dlls/mshtml/tests/htmllocation.c |8 2 files changed, 10 insertions(+), 25 deletions(-) -hres = CoInternetParseUrl(doc_url, PARSE_PATH_FROM_URL, 0, buf, sizeof(buf), size, 0);

Re: [PATCH 1/2] mshtml: Reimplement IHTMLLocation::get_href

2009-10-16 Thread Andrew Eikum
Jacek Caban wrote: Hi Andrew, Andrew Eikum wrote: --- dlls/mshtml/htmllocation.c | 93 +++-- dlls/mshtml/tests/htmllocation.c |4 +- 2 files changed, 90 insertions(+), 7 deletions(-) What's IHTMLDocument2::URL value in these cases? I'd expect it

Re: [PATCH 2/2] mshtml: Reimplement HTMLLocation::get_pathname

2009-10-16 Thread Andrew Eikum
Jacek Caban wrote: -hres = CoInternetParseUrl(doc_url, PARSE_PATH_FROM_URL, 0, buf, sizeof(buf), size, 0); Please don't remove it. Using pluggable protocol has a visible on application and I've tested that it really should be called when I implemented it (altaught there is no test for it

Re: [PATCH 1/2] mshtml: Reimplement IHTMLLocation::get_href

2009-10-16 Thread Jacek Caban
Andrew Eikum wrote: Jacek Caban wrote: Hi Andrew, Andrew Eikum wrote: --- dlls/mshtml/htmllocation.c | 93 +++-- dlls/mshtml/tests/htmllocation.c |4 +- 2 files changed, 90 insertions(+), 7 deletions(-) What's IHTMLDocument2::URL value in these

Re: [PATCH 2/2] mshtml: Reimplement HTMLLocation::get_pathname

2009-10-16 Thread Jacek Caban
Andrew Eikum wrote: Jacek Caban wrote: -hres = CoInternetParseUrl(doc_url, PARSE_PATH_FROM_URL, 0, buf, sizeof(buf), size, 0); Please don't remove it. Using pluggable protocol has a visible on application and I've tested that it really should be called when I implemented it (altaught

SCSITaskDevice vs our own driver

2009-10-16 Thread Charles Davis
Hi, Eventually, I want to implement IOCTL_SCSI_PASS_THOROUGH on Mac OS. The way I see it, there are two ways to do this: 1. Use the SCSITaskDevice interface. This is a CFPlugIn object provided by the driver (it's like a COM object). We have to get exclusive access (this requires all the handles

Re: search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one?

2009-10-16 Thread Jeremy White
I think we never pursued the question Dan posed in this subject line. That is, Powerpoint 2007 makes the following call: Call KERNEL32.LoadLibraryA(0033c0a8 C:\\Program Files\\Common Files\\Microsoft Shared\\office12\\riched20.dll) It's clearly trying to load it's private dll. Instead of

Re: search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one?

2009-10-16 Thread Dan Kegel
I think your approach is peachy, but Alexandre wanted a version check; look at his most recent post in this thread: ... The version of the native dll, compared to the builtin. I could imagine a heuristic where if the major version of native is higher than builtin you default to native or

Re: Towards leveraging app build and unit tests as a way to test wine

2009-10-16 Thread Dan Kegel
On Wed, Aug 26, 2009 at 9:29 AM, Dan Kegel d...@kegel.com wrote: Wine is far enough along that it ought to be able to build and run unit test suites from apps like Inkscape, Firefox, and OpenOffice ... Next step: grabbing firefox source and building. I've collected some of this info in

Re: Towards leveraging app build and unit tests as a way to test wine

2009-10-16 Thread Austin English
On Sat, Oct 17, 2009 at 12:12 AM, Dan Kegel d...@kegel.com wrote: If anyone's interested, I can provide precompiled versions of more of Chromium's test suite.  Finding Wine bugs with these isn't quite like shooting fish in a barrel, but it's close :-) Actually, I've been CC'ing myself on those