Re: Debug help needed : Unhandled page fault on read access to 0xffffffff]

2009-10-28 Thread Vitaliy Margolen
André Hentschel wrote: > Have a look at: http://wiki.winehq.org/Backtraces > That should make clear that you need to build your own wine first to get > debug symbols. It won't help much with 16-bit code... Winedbg always had issues with it. Vitaliy.

Re: [1/2] shell32/tests: Program Manager DDE Conformance Tests

2009-10-28 Thread Vitaliy Margolen
Mike wrote: > Vitaliy, > > Thanks for the quick feedback. I'll make the changes you've suggested and > repost, probably next week. A couple quick questions about your comments: > > Indentation: >> Tabs should always be set to 8 spaces, not 4. For Wine >> please use 4-space >> indentations, no tab

Re: for the record, my ole32 binary tree search patch is correct

2009-10-28 Thread Yuriy Kaminskiy
On 28.10.2009 20:30, Vincent Povirk wrote: >> If I've not mistaken, that uses lstricmp internally for comparing keys. > > It uses lstrcmpiW, which according to MSDN can behave differently > based on locale, but I don't think the Wine version does. Note, that, it is not only difference in >0x7f "n

kernel32: add more tests for FormatMessage{A,W}

2009-10-28 Thread Louis Lenders
>FormatMessage uses the same backend to find the requested resource as >FindResource does, so I'd guess that they both fail in the same way >when a resource id or a language does not exist in the module. I still fail to see how I can call FindResource for a missing message-id. In the end they

Re: [PATCH 01/12] d3d10: Fix a HeapFree() in d3d10_effect_Release().

2009-10-28 Thread Rico Schüller
Am 28.10.2009 12:38, schrieb Stefan Dösinger: Am 28.10.2009 um 11:43 schrieb Henri Verbeet: The patches are correct, I wrote tests for this for commits 508635ac4c290b00bd2aa97026e627a50d3c4cee, 58fcb06c07cbe4fd9cd94dc138d625cf08b82fb7 and fbbbdc09a591d7e8deae3830400ac7ad1d2fca8e. I didn't submi

Re: for the record, my ole32 binary tree search patch is correct

2009-10-28 Thread Vincent Povirk
> If I've not mistaken, that uses lstricmp internally for comparing keys. It uses lstrcmpiW, which according to MSDN can behave differently based on locale, but I don't think the Wine version does. The comparison is in the propertyNameCmp function. I think that the MS storage code probably does

Re: Debug help needed : Unhandled page fault on read access to 0xffffffff]

2009-10-28 Thread André Hentschel
Philippe De Muyter schrieb: > Hello Alexandre, > > It's a long time now since my last contrib to the wine project (1997), > and I try to run a proprietary W31/W95 program without any success : > > It fails immediately with : > > wine: Unhandled page fault on read access to 0x at address

CPPcheck October 27 Git

2009-10-28 Thread chris ahrendt
Current Leaks: [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd [/home/cahrendt/wine-git/dlls/winex11.drv/xfont.c:2963]: (possible error) Resource leak: fd Tool Leaks: [/home/cahrendt/wi

Debug help needed : Unhandled page fault on read access to 0xffffffff]

2009-10-28 Thread Philippe De Muyter
Hello Alexandre, It's a long time now since my last contrib to the wine project (1997), and I try to run a proprietary W31/W95 program without any success : It fails immediately with : wine: Unhandled page fault on read access to 0x at address 0x124f:0x90f7 (thread 001c), starting

Re: for the record, my ole32 binary tree search patch is correct

2009-10-28 Thread Yuriy Kaminskiy
On 27.10.2009 22:50, Vincent Povirk wrote: > I sent the following patch recently: > > commit ee6856d874d687c4504914e61bcde3e6b8823bca > Author: Vincent Povirk > Date: Fri Oct 23 13:57:42 2009 -0500 > > ole32: Don't use IEnumSTATSTG to search for elements of storages. > > We use it to

Re: kernel32: add more tests for FormatMessage{A,W}

2009-10-28 Thread Dmitry Timoshkov
"Louis Lenders" wrote: FormatMessage uses the same backend to find the requested resource as FindResource does, so I'd guess that they both fail in the same way when a resource id or a language does not exist in the module. Parsing an actual resource data is not necessary. ok, but isn't that

kernel32: add more tests for FormatMessage{A,W}

2009-10-28 Thread Louis Lenders
>FormatMessage uses the same backend to find the requested resource as >FindResource does, so I'd guess that they both fail in the same way >when a resource id or a language does not exist in the module. Parsing >an actual resource data is not necessary. ok, but isn't that test already in tests/r

re: Nate Gallaher : msi: Add tablename tracking to VIEW_find_column

2009-10-28 Thread Dan Kegel
Hi Nate, your patch seems to have caused new valgrind warnings, could you have a look? Found via http://kegel.com/wine/valgrind/logs/2009-10-27-08.06/diff-msi_db.txt Details at http://kegel.com/wine/valgrind/logs/2009-10-27-08.06/vg-msi_db.txt Conditional jump or move depends on uninitialise

Re: kernel32: add more tests for FormatMessage{A,W}

2009-10-28 Thread Dmitry Timoshkov
"Louis Lenders" wrote: 1. There is no point in testing last error if an API didn't fail Couldn't it be that the API sets ERROR_SUCCES if it doesn't fail? That's unusual, there are APIs that do that, but they are exceptions, and it's worth to test (and fix) it only if there is an app that de

kernel32: add more tests for FormatMessage{A,W}

2009-10-28 Thread Louis Lenders
>A couple of suggestions: >1. There is no point in testing last error if an API didn't fail Couldn't it be that the API sets ERROR_SUCCES if it doesn't fail? >2. It would be helpful to simultaneously test return values and >last error for FindResource, which should have similar behaviour >(and

[PATCH 5] winmm/tests: Add MCI waveaudio tests.

2009-10-28 Thread Joerg-Cyril.Hoehle
Paul Virnes wrote: >> What I'm missing is sort of the converse of skip: >> Perform a test on all platforms *except* Wine >Isn't there anything in your current test suite that succeeds on Windows >but fails on Wine? This is it! So simple, right in front of my eyes. Thanks, Jörg Höhle.

Re: [PATCH 01/12] d3d10: Fix a HeapFree() in d3d10_effect_Release().

2009-10-28 Thread Stefan Dösinger
Am 28.10.2009 um 11:43 schrieb Henri Verbeet: The patches are correct, I wrote tests for this for commits 508635ac4c290b00bd2aa97026e627a50d3c4cee, 58fcb06c07cbe4fd9cd94dc138d625cf08b82fb7 and fbbbdc09a591d7e8deae3830400ac7ad1d2fca8e. I didn't submit those though. Ok

Re: [PATCH 01/12] d3d10: Fix a HeapFree() in d3d10_effect_Release().

2009-10-28 Thread Ivan Gyurdiev
On 10/28/2009 06:32 AM, Stefan Dösinger wrote: Am 27.10.2009 um 20:10 schrieb Rico Schüller: Hi, this patch series implements a couple of ID3D10EffectVariable::As*() functions (patches 2-11). Do we have any tests for the As* behavior? Most conversions don't make any sense, so if the app wa

Re: [PATCH 01/12] d3d10: Fix a HeapFree() in d3d10_effect_Release().

2009-10-28 Thread Henri Verbeet
2009/10/28 Stefan Dösinger : > Do we have any tests for the As* behavior? > > Most conversions don't make any sense, so if the app wants a constant buffer > as a render target view returning a null obj  is probably a sane thing. But > ::AsString potentially makes sense for all objects, maybe in a s

Re: [PATCH 01/12] d3d10: Fix a HeapFree() in d3d10_effect_Release().

2009-10-28 Thread Stefan Dösinger
Am 27.10.2009 um 20:10 schrieb Rico Schüller: Hi, this patch series implements a couple of ID3D10EffectVariable::As*() functions (patches 2-11). Do we have any tests for the As* behavior? Most conversions don't make any sense, so if the app wants a constant buffer as a render target view