Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-12-02 Thread Gert van den Berg
On Wed, Dec 2, 2009 at 22:52, Ken Thomases wrote: > On Dec 2, 2009, at 1:22 PM, Gert van den Berg wrote: >> As far as I can figure out, no LC_* variable, except LC_ALL specific >> the actual locale? They only determine individual settings, which >> overwrites the default for the locale, as set by

Re: Slackware packager?

2009-12-02 Thread Jesse Allen
On Tue, Dec 1, 2009 at 11:54 AM, Jeremy White wrote: > So Adam Schreiber reports that he's no longer > doing the Slackware packages. > > Is there an active Packager currently?  If so, can > you submit a patch to remove Adam's name and insert yours? > > If not, I guess I'll submit a patch to remove

Re: RFC: dsound: Add support for enumerating capture devices through openal, try 4

2009-12-02 Thread Ken Thomases
On Dec 2, 2009, at 12:11 PM, Maarten Lankhorst wrote: This patch doesn't apply, just a rfc email to see if this approach is correct :) +static void *openal_handle = RTLD_DEFAULT; +#ifdef SONAME_LIBOPENAL +char error[128]; +openal_handle = wine_dlopen(SONAME_LIBOPENAL, RTLD_NOW, er

Re: [4/6] WineD3D: Infrastructure to render swapchains to a FBO

2009-12-02 Thread Stefan Dösinger
Am 02.12.2009 um 22:10 schrieb Henri Verbeet: >> switch(wined3d_settings.offscreen_rendering_mode) { >> case ORM_FBO: >> +This->offscreenBuffer = GL_COLOR_ATTACHMENT0; > This change is probably correct, but note that if it matters you're > probably doing something wrong. It

Re: [3/6] WineD3D: A function for checking if a surface is offscreen

2009-12-02 Thread Stefan Dösinger
Am 02.12.2009 um 22:10 schrieb Henri Verbeet: > Btw, note that the surface being offscreen is the common case, and > onscreen surfaces are the exception. Maybe surface_is_onscreen() makes > more sense, but I'll leave that up to you. I think its better to keep offscreen rendering the special case s

Re: [2/6] WineD3D: Add a function for initializing surface sysmem

2009-12-02 Thread Stefan Dösinger
Am 02.12.2009 um 22:10 schrieb Henri Verbeet: > IWineD3DDeviceImpl_Reset() suffers from similar issues in general, so > maybe we just don't care, but if one of the updateSurfaceDesc() calls > fails you're left with inconsistent surface sizes. We don't care because by Microsoft's design Reset() lea

Re: [3/6] WineD3D: A function for checking if a surface is offscreen

2009-12-02 Thread Henri Verbeet
2009/12/2 Stefan Dösinger : > @@ -5674,7 +5674,7 @@ static void color_fill_fbo(IWineD3DDevice *iface, > IWineD3DSurface *surface, > IWineD3DSwapChain *swapchain; > > swapchain = get_swapchain(surface); > -if (swapchain) { > +if (!surface_is_offscreen(surface)) { That's ok, but th

Re: [4/6] WineD3D: Infrastructure to render swapchains to a FBO

2009-12-02 Thread Henri Verbeet
2009/12/2 Stefan Dösinger : > @@ -1082,6 +1082,7 @@ static HRESULT WINAPI > IWineD3DDeviceImpl_CreateSwapChain(IWineD3DDevice *iface, > object->wineD3DDevice = This; > object->parent = parent; > object->ref = 1; > +object->render_to_fbo = FALSE; This is redundant, the field is a

Re: [2/6] WineD3D: Add a function for initializing surface sysmem

2009-12-02 Thread Henri Verbeet
2009/12/2 Stefan Dösinger : > -updateSurfaceDesc((IWineD3DSurfaceImpl *)swapchain->frontBuffer, > pPresentationParameters); > +hr = updateSurfaceDesc((IWineD3DSurfaceImpl > *)swapchain->frontBuffer, pPresentationParameters); > +if(FAILED(hr)) > +{ > +IW

Re: RFC: winediag script

2009-12-02 Thread Roderick Colenbrander
On Wed, Dec 2, 2009 at 9:11 PM, Dan Kegel wrote: > I love the idea. Could it be packaged with wine, or > do you think it would be better off being a cousin of winetricks? > > > The current script is a proof of concept. It would be nice if we could have something like this in Wine. The main thin

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-12-02 Thread Ken Thomases
On Dec 2, 2009, at 1:22 PM, Gert van den Berg wrote: I'm using Terminal.app using default settings (AFAIK, except for colors). "Set locale variables at startup" is enabled. I don't see settings for en_ZA* in /usr/share/locale (af_ZA does exist, but if my applications turn Afrikaans I'll go insa

re: RFC: winediag script

2009-12-02 Thread Dan Kegel
I love the idea. Could it be packaged with wine, or do you think it would be better off being a cousin of winetricks?

Re: [3/6] imagehlp: Implement ImageRemoveCertificate

2009-12-02 Thread Jacek Caban
Hi Owen, Owen Rudge wrote: --- dlls/imagehlp/integrity.c | 73 +-- dlls/imagehlp/tests/integrity.c |4 +- 2 files changed, 72 insertions(+), 5 deletions(-) +cert_data = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, data_size); + +

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-12-02 Thread Gert van den Berg
On Wed, Dec 2, 2009 at 18:05, Ken Thomases wrote: > Are you using Terminal.app or some other terminal application?  If > Terminal.app, have you turned off the "Set LANG environment variable on > startup" setting in preferences?  (That's the name on Leopard.  If I recall, > that setting is slightly

Re: Tests question.

2009-12-02 Thread Austin English
On Wed, Dec 2, 2009 at 11:43 AM, David Anderson wrote: > I am trying to get the tests to run before I submit a patch to > shdocvw/webbrowser.c.  My first attempts to get the tests to run. > > This morning I  did > cd /home/davea/winebld/wine > git fetch; git rebase origin         # make sure you'r

Re: Tests question.

2009-12-02 Thread James Mckenzie
>I am trying to get the tests to run before I submit a patch to >shdocvw/webbrowser.c. My first attempts to get the tests to run. > >This morning I did >cd /home/davea/winebld/wine >git fetch; git rebase origin # make sure you're up to date >./configure && make depend && make # rebuild

Re: [PATCH 1/2] msvcrt: Add test to check if signal(SIGBREAK, ...) works (todo_wine).

2009-12-02 Thread Henri Verbeet
2009/12/2 Charles Davis : > You don't get added to AUTHORS until you've hacked on Wine enough. I > learned that the hard way when I tried to put my name at the top of an > already-existing file. > AUTHORS is periodically updated by Alexandre. The amount of patches / work doesn't matter, it's suppos

Tests question.

2009-12-02 Thread David Anderson
I am trying to get the tests to run before I submit a patch to shdocvw/webbrowser.c. My first attempts to get the tests to run. This morning I did cd /home/davea/winebld/wine git fetch; git rebase origin # make sure you're up to date ./configure && make depend && make # rebuild the tr

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-12-02 Thread Ken Thomases
On Dec 1, 2009, at 1:30 PM, Gert van den Berg wrote: My OS X settings is: (Language set to "English", "Formats" set to "South Africa") MoHaGLaptop:~ mohag$ locale LANG= LC_COLLATE="C" LC_CTYPE="UTF-8" LC_MESSAGES="C" LC_MONETARY="C" LC_NUMERIC="C" LC_TIME="C" LC_ALL= Are you using Terminal.app

RFC: winediag script

2009-12-02 Thread Roderick Colenbrander
Hi, Over the years I have assisted a lot of people setting up Wine. In a lot of cases Wine doesn't work well because of missing libraries, pulseaudio, misconfigured display drivers and so on. I have written a script called 'winediag' which attempts to scan a system for the most common problems. R

Re: [PATCH 1/2] msvcrt: Add test to check if signal(SIGBREAK, ...) works (todo_wine).

2009-12-02 Thread James Mckenzie
Peter Rosin >Subject: [PATCH 1/2] msvcrt: Add test to check if signal(SIGBREAK, ...) works >(todo_wine). > > AUTHORS is not a developer editable file. Resubmit without this change. When you have submitted enough changes to Wine, you name will be added by AJ. James McKenzie

Re: [PATCH 1/2] msvcrt: Add test to check if signal(SIGBREAK, ...) works (todo_wine).

2009-12-02 Thread Charles Davis
You don't get added to AUTHORS until you've hacked on Wine enough. I learned that the hard way when I tried to put my name at the top of an already-existing file. Chip

Re: Silencing RtlNtStatusToDosErrorNoTeb() a bit

2009-12-02 Thread Wolfram Sang
Hello Dmitry, thanks for your fast reply. Sorry, I might be still missing something, as I am a bit confused with some details. Dmitry Timoshkov wrote: Another solution might be to define, let's say, ERROR_WINE_FIXME for all real fixmes and convert them to ERROR_MR_MID_NOT_FOUND. If a FIXME

Valgrind cleanup status

2009-12-02 Thread Dan Kegel
The logs of valgrind errors at http://kegel.com/wine/valgrind/logs/ are showing a nice downward trend: date files errors nonleak errors 2009-10-23 84 2383 339 2009-10-26 82 2344 319 2009-10-27 82 2318 294 2009-10-28 83 2325 294 2009-10-29 80

Re: [2/4] ntdll: add support for the HEAP_FREE_CHECKING_ENABLED style of heap overrun detection.

2009-12-02 Thread Alexandre Julliard
Dan Kegel writes: > On Tue, Dec 1, 2009 at 11:22 AM, Alexandre Julliard > wrote: >> Validation should only happen when explicitly requested. > > Should I submit a separate patch to remove the existing small arena > validation from RtlFreeHeap and RtlReAllocateHeap, then? No. These are not here

Re: New winetricks 20091125: new verbs ie7, alsa, fbo, pbuffer, ...

2009-12-02 Thread Dan Kegel
>> Could it be possible to "fix" mdac as well? Because of wine now having a >> more >> or less stubbed oledb32.dll, apps that need mdac don't run properly anymore. >> Simple solution is to set oledb32 to native, before the mdac installer is >> started, (and leave it to native afterwards) Could th