Re: Wine sound discussion summary

2009-12-06 Thread Sir Gallantmon
On Sun, Dec 6, 2009 at 4:37 PM, Roderick Colenbrander < thunderbir...@gmail.com> wrote: > On Sun, Dec 6, 2009 at 11:34 PM, Stefan Dösinger > wrote: > > > > Am 06.12.2009 um 23:21 schrieb Maarten Lankhorst: > >> I wouldn't be surprised if this still was the case, we could keep the > midi interface

Re: Wine sound discussion summary

2009-12-06 Thread Roderick Colenbrander
On Sun, Dec 6, 2009 at 11:34 PM, Stefan Dösinger wrote: > > Am 06.12.2009 um 23:21 schrieb Maarten Lankhorst: >> I wouldn't be surprised if this still was the case, we could keep the midi >> interfaces around and just report 0 wave in/out devices for >> oss/coreaudio/alsaa once we complete wine7

Re: Wine sound discussion summary

2009-12-06 Thread Stefan Dösinger
Am 06.12.2009 um 23:21 schrieb Maarten Lankhorst: > I wouldn't be surprised if this still was the case, we could keep the midi > interfaces around and just report 0 wave in/out devices for > oss/coreaudio/alsaa once we complete wine7audio.drv. So you mean keeping the existing infrastructure arou

Re: Wine sound discussion summary

2009-12-06 Thread Roderick Colenbrander
On Sun, Dec 6, 2009 at 11:19 PM, Stefan Dösinger wrote: > > Am 06.12.2009 um 22:57 schrieb Roderick Colenbrander: >> Joysticks work using /dev/js or evdev these days. It was hard to find >> some info on MIDI for Vista but I believe it still works using WinMM. >> You really need oss or alsa for mid

Re: Wine sound discussion summary

2009-12-06 Thread Maarten Lankhorst
Hello, Roderick Colenbrander schreef: On Sun, Dec 6, 2009 at 10:42 PM, Stefan Dösinger wrote: Though, how would MIDI be handled. I think that OpenAL doesn't handle MIDI... Good question. As far as I can see PulseAudio doesn't support MIDI either, but it is certainly available in A

Re: Wine sound discussion summary

2009-12-06 Thread Stefan Dösinger
Am 06.12.2009 um 22:57 schrieb Roderick Colenbrander: > Joysticks work using /dev/js or evdev these days. It was hard to find > some info on MIDI for Vista but I believe it still works using WinMM. > You really need oss or alsa for midi I think. There's this: http://www.jcabs-rumblings.com/Progra

Re: Wine sound discussion summary

2009-12-06 Thread Roderick Colenbrander
On Sun, Dec 6, 2009 at 10:42 PM, Stefan Dösinger wrote: >> Though, how would MIDI be handled. I think that OpenAL doesn't handle MIDI... > Good question. > > As far as I can see PulseAudio doesn't support MIDI either, but it is > certainly available in Alsa, CoreAudio and on Windows Vista, even t

Re: Wine sound discussion summary

2009-12-06 Thread Stefan Dösinger
> Though, how would MIDI be handled. I think that OpenAL doesn't handle MIDI... Good question. As far as I can see PulseAudio doesn't support MIDI either, but it is certainly available in Alsa, CoreAudio and on Windows Vista, even though its more tricky to activate HW midi on Vista. Emulating M

Re: [PATCH] winhttp: check for endCert being NULL (Coverity)

2009-12-06 Thread Juan Lang
Hi Marcus, -if (ret) +if (ret && endCert) ret = netconn_verify_cert( endCert, store, server ); In this case you'll return TRUE if endCert is NULL, implying that the certificate chain is valid when it most likely isn't, or at least its validity couldn't be

Re: Wine sound discussion summary

2009-12-06 Thread Stefan Dösinger
Am 06.12.2009 um 20:20 schrieb Roderick Colenbrander: > We would like to let the 'audio library' do > all the mixing and hard work. Maarten advocated to use OpenAL as the > audio library. This would allow us to get rid of all the different > audio backends which would make maintenance easier. The

Re: Wine sound discussion summary

2009-12-06 Thread Roderick Colenbrander
On Sun, Dec 6, 2009 at 5:10 PM, Roderick Colenbrander wrote: > On Sun, Dec 6, 2009 at 5:08 PM, Stefan Dösinger > wrote: >> >> Am 06.12.2009 um 15:32 schrieb Roderick Colenbrander: >>> This audio engine is quite similar to >>> pulseaudio and it offers functionality like per stream volume which >>

Re: Wine sound discussion summary

2009-12-06 Thread Ove Kaaven
Roderick Colenbrander skrev: > This audio engine is quite similar to > pulseaudio and it offers functionality like per stream volume which > normal APIs like oss/alsa/openal don't offer, What? If configured appropriately, ALSA can do it, although with the current API it's not straightforward, as

Very long printernames and test failures

2009-12-06 Thread Paul Vriens
Hi Detlef, Some test failures are shown on boxes with long printernames, for example: http://test.winehq.org/data/17b7ee13fb55e872902be3156610e583e4cd324b/vista_test-on-vista/winspool.drv:info.html http://test.winehq.org/data/17b7ee13fb55e872902be3156610e583e4cd324b/win7_153/winspool.drv:info.ht

Re: ole32: Fix invalid memory access in storage32

2009-12-06 Thread Vincent Povirk
On Sun, Dec 6, 2009 at 8:12 AM, Huw Davies wrote: > By the way, in storage32.h the filename member of struct StorageBaseImpl is > declared as > WCHAR filename[DIRENTRY_NAME_BUFFER_LEN]; > shouldn't it be > WCHAR filename[DIRENTRY_NAME_MAX_LEN]; > ? > > Huw. I'm not sure. I think I copied it from

Re: Leaks galore!

2009-12-06 Thread Dan Kegel
On Sat, Dec 5, 2009 at 1:24 PM, Dan Kegel wrote: > I'm going to do one more quick run today, disabling three > more d3d tests that crash, and (riskily) running with -j2 Done, see http://kegel.com/wine/valgrind/logs/2009-12-05-15.20/ I checked in my recent script changes to http://code.google.com

Re: Wine sound discussion summary

2009-12-06 Thread Roderick Colenbrander
On Sun, Dec 6, 2009 at 5:08 PM, Stefan Dösinger wrote: > > Am 06.12.2009 um 15:32 schrieb Roderick Colenbrander: >> This audio engine is quite similar to >> pulseaudio and it offers functionality like per stream volume which >> normal APIs like oss/alsa/openal don't offer, so these APIs would map

Re: Wine sound discussion summary

2009-12-06 Thread Stefan Dösinger
Am 06.12.2009 um 15:32 schrieb Roderick Colenbrander: > This audio engine is quite similar to > pulseaudio and it offers functionality like per stream volume which > normal APIs like oss/alsa/openal don't offer, so these APIs would map > better to a sound server than to a standard library. I am wo

Re: ole32: Fix invalid memory access in storage32

2009-12-06 Thread Nathan Gallaher
On Sun, 6 Dec 2009, Huw Davies wrote: By the way, in storage32.h the filename member of struct StorageBaseImpl is declared as WCHAR filename[DIRENTRY_NAME_BUFFER_LEN]; shouldn't it be WCHAR filename[DIRENTRY_NAME_MAX_LEN]; ? Huw. Looking at it, I can't tell. Perhaps Vincent Povirk can expl

Re: Wine sound discussion summary

2009-12-06 Thread Roderick Colenbrander
I have made some drawings of the current Wine audio architecture, the WinXP architecture, the Vista architecture and the proposals we have seen. The drawings are based on information which can be found on MSDN. Regarding Vista/Win7 it would be useful to read: http://msdn.microsoft.com/en-us/library

Re: ole32: Fix invalid memory access in storage32

2009-12-06 Thread Huw Davies
Nathan Gallaher wrote: In StorageImpl_construct(): For pwcsName strings shorter than DIRENTRY_NAME_BUFFER_LEN-1, an invalid read would be noted by valgrind as the memcpy wanders off the end of the string. Do the needful to calculate the required string length. By the way, in storage32.h the f

Re: Wine sound discussion summary

2009-12-06 Thread Stefan Dösinger
Am 06.12.2009 um 14:20 schrieb Reece Dunn: >> * Supporting DirectSound 3D is easy - openal just has it available. No need >> to reinvent the wheel. There are still a lot of dsound 3d games from WinXP >> and earlier. > > This is good, as those older games will then sound better on > Linux+Wine

Re: Wine sound discussion summary

2009-12-06 Thread Reece Dunn
2009/12/6 Stefan Dösinger > Hi, > For those who didn't follow the big dsound argument thread, here is a quick > summary of the main points. I originally inteded this as a summary mail, but > while collecting the arguments I have instead taken the discussion off-list > accidentally. But here's

Wine sound discussion summary

2009-12-06 Thread Stefan Dösinger
Hi, For those who didn't follow the big dsound argument thread, here is a quick summary of the main points. I originally inteded this as a summary mail, but while collecting the arguments I have instead taken the discussion off-list accidentally. But here's the current state: Pretty much everyo

Re: listview: Fix LISTVIEW_CancelEditLabel to not save the changed text

2009-12-06 Thread Nikolay Sivov
Jeff Latimer wrote: On 06/12/09 18:56, Nikolay Sivov wrote: Jeff Latimer wrote: --- dlls/comctl32/listview.c |2 +- dlls/comctl32/tests/listview.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Hi, Jeff. This is obviously wrong. Test will fail on native systems after y

Re: listview: Fix LISTVIEW_CancelEditLabel to not save the changed text

2009-12-06 Thread Jeff Latimer
On 06/12/09 18:56, Nikolay Sivov wrote: Jeff Latimer wrote: --- dlls/comctl32/listview.c |2 +- dlls/comctl32/tests/listview.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Hi, Jeff. This is obviously wrong. Test will fail on native systems after your patch. Why do y