Re: mshtml: Added JavaScript tests architecture and simple tests.

2009-12-21 Thread Jacek Caban
On 12/21/09 4:16 PM, Alexandre Julliard wrote: Jacek Caban writes: --- dlls/mshtml/tests/Makefile.in |2 + dlls/mshtml/tests/jstest.html | 20 ++ dlls/mshtml/tests/rsrc.rc | 20 ++ dlls/mshtml/tests/script.c| 735 - 4 files cha

Re: tools/widl: Split expr_int_const off from expr

2009-12-21 Thread Henri Verbeet
2009/12/21 Gerald Pfeifer : > How shall we best tackle this? > At least for the wined3d ones, we might as well just add them to the enum, the macros aren't strictly necessary.

Re: tools/widl: Split expr_int_const off from expr

2009-12-21 Thread Gerald Pfeifer
Hi Rob, first of all sorry for the delay in getting back to this. I kept looking for alternative approaches, but now ended up figuring that really laying down the issue at hand I was trying to solve in front of everyone a priori will be the better approach. Let me first respond to concrete feedba

Re: qedit.dll: Add minimal stubs for NullRenderer and SampleGrabber

2009-12-21 Thread Alexandre Julliard
Paul Chitescu writes: > About the macros - were you talking about the VTBL_COMMON which is pretty > short or DEF_COMMON which is long and would cause the source code to grow > unnecessarily? There are more interfaces to be implemented and I find easier > to mantain _one_ macro rather than 6 co

Re: qedit.dll: Add minimal stubs for NullRenderer and SampleGrabber

2009-12-21 Thread Paul Chitescu
On Monday 21 December 2009 05:05:25 pm Alexandre Julliard wrote: > Paul Chitescu writes: > > > Changelog: > > qedit.dll: Add minimal stubs for NullRenderer and SampleGrabber. > > > > It doesn't make much sense to break this patch in two since most applications > > connect a SampleGrabber to

Re: mshtml: Added JavaScript tests architecture and simple tests.

2009-12-21 Thread Alexandre Julliard
Jacek Caban writes: > --- > dlls/mshtml/tests/Makefile.in |2 + > dlls/mshtml/tests/jstest.html | 20 ++ > dlls/mshtml/tests/rsrc.rc | 20 ++ > dlls/mshtml/tests/script.c| 735 > - > 4 files changed, 759 insertions(+), 18 deletions(-) > c

Re: qedit.dll: Add minimal stubs for NullRenderer and SampleGrabber

2009-12-21 Thread Alexandre Julliard
Paul Chitescu writes: > Changelog: > qedit.dll: Add minimal stubs for NullRenderer and SampleGrabber. > > It doesn't make much sense to break this patch in two since most applications > connect a SampleGrabber to a NullRenderer to capture frames. That doesn't mean you can't split the patc

Re: [PATCH 3/4] kernel32/path: Fix last error in SearchPathA/W with tests

2009-12-21 Thread Nikolay Sivov
On 12/21/2009 17:49, Paul Vriens wrote: On 12/21/2009 03:37 PM, Nikolay Sivov wrote: On 12/21/2009 17:21, Paul Vriens wrote: On 12/21/2009 02:32 AM, Nikolay Sivov wrote: Fix last error in SearchPathA/W with tests Hi Nikolay, Any reason all tests are relying on both the A- and W-version bein

Re: [PATCH 3/4] kernel32/path: Fix last error in SearchPathA/W with tests

2009-12-21 Thread Paul Vriens
On 12/21/2009 03:37 PM, Nikolay Sivov wrote: On 12/21/2009 17:21, Paul Vriens wrote: On 12/21/2009 02:32 AM, Nikolay Sivov wrote: Fix last error in SearchPathA/W with tests Hi Nikolay, Any reason all tests are relying on both the A- and W-version being available? MSDN lied again, it's docu

Re: [PATCH 3/4] kernel32/path: Fix last error in SearchPathA/W with tests

2009-12-21 Thread Nikolay Sivov
On 12/21/2009 17:21, Paul Vriens wrote: On 12/21/2009 02:32 AM, Nikolay Sivov wrote: Fix last error in SearchPathA/W with tests Hi Nikolay, Any reason all tests are relying on both the A- and W-version being available? MSDN lied again, it's documented to be available in win2k. SearchPath

Re: [PATCH 3/4] kernel32/path: Fix last error in SearchPathA/W with tests

2009-12-21 Thread Paul Vriens
On 12/21/2009 02:32 AM, Nikolay Sivov wrote: Fix last error in SearchPathA/W with tests Hi Nikolay, Any reason all tests are relying on both the A- and W-version being available? SearchPathA is implemented on Win98. SearchPathW is exported but not implemented. This means the current tests

some 16 bit apps crash with gcc-4.3 (Ubuntu Intrepid); work with 4.2 (Hardy) - Caesar 3

2009-12-21 Thread Joerg-Cyril.Hoehle
Hi, the news is that a few 16bit apps crash in Wine, apparently depending on the gcc version used to compile Wine. This was known to affect copy-protected apps, but in the present case, copy protection is not involved. >perhaps that old wine-1.1.16 was compiled with Ubuntu Hardy, not Intrepid...

Re: [2/2] wininet: Free per-thread error info upon exit from an async procedure.

2009-12-21 Thread Hans Leidekker
On Monday 21 December 2009 13:09:05 Jacek Caban wrote: > You have to set TLS value to NULL otherwise it will crash on next > INTERNET_SetLastError in the same thread on another async call. But the Thanks for catching that. > right way to fix this is to get rid of INTERNET_[GS]etLastError. This

Re: [2/2] wininet: Free per-thread error info upon exit from an async procedure.

2009-12-21 Thread Jacek Caban
Hi Hans. On 12/21/09 11:14 AM, Hans Leidekker wrote: Found by Valgrind. --- dlls/wininet/internet.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c index d749e53..2b8d767 100644 --- a/dlls/wininet/internet.c +++ b